RFR: Upgrade JUnit 5

[Erik Duveblad via github.com]

On Thu, 22 Aug 2019 11:58:43 GMT, Christian Stein via github.com <duke at openjdk.java.net> wrote:

> Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1
> 
> - Set Jupiter version number 5.5.1
> - Introduce Platform Launcher 1.5.1 test runtime dependency
>   in order to force Gradle to load the module from the module-path
> - Add missing "requires 'org.junit.jupiter.params'" directives
>   in modules: jcheck, storage, vcs, and webrev
> 
> Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69
> 
> ----------------
> 
> Commits:
>  - 5e253f99:	Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1
> 			- Set Jupiter version number 5.5.1
> 			- Introduce Platform Launcher 1.5.1 test runtime dependency
> 			in order to force Gradle to load the module from the module-path
> 			- Add missing "requires 'org.junit.jupiter.params'" directives
> 			in modules: jcheck, storage, vcs, and webrev
> 			Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/66
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/66/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/66.diff
> 
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/66/head:pull/66

build.gradle line 54:

> 53: 
> 54:     test {
> 55:         useJUnitPlatform()

Hmm, I don't really follow here - how does adding a test runtime dependency on org.junit.platform:junit-platform-launcher:1.5.1 force Gradle to load the JUnit Platform launcher from the module path? Did you forgot to `git add` a change made to `buildSrc/.../ModulePlugin.java`?

PR: https://git.openjdk.java.net/skara/pull/66