RFR: Make ext.py compatible with hg5 api

Erik Duveblad via github.com duke at openjdk.java.net
Thu Aug 22 14:40:18 UTC 2019


On Thu, 22 Aug 2019 13:30:36 GMT, Jorn Vernee via github.com <duke at openjdk.java.net> wrote:

> On Thu, 22 Aug 2019 12:04:42 GMT, Jorn Vernee via github.com <duke at openjdk.java.net> wrote:
> 
>> The HG api changes in version 5 to drop the first 2 parameters to `mercurial.match.exact`, which breaks the extension script.
>> 
>> This PR detects whether we're running on hg 5, and if so, calls the function without the first 2 arguments instead.
>> 
>> ----------------
>> 
>> Commits:
>>  - 741ee3e3:	Make ext.py compatible with hg5 api
>> 
>> Pull request:
>> https://git.openjdk.java.net/skara/pull/67
>> 
>> Webrev:
>> https://webrevs.openjdk.java.net/skara/67/webrev.00
>> 
>> Patch:
>> https://git.openjdk.java.net/skara/pull/67.diff
>> 
>> Fetch command:
>> git fetch https://git.openjdk.java.net/skara pull/67/head:pull/67
> 
> @edvbld There was one other call to `mercurial.match.exact` which I forgot to change earlier (but was caught by another test)... changed that as well.
> 
> Still good to go?
> 
> PR: https://git.openjdk.java.net/skara/pull/67

@JornVernee yep, still good!

PR: https://git.openjdk.java.net/skara/pull/67


More information about the skara-dev mailing list