RFR: Add ReadOnlyRepository::contains
Robin Westberg via github.com
duke at openjdk.java.net
Thu Aug 29 06:18:28 UTC 2019
On Wed, 28 Aug 2019 17:24:35 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:
> Hi all,
>
> this patch adds `ReadOnlyRepository::contains` that checks if a given hash `h` resides in the given branch `b`. I also added small unit test case, it was hard to add more elaborate tests given that `HgRepository::branch` creates a bookmark and not a branch.
>
> ## Testing
> - [x] `sh gradlew test` passes
> - [x] Added a small unit test
>
> Thanks,
> Erik
>
> ----------------
>
> Commits:
> - d0559535: Add ReadOnlyRepository::contains
>
> Pull request:
> https://git.openjdk.java.net/skara/pull/96
>
> Webrev:
> https://webrevs.openjdk.java.net/skara/96/webrev.00
>
> Patch:
> https://git.openjdk.java.net/skara/pull/96.diff
>
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/96/head:pull/96
This PR has been reviewed by Robin Westberg via github.com - changes are approved. Review comment:
Looks good!
PR: https://git.openjdk.java.net/skara/pull/96
More information about the skara-dev
mailing list