RFR: TestHostedRepository::getPullRequests should only return open PRs
Robin Westberg via github.com
duke at openjdk.java.net
Thu Aug 29 09:36:44 UTC 2019
On Thu, 29 Aug 2019 09:36:43 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:
> Hi,
>
> this patch fixes `TestHostedRepository::getPullRequests` so that it only returns pull requests with state `PullRequest.State.OPEN` - this is how GitLab and GitHub works.
>
> Thanks,
> Erik
>
> ----------------
>
> Commits:
> - d3b0c0ab: TestHostedRepository::getPullRequests should only return open PRs
>
> Pull request:
> https://git.openjdk.java.net/skara/pull/102
>
> Webrev:
> https://webrevs.openjdk.java.net/skara/102/webrev.00
>
> Patch:
> https://git.openjdk.java.net/skara/pull/102.diff
>
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/102/head:pull/102
This PR has been reviewed by Robin Westberg via github.com - changes are approved. Review comment:
Looks good, only a minor comment!
PR: https://git.openjdk.java.net/skara/pull/102
test/src/main/java/org/openjdk/skara/test/TestPullRequest.java line 261:
> 260: }
> 261:
> 262: boolean isOpen() {
```suggestion
boolean isOpen() {
```
Can perhaps keep this one package private.
PR: https://git.openjdk.java.net/skara/pull/102
More information about the skara-dev
mailing list