RFR: 91: Avoid discarding pending items of different types

Erik Duveblad via github.com duke at openjdk.java.net
Fri Aug 30 08:26:48 UTC 2019


On Fri, 30 Aug 2019 06:10:01 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:

> Hi all,
> 
> Please review this change that stops the BotRunner from discarding pending WorkItems in favor of newer ones of a different type, even though they cannot be run concurrently.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 358ed180:	Avoid discarding a pending workitem in favor of one with a different type
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/108
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/108/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/108.diff
> 
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/108/head:pull/108

This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:

Thanks, fix looks good!

PR: https://git.openjdk.java.net/skara/pull/108


More information about the skara-dev mailing list