RFR: Batch commit, add and files methods in HgRepository
Robin Westberg via github.com
duke at openjdk.java.net
Fri Aug 30 08:49:09 UTC 2019
On Fri, 30 Aug 2019 08:29:16 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:
> Hi all,
>
> this small patch adds "batching" to the `commit`, `add` and `files` methods in `HgRepository` to avoid command-line overflow for large lists.
>
> ## Testing
> - [x] `sh gradlew test` passes on Linux x86_64
>
> Thanks,
> Erik
>
> ----------------
>
> Commits:
> - 5f2088c0: Batch commit, add and files methods in HgRepository
>
> Pull request:
> https://git.openjdk.java.net/skara/pull/109
>
> Webrev:
> https://webrevs.openjdk.java.net/skara/109/webrev.00
>
> Patch:
> https://git.openjdk.java.net/skara/pull/109.diff
>
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/109/head:pull/109
This PR has been reviewed by Robin Westberg via github.com - changes are approved. Review comment:
Wondering if the allFiles could use the batch function as well with some refactoring, but no need to change that now.
PR: https://git.openjdk.java.net/skara/pull/109
More information about the skara-dev
mailing list