RFR: 8: Use a file based approach for GitToHgConverter.java

Robin Westberg via github.com duke at openjdk.java.net
Fri Aug 30 11:28:36 UTC 2019


On Fri, 30 Aug 2019 09:04:23 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:

> Hi,
> 
> this patch introduces a file based approach for `GitToHgConverter` (instead of interpreting diffs). This is much more stable solution, we do not have to handle different encodings etc. Successfully converted the jfx repo from git to hg (and a bunch of smaller ones like jmc, code-tools/*, etc).
> 
> Thanks,
> Erik
> 
> ----------------
> 
> Commits:
>  - 7b3a05e6:	8: Use a file based approach for GitToHgConverter.java
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/110
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/110/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/110.diff
> 
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/110/head:pull/110

This PR has been reviewed by Robin Westberg via github.com - changes are approved. Review comment:

Looks good!

PR: https://git.openjdk.java.net/skara/pull/110


More information about the skara-dev mailing list