From ehelin at openjdk.java.net Mon Dec 2 09:00:43 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 2 Dec 2019 09:00:43 GMT Subject: RFR: 92: GitRepository::currentBranch fails when on a detached HEAD In-Reply-To: References: Message-ID: <6wNSh_4L1xlJYADFcXQUPX6cpHTY4JbkgLxXvivAVBE=.1cb1186b-2a2f-4317-be76-d06a16b9b3ee@github.com> On Fri, 29 Nov 2019 11:30:04 GMT, Robin Westberg wrote: > On Fri, 29 Nov 2019 11:27:22 GMT, Robin Westberg wrote: > >> On Thu, 28 Nov 2019 15:10:50 GMT, Erik Helin wrote: >> >>> Hi all, >>> >>> please review this pull request that makes `git webrev` work when the repository is in a "detached HEAD" state (i.e. there is no active branch). The main part of the change is making `ReadOnlyRepository::currentBranch` return `Optional` instead of `Branch`. >>> >>> Thanks, >>> Erik >>> >>> ## Testing >>> - [x] `make test` on Linux x64 >>> - [x] Manually running `git webrev` on a repository with a detached HEAD >>> >>> ---------------- >>> >>> Commits: >>> - 3dc4fea9: 92: GitRepository::currentBranch fails when on a detached HEAD >>> >>> Changes: https://git.openjdk.java.net/skara/pull/278/files >>> Webrev: https://webrevs.openjdk.java.net/skara/278/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/SKARA-92 >>> Stats: 40 lines in 8 files changed: 16 ins; 2 del; 22 mod >>> Patch: https://git.openjdk.java.net/skara/pull/278.diff >>> Fetch: git fetch https://git.openjdk.java.net/skara pull/278/head:pull/278 >> >> vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java line 603: >> >>> 602: var current = currentBranch().orElseThrow(() -> >>> 603: new IOException("No current branch to rebase upon") >>> 604: ); >> >> Should this mention the detached head then as well perhaps? > > Scratch that, guess this is hg :) Yes, this is in `HgRepository`, so a "detached HEAD" is not possible. I actually don't think `currentBranch` _can_ fail for `HgRepository`, since the current branch is part of the commit metadata in Mercurial (not just a ref as in git). I added a message anyhow to distinguish this scenario. PR: https://git.openjdk.java.net/skara/pull/278 From ehelin at openjdk.java.net Mon Dec 2 09:01:33 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 2 Dec 2019 09:01:33 GMT Subject: [Integrated] RFR: 92: GitRepository::currentBranch fails when on a detached HEAD In-Reply-To: References: Message-ID: Changeset: 0fb118f0 Author: Erik Helin Date: 2019-12-02 09:01:14 +0000 URL: https://git.openjdk.java.net/skara/commit/0fb118f0 92: GitRepository::currentBranch fails when on a detached HEAD Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java ! cli/src/main/java/org/openjdk/skara/cli/GitPublish.java ! cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/TestRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java ! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java From ehelin at openjdk.java.net Mon Dec 2 11:47:46 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 2 Dec 2019 11:47:46 GMT Subject: RFR: Add config option sync.branches and make git-sync less chatty Message-ID: Hi all, please review this small pull request that adds the configuration option `sync.branches`. Setting `sync.branches` means I don't have to provide `--branches` to `git-sync` every time for repositories where I know I always want to sync only a subset of the remote branches. I also moved the printing of "Skipping branch foo..." behind the `--verbose` (or `--debug`) switch, since `git-sync` became quite chatty otherwise for upstream repositories with lots of branches. Thanks, Erik ## Testing - [x] Manual testing of `git-sync` ---------------- Commits: - a8c4dee6: Add config option sync.branches and make git-sync less chatty Changes: https://git.openjdk.java.net/skara/pull/279/files Webrev: https://webrevs.openjdk.java.net/skara/279/webrev.00 Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/279.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/279/head:pull/279 PR: https://git.openjdk.java.net/skara/pull/279 From rwestberg at openjdk.java.net Mon Dec 2 12:55:46 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 2 Dec 2019 12:55:46 GMT Subject: [Approved] RFR: Add config option sync.branches and make git-sync less chatty In-Reply-To: References: Message-ID: On Mon, 2 Dec 2019 11:47:46 GMT, Erik Helin wrote: > Hi all, > > please review this small pull request that adds the configuration option `sync.branches`. Setting `sync.branches` means I don't have to provide `--branches` to `git-sync` every time for repositories where I know I always want to sync only a subset of the remote branches. > > I also moved the printing of "Skipping branch foo..." behind the `--verbose` (or `--debug`) switch, since `git-sync` became quite chatty otherwise for upstream repositories with lots of branches. > > Thanks, > Erik > > ## Testing > - [x] Manual testing of `git-sync` > > ---------------- > > Commits: > - a8c4dee6: Add config option sync.branches and make git-sync less chatty > > Changes: https://git.openjdk.java.net/skara/pull/279/files > Webrev: https://webrevs.openjdk.java.net/skara/279/webrev.00 > Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/279.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/279/head:pull/279 Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/279 From rwestberg at openjdk.java.net Mon Dec 2 12:55:57 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 2 Dec 2019 12:55:57 GMT Subject: RFR: Add config option sync.branches and make git-sync less chatty In-Reply-To: References: Message-ID: On Mon, 2 Dec 2019 11:47:46 GMT, Erik Helin wrote: > Hi all, > > please review this small pull request that adds the configuration option `sync.branches`. Setting `sync.branches` means I don't have to provide `--branches` to `git-sync` every time for repositories where I know I always want to sync only a subset of the remote branches. > > I also moved the printing of "Skipping branch foo..." behind the `--verbose` (or `--debug`) switch, since `git-sync` became quite chatty otherwise for upstream repositories with lots of branches. > > Thanks, > Erik > > ## Testing > - [x] Manual testing of `git-sync` > > ---------------- > > Commits: > - a8c4dee6: Add config option sync.branches and make git-sync less chatty > > Changes: https://git.openjdk.java.net/skara/pull/279/files > Webrev: https://webrevs.openjdk.java.net/skara/279/webrev.00 > Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/279.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/279/head:pull/279 Looks good! PR: https://git.openjdk.java.net/skara/pull/279 From ehelin at openjdk.java.net Mon Dec 2 13:12:42 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 2 Dec 2019 13:12:42 GMT Subject: [Integrated] RFR: Add config option sync.branches and make git-sync less chatty In-Reply-To: References: Message-ID: Changeset: 9ef803b7 Author: Erik Helin Date: 2019-12-02 13:12:25 +0000 URL: https://git.openjdk.java.net/skara/commit/9ef803b7 Add config option sync.branches and make git-sync less chatty Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitSync.java From rwestberg at openjdk.java.net Mon Dec 2 14:48:45 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 2 Dec 2019 14:48:45 GMT Subject: [Rev 03] RFR: No need for locking when using TestHostedRepository In-Reply-To: References: Message-ID: <41Q_HVzEsl6rKyx562Mkc4npMd7_wRLir_5CfepZKUg=.e178405b-6b0c-4d20-8ba1-643dc99b471b@github.com> The pull request has been updated with a complete new set of changes (possibly due to a rebase). ---------------- Commits: - 275dc4c6: Merge remote-tracking branch 'upstream/master' into avoid_lock - 8ae453d0: Use bare repos instead - f6c0004c: Recreate if needed - c37fb56e: Improve hosted repo init times - 16446a6e: No need for locking when using TestHostedRepository Changes: https://git.openjdk.java.net/skara/pull/219/files Webrev: https://webrevs.openjdk.java.net/skara/219/webrev.03 Stats: 79 lines in 7 files changed: 59 ins; 10 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/219.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/219/head:pull/219 PR: https://git.openjdk.java.net/skara/pull/219 From ehelin at openjdk.java.net Tue Dec 3 08:23:45 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 3 Dec 2019 08:23:45 GMT Subject: RFR: Use headHash instead of targetRef when fetching PRs Message-ID: <_xSbyy5_LNCMkuxr2gdi6opvL20cnp6F0f8wlUxXaYA=.25700005-6cfe-43db-9897-fded8d95c5b4@github.com> Hi all, please review this pull request that ensures that the `tester` bot uses `pr.headHash()` instead of `pr.targetRef()` when fetching the changes for a PR (otherwise we just fetch `master` most of the time). I also removed the `targetRef` implementation for `InMemoryPullRequest` and updated the `TestWorkItem` tests to ensure that `TestWorkItem` does _not_ use `pr.targetRef()`. Thanks, Erik ## Testing - [x] `make test` passes on Linux x64 ---------------- Commits: - fd5b1e1d: Use headHash instead of targetRef when fetching PRs Changes: https://git.openjdk.java.net/skara/pull/280/files Webrev: https://webrevs.openjdk.java.net/skara/280/webrev.00 Stats: 10 lines in 3 files changed: 0 ins; 5 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/280.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/280/head:pull/280 PR: https://git.openjdk.java.net/skara/pull/280 From rwestberg at openjdk.java.net Tue Dec 3 08:46:02 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 08:46:02 GMT Subject: [Approved] RFR: Use headHash instead of targetRef when fetching PRs In-Reply-To: <_xSbyy5_LNCMkuxr2gdi6opvL20cnp6F0f8wlUxXaYA=.25700005-6cfe-43db-9897-fded8d95c5b4@github.com> References: <_xSbyy5_LNCMkuxr2gdi6opvL20cnp6F0f8wlUxXaYA=.25700005-6cfe-43db-9897-fded8d95c5b4@github.com> Message-ID: On Tue, 3 Dec 2019 08:23:45 GMT, Erik Helin wrote: > Hi all, > > please review this pull request that ensures that the `tester` bot uses `pr.headHash()` instead of `pr.targetRef()` when fetching the changes for a PR (otherwise we just fetch `master` most of the time). I also removed the `targetRef` implementation for `InMemoryPullRequest` and updated the `TestWorkItem` tests to ensure that `TestWorkItem` does _not_ use `pr.targetRef()`. > > Thanks, > Erik > > ## Testing > - [x] `make test` passes on Linux x64 > > ---------------- > > Commits: > - fd5b1e1d: Use headHash instead of targetRef when fetching PRs > > Changes: https://git.openjdk.java.net/skara/pull/280/files > Webrev: https://webrevs.openjdk.java.net/skara/280/webrev.00 > Stats: 10 lines in 3 files changed: 0 ins; 5 del; 5 mod > Patch: https://git.openjdk.java.net/skara/pull/280.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/280/head:pull/280 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/280 From ehelin at openjdk.java.net Tue Dec 3 09:02:45 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 3 Dec 2019 09:02:45 GMT Subject: [Integrated] RFR: Use headHash instead of targetRef when fetching PRs In-Reply-To: <_xSbyy5_LNCMkuxr2gdi6opvL20cnp6F0f8wlUxXaYA=.25700005-6cfe-43db-9897-fded8d95c5b4@github.com> References: <_xSbyy5_LNCMkuxr2gdi6opvL20cnp6F0f8wlUxXaYA=.25700005-6cfe-43db-9897-fded8d95c5b4@github.com> Message-ID: Changeset: c63ac247 Author: Erik Helin Date: 2019-12-03 09:02:33 +0000 URL: https://git.openjdk.java.net/skara/commit/c63ac247 Use headHash instead of targetRef when fetching PRs Reviewed-by: rwestberg ! bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestWorkItem.java ! bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java ! bots/tester/src/test/java/org/openjdk/skara/bots/tester/TestWorkItemTests.java From ehelin at openjdk.java.net Tue Dec 3 11:33:17 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 3 Dec 2019 11:33:17 GMT Subject: RFR: 175: Test bot might miss updates for completed jobs Message-ID: Hi all, please review this PR that fixes a somewhat tricky race in `TestBot`. The problem is that `TestBot` can miss jobs that transition quickly between scheduled and completed, since it is only checking for running jobs. The solution is to always save a state of the job that the `TestWorkItem` must observe. That is, if the `TestBot` observes `RUNNING`, then the `TestWorkItem` must observe `RUNNING` or `COMPLETED` (a job's state can only move forward, `SCHEDULED -> RUNNING -> COMPLETED`). Therefore the `TestBot` knows if that it observes all jobs as being completed, then the `TestWorkItem` must also observe all test jobs being completed. This solution might result in some benign additional updates, but should not result in missing any updates. Thanks, Erik ## Testing - [x] `make test` on Linux x64 ---------------- Commits: - bf7ad0d1: 175: Test bot might miss updates for completed jobs Changes: https://git.openjdk.java.net/skara/pull/281/files Webrev: https://webrevs.openjdk.java.net/skara/281/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-175 Stats: 15 lines in 1 file changed: 11 ins; 1 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/281.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/281/head:pull/281 PR: https://git.openjdk.java.net/skara/pull/281 From rwestberg at openjdk.java.net Tue Dec 3 11:43:40 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 11:43:40 GMT Subject: [Approved] RFR: 175: Test bot might miss updates for completed jobs In-Reply-To: References: Message-ID: On Tue, 3 Dec 2019 11:33:17 GMT, Erik Helin wrote: > Hi all, > > please review this PR that fixes a somewhat tricky race in `TestBot`. The problem is that `TestBot` can miss jobs that transition quickly between scheduled and completed, since it is only checking for running jobs. The solution is to always save a state of the job that the `TestWorkItem` must observe. That is, if the `TestBot` observes `RUNNING`, then the `TestWorkItem` must observe `RUNNING` or `COMPLETED` (a job's state can only move forward, `SCHEDULED -> RUNNING -> COMPLETED`). Therefore the `TestBot` knows if that it observes all jobs as being completed, then the `TestWorkItem` must also observe all test jobs being completed. > > This solution might result in some benign additional updates, but should not result in missing any updates. > > Thanks, > Erik > > ## Testing > - [x] `make test` on Linux x64 > > ---------------- > > Commits: > - bf7ad0d1: 175: Test bot might miss updates for completed jobs > > Changes: https://git.openjdk.java.net/skara/pull/281/files > Webrev: https://webrevs.openjdk.java.net/skara/281/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-175 > Stats: 15 lines in 1 file changed: 11 ins; 1 del; 3 mod > Patch: https://git.openjdk.java.net/skara/pull/281.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/281/head:pull/281 Looks good to me! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/281 From ehelin at openjdk.java.net Tue Dec 3 12:10:53 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 3 Dec 2019 12:10:53 GMT Subject: [Integrated] RFR: 175: Test bot might miss updates for completed jobs In-Reply-To: References: Message-ID: <67f01a9a-4c06-4fdb-adbc-d08ee0d6aaba@openjdk.org> Changeset: 320cd693 Author: Erik Helin Date: 2019-12-03 12:10:41 +0000 URL: https://git.openjdk.java.net/skara/commit/320cd693 175: Test bot might miss updates for completed jobs Reviewed-by: rwestberg ! bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestBot.java From ehelin at openjdk.java.net Tue Dec 3 13:22:48 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 3 Dec 2019 13:22:48 GMT Subject: RFR: Add test subcommand to git-pr Message-ID: Hi all, please review this small pull request that adds the `test` subcommand to `git pr`, so that one can now write `git pr test `. Thanks, Erik ## Testing - [x] Manual testing of `git pr test` ---------------- Commits: - 4e070615: Add test subcommand to git-pr Changes: https://git.openjdk.java.net/skara/pull/282/files Webrev: https://webrevs.openjdk.java.net/skara/282/webrev.00 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/282.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/282/head:pull/282 PR: https://git.openjdk.java.net/skara/pull/282 From rwestberg at openjdk.java.net Tue Dec 3 13:23:35 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 13:23:35 GMT Subject: [Approved] RFR: Add test subcommand to git-pr In-Reply-To: References: Message-ID: On Tue, 3 Dec 2019 13:22:48 GMT, Erik Helin wrote: > Hi all, > > please review this small pull request that adds the `test` subcommand to `git pr`, so that one can now write `git pr test `. > > Thanks, > Erik > > ## Testing > - [x] Manual testing of `git pr test` > > ---------------- > > Commits: > - 4e070615: Add test subcommand to git-pr > > Changes: https://git.openjdk.java.net/skara/pull/282/files > Webrev: https://webrevs.openjdk.java.net/skara/282/webrev.00 > Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/282.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/282/head:pull/282 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/282 From rwestberg at openjdk.java.net Tue Dec 3 13:37:34 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 13:37:34 GMT Subject: RFR: Improve review comment threading and quoting Message-ID: Hi all, Please review this change that improves how review comments are threaded and quoted when bridged to mailing lists. Best regards, Robin ---------------- Commits: - 14444724: Improve review comment threading and quoting Changes: https://git.openjdk.java.net/skara/pull/283/files Webrev: https://webrevs.openjdk.java.net/skara/283/webrev.00 Stats: 1310 lines in 19 files changed: 643 ins; 423 del; 244 mod Patch: https://git.openjdk.java.net/skara/pull/283.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/283/head:pull/283 PR: https://git.openjdk.java.net/skara/pull/283 From rwestberg at openjdk.java.net Tue Dec 3 14:01:37 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 14:01:37 GMT Subject: [Rev 01] RFR: Improve review comment threading and quoting In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 691bde16: Fix compile error after rebase Changes: - all: https://git.openjdk.java.net/skara/pull/283/files - new: https://git.openjdk.java.net/skara/pull/283/files/14444724..691bde16 Webrevs: - full: https://webrevs.openjdk.java.net/skara/283/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/283/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/283.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/283/head:pull/283 PR: https://git.openjdk.java.net/skara/pull/283 From ehelin at openjdk.java.net Tue Dec 3 14:10:17 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 3 Dec 2019 14:10:17 GMT Subject: [Integrated] RFR: Add test subcommand to git-pr In-Reply-To: References: Message-ID: Changeset: cf5a6cf8 Author: Erik Helin Date: 2019-12-03 14:10:07 +0000 URL: https://git.openjdk.java.net/skara/commit/cf5a6cf8 Add test subcommand to git-pr Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java From ehelin at openjdk.java.net Tue Dec 3 14:10:25 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 3 Dec 2019 14:10:25 GMT Subject: [Approved] RFR: Improve review comment threading and quoting In-Reply-To: References: Message-ID: On Tue, 3 Dec 2019 14:01:37 GMT, Robin Westberg wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - 691bde16: Fix compile error after rebase > > Changes: > - all: https://git.openjdk.java.net/skara/pull/283/files > - new: https://git.openjdk.java.net/skara/pull/283/files/14444724..691bde16 > > Webrevs: > - full: https://webrevs.openjdk.java.net/skara/283/webrev.01 > - incr: https://webrevs.openjdk.java.net/skara/283/webrev.00-01 > > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/283.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/283/head:pull/283 Great work Robin, looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/283 From rwestberg at openjdk.java.net Tue Dec 3 14:15:06 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 14:15:06 GMT Subject: [Integrated] RFR: Improve review comment threading and quoting In-Reply-To: References: Message-ID: Changeset: 8f5854b2 Author: Robin Westberg Date: 2019-12-03 14:14:56 +0000 URL: https://git.openjdk.java.net/skara/commit/8f5854b2 Improve review comment threading and quoting Reviewed-by: ehelin + bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java + bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/HostUserToEmailAuthor.java + bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/HostUserToRole.java + bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/HostUserToUserName.java - bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/PullRequestInstance.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java + bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevNotification.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevStorage.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/WebrevStorageTests.java ! email/src/main/java/org/openjdk/skara/email/EmailBuilder.java ! forge/src/main/java/org/openjdk/skara/forge/Review.java ! forge/src/main/java/org/openjdk/skara/forge/ReviewComment.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/Comment.java ! test/src/main/java/org/openjdk/skara/test/TestPullRequest.java From ehelin at openjdk.java.net Tue Dec 3 14:15:57 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 3 Dec 2019 14:15:57 GMT Subject: RFR: Replace ContinuousIntegration.query with ContinuousIntegration.jobsFor Message-ID: <_UUr-h3ZoQR_ZA7IhBaQ2mbDjSC27ORDXodNz0pUJDA=.00cc2aeb-acf7-4d61-be43-f86546f06c41@github.com> Hi all, please review this small pull request that narrows the scope of `ContinuousIntegration.query(String s)` to what is really is used for - `ContinuousIntegration.jobsFor(PullRequest pr)`. Thanks, Erik ## Testing - [x] `make test` on Linux x64 - [x] `make images` ---------------- Commits: - 710372a5: Replace ContinuousIntegration.query with ContinuousIntegration.jobsFor Changes: https://git.openjdk.java.net/skara/pull/284/files Webrev: https://webrevs.openjdk.java.net/skara/284/webrev.00 Stats: 11 lines in 5 files changed: 5 ins; 3 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/284.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/284/head:pull/284 PR: https://git.openjdk.java.net/skara/pull/284 From rwestberg at openjdk.java.net Tue Dec 3 14:17:55 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 14:17:55 GMT Subject: [Approved] RFR: Replace ContinuousIntegration.query with ContinuousIntegration.jobsFor In-Reply-To: <_UUr-h3ZoQR_ZA7IhBaQ2mbDjSC27ORDXodNz0pUJDA=.00cc2aeb-acf7-4d61-be43-f86546f06c41@github.com> References: <_UUr-h3ZoQR_ZA7IhBaQ2mbDjSC27ORDXodNz0pUJDA=.00cc2aeb-acf7-4d61-be43-f86546f06c41@github.com> Message-ID: On Tue, 3 Dec 2019 14:15:57 GMT, Erik Helin wrote: > Hi all, > > please review this small pull request that narrows the scope of `ContinuousIntegration.query(String s)` to what is really is used for - `ContinuousIntegration.jobsFor(PullRequest pr)`. > > Thanks, > Erik > > ## Testing > - [x] `make test` on Linux x64 > - [x] `make images` > > ---------------- > > Commits: > - 710372a5: Replace ContinuousIntegration.query with ContinuousIntegration.jobsFor > > Changes: https://git.openjdk.java.net/skara/pull/284/files > Webrev: https://webrevs.openjdk.java.net/skara/284/webrev.00 > Stats: 11 lines in 5 files changed: 5 ins; 3 del; 3 mod > Patch: https://git.openjdk.java.net/skara/pull/284.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/284/head:pull/284 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/284 From ehelin at openjdk.java.net Tue Dec 3 14:18:26 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 3 Dec 2019 14:18:26 GMT Subject: [Integrated] RFR: Replace ContinuousIntegration.query with ContinuousIntegration.jobsFor In-Reply-To: <_UUr-h3ZoQR_ZA7IhBaQ2mbDjSC27ORDXodNz0pUJDA=.00cc2aeb-acf7-4d61-be43-f86546f06c41@github.com> References: <_UUr-h3ZoQR_ZA7IhBaQ2mbDjSC27ORDXodNz0pUJDA=.00cc2aeb-acf7-4d61-be43-f86546f06c41@github.com> Message-ID: Changeset: fb012ba8 Author: Erik Helin Date: 2019-12-03 14:18:17 +0000 URL: https://git.openjdk.java.net/skara/commit/fb012ba8 Replace ContinuousIntegration.query with ContinuousIntegration.jobsFor Reviewed-by: rwestberg ! bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestBot.java ! bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryContinuousIntegration.java ! ci/build.gradle ! ci/src/main/java/module-info.java ! ci/src/main/java/org/openjdk/skara/ci/ContinuousIntegration.java From rwestberg at openjdk.java.net Tue Dec 3 14:34:28 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 14:34:28 GMT Subject: RFR: Add support for Resolved issue state Message-ID: Hi all, Please review this small change that adds support for setting issues to a Resolved state. Currently only supported by Jira, GitLab and GitHub will treat it as Closed. Best regards, Robin ------------- Commits: - 54372123: Add support for Resolved issue state Changes: https://git.openjdk.java.net/skara/pull/285/files Webrev: https://webrevs.openjdk.java.net/skara/285/webrev.00 Stats: 17 lines in 4 files changed: 14 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/285.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/285/head:pull/285 PR: https://git.openjdk.java.net/skara/pull/285 From rwestberg at openjdk.java.net Tue Dec 3 14:38:10 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 14:38:10 GMT Subject: RFR: Add support for Resolved issue state In-Reply-To: References: Message-ID: On Tue, 3 Dec 2019 14:33:45 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that adds support for setting issues to a Resolved state. Currently only supported by Jira, GitLab and GitHub will treat it as Closed. > > Best regards, > Robin issuetracker/src/main/java/org/openjdk/skara/issuetracker/Issue.java line 107: > 106: OPEN, > 107: RESOLVED, > 108: CLOSED Another option would be to simply map CLOSED to the Jira Resolved state as that's probably what we want to always use.. ------------- PR: https://git.openjdk.java.net/skara/pull/285 From rwestberg at openjdk.java.net Tue Dec 3 14:40:28 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 14:40:28 GMT Subject: RFR: Add support for Resolved issue state In-Reply-To: References: Message-ID: <9qg0AMOgxghhIXyz4l1wV8efI6zJkVYZt1z3mFv8G3I=.16585c3f-54a4-41b1-be26-b540ed08abf1@github.com> On Tue, 3 Dec 2019 14:37:58 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this small change that adds support for setting issues to a Resolved state. Currently only supported by Jira, GitLab and GitHub will treat it as Closed. >> >> Best regards, >> Robin > > issuetracker/src/main/java/org/openjdk/skara/issuetracker/Issue.java line 107: > >> 106: OPEN, >> 107: RESOLVED, >> 108: CLOSED > > Another option would be to simply map CLOSED to the Jira Resolved state as that's probably what we want to always use.. Jira also supports renaming its states, so it's possible that we'll need to switch to setting State as a string to be interpreted as the particular Issue implementation sees fit. ------------- PR: https://git.openjdk.java.net/skara/pull/285 From ehelin at openjdk.java.net Tue Dec 3 14:41:39 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 3 Dec 2019 14:41:39 GMT Subject: RFR: Add support for Resolved issue state In-Reply-To: <9qg0AMOgxghhIXyz4l1wV8efI6zJkVYZt1z3mFv8G3I=.16585c3f-54a4-41b1-be26-b540ed08abf1@github.com> References: <9qg0AMOgxghhIXyz4l1wV8efI6zJkVYZt1z3mFv8G3I=.16585c3f-54a4-41b1-be26-b540ed08abf1@github.com> Message-ID: On Tue, 3 Dec 2019 14:40:17 GMT, Robin Westberg wrote: >> issuetracker/src/main/java/org/openjdk/skara/issuetracker/Issue.java line 107: >> >>> 106: OPEN, >>> 107: RESOLVED, >>> 108: CLOSED >> >> Another option would be to simply map CLOSED to the Jira Resolved state as that's probably what we want to always use.. > > Jira also supports renaming its states, so it's possible that we'll need to switch to setting State as a string to be interpreted as the particular Issue implementation sees fit. I think using `RESOLVED` makes sense for now ?? ------------- PR: https://git.openjdk.java.net/skara/pull/285 From ehelin at openjdk.java.net Tue Dec 3 14:41:57 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 3 Dec 2019 14:41:57 GMT Subject: RFR: Add support for Resolved issue state In-Reply-To: References: Message-ID: On Tue, 3 Dec 2019 14:33:45 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that adds support for setting issues to a Resolved state. Currently only supported by Jira, GitLab and GitHub will treat it as Closed. > > Best regards, > Robin Looks good! ---------------- Approved by ehelin (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/285 From rwestberg at openjdk.java.net Tue Dec 3 14:45:37 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 14:45:37 GMT Subject: RFR: Add support for Resolved issue state In-Reply-To: References: Message-ID: On Tue, 3 Dec 2019 14:41:49 GMT, Erik Helin wrote: >> Hi all, >> >> Please review this small change that adds support for setting issues to a Resolved state. Currently only supported by Jira, GitLab and GitHub will treat it as Closed. >> >> Best regards, >> Robin > > Looks good! > > ---------------- > > Approved by ehelin (Reviewer). Thanks for reviewing! ------------- PR: https://git.openjdk.java.net/skara/pull/285 From rwestberg at openjdk.java.net Tue Dec 3 14:52:08 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 14:52:08 GMT Subject: [Integrated] RFR: Add support for Resolved issue state In-Reply-To: References: Message-ID: <6d50883b-8ba2-4215-ac4f-f33820971a68@openjdk.org> Changeset: c18c7d3d Author: Robin Westberg Date: 2019-12-03 14:51:49 +0000 URL: https://git.openjdk.java.net/skara/commit/c18c7d3d Add support for Resolved issue state Reviewed-by: ehelin ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/Issue.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java From ehelin at openjdk.java.net Tue Dec 3 19:19:34 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 3 Dec 2019 19:19:34 GMT Subject: RFR: 176: git-pr should promote usage of git-publish Message-ID: Hi all, pleaser review this small pull request that promotes usage of `git publish` instead of `git push --set-upstream`. Testing: - [x] Tested live while demoing features Thanks, Erik ------------- Commits: - 06d2e44f: 176: git-pr should promote usage of git-publish Changes: https://git.openjdk.java.net/skara/pull/286/files Webrev: https://webrevs.openjdk.java.net/skara/286/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-176 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/286.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/286/head:pull/286 PR: https://git.openjdk.java.net/skara/pull/286 From rwestberg at openjdk.java.net Tue Dec 3 19:20:23 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 19:20:23 GMT Subject: RFR: 176: git-pr should promote usage of git-publish In-Reply-To: References: Message-ID: On Tue, 3 Dec 2019 19:18:53 GMT, Erik Helin wrote: > Hi all, > > pleaser review this small pull request that promotes usage of `git publish` > instead of `git push --set-upstream`. > > Testing: > - [x] Tested live while demoing features > > Thanks, > Erik Looks good, but do we need to update something else like a manpage? ------------- PR: https://git.openjdk.java.net/skara/pull/286 From erik.helin at oracle.com Tue Dec 3 19:22:00 2019 From: erik.helin at oracle.com (Erik Helin) Date: Tue, 3 Dec 2019 20:22:00 +0100 Subject: RFR: 176: git-pr should promote usage of git-publish In-Reply-To: References: Message-ID: On 12/3/19 8:20 PM, Robin Westberg wrote: > On Tue, 3 Dec 2019 19:18:53 GMT, Erik Helin wrote: > >> Hi all, >> >> pleaser review this small pull request that promotes usage of `git publish` >> instead of `git push --set-upstream`. >> >> Testing: >> - [x] Tested live while demoing features >> >> Thanks, >> Erik > > Looks good, but do we need to update something else like a manpage? Nope, I think we are good. This is only mentioned in the output of the tool. Thanks, Erik From rwestberg at openjdk.java.net Tue Dec 3 19:25:43 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 3 Dec 2019 19:25:43 GMT Subject: RFR: 176: git-pr should promote usage of git-publish In-Reply-To: References: Message-ID: <0ERZvv0L4Gi6XmlDDQAoLeNS5lew8E9Xx4ThVsLLtTM=.86fd1b86-0f67-4a72-917a-1aa4277e9cb7@github.com> On Tue, 3 Dec 2019 19:18:53 GMT, Erik Helin wrote: > Hi all, > > pleaser review this small pull request that promotes usage of `git publish` > instead of `git push --set-upstream`. > > Testing: > - [x] Tested live while demoing features > > Thanks, > Erik Okay, looks good then! ---------------- Approved by rwestberg (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/286 From ehelin at openjdk.java.net Tue Dec 3 19:33:53 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 3 Dec 2019 19:33:53 GMT Subject: [Integrated] RFR: 176: git-pr should promote usage of git-publish In-Reply-To: References: Message-ID: <0383e4c6-ff5d-4d4f-9456-81df26f71ada@openjdk.org> Changeset: ce8fa520 Author: Erik Helin Date: 2019-12-03 19:33:42 +0000 URL: https://git.openjdk.java.net/skara/commit/ce8fa520 176: git-pr should promote usage of git-publish Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java From rwestberg at openjdk.java.net Wed Dec 4 07:25:00 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 4 Dec 2019 07:25:00 GMT Subject: RFR: Resolve issues instead of closing Message-ID: Hi all, Please review this minor change in the issue updater to set issues as resolved instead of closed when they are integrated, similar to what hgupdater does. Best regards, Robin ------------- Commits: - 0a624684: Resolve issues instead of closing Changes: https://git.openjdk.java.net/skara/pull/287/files Webrev: https://webrevs.openjdk.java.net/skara/287/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/287.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/287/head:pull/287 PR: https://git.openjdk.java.net/skara/pull/287 From ehelin at openjdk.java.net Wed Dec 4 08:20:13 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 4 Dec 2019 08:20:13 GMT Subject: RFR: Resolve issues instead of closing In-Reply-To: References: Message-ID: On Wed, 4 Dec 2019 07:24:13 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change in the issue updater to set issues as resolved instead of closed when they are integrated, similar to what hgupdater does. > > Best regards, > Robin Looks good! ---------------- Approved by ehelin (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/287 From rwestberg at openjdk.java.net Wed Dec 4 08:44:22 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 4 Dec 2019 08:44:22 GMT Subject: [Integrated] RFR: Resolve issues instead of closing In-Reply-To: References: Message-ID: <7c8cad96-3204-4cdc-869b-c31ee5620fc2@openjdk.org> Changeset: 878885b4 Author: Robin Westberg Date: 2019-12-04 08:44:11 +0000 URL: https://git.openjdk.java.net/skara/commit/878885b4 Resolve issues instead of closing Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java From rwestberg at openjdk.java.net Wed Dec 4 08:57:12 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 4 Dec 2019 08:57:12 GMT Subject: RFR: 177: Filter markdown escapes when sending plaintext emails Message-ID: Hi all, Please review this change that extends the markdown to text filtering to handle the escapes that can be inserted by the text to markdown filter. Best regards, Robin ------------- Commits: - 1154c19b: Remove the formatting that TextToMarkdown can insert Changes: https://git.openjdk.java.net/skara/pull/288/files Webrev: https://webrevs.openjdk.java.net/skara/288/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-177 Stats: 24 lines in 2 files changed: 22 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/288.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/288/head:pull/288 PR: https://git.openjdk.java.net/skara/pull/288 From ehelin at openjdk.java.net Wed Dec 4 09:17:28 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 4 Dec 2019 09:17:28 GMT Subject: RFR: 177: Filter markdown escapes when sending plaintext emails In-Reply-To: References: Message-ID: On Wed, 4 Dec 2019 08:56:25 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that extends the markdown to text filtering to handle the escapes that can be inserted by the text to markdown filter. > > Best regards, > Robin Wow, now that is a regular expression! Looks good, thanks for adding tests. ---------------- Approved by ehelin (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/288 From rwestberg at openjdk.java.net Wed Dec 4 09:19:07 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 4 Dec 2019 09:19:07 GMT Subject: RFR: 177: Filter markdown escapes when sending plaintext emails In-Reply-To: References: Message-ID: On Wed, 4 Dec 2019 09:17:19 GMT, Erik Helin wrote: >> Hi all, >> >> Please review this change that extends the markdown to text filtering to handle the escapes that can be inserted by the text to markdown filter. >> >> Best regards, >> Robin > > Wow, now that is a regular expression! Looks good, thanks for adding tests. > > ---------------- > > Approved by ehelin (Reviewer). ?? thanks for the review! ------------- PR: https://git.openjdk.java.net/skara/pull/288 From rwestberg at openjdk.java.net Wed Dec 4 09:21:18 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 4 Dec 2019 09:21:18 GMT Subject: [Integrated] RFR: 177: Filter markdown escapes when sending plaintext emails In-Reply-To: References: Message-ID: Changeset: b2176cd1 Author: Robin Westberg Date: 2019-12-04 09:21:08 +0000 URL: https://git.openjdk.java.net/skara/commit/b2176cd1 177: Filter markdown escapes when sending plaintext emails Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MarkdownToText.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MarkdownToTextTests.java From ehelin at openjdk.java.net Wed Dec 4 09:50:42 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 4 Dec 2019 09:50:42 GMT Subject: RFR: 178: Test bot misses transition from RUNNING to COMPLETE Message-ID: <7R2hmVf5NAYAU4Z6gKJELUInz9LHQQMGSZmd1UGw6sU=.4978d60e-345d-4fe3-b398-3539e8a4461a@github.com> Hi all, please review this pull request that ensures that the test bot will execute a `TestWorkItem` when jobs are doing the final transition from `RUNNING` to `COMPLETE`. This is done by having the `TestBot` observe the two last states, not just the last state. By observing the last two states, the `TestBot` can witness the final transition from `RUNNING` to `COMPLETE`. Thanks, Erik ------------- Commits: - bbd9bde1: 178: Test bot misses transition from RUNNING to COMPLETE Changes: https://git.openjdk.java.net/skara/pull/289/files Webrev: https://webrevs.openjdk.java.net/skara/289/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-178 Stats: 20 lines in 1 file changed: 17 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/289.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/289/head:pull/289 PR: https://git.openjdk.java.net/skara/pull/289 From rwestberg at openjdk.java.net Wed Dec 4 09:51:47 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 4 Dec 2019 09:51:47 GMT Subject: RFR: 178: Test bot misses transition from RUNNING to COMPLETE In-Reply-To: <7R2hmVf5NAYAU4Z6gKJELUInz9LHQQMGSZmd1UGw6sU=.4978d60e-345d-4fe3-b398-3539e8a4461a@github.com> References: <7R2hmVf5NAYAU4Z6gKJELUInz9LHQQMGSZmd1UGw6sU=.4978d60e-345d-4fe3-b398-3539e8a4461a@github.com> Message-ID: On Wed, 4 Dec 2019 09:49:59 GMT, Erik Helin wrote: > Hi all, > > please review this pull request that ensures that the test bot will execute a > `TestWorkItem` when jobs are doing the final transition from `RUNNING` to > `COMPLETE`. This is done by having the `TestBot` observe the two last states, > not just the last state. By observing the last two states, the `TestBot` can > witness the final transition from `RUNNING` to `COMPLETE`. > > Thanks, > Erik That should do it! ---------------- Approved by rwestberg (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/289 From ehelin at openjdk.java.net Wed Dec 4 10:31:49 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 4 Dec 2019 10:31:49 GMT Subject: [Integrated] RFR: 178: Test bot misses transition from RUNNING to COMPLETE In-Reply-To: <7R2hmVf5NAYAU4Z6gKJELUInz9LHQQMGSZmd1UGw6sU=.4978d60e-345d-4fe3-b398-3539e8a4461a@github.com> References: <7R2hmVf5NAYAU4Z6gKJELUInz9LHQQMGSZmd1UGw6sU=.4978d60e-345d-4fe3-b398-3539e8a4461a@github.com> Message-ID: <74974fa3-8984-4d89-aeab-6ea86acb472b@openjdk.org> Changeset: 0417bc26 Author: Erik Helin Date: 2019-12-04 10:31:38 +0000 URL: https://git.openjdk.java.net/skara/commit/0417bc26 178: Test bot misses transition from RUNNING to COMPLETE Reviewed-by: rwestberg ! bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestBot.java From rwestberg at openjdk.java.net Wed Dec 4 11:34:55 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 4 Dec 2019 11:34:55 GMT Subject: RFR: Improve Jira state transition handling Message-ID: Hi all, Please review this change that improves the Jira state transition handling. Sometimes it is required to transition in two steps to reach the wanted state. Best regards, Robin ------------- Commits: - daa87a6c: Improve Jira state transition handling Changes: https://git.openjdk.java.net/skara/pull/290/files Webrev: https://webrevs.openjdk.java.net/skara/290/webrev.00 Stats: 56 lines in 2 files changed: 43 ins; 0 del; 13 mod Patch: https://git.openjdk.java.net/skara/pull/290.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/290/head:pull/290 PR: https://git.openjdk.java.net/skara/pull/290 From ehelin at openjdk.java.net Wed Dec 4 11:38:08 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 4 Dec 2019 11:38:08 GMT Subject: RFR: Improve Jira state transition handling In-Reply-To: References: Message-ID: On Wed, 4 Dec 2019 11:34:14 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that improves the Jira state transition handling. Sometimes it is required to transition in two steps to reach the wanted state. > > Best regards, > Robin Nice fix, looks good! ---------------- Approved by ehelin (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/290 From rwestberg at openjdk.java.net Wed Dec 4 12:31:43 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 4 Dec 2019 12:31:43 GMT Subject: [Rev 01] RFR: Improve Jira state transition handling In-Reply-To: References: Message-ID: <_Gm6PeBjySPHh8jC5_SHXG8WkEiDTJizCRN_S7YAxa8=.3863016b-3a0e-4b27-b757-3a9e7a75df3b@github.com> > Hi all, > > Please review this change that improves the Jira state transition handling. Sometimes it is required to transition in two steps to reach the wanted state. > > Best regards, > Robin The pull request has been updated with 1 additional commit. ------------- Added commits: - 90c6fbfc: Remove unused method Changes: - all: https://git.openjdk.java.net/skara/pull/290/files - new: https://git.openjdk.java.net/skara/pull/290/files/daa87a6c..90c6fbfc Webrevs: - full: https://webrevs.openjdk.java.net/skara/290/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/290/webrev.00-01 Stats: 15 lines in 1 file changed: 2 ins; 13 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/290.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/290/head:pull/290 PR: https://git.openjdk.java.net/skara/pull/290 From rwestberg at openjdk.java.net Wed Dec 4 12:38:48 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 4 Dec 2019 12:38:48 GMT Subject: [Integrated] RFR: Improve Jira state transition handling In-Reply-To: References: Message-ID: <53c53295-9032-4865-9378-8fc0e985c32c@openjdk.org> Changeset: 7bcc027f Author: Robin Westberg Date: 2019-12-04 12:38:38 +0000 URL: https://git.openjdk.java.net/skara/commit/7bcc027f Improve Jira state transition handling Reviewed-by: ehelin ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java ! issuetracker/src/test/java/org/openjdk/skara/issuetracker/IssueTrackerTests.java From rwestberg at openjdk.java.net Wed Dec 4 13:55:14 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 4 Dec 2019 13:55:14 GMT Subject: RFR: 181: Improve approval messages Message-ID: Hi all, Please review this change that improves the pull request approval messages, and adjusts the formatting a bit. Best regards, Robin ------------- Commits: - 0970237f: Adjust approval message, improve formatting Changes: https://git.openjdk.java.net/skara/pull/291/files Webrev: https://webrevs.openjdk.java.net/skara/291/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-181 Stats: 67 lines in 5 files changed: 30 ins; 27 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/291.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/291/head:pull/291 PR: https://git.openjdk.java.net/skara/pull/291 From rwestberg at openjdk.java.net Wed Dec 4 14:30:11 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 4 Dec 2019 14:30:11 GMT Subject: [Rev 01] RFR: 181: Improve approval messages In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that improves the pull request approval messages, and adjusts the formatting a bit. > > Best regards, > Robin The pull request has been updated with 1 additional commit. ------------- Added commits: - c8d8cd8f: Revert the role description changes Changes: - all: https://git.openjdk.java.net/skara/pull/291/files - new: https://git.openjdk.java.net/skara/pull/291/files/0970237f..c8d8cd8f Webrevs: - full: https://webrevs.openjdk.java.net/skara/291/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/291/webrev.00-01 Stats: 6 lines in 3 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/291.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/291/head:pull/291 PR: https://git.openjdk.java.net/skara/pull/291 From ehelin at openjdk.java.net Wed Dec 4 14:33:43 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 4 Dec 2019 14:33:43 GMT Subject: [Rev 01] RFR: 181: Improve approval messages In-Reply-To: References: Message-ID: On Wed, 4 Dec 2019 14:33:43 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this change that improves the pull request approval messages, and adjusts the formatting a bit. >> >> Best regards, >> Robin > > The pull request has been updated with 1 additional commit. Looks good! ---------------- Approved by ehelin (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/291 From rwestberg at openjdk.java.net Wed Dec 4 14:44:44 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 4 Dec 2019 14:44:44 GMT Subject: RFR: 165: Replace large webrev files with placeholders instead of dropping them Message-ID: Hi all, Please review this change that replaces large files in published webrevs with a placeholder message, instead of just omitting them. Best regards, Robin ------------- Commits: - 917126e2: Fix generation, add a test - 3644c10e: Replace large webrev files with a placeholder instead of just dropping them Changes: https://git.openjdk.java.net/skara/pull/292/files Webrev: https://webrevs.openjdk.java.net/skara/292/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-165 Stats: 96 lines in 2 files changed: 81 ins; 13 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/292.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/292/head:pull/292 PR: https://git.openjdk.java.net/skara/pull/292 From rwestberg at openjdk.java.net Wed Dec 4 14:47:45 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 4 Dec 2019 14:47:45 GMT Subject: [Integrated] RFR: 181: Improve approval messages In-Reply-To: References: Message-ID: Changeset: b80fb59c Author: Robin Westberg Date: 2019-12-04 14:47:34 +0000 URL: https://git.openjdk.java.net/skara/commit/b80fb59c 181: Improve approval messages Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From ehelin at openjdk.java.net Wed Dec 4 15:45:47 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 4 Dec 2019 15:45:47 GMT Subject: RFR: Make instantiating forges from known hosts faster Message-ID: Hi all, please review this pull request that speeds things up a little when calling `Forge.from`. If the hostname of the provided URI exactly matches a known host for exactly one `ForgeFactory`, then I argue that it is safe to create a `Forge` from that factory and return it without calling `isValid()` first. In other words, I would be very surprised if we ever encounter an issue with returning a `GitHubForge` instance for URIs with a hostname of `github.com` (and vice-versa, a `GitLabForge` instance for URIs with a hostname of `gitlab.com`). Thanks, Erik ## Testing - [x] `make test` on Linux x64 ------------- Commits: - 82a6626c: Make instatiating forges from known hosts faster Changes: https://git.openjdk.java.net/skara/pull/293/files Webrev: https://webrevs.openjdk.java.net/skara/293/webrev.00 Stats: 43 lines in 5 files changed: 39 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/293.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/293/head:pull/293 PR: https://git.openjdk.java.net/skara/pull/293 From ehelin at openjdk.java.net Wed Dec 4 15:47:37 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 4 Dec 2019 15:47:37 GMT Subject: RFR: 165: Replace large webrev files with placeholders instead of dropping them In-Reply-To: References: Message-ID: On Wed, 4 Dec 2019 14:44:04 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that replaces large files in published webrevs with a placeholder message, instead of just omitting them. > > Best regards, > Robin This looks good in general, but won't this destroy the navigation arrows for .e.g. the udiff or frames view? Or maybe it just overwrites the content, I don't recall ?? ------------- PR: https://git.openjdk.java.net/skara/pull/292 From rwestberg at openjdk.java.net Thu Dec 5 06:56:40 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 5 Dec 2019 06:56:40 GMT Subject: RFR: Make instantiating forges from known hosts faster In-Reply-To: References: Message-ID: On Wed, 4 Dec 2019 15:45:04 GMT, Erik Helin wrote: > Hi all, > > please review this pull request that speeds things up a little when calling `Forge.from`. If the hostname of the provided URI exactly matches a known host for exactly one `ForgeFactory`, then I argue that it is safe to create a `Forge` from that factory and return it without calling `isValid()` first. In other words, I would be very surprised if we ever encounter an issue with returning a `GitHubForge` instance for URIs with a hostname of `github.com` (and vice-versa, a `GitLabForge` instance for URIs with a hostname of `gitlab.com`). > > Thanks, > Erik > > ## Testing > - [x] `make test` on Linux x64 Looks good, I agree that it should be safe! ---------------- Approved by rwestberg (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/293 From rwestberg at openjdk.java.net Thu Dec 5 07:41:07 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 5 Dec 2019 07:41:07 GMT Subject: [Rev 01] RFR: 165: Replace large webrev files with placeholders instead of dropping them In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that replaces large files in published webrevs with a placeholder message, instead of just omitting them. > > Best regards, > Robin The pull request has been updated with 1 additional commit. ------------- Added commits: - 82bbe563: Handle html file content replacement a little nicer Changes: - all: https://git.openjdk.java.net/skara/pull/292/files - new: https://git.openjdk.java.net/skara/pull/292/files/917126e2..82bbe563 Webrevs: - full: https://webrevs.openjdk.java.net/skara/292/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/292/webrev.00-01 Stats: 51 lines in 1 file changed: 31 ins; 17 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/292.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/292/head:pull/292 PR: https://git.openjdk.java.net/skara/pull/292 From rwestberg at openjdk.java.net Thu Dec 5 07:43:00 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 5 Dec 2019 07:43:00 GMT Subject: RFR: 165: Replace large webrev files with placeholders instead of dropping them In-Reply-To: References: Message-ID: <7nbfRa0ptGG_l5RSQfXIOWWC8reaUcvqX9iVSgdXKLo=.acb38c39-421c-402c-abb9-c7d06d31e676@github.com> On Wed, 4 Dec 2019 15:47:30 GMT, Erik Helin wrote: >> Hi all, >> >> Please review this change that replaces large files in published webrevs with a placeholder message, instead of just omitting them. >> >> Best regards, >> Robin > > This looks good in general, but won't this destroy the navigation arrows for e.g. the udiff or frames view? Or maybe it just overwrites the content, I don't recall ?? It would indeed destroy navigation, I've updated it a bit to handle .html files a bit nicer. This also ensures that the instructions are displayed with proper line breaks as they will be placed inside `
` tags if possible.

-------------

PR: https://git.openjdk.java.net/skara/pull/292

From ehelin at openjdk.java.net  Thu Dec  5 08:15:41 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 08:15:41 GMT
Subject: [Integrated] RFR: Make instantiating forges from known hosts
 faster
In-Reply-To: 
References: 
Message-ID: 

Changeset: 1169050c
Author:    Erik Helin 
Date:      2019-12-05 08:15:29 +0000
URL:       https://git.openjdk.java.net/skara/commit/1169050c

Make instantiating forges from known hosts faster

Reviewed-by: rwestberg

! forge/src/main/java/org/openjdk/skara/forge/Forge.java
! forge/src/main/java/org/openjdk/skara/forge/ForgeFactory.java
! forge/src/main/java/org/openjdk/skara/forge/github/GitHubForgeFactory.java
! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabForgeFactory.java
! forge/src/test/java/org/openjdk/skara/forge/ForgeTests.java

From ehelin at openjdk.java.net  Thu Dec  5 08:16:10 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 08:16:10 GMT
Subject: [Rev 01] RFR: 165: Replace large webrev files with placeholders
 instead of dropping them
In-Reply-To: 
References: 
 
Message-ID: 

On Thu, 5 Dec 2019 08:16:10 GMT, Robin Westberg  wrote:

>> Hi all,
>> 
>> Please review this change that replaces large files in published webrevs with a placeholder message, instead of just omitting them.
>> 
>> Best regards,
>> Robin
> 
> The pull request has been updated with 1 additional commit.

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/292

From ehelin at openjdk.java.net  Thu Dec  5 09:21:39 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 09:21:39 GMT
Subject: RFR: Cache labels in GitHubPullRequest
Message-ID: 

Hi all,

please review this pull request that introduces a simple label cache for `GitHubPullRequest`. Since a `GitHubPullRequest` instance can't be accessed by multiple threads it is safe to use a very simple cache mechanism. The only calls that can mutate labels on a PR are `addLabel` and `removeLabel`. A user on GitHub could of course add a label, but we make no guarantees that a `GitHubPullRequest` instance reflects what happens on GitHub, code wanting to ensure they have the latest state must create a new `GitHubPullRequest` instance.

Thanks,
Erik

-------------

Commits:
 - 114b5d69: Cache labels in GitHubPullRequest

Changes: https://git.openjdk.java.net/skara/pull/294/files
 Webrev: https://webrevs.openjdk.java.net/skara/294/webrev.00
  Stats: 18 lines in 1 file changed: 13 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/skara/pull/294.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/294/head:pull/294

PR: https://git.openjdk.java.net/skara/pull/294

From rwestberg at openjdk.java.net  Thu Dec  5 09:35:39 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 5 Dec 2019 09:35:39 GMT
Subject: RFR: Cache labels in GitHubPullRequest
In-Reply-To: 
References: 
Message-ID: 

On Thu, 5 Dec 2019 09:21:02 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this pull request that introduces a simple label cache for `GitHubPullRequest`. Since a `GitHubPullRequest` instance can't be accessed by multiple threads it is safe to use a very simple cache mechanism. The only calls that can mutate labels on a PR are `addLabel` and `removeLabel`. A user on GitHub could of course add a label, but we make no guarantees that a `GitHubPullRequest` instance reflects what happens on GitHub, code wanting to ensure they have the latest state must create a new `GitHubPullRequest` instance.
> 
> Thanks,
> Erik

Looks good! I think it would be reasonable to do similar caching for other PR properties such as comments, but that can be done at some other time.

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/294

From ehelin at openjdk.java.net  Thu Dec  5 09:50:22 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 09:50:22 GMT
Subject: RFR: Cache labels in GitHubPullRequest
In-Reply-To: 
References: 
 
Message-ID: 

On Thu, 5 Dec 2019 09:35:32 GMT, Robin Westberg  wrote:

>> Hi all,
>> 
>> please review this pull request that introduces a simple label cache for `GitHubPullRequest`. Since a `GitHubPullRequest` instance can't be accessed by multiple threads it is safe to use a very simple cache mechanism. The only calls that can mutate labels on a PR are `addLabel` and `removeLabel`. A user on GitHub could of course add a label, but we make no guarantees that a `GitHubPullRequest` instance reflects what happens on GitHub, code wanting to ensure they have the latest state must create a new `GitHubPullRequest` instance.
>> 
>> Thanks,
>> Erik
> 
> Looks good! I think it would be reasonable to do similar caching for other PR properties such as comments, but that can be done at some other time.

Thanks for reviewing Robin! Yes, I agree that there are other parts of `GitHubPullRequest` that it would be worthwhile to cache, but lets tackle that in another PR.

-------------

PR: https://git.openjdk.java.net/skara/pull/294

From ehelin at openjdk.java.net  Thu Dec  5 09:50:52 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 09:50:52 GMT
Subject: [Integrated] RFR: Cache labels in GitHubPullRequest
In-Reply-To: 
References: 
Message-ID: <33f3f09a-5ec6-4b4c-b73b-5256cfd876a2@openjdk.org>

Changeset: c586baf9
Author:    Erik Helin 
Date:      2019-12-05 09:50:32 +0000
URL:       https://git.openjdk.java.net/skara/commit/c586baf9

Cache labels in GitHubPullRequest

Reviewed-by: rwestberg

! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java

From rwestberg at openjdk.java.net  Thu Dec  5 10:19:20 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 5 Dec 2019 10:19:20 GMT
Subject: [Integrated] RFR: 165: Replace large webrev files with
 placeholders instead of dropping them
In-Reply-To: 
References: 
Message-ID: <6b12d3a2-ae23-42d1-8a12-03aee076c5cf@openjdk.org>

Changeset: d88b5210
Author:    Robin Westberg 
Date:      2019-12-05 10:19:08 +0000
URL:       https://git.openjdk.java.net/skara/commit/d88b5210

165: Replace large webrev files with placeholders instead of dropping them

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevStorage.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/WebrevStorageTests.java

From rwestberg at openjdk.java.net  Thu Dec  5 10:21:01 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 5 Dec 2019 10:21:01 GMT
Subject: RFR: Try a bit harder to generate incremental webrevs
Message-ID: 

Hi all,

Please review this change that makes the mailing list bridge bot try a little harder to generate an incremental webrev. If a pull request has been rebased or merged the latest changes from the target branch, it may be possible to exclude these and generate a clean incremental webrev. If so, we do that.

Best regards,
Robin

-------------

Commits:
 - 9a37cbf2: Try a bit harder to generate incremental webrevs

Changes: https://git.openjdk.java.net/skara/pull/295/files
 Webrev: https://webrevs.openjdk.java.net/skara/295/webrev.00
  Stats: 105 lines in 4 files changed: 102 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/skara/pull/295.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/295/head:pull/295

PR: https://git.openjdk.java.net/skara/pull/295

From ehelin at openjdk.java.net  Thu Dec  5 10:32:28 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 10:32:28 GMT
Subject: RFR: Lazily request repository JSON for GitHub
Message-ID: 

Hi all,

please review this small pull request that ensures that we lazily request project info for an instance of `GitHubRepository`. It is quite common to only use a `GitHubRepository` instance to request for example all pull requests, a call which does need the project info to be populated. This patch saves us a network request in such scenarios. The caching is safe since an instance `GitHubRepository` can only be accessed by a single thread at a time.

Thanks,
Erik

-------------

Commits:
 - f451862c: Lazily request repository JSON for GitHub

Changes: https://git.openjdk.java.net/skara/pull/296/files
 Webrev: https://webrevs.openjdk.java.net/skara/296/webrev.00
  Stats: 14 lines in 1 file changed: 9 ins; 1 del; 4 mod
  Patch: https://git.openjdk.java.net/skara/pull/296.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/296/head:pull/296

PR: https://git.openjdk.java.net/skara/pull/296

From rwestberg at openjdk.java.net  Thu Dec  5 10:34:20 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 5 Dec 2019 10:34:20 GMT
Subject: RFR: Lazily request repository JSON for GitHub
In-Reply-To: 
References: 
Message-ID: <3_eOft1XVdPi7yyJ0B5vxAix52nv3V-wy-IN6w7O6ek=.77004f41-333f-412b-9f42-65b6d3ea3be8@github.com>

On Thu, 5 Dec 2019 10:31:51 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this small pull request that ensures that we lazily request project info for an instance of `GitHubRepository`. It is quite common to only use a `GitHubRepository` instance to request for example all pull requests, a call which does need the project info to be populated. This patch saves us a network request in such scenarios. The caching is safe since an instance `GitHubRepository` can only be accessed by a single thread at a time.
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/296

From ehelin at openjdk.java.net  Thu Dec  5 10:34:40 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 10:34:40 GMT
Subject: [Integrated] RFR: Lazily request repository JSON for GitHub
In-Reply-To: 
References: 
Message-ID: <65f76047-e423-444a-8cb4-8a6ade069c9e@openjdk.org>

Changeset: fbf47850
Author:    Erik Helin 
Date:      2019-12-05 10:34:27 +0000
URL:       https://git.openjdk.java.net/skara/commit/fbf47850

Lazily request repository JSON for GitHub

Reviewed-by: rwestberg

! forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java

From ehelin at openjdk.java.net  Thu Dec  5 10:38:59 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 10:38:59 GMT
Subject: RFR: Try a bit harder to generate incremental webrevs
In-Reply-To: 
References: 
Message-ID: <5hn6tHMTg_8zh0A01mjKb8A8j1_3104o1PXO_KqhCEs=.726a23c3-edec-402a-8992-de9f22408edf@github.com>

On Thu, 5 Dec 2019 10:20:16 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this change that makes the mailing list bridge bot try a little harder to generate an incremental webrev. If a pull request has been rebased or merged the latest changes from the target branch, it may be possible to exclude these and generate a clean incremental webrev. If so, we do that.
> 
> Best regards,
> Robin

Wow, really nice feature! Looks good, well done!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/295

From rwestberg at openjdk.java.net  Thu Dec  5 10:41:09 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 5 Dec 2019 10:41:09 GMT
Subject: RFR: Try a bit harder to generate incremental webrevs
In-Reply-To: <5hn6tHMTg_8zh0A01mjKb8A8j1_3104o1PXO_KqhCEs=.726a23c3-edec-402a-8992-de9f22408edf@github.com>
References: 
 <5hn6tHMTg_8zh0A01mjKb8A8j1_3104o1PXO_KqhCEs=.726a23c3-edec-402a-8992-de9f22408edf@github.com>
Message-ID: <8L6BJy1B0WPcelzCb2zWBtFDDSt983tQs7q5SrZt-IU=.ffde23c0-ff1b-4014-8979-ae035c7afdeb@github.com>

On Thu, 5 Dec 2019 10:38:44 GMT, Erik Helin  wrote:

>> Hi all,
>> 
>> Please review this change that makes the mailing list bridge bot try a little harder to generate an incremental webrev. If a pull request has been rebased or merged the latest changes from the target branch, it may be possible to exclude these and generate a clean incremental webrev. If so, we do that.
>> 
>> Best regards,
>> Robin
> 
> Wow, really nice feature! Looks good, well done!

Thanks for reviewing! Yes, will be interesting to see how often this works in practice!

-------------

PR: https://git.openjdk.java.net/skara/pull/295

From rwestberg at openjdk.java.net  Thu Dec  5 10:43:00 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 5 Dec 2019 10:43:00 GMT
Subject: [Integrated] RFR: Try a bit harder to generate incremental webrevs
In-Reply-To: 
References: 
Message-ID: 

Changeset: 60a4f7f1
Author:    Robin Westberg 
Date:      2019-12-05 10:42:50 +0000
URL:       https://git.openjdk.java.net/skara/commit/60a4f7f1

Try a bit harder to generate incremental webrevs

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java

From ehelin at openjdk.java.net  Thu Dec  5 11:03:50 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 11:03:50 GMT
Subject: RFR: git-pr: use upstream remote if available
Message-ID: <6mwjtwdwubS7LoG0qoGwndWU5ShDaSVuXZ4PbqAuqKE=.52a8fc08-c9a5-4a82-b615-cede3cb3113c@github.com>

Hi all,

please review this PR that updates `git pr` to make use of a `upstream` remote
if one is available. This speeds things up a bit since we don't have use the
forges REST API's to find the upstream ("parent") repository.

Thanks,
Erik

- [x] Manual testing of `git-pr` on Linux x64

-------------

Commits:
 - 3713cd63: git-pr: use upstream remote if available

Changes: https://git.openjdk.java.net/skara/pull/297/files
 Webrev: https://webrevs.openjdk.java.net/skara/297/webrev.00
  Stats: 26 lines in 1 file changed: 12 ins; 1 del; 13 mod
  Patch: https://git.openjdk.java.net/skara/pull/297.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/297/head:pull/297

PR: https://git.openjdk.java.net/skara/pull/297

From rwestberg at openjdk.java.net  Thu Dec  5 11:05:19 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 5 Dec 2019 11:05:19 GMT
Subject: RFR: git-pr: use upstream remote if available
In-Reply-To: <6mwjtwdwubS7LoG0qoGwndWU5ShDaSVuXZ4PbqAuqKE=.52a8fc08-c9a5-4a82-b615-cede3cb3113c@github.com>
References: <6mwjtwdwubS7LoG0qoGwndWU5ShDaSVuXZ4PbqAuqKE=.52a8fc08-c9a5-4a82-b615-cede3cb3113c@github.com>
Message-ID: 

On Thu, 5 Dec 2019 11:03:09 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this PR that updates `git pr` to make use of a `upstream` remote
> if one is available. This speeds things up a bit since we don't have use the
> forges REST API's to find the upstream ("parent") repository.
> 
> Thanks,
> Erik
> 
> - [x] Manual testing of `git-pr` on Linux x64

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/297

From ehelin at openjdk.java.net  Thu Dec  5 13:23:47 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 13:23:47 GMT
Subject: [Integrated] RFR: git-pr: use upstream remote if available
In-Reply-To: <6mwjtwdwubS7LoG0qoGwndWU5ShDaSVuXZ4PbqAuqKE=.52a8fc08-c9a5-4a82-b615-cede3cb3113c@github.com>
References: <6mwjtwdwubS7LoG0qoGwndWU5ShDaSVuXZ4PbqAuqKE=.52a8fc08-c9a5-4a82-b615-cede3cb3113c@github.com>
Message-ID: <79e213a4-b0e3-4d39-9b6e-ca8df8ff25d8@openjdk.org>

Changeset: adf1bcb7
Author:    Erik Helin 
Date:      2019-12-05 13:23:34 +0000
URL:       https://git.openjdk.java.net/skara/commit/adf1bcb7

git-pr: use upstream remote if available

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java

From ehelin at openjdk.java.net  Thu Dec  5 13:31:56 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 13:31:56 GMT
Subject: RFR: git-pr: no need to check forge validity
Message-ID: 

Hi all,

please review this small patch that removes an superfluous call to
`Forge.isValid` in `git-pr`. `Forge.from` already ensures that the returned
`Forge` is valid, so there is no need for `git-pr` to repeat this check.

Thanks,
Erik

-------------

Commits:
 - 1010210f: git-pr: no need to check forge validity

Changes: https://git.openjdk.java.net/skara/pull/298/files
 Webrev: https://webrevs.openjdk.java.net/skara/298/webrev.00
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/298.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/298/head:pull/298

PR: https://git.openjdk.java.net/skara/pull/298

From rwestberg at openjdk.java.net  Thu Dec  5 13:50:30 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 5 Dec 2019 13:50:30 GMT
Subject: RFR: git-pr: no need to check forge validity
In-Reply-To: 
References: 
Message-ID: 

On Thu, 5 Dec 2019 13:30:38 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this small patch that removes an superfluous call to
> `Forge.isValid` in `git-pr`. `Forge.from` already ensures that the returned
> `Forge` is valid, so there is no need for `git-pr` to repeat this check.
> 
> Thanks,
> Erik

Looks good, must be quite fast by now!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/298

From ehelin at openjdk.java.net  Thu Dec  5 14:20:00 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 14:20:00 GMT
Subject: [Integrated] RFR: git-pr: no need to check forge validity
In-Reply-To: 
References: 
Message-ID: 

Changeset: 35b9f650
Author:    Erik Helin 
Date:      2019-12-05 14:19:50 +0000
URL:       https://git.openjdk.java.net/skara/commit/35b9f650

git-pr: no need to check forge validity

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java

From ehelin at openjdk.java.net  Thu Dec  5 14:27:57 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 14:27:57 GMT
Subject: RFR: git-pr: do not fetch pull requests twice
Message-ID: 

Hi all,

please review this small patch that fixes an issue where `git-pr` would
unnecessarily download the metadata for all pull requests _twice_.

Thanks,
Erik

-------------

Commits:
 - 410cf917: git-pr: do not fetch pull requests twice

Changes: https://git.openjdk.java.net/skara/pull/299/files
 Webrev: https://webrevs.openjdk.java.net/skara/299/webrev.00
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/299.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/299/head:pull/299

PR: https://git.openjdk.java.net/skara/pull/299

From rwestberg at openjdk.java.net  Thu Dec  5 14:28:40 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 5 Dec 2019 14:28:40 GMT
Subject: RFR: git-pr: do not fetch pull requests twice
In-Reply-To: 
References: 
Message-ID: 

On Thu, 5 Dec 2019 14:27:11 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this small patch that fixes an issue where `git-pr` would
> unnecessarily download the metadata for all pull requests _twice_.
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/299

From ehelin at openjdk.java.net  Thu Dec  5 14:55:11 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 5 Dec 2019 14:55:11 GMT
Subject: [Integrated] RFR: git-pr: do not fetch pull requests twice
In-Reply-To: 
References: 
Message-ID: 

Changeset: 14512736
Author:    Erik Helin 
Date:      2019-12-05 14:54:51 +0000
URL:       https://git.openjdk.java.net/skara/commit/14512736

git-pr: do not fetch pull requests twice

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java

From ehelin at openjdk.java.net  Fri Dec  6 15:33:36 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 6 Dec 2019 15:33:36 GMT
Subject: RFR: git-fork: support configuration and more options
Message-ID: 

Hi all,

please review this (large) rewrite of `git-fork`. The command is mostly
backwards compatible, but I've added a number of new options (and made them all
configurable).

Some particulary nice features:

- support for `--reference` means really fast clone times if you have a similar
  repository available locally
- support for `--forge` means very short command-lines (particularly if you one
  configures this flag)
- support for the `ssh://` protocol is more natural when cloning a personal fork

All features taken together becomes faily smooth. As an example, consider the
following `~/.gitconfig`:

[fork]
       ssh = true
       forge = github.com
       reference = ~/git/github.com/openjdk/jdk

_If_ I have a `jdk` repository available at the above path (it doesn't have to
be up to date), then a fork of _any_ jdk derived repostiry becomes really fast:

$ time git fork openjdk/panama
Fork available at: https://github.com/edvbld/panama
Cloning ssh://git at github.com/edvbld/panama.git...
Cloning into 'panama'...
remote: Enumerating objects: 12082, done.
remote: Counting objects: 100% (12082/12082), done.
remote: Total 35466 (delta 12082), reused 12082 (delta 12082), pack-reused 23384
Receiving objects: 100% (35466/35466), 13.08 MiB | 10.86 MiB/s, done.
Resolving deltas: 100% (28691/28691), completed with 1851 local objects.
Updating files: 100% (67732/67732), done.
Adding remote 'upstream' for https://github.com/openjdk/panama...done

real    0m23.801s
user    0m8.834s
sys     0m2.959s

I've tested `git-pr` manually and it all seems to hang together ??

Thanks,
Erik

-------------

Commits:
 - 530f03ef: git-fork: support configuration and more options

Changes: https://git.openjdk.java.net/skara/pull/300/files
 Webrev: https://webrevs.openjdk.java.net/skara/300/webrev.00
  Stats: 212 lines in 1 file changed: 155 ins; 8 del; 49 mod
  Patch: https://git.openjdk.java.net/skara/pull/300.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/300/head:pull/300

PR: https://git.openjdk.java.net/skara/pull/300

From ehelin at openjdk.java.net  Mon Dec  9 07:40:43 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 9 Dec 2019 07:40:43 GMT
Subject: [Rev 01] RFR: git-fork: support configuration and more options
In-Reply-To: 
References: 
Message-ID: 

> Hi all,
> 
> please review this (large) rewrite of `git-fork`. The command is mostly
> backwards compatible, but I've added a number of new options (and made them all
> configurable).
> 
> Some particularly nice features:
> 
> - support for `--reference` means really fast clone times if you have a similar
>   repository available locally
> - support for `--host` means very short command-lines (particularly if you one
>   configures this flag)
> - support for the `ssh://` protocol is more natural when cloning a personal fork
> 
> All features taken together becomes faily smooth. As an example, consider the
> following `~/.gitconfig`:
> 
> [fork]
>        ssh = true
>        host = github.com
>        reference = ~/git/github.com/openjdk/jdk
> 
> _If_ I have a `jdk` repository available at the above path (it doesn't have to
> be up to date), then a fork of _any_ jdk derived repostiry becomes really fast:
> 
> $ time git fork openjdk/panama
> Fork available at: https://github.com/edvbld/panama
> Cloning ssh://git at github.com/edvbld/panama.git...
> Cloning into 'panama'...
> remote: Enumerating objects: 12082, done.
> remote: Counting objects: 100% (12082/12082), done.
> remote: Total 35466 (delta 12082), reused 12082 (delta 12082), pack-reused 23384
> Receiving objects: 100% (35466/35466), 13.08 MiB | 10.86 MiB/s, done.
> Resolving deltas: 100% (28691/28691), completed with 1851 local objects.
> Updating files: 100% (67732/67732), done.
> Adding remote 'upstream' for https://github.com/openjdk/panama...done
> 
> real    0m23.801s
> user    0m8.834s
> sys     0m2.959s
> 
> I've tested `git-pr` manually and it all seems to hang together ??
> 
> Thanks,
> Erik

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - 727627ec: Use --host instead of --forge

Changes:
  - all: https://git.openjdk.java.net/skara/pull/300/files
  - new: https://git.openjdk.java.net/skara/pull/300/files/530f03ef..727627ec

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/300/webrev.01
 - incr: https://webrevs.openjdk.java.net/skara/300/webrev.00-01

  Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/skara/pull/300.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/300/head:pull/300

PR: https://git.openjdk.java.net/skara/pull/300

From rwestberg at openjdk.java.net  Mon Dec  9 07:40:44 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 9 Dec 2019 07:40:44 GMT
Subject: [Rev 01] RFR: git-fork: support configuration and more options
In-Reply-To: 
References: 
 
Message-ID: 

On Mon, 9 Dec 2019 07:40:24 GMT, Erik Helin  wrote:

>> Hi all,
>> 
>> please review this (large) rewrite of `git-fork`. The command is mostly
>> backwards compatible, but I've added a number of new options (and made them all
>> configurable).
>> 
>> Some particularly nice features:
>> 
>> - support for `--reference` means really fast clone times if you have a similar
>>   repository available locally
>> - support for `--host` means very short command-lines (particularly if you one
>>   configures this flag)
>> - support for the `ssh://` protocol is more natural when cloning a personal fork
>> 
>> All features taken together becomes faily smooth. As an example, consider the
>> following `~/.gitconfig`:
>> 
>> [fork]
>>        ssh = true
>>        host = github.com
>>        reference = ~/git/github.com/openjdk/jdk
>> 
>> _If_ I have a `jdk` repository available at the above path (it doesn't have to
>> be up to date), then a fork of _any_ jdk derived repostiry becomes really fast:
>> 
>> $ time git fork openjdk/panama
>> Fork available at: https://github.com/edvbld/panama
>> Cloning ssh://git at github.com/edvbld/panama.git...
>> Cloning into 'panama'...
>> remote: Enumerating objects: 12082, done.
>> remote: Counting objects: 100% (12082/12082), done.
>> remote: Total 35466 (delta 12082), reused 12082 (delta 12082), pack-reused 23384
>> Receiving objects: 100% (35466/35466), 13.08 MiB | 10.86 MiB/s, done.
>> Resolving deltas: 100% (28691/28691), completed with 1851 local objects.
>> Updating files: 100% (67732/67732), done.
>> Adding remote 'upstream' for https://github.com/openjdk/panama...done
>> 
>> real    0m23.801s
>> user    0m8.834s
>> sys     0m2.959s
>> 
>> I've tested `git-pr` manually and it all seems to hang together ??
>> 
>> Thanks,
>> Erik
> 
> The pull request has been updated with 1 additional commit.

Looks good, just had a few minor text comments!

cli/src/main/java/org/openjdk/skara/cli/GitFork.java line 112:

> 111:                   .describe("DIR")
> 112:                   .helptext("Same as git clones flag 'reference-if-able'")
> 113:                   .optional(),

Suggestion:

                  .helptext("Same as git clone's flag 'reference-if-able'")

cli/src/main/java/org/openjdk/skara/cli/GitFork.java line 230:

> 229:         if (credentials.password() == null) {
> 230:             exit("error: no personal acess token found, use git-credentials or the environment variable GIT_TOKEN");
> 231:         }

Suggestion:

            exit("error: no personal access token found, use git-credentials or the environment variable GIT_TOKEN");

cli/src/main/java/org/openjdk/skara/cli/GitFork.java line 233:

> 232:         if (credentials.username() == null) {
> 233:             exit("error: no username for found, use git-credentials or the flag --username");
> 234:         }

Suggestion:

            exit("error: no username for " + webURI.getHost() + " found, use git-credentials or the flag --username");

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/300

From ehelin at openjdk.java.net  Mon Dec  9 09:43:01 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 9 Dec 2019 09:43:01 GMT
Subject: [Rev 02] RFR: git-fork: support configuration and more options
In-Reply-To: 
References: 
Message-ID: 

> Hi all,
> 
> please review this (large) rewrite of `git-fork`. The command is mostly
> backwards compatible, but I've added a number of new options (and made them all
> configurable).
> 
> Some particularly nice features:
> 
> - support for `--reference` means really fast clone times if you have a similar
>   repository available locally
> - support for `--host` means very short command-lines (particularly if you one
>   configures this flag)
> - support for the `ssh://` protocol is more natural when cloning a personal fork
> 
> All features taken together becomes faily smooth. As an example, consider the
> following `~/.gitconfig`:
> 
> [fork]
>        ssh = true
>        host = github.com
>        reference = ~/git/github.com/openjdk/jdk
> 
> _If_ I have a `jdk` repository available at the above path (it doesn't have to
> be up to date), then a fork of _any_ jdk derived repostiry becomes really fast:
> 
> $ time git fork openjdk/panama
> Fork available at: https://github.com/edvbld/panama
> Cloning ssh://git at github.com/edvbld/panama.git...
> Cloning into 'panama'...
> remote: Enumerating objects: 12082, done.
> remote: Counting objects: 100% (12082/12082), done.
> remote: Total 35466 (delta 12082), reused 12082 (delta 12082), pack-reused 23384
> Receiving objects: 100% (35466/35466), 13.08 MiB | 10.86 MiB/s, done.
> Resolving deltas: 100% (28691/28691), completed with 1851 local objects.
> Updating files: 100% (67732/67732), done.
> Adding remote 'upstream' for https://github.com/openjdk/panama...done
> 
> real    0m23.801s
> user    0m8.834s
> sys     0m2.959s
> 
> I've tested `git-pr` manually and it all seems to hang together ??
> 
> Thanks,
> Erik

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - baa569ce: Fix spelling

Changes:
  - all: https://git.openjdk.java.net/skara/pull/300/files
  - new: https://git.openjdk.java.net/skara/pull/300/files/727627ec..baa569ce

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/300/webrev.02
 - incr: https://webrevs.openjdk.java.net/skara/300/webrev.01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/300.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/300/head:pull/300

PR: https://git.openjdk.java.net/skara/pull/300

From ehelin at openjdk.java.net  Mon Dec  9 09:43:30 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 9 Dec 2019 09:43:30 GMT
Subject: [Rev 03] RFR: git-fork: support configuration and more options
In-Reply-To: 
References: 
Message-ID: 

> Hi all,
> 
> please review this (large) rewrite of `git-fork`. The command is mostly
> backwards compatible, but I've added a number of new options (and made them all
> configurable).
> 
> Some particularly nice features:
> 
> - support for `--reference` means really fast clone times if you have a similar
>   repository available locally
> - support for `--host` means very short command-lines (particularly if you one
>   configures this flag)
> - support for the `ssh://` protocol is more natural when cloning a personal fork
> 
> All features taken together becomes faily smooth. As an example, consider the
> following `~/.gitconfig`:
> 
> [fork]
>        ssh = true
>        host = github.com
>        reference = ~/git/github.com/openjdk/jdk
> 
> _If_ I have a `jdk` repository available at the above path (it doesn't have to
> be up to date), then a fork of _any_ jdk derived repostiry becomes really fast:
> 
> $ time git fork openjdk/panama
> Fork available at: https://github.com/edvbld/panama
> Cloning ssh://git at github.com/edvbld/panama.git...
> Cloning into 'panama'...
> remote: Enumerating objects: 12082, done.
> remote: Counting objects: 100% (12082/12082), done.
> remote: Total 35466 (delta 12082), reused 12082 (delta 12082), pack-reused 23384
> Receiving objects: 100% (35466/35466), 13.08 MiB | 10.86 MiB/s, done.
> Resolving deltas: 100% (28691/28691), completed with 1851 local objects.
> Updating files: 100% (67732/67732), done.
> Adding remote 'upstream' for https://github.com/openjdk/panama...done
> 
> real    0m23.801s
> user    0m8.834s
> sys     0m2.959s
> 
> I've tested `git-pr` manually and it all seems to hang together ??
> 
> Thanks,
> Erik

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - 64fec188: Fix more spelling

Changes:
  - all: https://git.openjdk.java.net/skara/pull/300/files
  - new: https://git.openjdk.java.net/skara/pull/300/files/baa569ce..64fec188

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/300/webrev.03
 - incr: https://webrevs.openjdk.java.net/skara/300/webrev.02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/300.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/300/head:pull/300

PR: https://git.openjdk.java.net/skara/pull/300

From ehelin at openjdk.java.net  Mon Dec  9 09:44:16 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 9 Dec 2019 09:44:16 GMT
Subject: [Rev 04] RFR: git-fork: support configuration and more options
In-Reply-To: 
References: 
Message-ID: 

> Hi all,
> 
> please review this (large) rewrite of `git-fork`. The command is mostly
> backwards compatible, but I've added a number of new options (and made them all
> configurable).
> 
> Some particularly nice features:
> 
> - support for `--reference` means really fast clone times if you have a similar
>   repository available locally
> - support for `--host` means very short command-lines (particularly if you one
>   configures this flag)
> - support for the `ssh://` protocol is more natural when cloning a personal fork
> 
> All features taken together becomes faily smooth. As an example, consider the
> following `~/.gitconfig`:
> 
> [fork]
>        ssh = true
>        host = github.com
>        reference = ~/git/github.com/openjdk/jdk
> 
> _If_ I have a `jdk` repository available at the above path (it doesn't have to
> be up to date), then a fork of _any_ jdk derived repostiry becomes really fast:
> 
> $ time git fork openjdk/panama
> Fork available at: https://github.com/edvbld/panama
> Cloning ssh://git at github.com/edvbld/panama.git...
> Cloning into 'panama'...
> remote: Enumerating objects: 12082, done.
> remote: Counting objects: 100% (12082/12082), done.
> remote: Total 35466 (delta 12082), reused 12082 (delta 12082), pack-reused 23384
> Receiving objects: 100% (35466/35466), 13.08 MiB | 10.86 MiB/s, done.
> Resolving deltas: 100% (28691/28691), completed with 1851 local objects.
> Updating files: 100% (67732/67732), done.
> Adding remote 'upstream' for https://github.com/openjdk/panama...done
> 
> real    0m23.801s
> user    0m8.834s
> sys     0m2.959s
> 
> I've tested `git-pr` manually and it all seems to hang together ??
> 
> Thanks,
> Erik

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - dfae228f: Print host

Changes:
  - all: https://git.openjdk.java.net/skara/pull/300/files
  - new: https://git.openjdk.java.net/skara/pull/300/files/64fec188..dfae228f

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/300/webrev.04
 - incr: https://webrevs.openjdk.java.net/skara/300/webrev.03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/300.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/300/head:pull/300

PR: https://git.openjdk.java.net/skara/pull/300

From ehelin at openjdk.java.net  Mon Dec  9 09:44:30 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 9 Dec 2019 09:44:30 GMT
Subject: [Rev 04] RFR: git-fork: support configuration and more options
In-Reply-To: 
References: 
 
 
Message-ID: 

On Mon, 9 Dec 2019 07:17:59 GMT, Robin Westberg  wrote:

>> The pull request has been updated with 1 additional commit.
> 
> Looks good, just had a few minor text comments!

Thanks Robin for reviewing!

-------------

PR: https://git.openjdk.java.net/skara/pull/300

From ehelin at openjdk.java.net  Mon Dec  9 10:01:09 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 9 Dec 2019 10:01:09 GMT
Subject: [Integrated] RFR: git-fork: support configuration and more options
In-Reply-To: 
References: 
Message-ID: 

Changeset: 42099781
Author:    Erik Helin 
Date:      2019-12-09 10:00:55 +0000
URL:       https://git.openjdk.java.net/skara/commit/42099781

git-fork: support configuration and more options

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitFork.java

From ehelin at openjdk.java.net  Mon Dec  9 10:09:06 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 9 Dec 2019 10:09:06 GMT
Subject: RFR: git-sync: use upstream remote and support fork remote
Message-ID: 

Hi all,

please review this patch that makes `git-sync` use the `upstream` remote if it is available. `git-sync` has also learned that if the `fork` remote is present, then it should sync from `origin` to `fork`.

I also updated the names to make them clearer, the words `upstream` and `origin` were confusing.

Thanks,
Erik

## Testing
- [x] Manual testing of `git-sync` on Linux x64

-------------

Commits:
 - 9fb50503: git-sync: use upstream remote and support fork remote

Changes: https://git.openjdk.java.net/skara/pull/301/files
 Webrev: https://webrevs.openjdk.java.net/skara/301/webrev.00
  Stats: 38 lines in 1 file changed: 15 ins; 2 del; 21 mod
  Patch: https://git.openjdk.java.net/skara/pull/301.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/301/head:pull/301

PR: https://git.openjdk.java.net/skara/pull/301

From ehelin at openjdk.java.net  Mon Dec  9 13:31:18 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 9 Dec 2019 13:31:18 GMT
Subject: RFR: git-defpath: add support for --upstream and --fork
Message-ID: 

Hi all,

please review this patch that adds support for the `--upstream` and `--fork` arguments to `git-defpath` (note that `git defpath --fork` might fork the repo as a side-effect). I also made the rest of the arguments to `git-defpath` configurable.

Thanks,
Erik

## Testing
- [x] Manual testing of `git-defpath`

-------------

Commits:
 - 5dc9584c: git-defpath: add support for --upstream and --fork

Changes: https://git.openjdk.java.net/skara/pull/302/files
 Webrev: https://webrevs.openjdk.java.net/skara/302/webrev.00
  Stats: 131 lines in 1 file changed: 115 ins; 7 del; 9 mod
  Patch: https://git.openjdk.java.net/skara/pull/302.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/302/head:pull/302

PR: https://git.openjdk.java.net/skara/pull/302

From rwestberg at openjdk.java.net  Mon Dec  9 14:05:17 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 9 Dec 2019 14:05:17 GMT
Subject: RFR: git-sync: use upstream remote and support fork remote
In-Reply-To: 
References: 
Message-ID: <9J6XaUfEZOBHJeBa8bt3fZVkdfKgFKCxcGGCuJqjs9g=.26693830-6dfb-4475-8ed9-46256d5c8344@github.com>

On Mon, 9 Dec 2019 10:08:28 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that makes `git-sync` use the `upstream` remote if it is available. `git-sync` has also learned that if the `fork` remote is present, then it should sync from `origin` to `fork`.
> 
> I also updated the names to make them clearer, the words `upstream` and `origin` were confusing.
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git-sync` on Linux x64

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/301

From rwestberg at openjdk.java.net  Mon Dec  9 14:07:26 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 9 Dec 2019 14:07:26 GMT
Subject: RFR: git-defpath: add support for --upstream and --fork
In-Reply-To: 
References: 
Message-ID: 

On Mon, 9 Dec 2019 13:30:39 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that adds support for the `--upstream` and `--fork` arguments to `git-defpath` (note that `git defpath --fork` might fork the repo as a side-effect). I also made the rest of the arguments to `git-defpath` configurable.
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git-defpath`

Looks good as well!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/302

From ehelin at openjdk.java.net  Mon Dec  9 14:39:01 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 9 Dec 2019 14:39:01 GMT
Subject: RFR: git-webrev: add support for "upstream" remote
Message-ID: 

Hi all,

please review this small patch that add supports to `git-webrev` for repositories with a remote named `upstream` (used for discovering the upstream repository).

Thanks,
Erik

## Testing
- [x] Manual testing of `git-webrev`

-------------

Commits:
 - 5c078555: git-webrev: add support for "upstream" remote

Changes: https://git.openjdk.java.net/skara/pull/303/files
 Webrev: https://webrevs.openjdk.java.net/skara/303/webrev.00
  Stats: 27 lines in 1 file changed: 12 ins; 5 del; 10 mod
  Patch: https://git.openjdk.java.net/skara/pull/303.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/303/head:pull/303

PR: https://git.openjdk.java.net/skara/pull/303

From rwestberg at openjdk.java.net  Mon Dec  9 14:40:27 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 9 Dec 2019 14:40:27 GMT
Subject: RFR: git-webrev: add support for "upstream" remote
In-Reply-To: 
References: 
Message-ID: 

On Mon, 9 Dec 2019 14:37:31 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this small patch that add supports to `git-webrev` for repositories with a remote named `upstream` (used for discovering the upstream repository).
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git-webrev`

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/303

From ehelin at openjdk.java.net  Mon Dec  9 14:49:19 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 9 Dec 2019 14:49:19 GMT
Subject: [Integrated] RFR: git-defpath: add support for --upstream and
 --fork
In-Reply-To: 
References: 
Message-ID: 

Changeset: d383902d
Author:    Erik Helin 
Date:      2019-12-09 14:49:06 +0000
URL:       https://git.openjdk.java.net/skara/commit/d383902d

git-defpath: add support for --upstream and --fork

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitDefpath.java

From ehelin at openjdk.java.net  Mon Dec  9 14:49:30 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 9 Dec 2019 14:49:30 GMT
Subject: [Integrated] RFR: git-webrev: add support for "upstream" remote
In-Reply-To: 
References: 
Message-ID: <16c023fe-f690-466f-ab2d-36392e833bdb@openjdk.org>

Changeset: 4b59403a
Author:    Erik Helin 
Date:      2019-12-09 14:49:15 +0000
URL:       https://git.openjdk.java.net/skara/commit/4b59403a

git-webrev: add support for "upstream" remote

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java

From ehelin at openjdk.java.net  Mon Dec  9 14:49:49 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 9 Dec 2019 14:49:49 GMT
Subject: [Integrated] RFR: git-sync: use upstream remote and support fork
 remote
In-Reply-To: 
References: 
Message-ID: 

Changeset: 8d3e18d3
Author:    Erik Helin 
Date:      2019-12-09 14:49:32 +0000
URL:       https://git.openjdk.java.net/skara/commit/8d3e18d3

git-sync: use upstream remote and support fork remote

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitSync.java

From ehelin at openjdk.java.net  Tue Dec 10 08:44:19 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 10 Dec 2019 08:44:19 GMT
Subject: RFR: git-fork: add --sync option
Message-ID: 

Hi all,

please review this patch that adds the `--sync` option to `git-fork`. Setting
`--sync` (either via command-line or configuration file) makes `git-fork` sync
the fork with the upstream repository as a last step. This ensures that the
local clone of the fork on the user's machine is fully up to date with
upstream.

Note that I hade to shuffle some code around in `git-sync` to allow for this,
since `git-fork` simply just calls `git-sync` to implement this feaure.

Thanks,
Erik

- [x] Manual testing of `git-fork`

-------------

Commits:
 - e234fb97: git-fork: add --sync option

Changes: https://git.openjdk.java.net/skara/pull/304/files
 Webrev: https://webrevs.openjdk.java.net/skara/304/webrev.00
  Stats: 36 lines in 2 files changed: 27 ins; 4 del; 5 mod
  Patch: https://git.openjdk.java.net/skara/pull/304.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/304/head:pull/304

PR: https://git.openjdk.java.net/skara/pull/304

From rwestberg at openjdk.java.net  Tue Dec 10 08:51:28 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 10 Dec 2019 08:51:28 GMT
Subject: RFR: git-fork: add --sync option
In-Reply-To: 
References: 
Message-ID: 

On Tue, 10 Dec 2019 08:43:35 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that adds the `--sync` option to `git-fork`. Setting
> `--sync` (either via command-line or configuration file) makes `git-fork` sync
> the fork with the upstream repository as a last step. This ensures that the
> local clone of the fork on the user's machine is fully up to date with
> upstream.
> 
> Note that I hade to shuffle some code around in `git-sync` to allow for this,
> since `git-fork` simply just calls `git-sync` to implement this feaure.
> 
> Thanks,
> Erik
> 
> - [x] Manual testing of `git-fork`

Looks good, just one minor comment!

cli/src/main/java/org/openjdk/skara/cli/GitFork.java line 147:

> 146:                   .fullname("sync")
> 147:                   .helptext("Sync with the upstream repository after succesful fork")
> 148:                   .optional(),

Suggestion:

                  .helptext("Sync with the upstream repository after successful fork")

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/304

From ehelin at openjdk.java.net  Tue Dec 10 09:07:57 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 10 Dec 2019 09:07:57 GMT
Subject: [Rev 01] RFR: git-fork: add --sync option
In-Reply-To: 
References: 
Message-ID: 

> Hi all,
> 
> please review this patch that adds the `--sync` option to `git-fork`. Setting
> `--sync` (either via command-line or configuration file) makes `git-fork` sync
> the fork with the upstream repository as a last step. This ensures that the
> local clone of the fork on the user's machine is fully up to date with
> upstream.
> 
> Note that I hade to shuffle some code around in `git-sync` to allow for this,
> since `git-fork` simply just calls `git-sync` to implement this feaure.
> 
> Thanks,
> Erik
> 
> - [x] Manual testing of `git-fork`

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - b4a2d986: Fix spelling

Changes:
  - all: https://git.openjdk.java.net/skara/pull/304/files
  - new: https://git.openjdk.java.net/skara/pull/304/files/e234fb97..b4a2d986

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/304/webrev.01
 - incr: https://webrevs.openjdk.java.net/skara/304/webrev.00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/304.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/304/head:pull/304

PR: https://git.openjdk.java.net/skara/pull/304

From ehelin at openjdk.java.net  Tue Dec 10 09:08:12 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 10 Dec 2019 09:08:12 GMT
Subject: [Rev 01] RFR: git-fork: add --sync option
In-Reply-To: 
References: 
 
Message-ID: 

On Tue, 10 Dec 2019 08:50:33 GMT, Robin Westberg  wrote:

>> The pull request has been updated with 1 additional commit.
> 
> cli/src/main/java/org/openjdk/skara/cli/GitFork.java line 147:
> 
>> 146:                   .fullname("sync")
>> 147:                   .helptext("Sync with the upstream repository after succesful fork")
>> 148:                   .optional(),
> 
> Suggestion:
> 
>                   .helptext("Sync with the upstream repository after successful fork")

Thanks!

-------------

PR: https://git.openjdk.java.net/skara/pull/304

From ehelin at openjdk.java.net  Tue Dec 10 09:08:20 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 10 Dec 2019 09:08:20 GMT
Subject: [Integrated] RFR: git-fork: add --sync option
In-Reply-To: 
References: 
Message-ID: <752b3ba6-c83e-4569-92b2-d170f6313d6e@openjdk.org>

Changeset: d0f98bec
Author:    Erik Helin 
Date:      2019-12-10 09:08:07 +0000
URL:       https://git.openjdk.java.net/skara/commit/d0f98bec

git-fork: add --sync option

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitFork.java
! cli/src/main/java/org/openjdk/skara/cli/GitSync.java

From ehelin at openjdk.java.net  Tue Dec 10 09:26:29 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 10 Dec 2019 09:26:29 GMT
Subject: RFR: git-fork: support subsection specific configuration
Message-ID: 

Hi all,

please review this patch that allows for subsection specific configurations for `git-fork`. 
For example if a user wants to reference different local repositories for
different upstream projects, that is now possible:

[fork]
       ssh = true
       sync = true

[fork "openjdk/jdk"]
       reference = ~/git/github.com/openjdk/jdk

[fork "openjdk/skara"]
       reference = ~/git/github.com/openjdk/skara

Thanks,
Erik

- [x] Manual testing of `git-fork`

-------------

Commits:
 - db9f8011: git-fork: support subsection specific configuration

Changes: https://git.openjdk.java.net/skara/pull/305/files
 Webrev: https://webrevs.openjdk.java.net/skara/305/webrev.00
  Stats: 65 lines in 1 file changed: 33 ins; 22 del; 10 mod
  Patch: https://git.openjdk.java.net/skara/pull/305.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/305/head:pull/305

PR: https://git.openjdk.java.net/skara/pull/305

From rwestberg at openjdk.java.net  Tue Dec 10 10:00:19 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 10 Dec 2019 10:00:19 GMT
Subject: RFR: git-fork: support subsection specific configuration
In-Reply-To: 
References: 
Message-ID: 

On Tue, 10 Dec 2019 09:25:49 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that allows for subsection specific configurations for `git-fork`. 
> For example if a user wants to reference different local repositories for
> different upstream projects, that is now possible:
> 
> [fork]
>        ssh = true
>        sync = true
> 
> [fork "openjdk/jdk"]
>        reference = ~/git/github.com/openjdk/jdk
> 
> [fork "openjdk/skara"]
>        reference = ~/git/github.com/openjdk/skara
> 
> Thanks,
> Erik
> 
> - [x] Manual testing of `git-fork`

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/305

From ehelin at openjdk.java.net  Tue Dec 10 13:33:17 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 10 Dec 2019 13:33:17 GMT
Subject: git: openjdk/skara: git-fork: support subsection specific
 configuration
Message-ID: 

Changeset: 870b670e
Author:    Erik Helin 
Date:      2019-12-10 13:33:07 +0000
URL:       https://git.openjdk.java.net/skara/commit/870b670e

git-fork: support subsection specific configuration

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitFork.java


From rwestberg at openjdk.java.net  Tue Dec 10 13:40:49 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 10 Dec 2019 13:40:49 GMT
Subject: RFR: Add support for Issue links with Jira implementation
Message-ID: <249DShE_OHPem6zBk_VBoRd9n2QBn-WOK2a6XwLC89M=.cf5378bb-d122-4438-ad35-1967ef80c8d7@github.com>

Hi all,

Please review this change that adds support for adding links to an issue, with an implementation for Jira and TestIssue.

Best regards,
Robin

-------------

Commits:
 - a10e4a3b: Add support for Issue links with Jira implementation

Changes: https://git.openjdk.java.net/skara/pull/306/files
 Webrev: https://webrevs.openjdk.java.net/skara/306/webrev.00
  Stats: 387 lines in 10 files changed: 384 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/306.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/306/head:pull/306

PR: https://git.openjdk.java.net/skara/pull/306

From ehelin at openjdk.java.net  Tue Dec 10 14:08:36 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 10 Dec 2019 14:08:36 GMT
Subject: RFR: Add support for Issue links with Jira implementation
In-Reply-To: <249DShE_OHPem6zBk_VBoRd9n2QBn-WOK2a6XwLC89M=.cf5378bb-d122-4438-ad35-1967ef80c8d7@github.com>
References: <249DShE_OHPem6zBk_VBoRd9n2QBn-WOK2a6XwLC89M=.cf5378bb-d122-4438-ad35-1967ef80c8d7@github.com>
Message-ID: 

On Tue, 10 Dec 2019 13:40:09 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this change that adds support for adding links to an issue, with an implementation for Jira and TestIssue.
> 
> Best regards,
> Robin

Nice patch, looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/306

From rwestberg at openjdk.java.net  Tue Dec 10 14:19:36 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 10 Dec 2019 14:19:36 GMT
Subject: RFR: Add support for Issue links with Jira implementation
In-Reply-To: 
References: <249DShE_OHPem6zBk_VBoRd9n2QBn-WOK2a6XwLC89M=.cf5378bb-d122-4438-ad35-1967ef80c8d7@github.com>
 
Message-ID: 

On Tue, 10 Dec 2019 14:08:26 GMT, Erik Helin  wrote:

>> Hi all,
>> 
>> Please review this change that adds support for adding links to an issue, with an implementation for Jira and TestIssue.
>> 
>> Best regards,
>> Robin
> 
> Nice patch, looks good!

Thanks for reviewing!

-------------

PR: https://git.openjdk.java.net/skara/pull/306

From rwestberg at openjdk.java.net  Tue Dec 10 14:19:57 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 10 Dec 2019 14:19:57 GMT
Subject: [Integrated] RFR: Add support for Issue links with Jira
 implementation
In-Reply-To: <249DShE_OHPem6zBk_VBoRd9n2QBn-WOK2a6XwLC89M=.cf5378bb-d122-4438-ad35-1967ef80c8d7@github.com>
References: <249DShE_OHPem6zBk_VBoRd9n2QBn-WOK2a6XwLC89M=.cf5378bb-d122-4438-ad35-1967ef80c8d7@github.com>
Message-ID: <69b2f2d2-ff31-4b28-b0f9-728240d84637@openjdk.org>

Changeset: 4b6d324f
Author:    Robin Westberg 
Date:      2019-12-10 14:19:45 +0000
URL:       https://git.openjdk.java.net/skara/commit/4b6d324f

Add support for Issue links with Jira implementation

Reviewed-by: ehelin

! bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java
! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java
! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/Issue.java
+ issuetracker/src/main/java/org/openjdk/skara/issuetracker/Link.java
+ issuetracker/src/main/java/org/openjdk/skara/issuetracker/LinkBuilder.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java
! issuetracker/src/test/java/org/openjdk/skara/issuetracker/IssueTrackerTests.java
! test/src/main/java/org/openjdk/skara/test/IssueData.java
! test/src/main/java/org/openjdk/skara/test/TestIssue.java

From ehelin at openjdk.java.net  Tue Dec 10 14:34:09 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 10 Dec 2019 14:34:09 GMT
Subject: RFR: 184: git-webrev exception on deleted files in hg
Message-ID: 

Hi all,

please review this patch that improves how our Mercurial plugin detects copied
and renamed files. We have to have our `diff_git_raw` implementation produce
the same results as `hg diff --git`, otherwise one might consider a file
renamed and the other one not, resulting in problems.

This patch make the results of `diff_git_raw` produce more similar results as
`hg diff --git` by making use of the `mercurial.copies` utility.

Thanks,
Erik

- [x] `make test`
- [x] Manually creating a webrev for the patch attached to the bug

-------------

Commits:
 - 5d18de23: 184: git-webrev exception on deleted files in hg

Changes: https://git.openjdk.java.net/skara/pull/307/files
 Webrev: https://webrevs.openjdk.java.net/skara/307/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-184
  Stats: 25 lines in 1 file changed: 20 ins; 3 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/307.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/307/head:pull/307

PR: https://git.openjdk.java.net/skara/pull/307

From rwestberg at openjdk.java.net  Tue Dec 10 14:46:56 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 10 Dec 2019 14:46:56 GMT
Subject: RFR: 184: git-webrev exception on deleted files in hg
In-Reply-To: 
References: 
Message-ID: 

On Tue, 10 Dec 2019 14:33:25 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that improves how our Mercurial plugin detects copied
> and renamed files. We have to have our `diff_git_raw` implementation produce
> the same results as `hg diff --git`, otherwise one might consider a file
> renamed and the other one not, resulting in problems.
> 
> This patch make the results of `diff_git_raw` produce more similar results as
> `hg diff --git` by making use of the `mercurial.copies` utility.
> 
> Thanks,
> Erik
> 
> - [x] `make test`
> - [x] Manually creating a webrev for the patch attached to the bug

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/307

From ehelin at openjdk.java.net  Tue Dec 10 14:54:07 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 10 Dec 2019 14:54:07 GMT
Subject: [Integrated] RFR: 184: git-webrev exception on deleted files in hg
In-Reply-To: 
References: 
Message-ID: <6f2db9a1-09f1-4b4f-87c8-1048af3e398b@openjdk.org>

Changeset: 3b425dcb
Author:    Erik Helin 
Date:      2019-12-10 14:53:54 +0000
URL:       https://git.openjdk.java.net/skara/commit/3b425dcb

184: git-webrev exception on deleted files in hg

Reviewed-by: rwestberg

! vcs/src/main/resources/ext.py

From rwestberg at openjdk.java.net  Wed Dec 11 08:28:30 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 08:28:30 GMT
Subject: RFR: Add link to reviews in related issues
Message-ID: 

Hi all,

Please review this change that adds support for getting notifications when an issue is added or removed from a pull request. This is then used to update such issues to contain a link to the PR.

Best regards,
Robin

-------------

Commits:
 - b2233f7b: Initial implementation of pull request notifications on added or removed issues

Changes: https://git.openjdk.java.net/skara/pull/308/files
 Webrev: https://webrevs.openjdk.java.net/skara/308/webrev.00
  Stats: 1047 lines in 12 files changed: 765 ins; 213 del; 69 mod
  Patch: https://git.openjdk.java.net/skara/pull/308.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/308/head:pull/308

PR: https://git.openjdk.java.net/skara/pull/308

From ehelin at openjdk.java.net  Wed Dec 11 08:40:56 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 08:40:56 GMT
Subject: RFR: Add link to reviews in related issues
In-Reply-To: 
References: 
Message-ID: <38jgR45m9-hUc20V69r-ZF_ZwQQF8SAb42SV0JUsAvA=.fc315c8e-2ba4-4d70-8868-92d38e256467@github.com>

On Wed, 11 Dec 2019 08:27:47 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this change that adds support for getting notifications when an issue is added or removed from a pull request. This is then used to update such issues to contain a link to the PR.
> 
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/308

From rwestberg at openjdk.java.net  Wed Dec 11 08:44:57 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 08:44:57 GMT
Subject: [Integrated] RFR: Add link to reviews in related issues
In-Reply-To: 
References: 
Message-ID: <665a5d8a-00c3-49a5-b191-95b239b105bd@openjdk.org>

Changeset: a728f09e
Author:    Robin Westberg 
Date:      2019-12-11 08:44:45 +0000
URL:       https://git.openjdk.java.net/skara/commit/a728f09e

Add link to reviews in related issues

Reviewed-by: ehelin

! bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JsonUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java
+ bots/notify/src/main/java/org/openjdk/skara/bots/notify/PullRequestIssues.java
+ bots/notify/src/main/java/org/openjdk/skara/bots/notify/PullRequestUpdateConsumer.java
+ bots/notify/src/main/java/org/openjdk/skara/bots/notify/PullRequestWorkItem.java
+ bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryUpdateConsumer.java
+ bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryWorkItem.java
- bots/notify/src/main/java/org/openjdk/skara/bots/notify/UpdateConsumer.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java

From ehelin at openjdk.java.net  Wed Dec 11 08:45:08 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 08:45:08 GMT
Subject: RFR: git-sync: add --fast-forward option
Message-ID: 

Hi all,

please review this patch that adds the `--fast-forward` option to `git-sync`.
Setting the option `--fast-forward` will cause `git-sync` to fast-forward all
local branches where possible. Since it is mostly common that developer's do
not make change to branches in their personal forks that are also present in
the upstream repository, the effect is that all local branches that map to
upstream branches (via the personal fork) will be updated locally.

Thanks,
Erik

- Manual testing of `git-sync` on Linux x64

-------------

Commits:
 - b82d9401: git-sync: add --fast-forward option

Changes: https://git.openjdk.java.net/skara/pull/309/files
 Webrev: https://webrevs.openjdk.java.net/skara/309/webrev.00
  Stats: 66 lines in 1 file changed: 61 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/skara/pull/309.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/309/head:pull/309

PR: https://git.openjdk.java.net/skara/pull/309

From rwestberg at openjdk.java.net  Wed Dec 11 09:01:43 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 09:01:43 GMT
Subject: RFR: git-sync: add --fast-forward option
In-Reply-To: 
References: 
Message-ID: 

On Wed, 11 Dec 2019 08:44:26 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that adds the `--fast-forward` option to `git-sync`.
> Setting the option `--fast-forward` will cause `git-sync` to fast-forward all
> local branches where possible. Since it is mostly common that developer's do
> not make change to branches in their personal forks that are also present in
> the upstream repository, the effect is that all local branches that map to
> upstream branches (via the personal fork) will be updated locally.
> 
> Thanks,
> Erik
> 
> - Manual testing of `git-sync` on Linux x64

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/309

From rwestberg at openjdk.java.net  Wed Dec 11 09:05:04 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 09:05:04 GMT
Subject: RFR: 186: Rename JNotifyBot class to NotifyBot
Message-ID: 

Hi all,

Please review this minor change that renamed the JNotifyBot class.

Best regards,
Robin

-------------

Commits:
 - 81f37d8f: Rename JNotifyBot class to NotifyBot

Changes: https://git.openjdk.java.net/skara/pull/310/files
 Webrev: https://webrevs.openjdk.java.net/skara/310/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-186
  Stats: 582 lines in 6 files changed: 278 ins; 278 del; 26 mod
  Patch: https://git.openjdk.java.net/skara/pull/310.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/310/head:pull/310

PR: https://git.openjdk.java.net/skara/pull/310

From ehelin at openjdk.java.net  Wed Dec 11 09:51:57 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 09:51:57 GMT
Subject: RFR: 186: Rename JNotifyBot class to NotifyBot
In-Reply-To: 
References: 
Message-ID: 

On Wed, 11 Dec 2019 09:04:19 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this minor change that renamed the JNotifyBot class.
> 
> Best regards,
> Robin

Looks good, thanks!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/310

From rwestberg at openjdk.java.net  Wed Dec 11 09:52:19 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 09:52:19 GMT
Subject: RFR: 186: Rename JNotifyBot class to NotifyBot
In-Reply-To: 
References: 
 
Message-ID: 

On Wed, 11 Dec 2019 09:51:46 GMT, Erik Helin  wrote:

>> Hi all,
>> 
>> Please review this minor change that renamed the JNotifyBot class.
>> 
>> Best regards,
>> Robin
> 
> Looks good, thanks!

Thanks for reviewing!

-------------

PR: https://git.openjdk.java.net/skara/pull/310

From ehelin at openjdk.java.net  Wed Dec 11 09:52:43 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 09:52:43 GMT
Subject: [Integrated] RFR: git-sync: add --fast-forward option
In-Reply-To: 
References: 
Message-ID: <42a7a060-40e3-405e-8550-fc9634c5e147@openjdk.org>

Changeset: bd9c621e
Author:    Erik Helin 
Date:      2019-12-11 09:52:23 +0000
URL:       https://git.openjdk.java.net/skara/commit/bd9c621e

git-sync: add --fast-forward option

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitSync.java

From rwestberg at openjdk.java.net  Wed Dec 11 09:52:44 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 09:52:44 GMT
Subject: [Integrated] RFR: 186: Rename JNotifyBot class to NotifyBot
In-Reply-To: 
References: 
Message-ID: 

Changeset: 281e2596
Author:    Robin Westberg 
Date:      2019-12-11 09:52:28 +0000
URL:       https://git.openjdk.java.net/skara/commit/281e2596

186: Rename JNotifyBot class to NotifyBot

Reviewed-by: ehelin

! bots/notify/src/main/java/module-info.java
- bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java
- bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java
+ bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBot.java
+ bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBotFactory.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java

From rwestberg at openjdk.java.net  Wed Dec 11 09:58:05 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 09:58:05 GMT
Subject: RFR: Add a link to the commit to related issues
Message-ID: 

Hi all,

Please review this change that adds a proper link to a commit, in addition to the existing comment currently made, when a commit referencing an issue is integrated.

Best regards,
Robin

-------------

Commits:
 - 5f64d36d: Add a link to the commit as well

Changes: https://git.openjdk.java.net/skara/pull/311/files
 Webrev: https://webrevs.openjdk.java.net/skara/311/webrev.00
  Stats: 32 lines in 3 files changed: 25 ins; 1 del; 6 mod
  Patch: https://git.openjdk.java.net/skara/pull/311.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/311/head:pull/311

PR: https://git.openjdk.java.net/skara/pull/311

From ehelin at openjdk.java.net  Wed Dec 11 10:06:24 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 10:06:24 GMT
Subject: RFR: Add a link to the commit to related issues
In-Reply-To: 
References: 
Message-ID: <5EkwGRIEfI4MoDiFh2BBu92zZyVoiuxcVAfZrPmxTCk=.17b5d806-dea7-4839-9ea2-23a8b922419c@github.com>

On Wed, 11 Dec 2019 09:57:23 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this change that adds a proper link to a commit, in addition to the existing comment currently made, when a commit referencing an issue is integrated.
> 
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/311

From rwestberg at openjdk.java.net  Wed Dec 11 10:10:15 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 10:10:15 GMT
Subject: [Integrated] RFR: Add a link to the commit to related issues
In-Reply-To: 
References: 
Message-ID: <204d8f58-4654-4fbd-941e-f096363c7983@openjdk.org>

Changeset: 6dfb9b7d
Author:    Robin Westberg 
Date:      2019-12-11 10:10:03 +0000
URL:       https://git.openjdk.java.net/skara/commit/6dfb9b7d

Add a link to the commit to related issues

Reviewed-by: ehelin

! bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBotFactory.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java

From ehelin at openjdk.java.net  Wed Dec 11 10:45:18 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 10:45:18 GMT
Subject: RFR: 189: git-pr should detect issue from branch name
Message-ID: 

Hi all,

please review this patch that takes the first steps towards making `git-pr` a
bit smart with regards to detecing JBS issues. This patch makes `git-pr` detect
a JBS issue from a branch name (currently only supporting the long form of
"project-id"). If a matching issue is found then the title of the PR will be
automatically set to the title of the issue.

Thanks,
Erik

- [x] Manual testing of `git-pr`

-------------

Commits:
 - 0aa717ae: skara-189

Changes: https://git.openjdk.java.net/skara/pull/312/files
 Webrev: https://webrevs.openjdk.java.net/skara/312/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-189
  Stats: 31 lines in 2 files changed: 30 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/312.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/312/head:pull/312

PR: https://git.openjdk.java.net/skara/pull/312

From rwestberg at openjdk.java.net  Wed Dec 11 10:50:43 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 10:50:43 GMT
Subject: RFR: Properly set commit icon
Message-ID: 

Hi all,

Please review this minor fix that properly sets the commit icon from the configuration, instead of replacing the review icon.

Best regards,
Robin

-------------

Commits:
 - 48118f20: Properly set commit icon

Changes: https://git.openjdk.java.net/skara/pull/313/files
 Webrev: https://webrevs.openjdk.java.net/skara/313/webrev.00
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/313.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/313/head:pull/313

PR: https://git.openjdk.java.net/skara/pull/313

From ehelin at openjdk.java.net  Wed Dec 11 10:51:09 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 10:51:09 GMT
Subject: RFR: Properly set commit icon
In-Reply-To: 
References: 
Message-ID: <9qM_hsJoC3uFvZ6tAGaZrQYGIlbhwJtn7-WEagFjTWo=.a2d496d9-b23d-4672-b311-ac0b61ae8b48@github.com>

On Wed, 11 Dec 2019 10:49:51 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this minor fix that properly sets the commit icon from the configuration, instead of replacing the review icon.
> 
> Best regards,
> Robin

Looks good, thanks!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/313

From rwestberg at openjdk.java.net  Wed Dec 11 10:52:27 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 10:52:27 GMT
Subject: RFR: 189: git-pr should detect issue from branch name
In-Reply-To: 
References: 
Message-ID: 

On Wed, 11 Dec 2019 10:44:31 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that takes the first steps towards making `git-pr` a
> bit smart with regards to detecing JBS issues. This patch makes `git-pr` detect
> a JBS issue from a branch name (currently only supporting the long form of
> "project-id"). If a matching issue is found then the title of the PR will be
> automatically set to the title of the issue.
> 
> Thanks,
> Erik
> 
> - [x] Manual testing of `git-pr`

Could you reuse openjdk.Issue.fromString here?

-------------



PR: https://git.openjdk.java.net/skara/pull/312

From rwestberg at openjdk.java.net  Wed Dec 11 10:53:28 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 10:53:28 GMT
Subject: [Integrated] RFR: Properly set commit icon
In-Reply-To: 
References: 
Message-ID: <89061bf2-ac37-4714-9489-d59eb9bbd5c9@openjdk.org>

Changeset: 1620db8d
Author:    Robin Westberg 
Date:      2019-12-11 10:53:14 +0000
URL:       https://git.openjdk.java.net/skara/commit/1620db8d

Properly set commit icon

Reviewed-by: ehelin

! bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBotFactory.java

From ehelin at openjdk.java.net  Wed Dec 11 12:03:16 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 12:03:16 GMT
Subject: RFR: 189: git-pr should detect issue from branch name
In-Reply-To: 
References: 
 
Message-ID: 

On Wed, 11 Dec 2019 10:52:16 GMT, Robin Westberg  wrote:

>> Hi all,
>> 
>> please review this patch that takes the first steps towards making `git-pr` a
>> bit smart with regards to detecing JBS issues. This patch makes `git-pr` detect
>> a JBS issue from a branch name (currently only supporting the long form of
>> "project-id"). If a matching issue is found then the title of the PR will be
>> automatically set to the title of the issue.
>> 
>> Thanks,
>> Erik
>> 
>> - [x] Manual testing of `git-pr`
> 
> Could you reuse openjdk.Issue.fromString here?

No, unfortunately not, `openjdk.Issue.fromString` look for an `ID: TITLE` pattern, here we are interested in a `PROJECT-ID` pattern.

-------------

PR: https://git.openjdk.java.net/skara/pull/312

From rwestberg at openjdk.java.net  Wed Dec 11 12:04:37 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 12:04:37 GMT
Subject: RFR: 189: git-pr should detect issue from branch name
In-Reply-To: 
References: 
Message-ID: 

On Wed, 11 Dec 2019 10:44:31 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that takes the first steps towards making `git-pr` a
> bit smart with regards to detecing JBS issues. This patch makes `git-pr` detect
> a JBS issue from a branch name (currently only supporting the long form of
> "project-id"). If a matching issue is found then the title of the PR will be
> automatically set to the title of the issue.
> 
> Thanks,
> Erik
> 
> - [x] Manual testing of `git-pr`

Okay, looks good then!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/312

From ehelin at openjdk.java.net  Wed Dec 11 12:06:17 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 12:06:17 GMT
Subject: [Integrated] RFR: 189: git-pr should detect issue from branch name
In-Reply-To: 
References: 
Message-ID: 

Changeset: 771d1921
Author:    Erik Helin 
Date:      2019-12-11 12:06:03 +0000
URL:       https://git.openjdk.java.net/skara/commit/771d1921

189: git-pr should detect issue from branch name

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/IssueTracker.java

From ehelin at openjdk.java.net  Wed Dec 11 12:12:37 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 12:12:37 GMT
Subject: RFR: 191: Add jbs entry in .jcheck/configuration
Message-ID: 

Hi all,

please review this tiny patch that just adds a `jbs` to the `.jcheck/conf` file.

Thanks,
Erik

-------------

Commits:
 - cb5cc8aa: skara-191

Changes: https://git.openjdk.java.net/skara/pull/314/files
 Webrev: https://webrevs.openjdk.java.net/skara/314/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-191
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/314.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/314/head:pull/314

PR: https://git.openjdk.java.net/skara/pull/314

From rwestberg at openjdk.java.net  Wed Dec 11 12:14:06 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 12:14:06 GMT
Subject: RFR: 191: Add jbs entry in .jcheck/configuration
In-Reply-To: 
References: 
Message-ID: 

On Wed, 11 Dec 2019 12:11:57 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this tiny patch that just adds a `jbs` to the `.jcheck/conf` file.
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/314

From ehelin at openjdk.java.net  Wed Dec 11 12:26:27 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 12:26:27 GMT
Subject: [Integrated] RFR: 191: Add jbs entry in .jcheck/configuration
In-Reply-To: 
References: 
Message-ID: 

Changeset: 881847d6
Author:    Erik Helin 
Date:      2019-12-11 12:26:13 +0000
URL:       https://git.openjdk.java.net/skara/commit/881847d6

191: Add jbs entry in .jcheck/configuration

Reviewed-by: rwestberg

! .jcheck/conf

From ehelin at openjdk.java.net  Wed Dec 11 12:37:56 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 12:37:56 GMT
Subject: RFR: 192: git-pr: use jbs entry in .jcheck/conf for finding issues
Message-ID: 

192: git-pr: use jbs entry in .jcheck/conf for finding issues

-------------

Commits:
 - 0a9d8ad0: skara-192

Changes: https://git.openjdk.java.net/skara/pull/315/files
 Webrev: https://webrevs.openjdk.java.net/skara/315/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-192
  Stats: 56 lines in 1 file changed: 40 ins; 4 del; 12 mod
  Patch: https://git.openjdk.java.net/skara/pull/315.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/315/head:pull/315

PR: https://git.openjdk.java.net/skara/pull/315

From rwestberg at openjdk.java.net  Wed Dec 11 13:07:16 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 13:07:16 GMT
Subject: RFR: 192: git-pr: use jbs entry in .jcheck/conf for finding issues
In-Reply-To: 
References: 
Message-ID: 

On Wed, 11 Dec 2019 12:37:09 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that makes `git-pr create` work a little harder for potentially finding a JBS issue for a local branch. Given a `jbs` entry in `.jcheck/conf`, the branch now only has to be a bug id (e.g. 192). Furthermore, if the branch is named something else that does not match an issue id, but the branch consist of a single commit, then `git-pr` will try to determine an issue from that commit message title.
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git-pr create`

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/315

From ehelin at openjdk.java.net  Wed Dec 11 13:16:36 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 13:16:36 GMT
Subject: [Integrated] RFR: 192: git-pr: use jbs entry in .jcheck/conf for
 finding issues
In-Reply-To: 
References: 
Message-ID: <2fd91531-932d-4110-9433-be454592efc4@openjdk.org>

Changeset: 21d32f21
Author:    Erik Helin 
Date:      2019-12-11 13:16:23 +0000
URL:       https://git.openjdk.java.net/skara/commit/21d32f21

192: git-pr: use jbs entry in .jcheck/conf for finding issues

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java

From ehelin at openjdk.java.net  Wed Dec 11 13:26:45 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 13:26:45 GMT
Subject: RFR: 190: git-pr: add flag --ignore-workspace
Message-ID: <21NfZf4fg_CK3Aju7g3rlSCYW6dcxqRHPFppas-wJns=.7b7e5c11-b051-40ab-bcc8-179a48fb66ba@github.com>

Hi all,

please review this small patch that adds the flag `--ignore-workspace` to
`git-pr create` (also configurable). When `--ignore-workspace` is set, then
`git-pr create` won't complain if there are changes in the worktree or in the
staging area.

Thanks,
Erik

- [x] Manual testing of `git-pr create` with changes in worktree and staging area

-------------

Commits:
 - 232e1960: skara-190

Changes: https://git.openjdk.java.net/skara/pull/316/files
 Webrev: https://webrevs.openjdk.java.net/skara/316/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-190
  Stats: 55 lines in 1 file changed: 33 ins; 22 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/316.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/316/head:pull/316

PR: https://git.openjdk.java.net/skara/pull/316

From rwestberg at openjdk.java.net  Wed Dec 11 13:29:06 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 13:29:06 GMT
Subject: RFR: 190: git-pr: add flag --ignore-workspace
In-Reply-To: <21NfZf4fg_CK3Aju7g3rlSCYW6dcxqRHPFppas-wJns=.7b7e5c11-b051-40ab-bcc8-179a48fb66ba@github.com>
References: <21NfZf4fg_CK3Aju7g3rlSCYW6dcxqRHPFppas-wJns=.7b7e5c11-b051-40ab-bcc8-179a48fb66ba@github.com>
Message-ID: 

On Wed, 11 Dec 2019 13:26:07 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this small patch that adds the flag `--ignore-workspace` to
> `git-pr create` (also configurable). When `--ignore-workspace` is set, then
> `git-pr create` won't complain if there are changes in the worktree or in the
> staging area.
> 
> Thanks,
> Erik
> 
> - [x] Manual testing of `git-pr create` with changes in worktree and staging area

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/316

From ehelin at openjdk.java.net  Wed Dec 11 13:37:45 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 13:37:45 GMT
Subject: [Integrated] RFR: 190: git-pr: add flag --ignore-workspace
In-Reply-To: <21NfZf4fg_CK3Aju7g3rlSCYW6dcxqRHPFppas-wJns=.7b7e5c11-b051-40ab-bcc8-179a48fb66ba@github.com>
References: <21NfZf4fg_CK3Aju7g3rlSCYW6dcxqRHPFppas-wJns=.7b7e5c11-b051-40ab-bcc8-179a48fb66ba@github.com>
Message-ID: <50eb374e-fb11-460d-ad1f-17ef440a1615@openjdk.org>

Changeset: e4f28b2a
Author:    Erik Helin 
Date:      2019-12-11 13:37:33 +0000
URL:       https://git.openjdk.java.net/skara/commit/e4f28b2a

190: git-pr: add flag --ignore-workspace

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java

From ehelin at openjdk.java.net  Wed Dec 11 14:11:22 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 11 Dec 2019 14:11:22 GMT
Subject: RFR: 193: git-pr: add flag --publish
Message-ID: 

Hi all,

please review this patch that adds the flag `--publish` to `git-pr create`
(also configurable). When `--publish` is set then `git-pr` will call
`git-publish --quiet` if the branch is not yet pushed to the remote. This
avoids having to type `git publish && git pr create` when creating pull
requests from the command-line.

Note that I had to update `git-publish` a bit to fully support the `--quiet`
flag.

Thanks,
Erik

- [x] Manual testing of `git-pr create --publish`

-------------

Commits:
 - c5649967: skara-193

Changes: https://git.openjdk.java.net/skara/pull/317/files
 Webrev: https://webrevs.openjdk.java.net/skara/317/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-193
  Stats: 31 lines in 2 files changed: 16 ins; 0 del; 15 mod
  Patch: https://git.openjdk.java.net/skara/pull/317.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/317/head:pull/317

PR: https://git.openjdk.java.net/skara/pull/317

From rwestberg at openjdk.java.net  Wed Dec 11 14:12:30 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 14:12:30 GMT
Subject: RFR: 193: git-pr: add flag --publish
In-Reply-To: 
References: 
Message-ID: 

On Wed, 11 Dec 2019 14:10:22 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that adds the flag `--publish` to `git-pr create`
> (also configurable). When `--publish` is set then `git-pr` will call
> `git-publish --quiet` if the branch is not yet pushed to the remote. This
> avoids having to type `git publish && git pr create` when creating pull
> requests from the command-line.
> 
> Note that I had to update `git-publish` a bit to fully support the `--quiet`
> flag.
> 
> Thanks,
> Erik
> 
> - [x] Manual testing of `git-pr create --publish`

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/317

From rwestberg at openjdk.java.net  Wed Dec 11 15:04:36 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 11 Dec 2019 15:04:36 GMT
Subject: RFR: Add support for security levels and comment visibility in Jira
Message-ID: 

Hi all,

Please review this change that adds support for security levels and comment visibility in Jira.

Best regards,
Robin

-------------

Commits:
 - 15609196: Add support for Jira's security levels and comment visibility

Changes: https://git.openjdk.java.net/skara/pull/318/files
 Webrev: https://webrevs.openjdk.java.net/skara/318/webrev.00
  Stats: 104 lines in 5 files changed: 82 ins; 7 del; 15 mod
  Patch: https://git.openjdk.java.net/skara/pull/318.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/318/head:pull/318

PR: https://git.openjdk.java.net/skara/pull/318

From ehelin at openjdk.java.net  Thu Dec 12 06:48:08 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 12 Dec 2019 06:48:08 GMT
Subject: [Integrated] RFR: 193: git-pr: add flag --publish
In-Reply-To: 
References: 
Message-ID: <4769658a-ac49-4b09-a448-5039aee99bb3@openjdk.org>

Changeset: 622b7e21
Author:    Erik Helin 
Date:      2019-12-12 06:47:54 +0000
URL:       https://git.openjdk.java.net/skara/commit/622b7e21

193: git-pr: add flag --publish

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java
! cli/src/main/java/org/openjdk/skara/cli/GitPublish.java

From ehelin at openjdk.java.net  Thu Dec 12 06:51:38 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 12 Dec 2019 06:51:38 GMT
Subject: RFR: Add support for security levels and comment visibility in
 Jira
In-Reply-To: 
References: 
Message-ID: 

On Wed, 11 Dec 2019 15:03:47 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this change that adds support for security levels and comment visibility in Jira.
> 
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/318

From ehelin at openjdk.java.net  Thu Dec 12 07:00:47 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 12 Dec 2019 07:00:47 GMT
Subject: RFR: 194: git-pr create --publish should not print messages from
 remote
Message-ID: 

Hi all,

please review this patch that adds `--quiet` to `git-publish` and updates
`git-pr` to make use of the `--quiet` flag. This is to prevent output from the
remote about creating a new pull request from showing up.

I also fixed a bug where the upstream branch has to be re-read after a
succesful publish.

Thanks,
Erik

- [x] Manual testing of `git pr create --publish`

-------------

Commits:
 - 37422af0: skara-194

Changes: https://git.openjdk.java.net/skara/pull/319/files
 Webrev: https://webrevs.openjdk.java.net/skara/319/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-194
  Stats: 35 lines in 2 files changed: 29 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/skara/pull/319.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/319/head:pull/319

PR: https://git.openjdk.java.net/skara/pull/319

From rwestberg at openjdk.java.net  Thu Dec 12 07:01:26 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 12 Dec 2019 07:01:26 GMT
Subject: RFR: 194: git-pr create --publish should not print messages from
 remote
In-Reply-To: 
References: 
Message-ID: 

On Thu, 12 Dec 2019 06:59:53 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that adds `--quiet` to `git-publish` and updates
> `git-pr` to make use of the `--quiet` flag. This is to prevent output from the
> remote about creating a new pull request from showing up.
> 
> I also fixed a bug where the upstream branch has to be re-read after a
> succesful publish.
> 
> Thanks,
> Erik
> 
> - [x] Manual testing of `git pr create --publish`

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/319

From rwestberg at openjdk.java.net  Thu Dec 12 07:12:37 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 12 Dec 2019 07:12:37 GMT
Subject: [Integrated] RFR: Add support for security levels and comment
 visibility in Jira
In-Reply-To: 
References: 
Message-ID: <8217939d-df06-4001-9ffe-712881ed2782@openjdk.org>

Changeset: ff3f983b
Author:    Robin Westberg 
Date:      2019-12-12 07:12:24 +0000
URL:       https://git.openjdk.java.net/skara/commit/ff3f983b

Add support for security levels and comment visibility in Jira

Reviewed-by: ehelin

! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraHost.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssueTrackerFactory.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java
! test/src/main/java/org/openjdk/skara/test/HostCredentials.java

From ehelin at openjdk.java.net  Thu Dec 12 07:18:35 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 12 Dec 2019 07:18:35 GMT
Subject: [Integrated] RFR: 194: git-pr create --publish should not print
 messages from remote
In-Reply-To: 
References: 
Message-ID: 

Changeset: d6e5a93d
Author:    Erik Helin 
Date:      2019-12-12 07:18:20 +0000
URL:       https://git.openjdk.java.net/skara/commit/d6e5a93d

194: git-pr create --publish should not print messages from remote

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java
! cli/src/main/java/org/openjdk/skara/cli/GitPublish.java

From ehelin at openjdk.java.net  Thu Dec 12 10:55:51 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 12 Dec 2019 10:55:51 GMT
Subject: RFR: 195: git-pr should support flag --ignore-local-commits
Message-ID: 

Hi all,

please review this patch that adds the flag `--ignore-local-commits` to `git-pr
create` (also configurable). If `--ignore-local-commits` is specified then
`git-pr create` will not complain about local commits in the branch have not
been pushed.

Thanks,
Erik

- [x] Manual testing of `git-pr create`

-------------

Commits:
 - 2234680f: skara-195

Changes: https://git.openjdk.java.net/skara/pull/320/files
 Webrev: https://webrevs.openjdk.java.net/skara/320/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-195
  Stats: 34 lines in 1 file changed: 18 ins; 6 del; 10 mod
  Patch: https://git.openjdk.java.net/skara/pull/320.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/320/head:pull/320

PR: https://git.openjdk.java.net/skara/pull/320

From rwestberg at openjdk.java.net  Thu Dec 12 12:27:32 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 12 Dec 2019 12:27:32 GMT
Subject: RFR: 196: Support setting the fixVersions field in Jira
Message-ID: 

Hi all,

Please review this change that adds support for setting the fixVersions field on Jira issues.

Best regards,
Robin

-------------

Commits:
 - 52e4c7b9: Add support for setting fixVersions in Jira

Changes: https://git.openjdk.java.net/skara/pull/321/files
 Webrev: https://webrevs.openjdk.java.net/skara/321/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-196
  Stats: 110 lines in 8 files changed: 109 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/321.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/321/head:pull/321

PR: https://git.openjdk.java.net/skara/pull/321

From ehelin at openjdk.java.net  Thu Dec 12 12:28:43 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 12 Dec 2019 12:28:43 GMT
Subject: RFR: 196: Support setting the fixVersions field in Jira
In-Reply-To: 
References: 
Message-ID: 

On Thu, 12 Dec 2019 12:26:51 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this change that adds support for setting the fixVersions field on Jira issues.
> 
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/321

From rwestberg at openjdk.java.net  Thu Dec 12 12:28:52 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 12 Dec 2019 12:28:52 GMT
Subject: RFR: 195: git-pr should support flag --ignore-local-commits
In-Reply-To: 
References: 
Message-ID: 

On Thu, 12 Dec 2019 10:54:59 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that adds the flag `--ignore-local-commits` to `git-pr
> create` (also configurable). If `--ignore-local-commits` is specified then
> `git-pr create` will not complain about local commits in the branch have not
> been pushed.
> 
> Thanks,
> Erik
> 
> - [x] Manual testing of `git-pr create`

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/320

From rwestberg at openjdk.java.net  Thu Dec 12 12:30:53 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 12 Dec 2019 12:30:53 GMT
Subject: [Integrated] RFR: 196: Support setting the fixVersions field in
 Jira
In-Reply-To: 
References: 
Message-ID: <957dfdfd-335a-4f8a-9f84-806e5615121c@openjdk.org>

Changeset: fcc4adc7
Author:    Robin Westberg 
Date:      2019-12-12 12:30:40 +0000
URL:       https://git.openjdk.java.net/skara/commit/fcc4adc7

196: Support setting the fixVersions field in Jira

Reviewed-by: ehelin

! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java
! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/Issue.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java
! issuetracker/src/test/java/org/openjdk/skara/issuetracker/IssueTrackerTests.java
! test/src/main/java/org/openjdk/skara/test/IssueData.java
! test/src/main/java/org/openjdk/skara/test/TestIssue.java

From ehelin at openjdk.java.net  Thu Dec 12 12:46:08 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 12 Dec 2019 12:46:08 GMT
Subject: RFR: 197: git-fork should use --dissociate with --reference-if-able
Message-ID: 

Hi all,

please review this patch that ensures we use the `--dissociate` option to `git
clone` when someone is using `git fork --reference`. We need to use this flag
to ensure that the objects are only borrowed from the referenced repository to
reduce network transfer, we don't the borrow to continue after the clone.

Testing:
- [x] Manual testing of `git-pr fork --reference`

Thanks,
Erik

-------------

Commits:
 - 03ae9043: skara-197

Changes: https://git.openjdk.java.net/skara/pull/322/files
 Webrev: https://webrevs.openjdk.java.net/skara/322/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-197
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/322.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/322/head:pull/322

PR: https://git.openjdk.java.net/skara/pull/322

From ehelin at openjdk.java.net  Thu Dec 12 13:49:24 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 12 Dec 2019 13:49:24 GMT
Subject: [Integrated] RFR: 195: git-pr should support flag
 --ignore-local-commits
In-Reply-To: 
References: 
Message-ID: <1b3ed94e-b0b4-465c-890d-fa534af2a92e@openjdk.org>

Changeset: 1c211b0a
Author:    Erik Helin 
Date:      2019-12-12 13:49:08 +0000
URL:       https://git.openjdk.java.net/skara/commit/1c211b0a

195: git-pr should support flag --ignore-local-commits

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java

From rwestberg at openjdk.java.net  Thu Dec 12 13:51:52 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 12 Dec 2019 13:51:52 GMT
Subject: RFR: 197: git-fork should use --dissociate with
 --reference-if-able
In-Reply-To: 
References: 
Message-ID: 

On Thu, 12 Dec 2019 12:45:16 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that ensures we use the `--dissociate` option to `git
> clone` when someone is using `git fork --reference`. We need to use this flag
> to ensure that the objects are only borrowed from the referenced repository to
> reduce network transfer, we don't the borrow to continue after the clone.
> 
> Testing:
> - [x] Manual testing of `git-pr fork --reference`
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/322

From rwestberg at openjdk.java.net  Thu Dec 12 13:55:44 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 12 Dec 2019 13:55:44 GMT
Subject: RFR: Fix build break
Message-ID: 

Hi all,

Please review this minor change that fixes a recently introduced build break. ?? 

Best regards,
Robin

-------------

Commits:
 - 3a96dd0a: Fix build break

Changes: https://git.openjdk.java.net/skara/pull/323/files
 Webrev: https://webrevs.openjdk.java.net/skara/323/webrev.00
  Stats: 15 lines in 1 file changed: 15 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/323.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/323/head:pull/323

PR: https://git.openjdk.java.net/skara/pull/323

From ehelin at openjdk.java.net  Thu Dec 12 13:56:13 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 12 Dec 2019 13:56:13 GMT
Subject: [Integrated] RFR: 197: git-fork should use --dissociate with
 --reference-if-able
In-Reply-To: 
References: 
Message-ID: <451463dc-91a9-42e4-bd7b-764871eba0d9@openjdk.org>

Changeset: 914cbefe
Author:    Erik Helin 
Date:      2019-12-12 13:56:01 +0000
URL:       https://git.openjdk.java.net/skara/commit/914cbefe

197: git-fork should use --dissociate with --reference-if-able

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitFork.java

From ehelin at openjdk.java.net  Thu Dec 12 14:21:32 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 12 Dec 2019 14:21:32 GMT
Subject: RFR: Fix build break
In-Reply-To: 
References: 
Message-ID: 

On Thu, 12 Dec 2019 13:55:04 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this minor change that fixes a recently introduced build break. ?? 
> 
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/323

From rwestberg at openjdk.java.net  Thu Dec 12 14:22:14 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 12 Dec 2019 14:22:14 GMT
Subject: [Integrated] RFR: Fix build break
In-Reply-To: 
References: 
Message-ID: 

Changeset: 8a8f5feb
Author:    Robin Westberg 
Date:      2019-12-12 14:22:02 +0000
URL:       https://git.openjdk.java.net/skara/commit/8a8f5feb

Fix build break

Reviewed-by: ehelin

! bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java

From rwestberg at openjdk.java.net  Thu Dec 12 14:31:34 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 12 Dec 2019 14:31:34 GMT
Subject: RFR: 199: Set fixVersion in an issue when a commit is integrated
Message-ID: 

Hi all,

Please review this change that sets fixVersion in a commit's issue after integration, if a version has been configured in the repository's .jcheck/conf file.

Also sets a version for Skara itself!

Best regards,
Robin

-------------

Commits:
 - 7dd2b9d9: Implement adding a fixVersion field in the notifier (if configured in .jcheck/conf)

Changes: https://git.openjdk.java.net/skara/pull/324/files
 Webrev: https://webrevs.openjdk.java.net/skara/324/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-199
  Stats: 117 lines in 9 files changed: 81 ins; 1 del; 35 mod
  Patch: https://git.openjdk.java.net/skara/pull/324.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/324/head:pull/324

PR: https://git.openjdk.java.net/skara/pull/324

From kcr at openjdk.java.net  Thu Dec 12 14:44:22 2019
From: kcr at openjdk.java.net (Kevin Rushforth)
Date: Thu, 12 Dec 2019 14:44:22 GMT
Subject: RFR: 199: Set fixVersion in an issue when a commit is integrated
In-Reply-To: 
References: 
Message-ID: 

On Thu, 12 Dec 2019 14:30:48 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this change that sets fixVersion in a commit's issue after integration, if a version has been configured in the repository's .jcheck/conf file.
> 
> Also sets a version for Skara itself!
> 
> Best regards,
> Robin

I don't think it is workable to have the configuration stored in the repo. We will have many cases where there will be upstream and downstream repos where commits will be synced from one to the other and you wouldn't want the fix version to be synced. Also, when forking repos or branches you want to set up and configure the new branch/repo and the master branch at the same time of the fork without pushing a commit to the repo. There are also cases (e.g., for sandbox repos) where you might not want the gitupdater feature enabled, and again it would be unworkable for the config to be in the repo.

I think this is better done via a separate database that maps each repo/branch to a fix version as well as enabling the auto update or not.

-------------

PR: https://git.openjdk.java.net/skara/pull/324

From ehelin at openjdk.java.net  Thu Dec 12 15:13:13 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 12 Dec 2019 15:13:13 GMT
Subject: RFR: 198: git-pr should remember mapping between PR and local branch
Message-ID: 

Hi all,

please review this patch that adds a mapping between pull requests and local
branches. This is done by adding a section per local branch to the
repositorie's local configuration file, for example:

[pr "skara-198"]
id = 310

Thanks,
Erik

-------------

Commits:
 - 2d86fa28: skara-198
 - 93f984ad: skara-198

Changes: https://git.openjdk.java.net/skara/pull/325/files
 Webrev: https://webrevs.openjdk.java.net/skara/325/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-198
  Stats: 74 lines in 5 files changed: 66 ins; 4 del; 4 mod
  Patch: https://git.openjdk.java.net/skara/pull/325.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/325/head:pull/325

PR: https://git.openjdk.java.net/skara/pull/325

From ehelin at openjdk.java.net  Thu Dec 12 15:16:42 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 12 Dec 2019 15:16:42 GMT
Subject: [Rev 01] RFR: 198: git-pr should remember mapping between PR and
 local branch
In-Reply-To: 
References: 
Message-ID: 

> Hi all,
> 
> please review this patch that adds a mapping between pull requests and local
> branches. This is done by adding a section per local branch to the
> repositorie's local configuration file, for example:
> 
> [pr "skara-198"]
> id = 310
> 
> Thanks,
> Erik

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - b6aec180: Fix bug

Changes:
  - all: https://git.openjdk.java.net/skara/pull/325/files
  - new: https://git.openjdk.java.net/skara/pull/325/files/2d86fa28..b6aec180

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/325/webrev.01
 - incr: https://webrevs.openjdk.java.net/skara/325/webrev.00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/325.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/325/head:pull/325

PR: https://git.openjdk.java.net/skara/pull/325

From ehelin at openjdk.java.net  Thu Dec 12 15:20:18 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 12 Dec 2019 15:20:18 GMT
Subject: [Rev 02] RFR: 198: git-pr should remember mapping between PR and
 local branch
In-Reply-To: 
References: 
Message-ID: 

> Hi all,
> 
> please review this patch that adds a mapping between pull requests and local
> branches. This is done by adding a section per local branch to the
> repositorie's local configuration file, for example:
> 
> [pr "skara-198"]
> id = 310
> 
> Thanks,
> Erik

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - 1d5644bc: Clean up temporary test directories

Changes:
  - all: https://git.openjdk.java.net/skara/pull/325/files
  - new: https://git.openjdk.java.net/skara/pull/325/files/b6aec180..1d5644bc

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/325/webrev.02
 - incr: https://webrevs.openjdk.java.net/skara/325/webrev.01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/325.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/325/head:pull/325

PR: https://git.openjdk.java.net/skara/pull/325

From rwestberg at openjdk.java.net  Fri Dec 13 09:40:34 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 13 Dec 2019 09:40:34 GMT
Subject: RFR: 199: Set fixVersion in an issue when a commit is integrated
In-Reply-To: 
References: 
 
Message-ID: 

On Thu, 12 Dec 2019 14:44:10 GMT, Kevin Rushforth  wrote:

>> Hi all,
>> 
>> Please review this change that sets fixVersion in a commit's issue after integration, if a version has been configured in the repository's .jcheck/conf file.
>> 
>> Also sets a version for Skara itself!
>> 
>> Best regards,
>> Robin
> 
> I don't think it is workable to have the configuration stored in the repo. We will have many cases where there will be upstream and downstream repos where commits will be synced from one to the other and you wouldn't want the fix version to be synced. Also, when forking repos or branches you want to set up and configure the new branch/repo and the master branch at the same time of the fork without pushing a commit to the repo. There are also cases (e.g., for sandbox repos) where you might not want the gitupdater feature enabled, and again it would be unworkable for the config to be in the repo.
> 
> I think this is better done via a separate database that maps each repo/branch to a fix version as well as enabling the auto update or not.

I think there may be projects where it would be useful to have the version information stored in the repository - for example, it would be immediately obvious when the version is bumped. But as you say, it may not be the case for all projects. I'll update the change to allow this to be configurable per project: Either a fixed version, read the version from .jcheck/conf, or don't set the version at all.

-------------

PR: https://git.openjdk.java.net/skara/pull/324

From rwestberg at openjdk.java.net  Fri Dec 13 09:42:34 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 13 Dec 2019 09:42:34 GMT
Subject: [Rev 01] RFR: 199: Set fixVersion in an issue when a commit is
 integrated
In-Reply-To: 
References: 
Message-ID: 

> Hi all,
> 
> Please review this change that sets fixVersion in a commit's issue after integration, if a version has been configured in the repository's .jcheck/conf file.
> 
> Also sets a version for Skara itself!
> 
> Best regards,
> Robin

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - fb8a41c4: Make new features configurable

Changes:
  - all: https://git.openjdk.java.net/skara/pull/324/files
  - new: https://git.openjdk.java.net/skara/pull/324/files/7dd2b9d9..fb8a41c4

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/324/webrev.01
 - incr: https://webrevs.openjdk.java.net/skara/324/webrev.00-01

  Stats: 163 lines in 5 files changed: 130 ins; 2 del; 31 mod
  Patch: https://git.openjdk.java.net/skara/pull/324.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/324/head:pull/324

PR: https://git.openjdk.java.net/skara/pull/324

From ehelin at openjdk.java.net  Fri Dec 13 10:00:21 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 13 Dec 2019 10:00:21 GMT
Subject: RFR: 200: git-info should show link to review
Message-ID: 

Hi all,

please review this patch that adds the flag `--review` to `git-info`. This
allows a user to show the link to the pull request for a given commit, for
example in the Skara repository:

$ git info --review --no-decoration 914cbefe88a059db12e9e55ac6a3168c75a005fd
https://git.openjdk.java.net/skara/pull/322

Thanks,
Erik

-------------

Commits:
 - 04bc2a08: skara-200

Changes: https://git.openjdk.java.net/skara/pull/326/files
 Webrev: https://webrevs.openjdk.java.net/skara/326/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-200
  Stats: 54 lines in 2 files changed: 39 ins; 10 del; 5 mod
  Patch: https://git.openjdk.java.net/skara/pull/326.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/326/head:pull/326

PR: https://git.openjdk.java.net/skara/pull/326

From rwestberg at openjdk.java.net  Fri Dec 13 10:19:35 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 13 Dec 2019 10:19:35 GMT
Subject: [Rev 02] RFR: 198: git-pr should remember mapping between PR and
 local branch
In-Reply-To: 
References: 
 
Message-ID: <-C98dmIInrWldLdlzKe5BdVNgeB1B7QKDW0J9zy3iQA=.02ae3a6e-5488-4ef1-aa1f-3e8aa4956c4e@github.com>

On Fri, 13 Dec 2019 10:19:34 GMT, Erik Helin  wrote:

>> Hi all,
>> 
>> please review this patch that adds a mapping between pull requests and local
>> branches. This is done by adding a section per local branch to the
>> repositorie's local configuration file, for example:
>> 
>> [pr "skara-198"]
>> id = 310
>> 
>> Thanks,
>> Erik
> 
> The pull request has been updated with 1 additional commit.

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/325

From rwestberg at openjdk.java.net  Fri Dec 13 10:20:33 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 13 Dec 2019 10:20:33 GMT
Subject: RFR: 200: git-info should show link to review
In-Reply-To: 
References: 
Message-ID: <_r7E2KQTrms6xp1PXV_0hu5oQTqv_0vN2QS1hoh_D-0=.80eb90fc-4409-42eb-859e-3991f0bffead@github.com>

On Fri, 13 Dec 2019 09:59:17 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that adds the flag `--review` to `git-info`. This
> allows a user to show the link to the pull request for a given commit, for
> example in the Skara repository:
> 
> $ git info --review --no-decoration 914cbefe88a059db12e9e55ac6a3168c75a005fd
> https://git.openjdk.java.net/skara/pull/322
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/326

From ehelin at openjdk.java.net  Fri Dec 13 10:53:14 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 13 Dec 2019 10:53:14 GMT
Subject: [Integrated] RFR: 198: git-pr should remember mapping between PR
 and local branch
In-Reply-To: 
References: 
Message-ID: <5b1acc7a-7794-4dc7-b090-e98bb9b67c30@openjdk.org>

Changeset: e3aefe98
Author:    Erik Helin 
Date:      2019-12-13 10:53:02 +0000
URL:       https://git.openjdk.java.net/skara/commit/e3aefe98

198: git-pr should remember mapping between PR and local branch

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java
! vcs/src/main/java/org/openjdk/skara/vcs/Repository.java
! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java
! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java
! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java

From ehelin at openjdk.java.net  Fri Dec 13 10:53:44 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 13 Dec 2019 10:53:44 GMT
Subject: [Integrated] RFR: 200: git-info should show link to review
In-Reply-To: 
References: 
Message-ID: <9f1d646b-ca23-4daa-af78-c8274d4f259b@openjdk.org>

Changeset: f73b2cb3
Author:    Erik Helin 
Date:      2019-12-13 10:53:30 +0000
URL:       https://git.openjdk.java.net/skara/commit/f73b2cb3

200: git-info should show link to review

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitInfo.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/JCheckConfiguration.java

From ehelin at openjdk.java.net  Fri Dec 13 11:00:41 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 13 Dec 2019 11:00:41 GMT
Subject: RFR: 201: git-info should by default show all options
Message-ID: 

Hi all,

please review this patch that makes `git-info` by default show all information
for a commit. I also made all the flags configurable and restructured the
output to make it more human-friendly.

Thanks,
Erik

-------------

Commits:
 - 221a940c: skara-201

Changes: https://git.openjdk.java.net/skara/pull/328/files
 Webrev: https://webrevs.openjdk.java.net/skara/328/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-201
  Stats: 116 lines in 1 file changed: 79 ins; 23 del; 14 mod
  Patch: https://git.openjdk.java.net/skara/pull/328.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/328/head:pull/328

PR: https://git.openjdk.java.net/skara/pull/328

From ehelin at openjdk.java.net  Fri Dec 13 11:04:54 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 13 Dec 2019 11:04:54 GMT
Subject: [Rev 01] RFR: 199: Set fixVersion in an issue when a commit is
 integrated
In-Reply-To: 
References: 
 
Message-ID: 

On Fri, 13 Dec 2019 11:04:53 GMT, Robin Westberg  wrote:

>> Hi all,
>> 
>> Please review this change that sets fixVersion in a commit's issue after integration, if a version has been configured in the repository's .jcheck/conf file.
>> 
>> Also sets a version for Skara itself!
>> 
>> Best regards,
>> Robin
> 
> The pull request has been updated with 1 additional commit.

bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java line 81:

> 80: 
> 81:                 if (fixVersion != null) {
> 82:                     if (fixVersion.equals("")) {

How about turning this around a bit into:

if (fixVersion == null) {
   // Try to find fixVersion from .jceck/conf
}
if (fixVersion != null) {
    issue.get().addFixVersion(fixVersion)
}
If you don't sent the `fixVersion` via the bot configuration, then it will be `null`, and then we will read it from `.jcheck/conf`. This avoids the need for the special `` version.

-------------

PR: https://git.openjdk.java.net/skara/pull/324

From rwestberg at openjdk.java.net  Fri Dec 13 11:05:46 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 13 Dec 2019 11:05:46 GMT
Subject: RFR: 201: git-info should by default show all options
In-Reply-To: 
References: 
Message-ID: 

On Fri, 13 Dec 2019 10:59:27 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that makes `git-info` by default show all information
> for a commit. I also made all the flags configurable and restructured the
> output to make it more human-friendly.
> 
> Thanks,
> Erik

This change looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/328

From rwestberg at openjdk.java.net  Fri Dec 13 11:07:33 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 13 Dec 2019 11:07:33 GMT
Subject: [Rev 01] RFR: 199: Set fixVersion in an issue when a commit is
 integrated
In-Reply-To: 
References: 
 
 
Message-ID: 

On Fri, 13 Dec 2019 11:04:46 GMT, Erik Helin  wrote:

>> The pull request has been updated with 1 additional commit.
> 
> bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java line 81:
> 
>> 80: 
>> 81:                 if (fixVersion != null) {
>> 82:                     if (fixVersion.equals("")) {
> 
> How about turning this around a bit into:
> 
> if (fixVersion == null) {
>    // Try to find fixVersion from .jceck/conf
> }
> if (fixVersion != null) {
>     issue.get().addFixVersion(fixVersion)
> }
> If you don't sent the `fixVersion` via the bot configuration, then it will be `null`, and then we will read it from `.jcheck/conf`. This avoids the need for the special `` version.

Right, but if you create a fork where you don't want to change the .jcheck/conf file (for merge reasons) you may perhaps not want the fixVersion updated?

-------------

PR: https://git.openjdk.java.net/skara/pull/324

From ehelin at openjdk.java.net  Fri Dec 13 15:45:15 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 13 Dec 2019 15:45:15 GMT
Subject: [Integrated] RFR: 201: git-info should by default show all options
In-Reply-To: 
References: 
Message-ID: <1821487d-aeb7-411f-8665-438296aedd86@openjdk.org>

Changeset: 70c81586
Author:    Erik Helin 
Date:      2019-12-13 15:45:01 +0000
URL:       https://git.openjdk.java.net/skara/commit/70c81586

201: git-info should by default show all options

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitInfo.java

From ehelin at openjdk.java.net  Fri Dec 13 15:47:18 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 13 Dec 2019 15:47:18 GMT
Subject: [Rev 01] RFR: 199: Set fixVersion in an issue when a commit is
 integrated
In-Reply-To: 
References: 
 
 
 
Message-ID: 

On Fri, 13 Dec 2019 11:07:19 GMT, Robin Westberg  wrote:

>> bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java line 81:
>> 
>>> 80: 
>>> 81:                 if (fixVersion != null) {
>>> 82:                     if (fixVersion.equals("")) {
>> 
>> How about turning this around a bit into:
>> 
>> if (fixVersion == null) {
>>    // Try to find fixVersion from .jceck/conf
>> }
>> if (fixVersion != null) {
>>     issue.get().addFixVersion(fixVersion)
>> }
>> If you don't sent the `fixVersion` via the bot configuration, then it will be `null`, and then we will read it from `.jcheck/conf`. This avoids the need for the special `` version.
> 
> Right, but if you create a fork where you don't want to change the .jcheck/conf file (for merge reasons) you may perhaps not want the fixVersion updated?

Good point! Should we then perhaps represent this using two parameters, `boolean shouldUpdateFixVersion` and `String fixVersion`?

-------------

PR: https://git.openjdk.java.net/skara/pull/324

From ehelin at openjdk.java.net  Fri Dec 13 15:55:02 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 13 Dec 2019 15:55:02 GMT
Subject: RFR: 202: git-pr create should use a proper Markdown file
Message-ID: 

Hi all,

please review this patch that updates `git pr create` to show a valid Markdown
file. The instructions have been moved into HTML comments looking like the
following:

 
 
 
 
 
 
 
 
 
 
 
 

I also took the opportunity to tweak the message a bit. Furthermore I added the
status for each commit so that it is easy to see changed files and also added a
link to an eventual issue. Personally I think the end result turned out quite
nice.

Thanks,
Erik

## Testing
- [x] Manual testing of `git pr create`

-------------

Commits:
 - 1633065c: skara-202

Changes: https://git.openjdk.java.net/skara/pull/329/files
 Webrev: https://webrevs.openjdk.java.net/skara/329/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-202
  Stats: 52 lines in 1 file changed: 36 ins; 3 del; 13 mod
  Patch: https://git.openjdk.java.net/skara/pull/329.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/329/head:pull/329

PR: https://git.openjdk.java.net/skara/pull/329

From rwestberg at openjdk.java.net  Mon Dec 16 07:04:54 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 16 Dec 2019 07:04:54 GMT
Subject: [Rev 02] RFR: 199: Set fixVersion in an issue when a commit is
 integrated
In-Reply-To: 
References: 
Message-ID: 

> Hi all,
> 
> Please review this change that sets fixVersion in a commit's issue after integration, if a version has been configured in the repository's .jcheck/conf file.
> 
> Also sets a version for Skara itself!
> 
> Best regards,
> Robin

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - 39515c61: Avoid using a magic value for fixVersion

Changes:
  - all: https://git.openjdk.java.net/skara/pull/324/files
  - new: https://git.openjdk.java.net/skara/pull/324/files/fb8a41c4..39515c61

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/324/webrev.02
 - incr: https://webrevs.openjdk.java.net/skara/324/webrev.01-02

  Stats: 15 lines in 3 files changed: 4 ins; 0 del; 11 mod
  Patch: https://git.openjdk.java.net/skara/pull/324.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/324/head:pull/324

PR: https://git.openjdk.java.net/skara/pull/324

From rwestberg at openjdk.java.net  Mon Dec 16 07:08:34 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 16 Dec 2019 07:08:34 GMT
Subject: RFR: 202: git-pr create should use a proper Markdown file
In-Reply-To: 
References: 
Message-ID: 

On Fri, 13 Dec 2019 15:54:10 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that updates `git pr create` to show a valid Markdown
> file. The instructions have been moved into HTML comments looking like the
> following:
> 
>  
>  
>  
>  
>  
>  
>  
>  
>  
>  
>  
>  
> 
> I also took the opportunity to tweak the message a bit. Furthermore I added the
> status for each commit so that it is easy to see changed files and also added a
> link to an eventual issue. Personally I think the end result turned out quite
> nice.
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git pr create`

Looks good, had one minor comment, feel free to ignore it. :)

cli/src/main/java/org/openjdk/skara/cli/GitPr.java line 789:

> 788:                              .stream()
> 789:                              .filter(l -> !(l.startsWith("")))
> 790:                              .collect(Collectors.toList());

Perhaps add a .map(String::strip) before this one to prevent whitespace mistakes?

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/329

From ehelin at openjdk.java.net  Mon Dec 16 07:23:24 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 07:23:24 GMT
Subject: [Rev 02] RFR: 199: Set fixVersion in an issue when a commit is
 integrated
In-Reply-To: 
References: 
 
Message-ID: <3mVu4R0syfOMzCjQGZ14etrcsnA__JVVBX5MsJ3C4yk=.06f0475a-4109-4a7f-b39e-a912a10bba30@github.com>

On Mon, 16 Dec 2019 07:23:24 GMT, Robin Westberg  wrote:

>> Hi all,
>> 
>> Please review this change that sets fixVersion in a commit's issue after integration, if a version has been configured in the repository's .jcheck/conf file.
>> 
>> Also sets a version for Skara itself!
>> 
>> Best regards,
>> Robin
> 
> The pull request has been updated with 1 additional commit.

Looks good, thanks!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/324

From ehelin at openjdk.java.net  Mon Dec 16 07:26:43 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 07:26:43 GMT
Subject: RFR: 202: git-pr create should use a proper Markdown file
In-Reply-To: 
References: 
 
Message-ID: 

On Mon, 16 Dec 2019 07:07:55 GMT, Robin Westberg  wrote:

>> Hi all,
>> 
>> please review this patch that updates `git pr create` to show a valid Markdown
>> file. The instructions have been moved into HTML comments looking like the
>> following:
>> 
>>  
>>  
>>  
>>  
>>  
>>  
>>  
>>  
>>  
>>  
>>  
>>  
>> 
>> I also took the opportunity to tweak the message a bit. Furthermore I added the
>> status for each commit so that it is easy to see changed files and also added a
>> link to an eventual issue. Personally I think the end result turned out quite
>> nice.
>> 
>> Thanks,
>> Erik
>> 
>> ## Testing
>> - [x] Manual testing of `git pr create`
> 
> cli/src/main/java/org/openjdk/skara/cli/GitPr.java line 789:
> 
>> 788:                              .stream()
>> 789:                              .filter(l -> !(l.startsWith("")))
>> 790:                              .collect(Collectors.toList());
> 
> Perhaps add a .map(String::strip) before this one to prevent whitespace mistakes?

Yeah, I was thinking about that, but then I realized that _if_ you want to include an HTML comment in your PR text (like this PR does) then the easiest way to do that is to just insert a space at the end of the sentence ??

Not sure how common it will be to include HTML comments though, this is the first time I've done it, but I think I prefer the "simple" semantics that the line strictly has to start and end with ``.

-------------

PR: https://git.openjdk.java.net/skara/pull/329

From rwestberg at openjdk.java.net  Mon Dec 16 07:38:15 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 16 Dec 2019 07:38:15 GMT
Subject: [Integrated] RFR: 199: Set fixVersion in an issue when a commit
 is integrated
In-Reply-To: 
References: 
Message-ID: <3b2296a5-a258-4875-86c4-c505bd137e47@openjdk.org>

Changeset: 71aff940
Author:    Robin Westberg 
Date:      2019-12-16 07:38:01 +0000
URL:       https://git.openjdk.java.net/skara/commit/71aff940

199: Set fixVersion in an issue when a commit is integrated

Reviewed-by: ehelin

! .jcheck/conf
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JsonUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBotFactory.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryUpdateConsumer.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryWorkItem.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/GeneralConfiguration.java
! test/src/main/java/org/openjdk/skara/test/CheckableRepository.java

From ehelin at openjdk.java.net  Mon Dec 16 08:35:36 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 08:35:36 GMT
Subject: RFR: 203: git-pr: add flag --jcheck to run jcheck as part of git-pr
 create
Message-ID: 

Hi all,

please review this patch that adds the flag `--jcheck` to `git-pr create`. As
the name suggests, adding the flag `--jcheck` to `git-pr create` will cause
`git-pr create` to run jcheck on the commits that will be part of the pull
request. Since not all messages are relevant for commits that are to be part of
a pull request (i.e. commit message errors do not matter) I added a new flag to
jcheck `--pull-request` to filter out those.

I also had to some slight refactoring to `GitJCheck.java` to allow it to be
called from other Java code.

Thanks,
Erik

-------------

Commits:
 - becc2d9f: skara-203

Changes: https://git.openjdk.java.net/skara/pull/330/files
 Webrev: https://webrevs.openjdk.java.net/skara/330/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-203
  Stats: 42 lines in 4 files changed: 27 ins; 0 del; 15 mod
  Patch: https://git.openjdk.java.net/skara/pull/330.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/330/head:pull/330

PR: https://git.openjdk.java.net/skara/pull/330

From rwestberg at openjdk.java.net  Mon Dec 16 08:38:49 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 16 Dec 2019 08:38:49 GMT
Subject: RFR: 203: git-pr: add flag --jcheck to run jcheck as part of
 git-pr create
In-Reply-To: 
References: 
Message-ID: 

On Mon, 16 Dec 2019 08:33:43 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that adds the flag `--jcheck` to `git-pr create`. As
> the name suggests, adding the flag `--jcheck` to `git-pr create` will cause
> `git-pr create` to run jcheck on the commits that will be part of the pull
> request. Since not all messages are relevant for commits that are to be part of
> a pull request (i.e. commit message errors do not matter) I added a new flag to
> jcheck `--pull-request` to filter out those.
> 
> I also had to some slight refactoring to `GitJCheck.java` to allow it to be
> called from other Java code.
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/330

From ehelin at openjdk.java.net  Mon Dec 16 09:13:22 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 09:13:22 GMT
Subject: [Integrated] RFR: 202: git-pr create should use a proper Markdown
 file
In-Reply-To: 
References: 
Message-ID: 

Changeset: 98ce3f26
Author:    Erik Helin 
Date:      2019-12-16 09:13:06 +0000
URL:       https://git.openjdk.java.net/skara/commit/98ce3f26

202: git-pr create should use a proper Markdown file

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java

From ehelin at openjdk.java.net  Mon Dec 16 09:15:07 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 09:15:07 GMT
Subject: [Rev 01] RFR: 203: git-pr: add flag --jcheck to run jcheck as
 part of git-pr create
In-Reply-To: 
References: 
Message-ID: 

> Hi all,
> 
> please review this patch that adds the flag `--jcheck` to `git-pr create`. As
> the name suggests, adding the flag `--jcheck` to `git-pr create` will cause
> `git-pr create` to run jcheck on the commits that will be part of the pull
> request. Since not all messages are relevant for commits that are to be part of
> a pull request (i.e. commit message errors do not matter) I added a new flag to
> jcheck `--pull-request` to filter out those.
> 
> I also had to some slight refactoring to `GitJCheck.java` to allow it to be
> called from other Java code.
> 
> Thanks,
> Erik

Previous commits in this pull request have been removed, probably due to a force push. The incremental views will show differences compared to the previous content of the PR.

-------------

Added commits:
 - bdebfeac: skara-203

Changes:
  - all: https://git.openjdk.java.net/skara/pull/330/files
  - new: https://git.openjdk.java.net/skara/pull/330/files/becc2d9f..bdebfeac

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/330/webrev.01
 - incr: https://webrevs.openjdk.java.net/skara/330/webrev.00-01

  Stats: 29 lines in 3 files changed: 21 ins; 0 del; 8 mod
  Patch: https://git.openjdk.java.net/skara/pull/330.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/330/head:pull/330

PR: https://git.openjdk.java.net/skara/pull/330

From ehelin at openjdk.java.net  Mon Dec 16 09:15:51 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 09:15:51 GMT
Subject: [Rev 01] RFR: 203: git-pr: add flag --jcheck to run jcheck as
 part of git-pr create
In-Reply-To: 
References: 
 
Message-ID: 

On Mon, 16 Dec 2019 08:38:42 GMT, Robin Westberg  wrote:

>> Previous commits in this pull request have been removed, probably due to a force push. The incremental views will show differences compared to the previous content of the PR.
> 
> Looks good!

Thanks for reviewing @rwestberg!

I'm sorry, I had forgotten a few local changes (I use `git-pr` to test `git-pr`...), could you please re-review?

-------------

PR: https://git.openjdk.java.net/skara/pull/330

From rwestberg at openjdk.java.net  Mon Dec 16 09:24:09 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 16 Dec 2019 09:24:09 GMT
Subject: [Rev 01] RFR: 203: git-pr: add flag --jcheck to run jcheck as
 part of git-pr create
In-Reply-To: 
References: 
 
Message-ID: 

On Mon, 16 Dec 2019 09:24:09 GMT, Erik Helin  wrote:

>> Hi all,
>> 
>> please review this patch that adds the flag `--jcheck` to `git-pr create`. As
>> the name suggests, adding the flag `--jcheck` to `git-pr create` will cause
>> `git-pr create` to run jcheck on the commits that will be part of the pull
>> request. Since not all messages are relevant for commits that are to be part of
>> a pull request (i.e. commit message errors do not matter) I added a new flag to
>> jcheck `--pull-request` to filter out those.
>> 
>> I also had to some slight refactoring to `GitJCheck.java` to allow it to be
>> called from other Java code.
>> 
>> Thanks,
>> Erik
> 
> Previous commits in this pull request have been removed, probably due to a force push. The incremental views will show differences compared to the previous content of the PR.

Still good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/330

From ehelin at openjdk.java.net  Mon Dec 16 09:25:20 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 09:25:20 GMT
Subject: [Integrated] RFR: 203: git-pr: add flag --jcheck to run jcheck as
 part of git-pr create
In-Reply-To: 
References: 
Message-ID: <5c34e990-34d7-47d9-b826-eff9285a9b6b@openjdk.org>

Changeset: 62197350
Author:    Erik Helin 
Date:      2019-12-16 09:25:07 +0000
URL:       https://git.openjdk.java.net/skara/commit/62197350

203: git-pr: add flag --jcheck to run jcheck as part of git-pr create

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java
! cli/src/main/java/org/openjdk/skara/cli/GitPr.java
! cli/src/main/java/org/openjdk/skara/cli/JCheckCLIVisitor.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/JCheck.java

From ehelin at openjdk.java.net  Mon Dec 16 10:11:12 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 10:11:12 GMT
Subject: RFR: 204: git-sync: must fetch before --fast-forward
Message-ID: 

Hi all,

please review this patch that ensures `git sync --fast-forward` fetches the
changes from the `to` remote _before_ trying to do "fast forward" merges. This
is needed because doing a push to a remote ref does not cause that ref to be
updated.

Thanks,
Erik

## Testing
- [x] Manual testing of `git sync --fast-foward`
- [x] Added a new unit test

-------------

Commits:
 - 7694fb6e: skara-204

Changes: https://git.openjdk.java.net/skara/pull/331/files
 Webrev: https://webrevs.openjdk.java.net/skara/331/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-204
  Stats: 43 lines in 5 files changed: 41 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/331.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/331/head:pull/331

PR: https://git.openjdk.java.net/skara/pull/331

From rwestberg at openjdk.java.net  Mon Dec 16 10:29:50 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 16 Dec 2019 10:29:50 GMT
Subject: RFR: 204: git-sync: must fetch before --fast-forward
In-Reply-To: 
References: 
Message-ID: 

On Mon, 16 Dec 2019 10:10:28 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that ensures `git sync --fast-forward` fetches the
> changes from the `to` remote _before_ trying to do "fast forward" merges. This
> is needed because doing a push to a remote ref does not cause that ref to be
> updated.
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git sync --fast-foward`
> - [x] Added a new unit test

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/331

From ehelin at openjdk.java.net  Mon Dec 16 10:33:21 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 10:33:21 GMT
Subject: [Integrated] RFR: 204: git-sync: must fetch before --fast-forward
In-Reply-To: 
References: 
Message-ID: 

Changeset: e6d33cd2
Author:    Erik Helin 
Date:      2019-12-16 10:33:06 +0000
URL:       https://git.openjdk.java.net/skara/commit/e6d33cd2

204: git-sync: must fetch before --fast-forward

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitSync.java
! vcs/src/main/java/org/openjdk/skara/vcs/Repository.java
! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java
! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java
! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java

From ehelin at openjdk.java.net  Mon Dec 16 10:37:19 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 10:37:19 GMT
Subject: RFR: 205: git-pr: allow configurable default action
Message-ID: 

Hi all,

please review this small patch that makes the default action of `git pr`
configurable.

Thanks,
Erik

## Testing
- [x] Manual testing of `git pr` with and without a default action

-------------

Commits:
 - 4821a25d: skara-205

Changes: https://git.openjdk.java.net/skara/pull/332/files
 Webrev: https://webrevs.openjdk.java.net/skara/332/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-205
  Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/332/head:pull/332

PR: https://git.openjdk.java.net/skara/pull/332

From rwestberg at openjdk.java.net  Mon Dec 16 10:37:19 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 16 Dec 2019 10:37:19 GMT
Subject: RFR: 205: git-pr: allow configurable default action
In-Reply-To: 
References: 
Message-ID: 

On Mon, 16 Dec 2019 10:35:08 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this small patch that makes the default action of `git pr`
> configurable.
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git pr` with and without a default action

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/332

From ehelin at openjdk.java.net  Mon Dec 16 10:42:40 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 10:42:40 GMT
Subject: [Integrated] RFR: 205: git-pr: allow configurable default action
In-Reply-To: 
References: 
Message-ID: <83fe5deb-05fc-4b7a-ab07-14bbf6d6f6ca@openjdk.org>

Changeset: e6ed98e9
Author:    Erik Helin 
Date:      2019-12-16 10:42:27 +0000
URL:       https://git.openjdk.java.net/skara/commit/e6ed98e9

205: git-pr: allow configurable default action

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java

From rwestberg at openjdk.java.net  Mon Dec 16 12:47:25 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 16 Dec 2019 12:47:25 GMT
Subject: RFR: 206: Add proper escaping for replacement pattern
Message-ID: 

Hi all,

Please review this fix that adds proper escaping for replacement patterns in the `TextToMarkdown.escapeFormatting` function. Previously it was possible for exceptions to be thrown on certain input containing regex control characters.

Best regards,
Robin

-------------

Commits:
 - 71ef4550: Add proper escaping for replacement pattern

Changes: https://git.openjdk.java.net/skara/pull/333/files
 Webrev: https://webrevs.openjdk.java.net/skara/333/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-206
  Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/333.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/333/head:pull/333

PR: https://git.openjdk.java.net/skara/pull/333

From ehelin at openjdk.java.net  Mon Dec 16 12:47:36 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 12:47:36 GMT
Subject: RFR: 206: Add proper escaping for replacement pattern
In-Reply-To: 
References: 
Message-ID: 

On Mon, 16 Dec 2019 12:45:45 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this fix that adds proper escaping for replacement patterns in the `TextToMarkdown.escapeFormatting` function. Previously it was possible for exceptions to be thrown on certain input containing regex control characters.
> 
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/333

From rwestberg at openjdk.java.net  Mon Dec 16 12:53:59 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 16 Dec 2019 12:53:59 GMT
Subject: [Integrated] RFR: 206: Add proper escaping for replacement pattern
In-Reply-To: 
References: 
Message-ID: <56a7b48b-acbe-4768-9541-04050c2fd206@openjdk.org>

Changeset: ba7d001e
Author:    Robin Westberg 
Date:      2019-12-16 12:53:46 +0000
URL:       https://git.openjdk.java.net/skara/commit/ba7d001e

206: Add proper escaping for replacement pattern

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/TextToMarkdown.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/TextToMarkdownTests.java

From ehelin at openjdk.java.net  Mon Dec 16 13:08:16 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 13:08:16 GMT
Subject: RFR: 208: git-publish: off-by-one error when parsing --quiet
Message-ID: 

Hi all,

please review this tiny patch that fixes an (embarrassing) off-by-one indexing error in `GitPublish.java`.

Thanks,
Erik

## Testing
- [x] Manual testing of `git-publish`

-------------

Commits:
 - 237380dd: skara-208

Changes: https://git.openjdk.java.net/skara/pull/334/files
 Webrev: https://webrevs.openjdk.java.net/skara/334/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-208
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/334.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/334/head:pull/334

PR: https://git.openjdk.java.net/skara/pull/334

From rwestberg at openjdk.java.net  Mon Dec 16 13:15:49 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 16 Dec 2019 13:15:49 GMT
Subject: RFR: 208: git-publish: off-by-one error when parsing --quiet
In-Reply-To: 
References: 
Message-ID: <56I1j7_RZAZYY3n3XPxBX4VNbh3-boh1jSgLieNhVeY=.b759bcf6-7736-467f-9c9f-346a717f2951@github.com>

On Mon, 16 Dec 2019 13:06:10 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this tiny patch that fixes an (embarrassing) off-by-one indexing error in `GitPublish.java`.
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git-publish`

:)

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/334

From ehelin at openjdk.java.net  Mon Dec 16 14:31:39 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 16 Dec 2019 14:31:39 GMT
Subject: [Integrated] RFR: 208: git-publish: off-by-one error when parsing
 --quiet
In-Reply-To: 
References: 
Message-ID: <7dec7e3a-4f9b-4f60-a8bc-e1a7a178bd8f@openjdk.org>

Changeset: 7cb0f72d
Author:    Erik Helin 
Date:      2019-12-16 14:31:27 +0000
URL:       https://git.openjdk.java.net/skara/commit/7cb0f72d

208: git-publish: off-by-one error when parsing --quiet

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPublish.java

From ehelin at openjdk.java.net  Tue Dec 17 08:52:14 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 17 Dec 2019 08:52:14 GMT
Subject: RFR: 179: Make git-pr flags configurable
Message-ID: 

Hi all,

please review this patch that makes all the flags to `git-pr` configurable. It
is also possible to configure different values for flags depending on command,
e.g.:

[pr]
        default = list

[pr "create"]
        assignees = rwestberg

[pr "list"]
        assignees = ehelin

The above is a slightly contrived example just to show how it works. A more
realistic example is my current configuration for `git-pr`:

[pr]
	default = list

[pr "create"]
	ignore-workspace = true
	ignore-local-commits = true
	publish = true
	jcheck = true

Thanks,
Erik

## Testing
- [x] Manual testing of `git-pr` on Linux x64

-------------

Commits:
 - b599d0c1: skara-179

Changes: https://git.openjdk.java.net/skara/pull/335/files
 Webrev: https://webrevs.openjdk.java.net/skara/335/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-179
  Stats: 122 lines in 1 file changed: 75 ins; 16 del; 31 mod
  Patch: https://git.openjdk.java.net/skara/pull/335.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/335/head:pull/335

PR: https://git.openjdk.java.net/skara/pull/335

From rwestberg at openjdk.java.net  Tue Dec 17 08:54:25 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 17 Dec 2019 08:54:25 GMT
Subject: RFR: 179: Make git-pr flags configurable
In-Reply-To: 
References: 
Message-ID: 

On Tue, 17 Dec 2019 08:49:51 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that makes all the flags to `git-pr` configurable. It
> is also possible to configure different values for flags depending on command,
> e.g.:
> 
> [pr]
>         default = list
> 
> [pr "create"]
>         assignees = rwestberg
> 
> [pr "list"]
>         assignees = ehelin
> 
> The above is a slightly contrived example just to show how it works. A more
> realistic example is my current configuration for `git-pr`:
> 
> [pr]
> 	default = list
> 
> [pr "create"]
> 	ignore-workspace = true
> 	ignore-local-commits = true
> 	publish = true
> 	jcheck = true
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git-pr` on Linux x64

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/335

From ehelin at openjdk.java.net  Tue Dec 17 08:58:41 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 17 Dec 2019 08:58:41 GMT
Subject: [Integrated] RFR: 179: Make git-pr flags configurable
In-Reply-To: 
References: 
Message-ID: <5db70e96-3865-4787-b06f-6c1833636a37@openjdk.org>

Changeset: e781a164
Author:    Erik Helin 
Date:      2019-12-17 08:58:26 +0000
URL:       https://git.openjdk.java.net/skara/commit/e781a164

179: Make git-pr flags configurable

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java

From rwestberg at openjdk.java.net  Tue Dec 17 09:20:16 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 17 Dec 2019 09:20:16 GMT
Subject: RFR: 207: Retry failed mlbridge comment post operations
Message-ID: 

Hi all,

Please review this change that ensures that failed mlbridge comment post operations are retried. It also ensures that unique post operations can run concurrently (and thus will not be dropped in case the scheduler is saturated).

Best regards,
Robin

-------------

Commits:
 - 19507521: Ensure that exceptions during comment posting causes a retry

Changes: https://git.openjdk.java.net/skara/pull/336/files
 Webrev: https://webrevs.openjdk.java.net/skara/336/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-207
  Stats: 23 lines in 2 files changed: 20 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/skara/pull/336.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/336/head:pull/336

PR: https://git.openjdk.java.net/skara/pull/336

From ehelin at openjdk.java.net  Tue Dec 17 10:06:12 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 17 Dec 2019 10:06:12 GMT
Subject: RFR: 209: git-pr: add ISSUE column to git-pr list
Message-ID: <8p3p-mkDoOiFdGDGd3S0gccr0z456i7Gl7ecPQYn7s4=.876dab5d-824c-4d62-a102-6d02ef4f1e5a@github.com>

Hi all,

please review this patch that adds an "ISSUES" column to `git pr list` showing
the JBS issue ids a pull request are associated with. A future cleanup should
probably extract the pull request body parsing logic into a separate package so
it can be reused throughout Skara.

Thanks,
Erik

## Testing
- [x] Manual testing of `git pr list`

-------------

Commits:
 - 023d9b9a: skara-209

Changes: https://git.openjdk.java.net/skara/pull/337/files
 Webrev: https://webrevs.openjdk.java.net/skara/337/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-209
  Stats: 53 lines in 1 file changed: 49 ins; 1 del; 3 mod
  Patch: https://git.openjdk.java.net/skara/pull/337.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/337/head:pull/337

PR: https://git.openjdk.java.net/skara/pull/337

From rwestberg at openjdk.java.net  Tue Dec 17 10:31:11 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 17 Dec 2019 10:31:11 GMT
Subject: RFR: 209: git-pr: add ISSUE column to git-pr list
In-Reply-To: <8p3p-mkDoOiFdGDGd3S0gccr0z456i7Gl7ecPQYn7s4=.876dab5d-824c-4d62-a102-6d02ef4f1e5a@github.com>
References: <8p3p-mkDoOiFdGDGd3S0gccr0z456i7Gl7ecPQYn7s4=.876dab5d-824c-4d62-a102-6d02ef4f1e5a@github.com>
Message-ID: 

On Tue, 17 Dec 2019 10:05:22 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that adds an "ISSUES" column to `git pr list` showing
> the JBS issue ids a pull request are associated with. A future cleanup should
> probably extract the pull request body parsing logic into a separate package so
> it can be reused throughout Skara.
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git pr list`

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/337

From ehelin at openjdk.java.net  Tue Dec 17 11:20:00 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 17 Dec 2019 11:20:00 GMT
Subject: RFR: 207: Retry failed mlbridge comment post operations
In-Reply-To: 
References: 
Message-ID: 

On Tue, 17 Dec 2019 09:19:32 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this change that ensures that failed mlbridge comment post operations are retried. It also ensures that unique post operations can run concurrently (and thus will not be dropped in case the scheduler is saturated).
> 
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/336

From ehelin at openjdk.java.net  Tue Dec 17 11:23:52 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 17 Dec 2019 11:23:52 GMT
Subject: [Integrated] RFR: 209: git-pr: add ISSUE column to git-pr list
In-Reply-To: <8p3p-mkDoOiFdGDGd3S0gccr0z456i7Gl7ecPQYn7s4=.876dab5d-824c-4d62-a102-6d02ef4f1e5a@github.com>
References: <8p3p-mkDoOiFdGDGd3S0gccr0z456i7Gl7ecPQYn7s4=.876dab5d-824c-4d62-a102-6d02ef4f1e5a@github.com>
Message-ID: <41447fb2-470a-4c7f-b7f8-766138278233@openjdk.org>

Changeset: 0a10693f
Author:    Erik Helin 
Date:      2019-12-17 11:23:38 +0000
URL:       https://git.openjdk.java.net/skara/commit/0a10693f

209: git-pr: add ISSUE column to git-pr list

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java

From ehelin at openjdk.java.net  Tue Dec 17 13:26:13 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 17 Dec 2019 13:26:13 GMT
Subject: RFR: 210: git-pr: add BRANCH column to git-pr list
Message-ID: 

Hi all,

please review this patch that adds the "BRANCH" column to the `git pr list`
output. The branch column will list the local branches in a repository that
corresponds to a pull request.

@rwestberg I had to make a few changes to `PullRequest`:

- renamed `sourceRef` to `fetchRef`
- added `sourceRef` which now really means the reference in the source
  repository ??
- added `sourceRepository` for getting the source repository for a pull request

I did the rename of `sourceRef` to `fetchRef` first, so I shouldn't have missed
updating any places where it was used.

Thanks,
Erik

## Testing
- [x] `make test` on Linux x64
- [x] Manual testing of `git pr list` on Linux x64

-------------

Commits:
 - 90ff1737: skara-210

Changes: https://git.openjdk.java.net/skara/pull/338/files
 Webrev: https://webrevs.openjdk.java.net/skara/338/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-210
  Stats: 70 lines in 8 files changed: 62 ins; 0 del; 8 mod
  Patch: https://git.openjdk.java.net/skara/pull/338.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/338/head:pull/338

PR: https://git.openjdk.java.net/skara/pull/338

From rwestberg at openjdk.java.net  Tue Dec 17 13:29:00 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 17 Dec 2019 13:29:00 GMT
Subject: RFR: 210: git-pr: add BRANCH column to git-pr list
In-Reply-To: 
References: 
Message-ID: 

On Tue, 17 Dec 2019 13:25:27 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that adds the "BRANCH" column to the `git pr list`
> output. The branch column will list the local branches in a repository that
> corresponds to a pull request.
> 
> @rwestberg I had to make a few changes to `PullRequest`:
> 
> - renamed `sourceRef` to `fetchRef`
> - added `sourceRef` which now really means the reference in the source
>   repository ??
> - added `sourceRepository` for getting the source repository for a pull request
> 
> I did the rename of `sourceRef` to `fetchRef` first, so I shouldn't have missed
> updating any places where it was used.
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] `make test` on Linux x64
> - [x] Manual testing of `git pr list` on Linux x64

Sounds reasonable!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/338

From ehelin at openjdk.java.net  Tue Dec 17 13:32:41 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 17 Dec 2019 13:32:41 GMT
Subject: [Integrated] RFR: 210: git-pr: add BRANCH column to git-pr list
In-Reply-To: 
References: 
Message-ID: <2aab3c88-b903-4695-9e49-78cab3a8394e@openjdk.org>

Changeset: b95c20f3
Author:    Erik Helin 
Date:      2019-12-17 13:32:26 +0000
URL:       https://git.openjdk.java.net/skara/commit/b95c20f3

210: git-pr: add BRANCH column to git-pr list

Reviewed-by: rwestberg

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevStorage.java
! bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java
! cli/src/main/java/org/openjdk/skara/cli/GitPr.java
! forge/src/main/java/org/openjdk/skara/forge/PullRequest.java
! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java
! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java
! test/src/main/java/org/openjdk/skara/test/TestPullRequest.java

From rwestberg at openjdk.java.net  Tue Dec 17 13:45:27 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 17 Dec 2019 13:45:27 GMT
Subject: [Integrated] RFR: 207: Retry failed mlbridge comment post
 operations
In-Reply-To: 
References: 
Message-ID: <1102077b-747c-4349-97d2-fab9d2518bbf@openjdk.org>

Changeset: 6956b346
Author:    Robin Westberg 
Date:      2019-12-17 13:45:13 +0000
URL:       https://git.openjdk.java.net/skara/commit/6956b346

207: Retry failed mlbridge comment post operations

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CommentPosterWorkItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBot.java

From rwestberg at openjdk.java.net  Tue Dec 17 13:53:39 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 17 Dec 2019 13:53:39 GMT
Subject: RFR: 212: Retry notifications for updaters that can check current
 state
Message-ID: 

Hi all,

Please review this change that enables issue notifications to be retried in case transient server errors occur, but will not send out duplicate email notifications.

Best regards,
Robin

-------------

Commits:
 - b78f2a14: Initial implementation

Changes: https://git.openjdk.java.net/skara/pull/339/files
 Webrev: https://webrevs.openjdk.java.net/skara/339/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-212
  Stats: 211 lines in 8 files changed: 181 ins; 7 del; 23 mod
  Patch: https://git.openjdk.java.net/skara/pull/339.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/339/head:pull/339

PR: https://git.openjdk.java.net/skara/pull/339

From rwestberg at openjdk.java.net  Wed Dec 18 07:14:16 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 18 Dec 2019 07:14:16 GMT
Subject: [Rev 01] RFR: 212: Retry notifications for updaters that can
 check current state
In-Reply-To: 
References: 
Message-ID: 

> Hi all,
> 
> Please review this change that enables issue notifications to be retried in case transient server errors occur, but will not send out duplicate email notifications.
> 
> Best regards,
> Robin

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - 7aa81917: Improve naming and detection of previous issue comments

Changes:
  - all: https://git.openjdk.java.net/skara/pull/339/files
  - new: https://git.openjdk.java.net/skara/pull/339/files/b78f2a14..7aa81917

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/339/webrev.01
 - incr: https://webrevs.openjdk.java.net/skara/339/webrev.00-01

  Stats: 6 lines in 2 files changed: 1 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/skara/pull/339.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/339/head:pull/339

PR: https://git.openjdk.java.net/skara/pull/339

From ehelin at openjdk.java.net  Wed Dec 18 07:48:47 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 18 Dec 2019 07:48:47 GMT
Subject: [Rev 01] RFR: 212: Retry notifications for updaters that can
 check current state
In-Reply-To: 
References: 
 
Message-ID: <-ZN1Xliz1rbMwXKtFAdSnC3zW2U4LvvUmfeXPNCrIsA=.4269d1ea-4aa7-4cec-9a81-96085f2effa1@github.com>

On Wed, 18 Dec 2019 07:48:46 GMT, Robin Westberg  wrote:

>> Hi all,
>> 
>> Please review this change that enables issue notifications to be retried in case transient server errors occur, but will not send out duplicate email notifications.
>> 
>> Best regards,
>> Robin
> 
> The pull request has been updated with 1 additional commit.

bots/notify/src/main/java/org/openjdk/skara/bots/notify/PullRequestUpdateConsumer.java line 31:

> 30:     void handleRemovedIssue(PullRequest pr, Issue issue);
> 31:     boolean idempotent();
> 32: }

Suggestion:

    boolean isIdempotent();

-------------

PR: https://git.openjdk.java.net/skara/pull/339

From rwestberg at openjdk.java.net  Wed Dec 18 08:07:28 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 18 Dec 2019 08:07:28 GMT
Subject: [Rev 02] RFR: 212: Retry notifications for updaters that can
 check current state
In-Reply-To: 
References: 
Message-ID: 

> Hi all,
> 
> Please review this change that enables issue notifications to be retried in case transient server errors occur, but will not send out duplicate email notifications.
> 
> Best regards,
> Robin

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - e784547b: Updated after review

Changes:
  - all: https://git.openjdk.java.net/skara/pull/339/files
  - new: https://git.openjdk.java.net/skara/pull/339/files/7aa81917..e784547b

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/339/webrev.02
 - incr: https://webrevs.openjdk.java.net/skara/339/webrev.01-02

  Stats: 11 lines in 6 files changed: 0 ins; 1 del; 10 mod
  Patch: https://git.openjdk.java.net/skara/pull/339.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/339/head:pull/339

PR: https://git.openjdk.java.net/skara/pull/339

From ehelin at openjdk.java.net  Wed Dec 18 09:00:12 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 18 Dec 2019 09:00:12 GMT
Subject: RFR: 211: git-pr: add status subcommand
Message-ID: 

Hi all,

please review this patch that adds the beginnings of the `git pr status`
subcommand. The output of `git pr status` is currently:

$ git pr status 339
Status: RFR
Checks:
- jcheck: OK

I plan to add more information for individual checks. There are also two flags
supported, `--no-decoration` and `--no-checks`. If a user just wants the "raw"
status on standard out, then the following would be used:

$ git pr status --no-decoration --no-checks 339
RFR

This output is mainly intended for those that for example want to use the status
of a pull request in their own scripts.

Thanks,
Erik

## Testing
- [x] Manual testing of `git pr status`

-------------

Commits:
 - 72f4c775: skara-211

Changes: https://git.openjdk.java.net/skara/pull/340/files
 Webrev: https://webrevs.openjdk.java.net/skara/340/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-211
  Stats: 134 lines in 1 file changed: 109 ins; 20 del; 5 mod
  Patch: https://git.openjdk.java.net/skara/pull/340.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/340/head:pull/340

PR: https://git.openjdk.java.net/skara/pull/340

From ehelin at openjdk.java.net  Wed Dec 18 09:02:58 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 18 Dec 2019 09:02:58 GMT
Subject: [Rev 02] RFR: 212: Retry notifications for updaters that can
 check current state
In-Reply-To: 
References: 
 
Message-ID: 

On Wed, 18 Dec 2019 09:02:58 GMT, Robin Westberg  wrote:

>> Hi all,
>> 
>> Please review this change that enables issue notifications to be retried in case transient server errors occur, but will not send out duplicate email notifications.
>> 
>> Best regards,
>> Robin
> 
> The pull request has been updated with 1 additional commit.

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/339

From rwestberg at openjdk.java.net  Wed Dec 18 09:07:08 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 18 Dec 2019 09:07:08 GMT
Subject: RFR: 211: git-pr: add status subcommand
In-Reply-To: 
References: 
Message-ID: 

On Wed, 18 Dec 2019 08:59:20 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this patch that adds the beginnings of the `git pr status`
> subcommand. The output of `git pr status` is currently:
> 
> $ git pr status 339
> Status: RFR
> Checks:
> - jcheck: OK
> 
> I plan to add more information for individual checks. There are also two flags
> supported, `--no-decoration` and `--no-checks`. If a user just wants the "raw"
> status on standard out, then the following would be used:
> 
> $ git pr status --no-decoration --no-checks 339
> RFR
> 
> This output is mainly intended for those that for example want to use the status
> of a pull request in their own scripts.
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git pr status`

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/340

From ehelin at openjdk.java.net  Wed Dec 18 09:18:24 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 18 Dec 2019 09:18:24 GMT
Subject: [Integrated] RFR: 211: git-pr: add status subcommand
In-Reply-To: 
References: 
Message-ID: <5298b376-3943-42f7-a9c6-4c9efcef25ad@openjdk.org>

Changeset: d6aa3e17
Author:    Erik Helin 
Date:      2019-12-18 09:18:04 +0000
URL:       https://git.openjdk.java.net/skara/commit/d6aa3e17

211: git-pr: add status subcommand

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java

From rwestberg at openjdk.java.net  Wed Dec 18 09:23:19 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 18 Dec 2019 09:23:19 GMT
Subject: [Integrated] RFR: 212: Retry notifications for updaters that can
 check current state
In-Reply-To: 
References: 
Message-ID: <5d15380d-644c-42b3-b1a3-14aadc78b341@openjdk.org>

Changeset: 0f32008b
Author:    Robin Westberg 
Date:      2019-12-18 09:23:07 +0000
URL:       https://git.openjdk.java.net/skara/commit/0f32008b

212: Retry notifications for updaters that can check current state

Reviewed-by: ehelin

! bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JsonUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryUpdateConsumer.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryWorkItem.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java
! test/src/main/java/org/openjdk/skara/test/TestIssue.java

From rwestberg at openjdk.java.net  Wed Dec 18 13:44:14 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 18 Dec 2019 13:44:14 GMT
Subject: RFR: 213: More granular configuration for mailing list notifier
Message-ID: 

Hi all,

Please review this change that allows more granular configuration of the mailing list notifier, to be able to disable certain types of notifications per repository.

Best regards,
Robin

-------------

Commits:
 - f59dbde2: Add configurability for mailing list notifier

Changes: https://git.openjdk.java.net/skara/pull/341/files
 Webrev: https://webrevs.openjdk.java.net/skara/341/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-213
  Stats: 149 lines in 4 files changed: 124 ins; 11 del; 14 mod
  Patch: https://git.openjdk.java.net/skara/pull/341.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/341/head:pull/341

PR: https://git.openjdk.java.net/skara/pull/341

From ehelin at openjdk.java.net  Thu Dec 19 06:46:26 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 19 Dec 2019 06:46:26 GMT
Subject: RFR: 213: More granular configuration for mailing list notifier
In-Reply-To: 
References: 
Message-ID: 

On Wed, 18 Dec 2019 13:43:26 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this change that allows more granular configuration of the mailing list notifier, to be able to disable certain types of notifications per repository.
> 
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/341

From rwestberg at openjdk.java.net  Thu Dec 19 07:48:37 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 19 Dec 2019 07:48:37 GMT
Subject: [Integrated] RFR: 213: More granular configuration for mailing
 list notifier
In-Reply-To: 
References: 
Message-ID: <49dbc526-0285-4ab4-9400-aae7c8b02ba4@openjdk.org>

Changeset: c4a68c55
Author:    Robin Westberg 
Date:      2019-12-19 07:48:21 +0000
URL:       https://git.openjdk.java.net/skara/commit/c4a68c55

213: More granular configuration for mailing list notifier

Reviewed-by: ehelin

! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBotFactory.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryUpdateConsumer.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java

From rwestberg at openjdk.java.net  Thu Dec 19 08:19:30 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 19 Dec 2019 08:19:30 GMT
Subject: RFR: 172: Moving a PR from draft state should trigger a new check
Message-ID: 

Hi all,

Please review this small change that ensures that moving a PR from draft state triggers a new check.

Best regards,
Robin

-------------

Commits:
 - d4f26522: Include draft status in check metadata calculation

Changes: https://git.openjdk.java.net/skara/pull/342/files
 Webrev: https://webrevs.openjdk.java.net/skara/342/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-172
  Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/skara/pull/342.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/342/head:pull/342

PR: https://git.openjdk.java.net/skara/pull/342

From ehelin at openjdk.java.net  Thu Dec 19 09:30:44 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 19 Dec 2019 09:30:44 GMT
Subject: RFR: 172: Moving a PR from draft state should trigger a new check
In-Reply-To: 
References: 
Message-ID: <61nHp_9gXXN85q0szazMa6CCVG1IRCj18wu7fZaynlI=.a0d8dc44-72b3-496e-8827-6aa75bd6f758@github.com>

On Thu, 19 Dec 2019 08:18:34 GMT, Robin Westberg  wrote:

> Hi all,
> 
> Please review this small change that ensures that moving a PR from draft state triggers a new check.
> 
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/342

From rwestberg at openjdk.java.net  Thu Dec 19 09:43:08 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 19 Dec 2019 09:43:08 GMT
Subject: [Integrated] RFR: 172: Moving a PR from draft state should
 trigger a new check
In-Reply-To: 
References: 
Message-ID: <15f14740-0eb8-4eda-a438-c1182d117de0@openjdk.org>

Changeset: e895b3c3
Author:    Robin Westberg 
Date:      2019-12-19 09:42:50 +0000
URL:       https://git.openjdk.java.net/skara/commit/e895b3c3

172: Moving a PR from draft state should trigger a new check

Reviewed-by: ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java

From rwestberg at openjdk.java.net  Thu Dec 19 14:46:51 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 19 Dec 2019 14:46:51 GMT
Subject: RFR: 214: Improve the message given when a change can be integrated
Message-ID: 

Hi all,

This change adjusts the "this change is now ready to be integrated" message. After the change, it would look something like the below. Comments are welcome!

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all [project specific requirements](https://github.com/openjdk/skara/blob/master/CONTRIBUTING.md), type `/integrate` in a new comment to proceed. After integration, the commit message will be:
No need for locking when using TestHostedRepository

Reviewed-by: ehelin
- If you would like to add a summary, use the `/summary` command.
- To credit additional contributors, use the `/contributor` command.
- To add additional solved issues, use the `/solves` command.

Since the source branch of this PR was last updated there have been 61 commits pushed to the `master` branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge `master` into your branch first.

?? To integrate this PR with the above commit message, type `/integrate` in a new comment.

-------------

Commits:
 - 91d414c3: Adjust the message

Changes: https://git.openjdk.java.net/skara/pull/343/files
 Webrev: https://webrevs.openjdk.java.net/skara/343/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-214
  Stats: 19 lines in 1 file changed: 7 ins; 5 del; 7 mod
  Patch: https://git.openjdk.java.net/skara/pull/343.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/343/head:pull/343

PR: https://git.openjdk.java.net/skara/pull/343

From fastegal at openjdk.java.net  Thu Dec 19 16:33:39 2019
From: fastegal at openjdk.java.net (Jeanette Winzenburg)
Date: Thu, 19 Dec 2019 16:33:39 GMT
Subject: RFR: 214: Improve the message given when a change can be
 integrated
In-Reply-To: 
References: 
Message-ID: 

On Thu, 19 Dec 2019 14:46:07 GMT, Robin Westberg  wrote:

> Hi all,
> 
> This change adjusts the "this change is now ready to be integrated" message. After the change, it would look something like the below. Comments are welcome!
> 
> @rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all [project specific requirements](https://github.com/openjdk/skara/blob/master/CONTRIBUTING.md), type `/integrate` in a new comment to proceed. After integration, the commit message will be:
> No need for locking when using TestHostedRepository
> 
> Reviewed-by: ehelin
> - If you would like to add a summary, use the `/summary` command.
> - To credit additional contributors, use the `/contributor` command.
> - To add additional solved issues, use the `/solves` command.
> 
> Since the source branch of this PR was last updated there have been 61 commits pushed to the `master` branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge `master` into your branch first.
> 
> ?? To integrate this PR with the above commit message, type `/integrate` in a new comment.

looks good to me :)

-------------

PR: https://git.openjdk.java.net/skara/pull/343

From kcr at openjdk.java.net  Thu Dec 19 17:03:10 2019
From: kcr at openjdk.java.net (Kevin Rushforth)
Date: Thu, 19 Dec 2019 17:03:10 GMT
Subject: RFR: 214: Improve the message given when a change can be
 integrated
In-Reply-To: 
References: 
Message-ID: 

On Thu, 19 Dec 2019 14:46:07 GMT, Robin Westberg  wrote:

> Hi all,
> 
> This change adjusts the "this change is now ready to be integrated" message. After the change, it would look something like the below. Comments are welcome!
> 
> @rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all [project specific requirements](https://github.com/openjdk/skara/blob/master/CONTRIBUTING.md), type `/integrate` in a new comment to proceed. After integration, the commit message will be:
> No need for locking when using TestHostedRepository
> 
> Reviewed-by: ehelin
> - If you would like to add a summary, use the `/summary` command.
> - To credit additional contributors, use the `/contributor` command.
> - To add additional solved issues, use the `/solves` command.
> 
> Since the source branch of this PR was last updated there have been 61 commits pushed to the `master` branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge `master` into your branch first.
> 
> ?? To integrate this PR with the above commit message, type `/integrate` in a new comment.

Looks good. Thanks.

-------------

Marked as reviewed by kcr (no project role).

PR: https://git.openjdk.java.net/skara/pull/343

From rwestberg at openjdk.java.net  Fri Dec 20 08:53:17 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 20 Dec 2019 08:53:17 GMT
Subject: [Rev 01] RFR: 214: Improve the message given when a change can be
 integrated
In-Reply-To: 
References: 
Message-ID: 

> Hi all,
> 
> This change adjusts the "this change is now ready to be integrated" message. After the change, it would look something like the below. Comments are welcome!
> 
> @rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all [project specific requirements](https://github.com/openjdk/skara/blob/master/CONTRIBUTING.md), type `/integrate` in a new comment to proceed. After integration, the commit message will be:
> No need for locking when using TestHostedRepository
> 
> Reviewed-by: ehelin
> - If you would like to add a summary, use the `/summary` command.
> - To credit additional contributors, use the `/contributor` command.
> - To add additional solved issues, use the `/solves` command.
> 
> Since the source branch of this PR was last updated there have been 61 commits pushed to the `master` branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge `master` into your branch first.
> 
> ?? To integrate this PR with the above commit message, type `/integrate` in a new comment.

The pull request has been updated with 1 additional commit.

-------------

Added commits:
 - ebda6a9b: Adapt tests to updated message

Changes:
  - all: https://git.openjdk.java.net/skara/pull/343/files
  - new: https://git.openjdk.java.net/skara/pull/343/files/91d414c3..ebda6a9b

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/343/webrev.01
 - incr: https://webrevs.openjdk.java.net/skara/343/webrev.00-01

  Stats: 9 lines in 4 files changed: 2 ins; 1 del; 6 mod
  Patch: https://git.openjdk.java.net/skara/pull/343.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/343/head:pull/343

PR: https://git.openjdk.java.net/skara/pull/343

From ehelin at openjdk.java.net  Fri Dec 20 09:07:52 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 20 Dec 2019 09:07:52 GMT
Subject: [Rev 01] RFR: 214: Improve the message given when a change can be
 integrated
In-Reply-To: 
References: 
 
Message-ID: 

On Fri, 20 Dec 2019 09:07:51 GMT, Robin Westberg  wrote:

>> Hi all,
>> 
>> This change adjusts the "this change is now ready to be integrated" message. After the change, it would look something like the below. Comments are welcome!
>> 
>> @rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all [project specific requirements](https://github.com/openjdk/skara/blob/master/CONTRIBUTING.md), type `/integrate` in a new comment to proceed. After integration, the commit message will be:
>> No need for locking when using TestHostedRepository
>> 
>> Reviewed-by: ehelin
>> - If you would like to add a summary, use the `/summary` command.
>> - To credit additional contributors, use the `/contributor` command.
>> - To add additional solved issues, use the `/solves` command.
>> 
>> Since the source branch of this PR was last updated there have been 61 commits pushed to the `master` branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge `master` into your branch first.
>> 
>> ?? To integrate this PR with the above commit message, type `/integrate` in a new comment.
> 
> The pull request has been updated with 1 additional commit.

Looks good, nice work Robin!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/343

From rwestberg at openjdk.java.net  Fri Dec 20 09:11:24 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 20 Dec 2019 09:11:24 GMT
Subject: [Rev 01] RFR: 214: Improve the message given when a change can be
 integrated
In-Reply-To: 
References: 
 
 
Message-ID: <44j2i8FoxjKcvVzMRIhwK66535sX-hsHHjw1hdN8Xak=.94f2cf2c-8039-4ae0-bf00-c98e31c32049@github.com>

On Fri, 20 Dec 2019 09:07:35 GMT, Erik Helin  wrote:

>> The pull request has been updated with 1 additional commit.
> 
> Looks good, nice work Robin!

Thanks for the reviews, I'll push this, can always tweak it further later!

-------------

PR: https://git.openjdk.java.net/skara/pull/343

From rwestberg at openjdk.java.net  Fri Dec 20 09:11:46 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 20 Dec 2019 09:11:46 GMT
Subject: [Integrated] RFR: 214: Improve the message given when a change
 can be integrated
In-Reply-To: 
References: 
Message-ID: <67a69cd3-da83-4f83-b1ff-ba1e4d680d2d@openjdk.org>

Changeset: f0eef46f
Author:    Robin Westberg 
Date:      2019-12-20 09:11:27 +0000
URL:       https://git.openjdk.java.net/skara/commit/f0eef46f

214: Improve the message given when a change can be integrated

Reviewed-by: kcr, ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SolvesTests.java

From ehelin at openjdk.java.net  Fri Dec 20 14:10:37 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 20 Dec 2019 14:10:37 GMT
Subject: RFR: 219: Missing slash before CONTRIBUTING link in /integrate message
Message-ID: 

Hi all,

please review this small patch that fixes a typo with the URL to the
`COTNRIBUTING.md` file in the new "ready for integration" message.

Thanks,
Erik

-------------

Commits:
 - 990be795: skara-219

Changes: https://git.openjdk.java.net/skara/pull/344/files
 Webrev: https://webrevs.openjdk.java.net/skara/344/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-219
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/344.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/344/head:pull/344

PR: https://git.openjdk.java.net/skara/pull/344

From kcr at openjdk.java.net  Fri Dec 20 14:10:48 2019
From: kcr at openjdk.java.net (Kevin Rushforth)
Date: Fri, 20 Dec 2019 14:10:48 GMT
Subject: RFR: 219: Missing slash before CONTRIBUTING link in /integrate
 message
In-Reply-To: 
References: 
Message-ID: 

On Fri, 20 Dec 2019 14:09:56 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this small patch that fixes a typo with the URL to the
> `COTNRIBUTING.md` file in the new "ready for integration" message.
> 
> Thanks,
> Erik



-------------

Marked as reviewed by kcr (no project role).

PR: https://git.openjdk.java.net/skara/pull/344

From rwestberg at openjdk.java.net  Fri Dec 20 14:18:46 2019
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 20 Dec 2019 14:18:46 GMT
Subject: RFR: 219: Missing slash before CONTRIBUTING link in /integrate
 message
In-Reply-To: 
References: 
Message-ID: 

On Fri, 20 Dec 2019 14:09:56 GMT, Erik Helin  wrote:

> Hi all,
> 
> please review this small patch that fixes a typo with the URL to the
> `COTNRIBUTING.md` file in the new "ready for integration" message.
> 
> Thanks,
> Erik

Thanks, looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/344

From ehelin at openjdk.java.net  Fri Dec 20 14:46:19 2019
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 20 Dec 2019 14:46:19 GMT
Subject: [Integrated] RFR: 219: Missing slash before CONTRIBUTING link in
 /integrate message
In-Reply-To: 
References: 
Message-ID: <8650b92a-756b-4612-995d-a42db3ba66ae@openjdk.org>

Changeset: ec7cd48a
Author:    Erik Helin 
Date:      2019-12-20 14:46:03 +0000
URL:       https://git.openjdk.java.net/skara/commit/ec7cd48a

219: Missing slash before CONTRIBUTING link in /integrate message

Reviewed-by: kcr, rwestberg

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java