[Approved] RFR: Replace ContinuousIntegration.query with ContinuousIntegration.jobsFor
Robin Westberg
rwestberg at openjdk.java.net
Tue Dec 3 14:17:55 UTC 2019
On Tue, 3 Dec 2019 14:15:57 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
>
> please review this small pull request that narrows the scope of `ContinuousIntegration.query(String s)` to what is really is used for - `ContinuousIntegration.jobsFor(PullRequest pr)`.
>
> Thanks,
> Erik
>
> ## Testing
> - [x] `make test` on Linux x64
> - [x] `make images`
>
> ----------------
>
> Commits:
> - 710372a5: Replace ContinuousIntegration.query with ContinuousIntegration.jobsFor
>
> Changes: https://git.openjdk.java.net/skara/pull/284/files
> Webrev: https://webrevs.openjdk.java.net/skara/284/webrev.00
> Stats: 11 lines in 5 files changed: 5 ins; 3 del; 3 mod
> Patch: https://git.openjdk.java.net/skara/pull/284.diff
> Fetch: git fetch https://git.openjdk.java.net/skara pull/284/head:pull/284
Looks good!
----------------
Approved by rwestberg (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/284
More information about the skara-dev
mailing list