RFR: 165: Replace large webrev files with placeholders instead of dropping them

Robin Westberg rwestberg at openjdk.java.net
Thu Dec 5 07:43:00 UTC 2019

On Wed, 4 Dec 2019 15:47:30 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> Please review this change that replaces large files in published webrevs with a placeholder message, instead of just omitting them.
>> Best regards,
>> Robin
> This looks good in general, but won't this destroy the navigation arrows for e.g. the udiff or frames view? Or maybe it just overwrites the content, I don't recall ��

It would indeed destroy navigation, I've updated it a bit to handle .html files a bit nicer. This also ensures that the instructions are displayed with proper line breaks as they will be placed inside `<pre>` tags if possible.


PR: https://git.openjdk.java.net/skara/pull/292

More information about the skara-dev mailing list