RFR: Lazily request repository JSON for GitHub
Robin Westberg
rwestberg at openjdk.java.net
Thu Dec 5 10:34:20 UTC 2019
On Thu, 5 Dec 2019 10:31:51 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
>
> please review this small pull request that ensures that we lazily request project info for an instance of `GitHubRepository`. It is quite common to only use a `GitHubRepository` instance to request for example all pull requests, a call which does need the project info to be populated. This patch saves us a network request in such scenarios. The caching is safe since an instance `GitHubRepository` can only be accessed by a single thread at a time.
>
> Thanks,
> Erik
Looks good!
-------------
Marked as reviewed by rwestberg (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/296
More information about the skara-dev
mailing list