RFR: git-pr: no need to check forge validity

Robin Westberg rwestberg at openjdk.java.net
Thu Dec 5 13:50:30 UTC 2019

On Thu, 5 Dec 2019 13:30:38 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this small patch that removes an superfluous call to
> `Forge.isValid` in `git-pr`. `Forge.from` already ensures that the returned
> `Forge` is valid, so there is no need for `git-pr` to repeat this check.
> Thanks,
> Erik

Looks good, must be quite fast by now!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/298

More information about the skara-dev mailing list