RFR: git-fork: add --sync option
Robin Westberg
rwestberg at openjdk.java.net
Tue Dec 10 08:51:28 UTC 2019
On Tue, 10 Dec 2019 08:43:35 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
>
> please review this patch that adds the `--sync` option to `git-fork`. Setting
> `--sync` (either via command-line or configuration file) makes `git-fork` sync
> the fork with the upstream repository as a last step. This ensures that the
> local clone of the fork on the user's machine is fully up to date with
> upstream.
>
> Note that I hade to shuffle some code around in `git-sync` to allow for this,
> since `git-fork` simply just calls `git-sync` to implement this feaure.
>
> Thanks,
> Erik
>
> - [x] Manual testing of `git-fork`
Looks good, just one minor comment!
cli/src/main/java/org/openjdk/skara/cli/GitFork.java line 147:
> 146: .fullname("sync")
> 147: .helptext("Sync with the upstream repository after succesful fork")
> 148: .optional(),
Suggestion:
.helptext("Sync with the upstream repository after successful fork")
-------------
Marked as reviewed by rwestberg (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/304
More information about the skara-dev
mailing list