RFR: 184: git-webrev exception on deleted files in hg

Robin Westberg rwestberg at openjdk.java.net
Tue Dec 10 14:46:56 UTC 2019

On Tue, 10 Dec 2019 14:33:25 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that improves how our Mercurial plugin detects copied
> and renamed files. We have to have our `diff_git_raw` implementation produce
> the same results as `hg diff --git`, otherwise one might consider a file
> renamed and the other one not, resulting in problems.
> This patch make the results of `diff_git_raw` produce more similar results as
> `hg diff --git` by making use of the `mercurial.copies` utility.
> Thanks,
> Erik
> - [x] `make test`
> - [x] Manually creating a webrev for the patch attached to the bug

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/307

More information about the skara-dev mailing list