RFR: 189: git-pr should detect issue from branch name

Erik Helin ehelin at openjdk.java.net
Wed Dec 11 12:03:16 UTC 2019

On Wed, 11 Dec 2019 10:52:16 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> please review this patch that takes the first steps towards making `git-pr` a
>> bit smart with regards to detecing JBS issues. This patch makes `git-pr` detect
>> a JBS issue from a branch name (currently only supporting the long form of
>> "project-id"). If a matching issue is found then the title of the PR will be
>> automatically set to the title of the issue.
>> Thanks,
>> Erik
>> - [x] Manual testing of `git-pr`
> Could you reuse openjdk.Issue.fromString here?

No, unfortunately not, `openjdk.Issue.fromString` look for an `ID: TITLE` pattern, here we are interested in a `PROJECT-ID` pattern.


PR: https://git.openjdk.java.net/skara/pull/312

More information about the skara-dev mailing list