RFR: 197: git-fork should use --dissociate with --reference-if-able

Robin Westberg rwestberg at openjdk.java.net
Thu Dec 12 13:51:52 UTC 2019


On Thu, 12 Dec 2019 12:45:16 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that ensures we use the `--dissociate` option to `git
> clone` when someone is using `git fork --reference`. We need to use this flag
> to ensure that the objects are only borrowed from the referenced repository to
> reduce network transfer, we don't the borrow to continue after the clone.
> 
> Testing:
> - [x] Manual testing of `git-pr fork --reference`
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/322


More information about the skara-dev mailing list