[Rev 01] RFR: 199: Set fixVersion in an issue when a commit is integrated

[Erik Helin]

On Fri, 13 Dec 2019 11:07:19 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java line 81:
>> 
>>> 80: 
>>> 81:                 if (fixVersion != null) {
>>> 82:                     if (fixVersion.equals("<repo>")) {
>> 
>> How about turning this around a bit into:
>> 
>> if (fixVersion == null) {
>>    // Try to find fixVersion from .jceck/conf
>> }
>> if (fixVersion != null) {
>>     issue.get().addFixVersion(fixVersion)
>> }
>> If you don't sent the `fixVersion` via the bot configuration, then it will be `null`, and then we will read it from `.jcheck/conf`. This avoids the need for the special `<repo>` version.
> 
> Right, but if you create a fork where you don't want to change the .jcheck/conf file (for merge reasons) you may perhaps not want the fixVersion updated?

Good point! Should we then perhaps represent this using two parameters, `boolean shouldUpdateFixVersion` and `String fixVersion`?

-------------

PR: https://git.openjdk.java.net/skara/pull/324