RFR: 202: git-pr create should use a proper Markdown file

[Robin Westberg]

On Fri, 13 Dec 2019 15:54:10 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that updates `git pr create` to show a valid Markdown
> file. The instructions have been moved into HTML comments looking like the
> following:
> 
>  
>  
>  
>  
>  
>  
>  
>  
>  
>  
>  
>  
> 
> I also took the opportunity to tweak the message a bit. Furthermore I added the
> status for each commit so that it is easy to see changed files and also added a
> link to an eventual issue. Personally I think the end result turned out quite
> nice.
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git pr create`

Looks good, had one minor comment, feel free to ignore it. :)

cli/src/main/java/org/openjdk/skara/cli/GitPr.java line 789:

> 788:                              .stream()
> 789:                              .filter(l -> !(l.startsWith("<!--") && l.endsWith("-->")))
> 790:                              .collect(Collectors.toList());

Perhaps add a .map(String::strip) before this one to prevent whitespace mistakes?

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/329