RFR: 203: git-pr: add flag --jcheck to run jcheck as part of git-pr create
Robin Westberg
rwestberg at openjdk.java.net
Mon Dec 16 08:38:49 UTC 2019
On Mon, 16 Dec 2019 08:33:43 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
>
> please review this patch that adds the flag `--jcheck` to `git-pr create`. As
> the name suggests, adding the flag `--jcheck` to `git-pr create` will cause
> `git-pr create` to run jcheck on the commits that will be part of the pull
> request. Since not all messages are relevant for commits that are to be part of
> a pull request (i.e. commit message errors do not matter) I added a new flag to
> jcheck `--pull-request` to filter out those.
>
> I also had to some slight refactoring to `GitJCheck.java` to allow it to be
> called from other Java code.
>
> Thanks,
> Erik
Looks good!
-------------
Marked as reviewed by rwestberg (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/330
More information about the skara-dev
mailing list