RFR: 204: git-sync: must fetch before --fast-forward

Robin Westberg rwestberg at openjdk.java.net
Mon Dec 16 10:29:50 UTC 2019


On Mon, 16 Dec 2019 10:10:28 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that ensures `git sync --fast-forward` fetches the
> changes from the `to` remote _before_ trying to do "fast forward" merges. This
> is needed because doing a push to a remote ref does not cause that ref to be
> updated.
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git sync --fast-foward`
> - [x] Added a new unit test

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/331


More information about the skara-dev mailing list