RFR: 179: Make git-pr flags configurable

Robin Westberg rwestberg at openjdk.java.net
Tue Dec 17 08:54:25 UTC 2019


On Tue, 17 Dec 2019 08:49:51 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes all the flags to `git-pr` configurable. It
> is also possible to configure different values for flags depending on command,
> e.g.:
> 
> [pr]
>         default = list
> 
> [pr "create"]
>         assignees = rwestberg
> 
> [pr "list"]
>         assignees = ehelin
> 
> The above is a slightly contrived example just to show how it works. A more
> realistic example is my current configuration for `git-pr`:
> 
> [pr]
> 	default = list
> 
> [pr "create"]
> 	ignore-workspace = true
> 	ignore-local-commits = true
> 	publish = true
> 	jcheck = true
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Manual testing of `git-pr` on Linux x64

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/335


More information about the skara-dev mailing list