RFR: 210: git-pr: add BRANCH column to git-pr list

Robin Westberg rwestberg at openjdk.java.net
Tue Dec 17 13:29:00 UTC 2019

On Tue, 17 Dec 2019 13:25:27 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that adds the "BRANCH" column to the `git pr list`
> output. The branch column will list the local branches in a repository that
> corresponds to a pull request.
> @rwestberg I had to make a few changes to `PullRequest`:
> - renamed `sourceRef` to `fetchRef`
> - added `sourceRef` which now really means the reference in the source
>   repository ��
> - added `sourceRepository` for getting the source repository for a pull request
> I did the rename of `sourceRef` to `fetchRef` first, so I shouldn't have missed
> updating any places where it was used.
> Thanks,
> Erik
> ## Testing
> - [x] `make test` on Linux x64
> - [x] Manual testing of `git pr list` on Linux x64

Sounds reasonable!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/338

More information about the skara-dev mailing list