[Rev 01] RFR: 212: Retry notifications for updaters that can check current state

Erik Helin ehelin at openjdk.java.net
Wed Dec 18 07:48:47 UTC 2019


On Wed, 18 Dec 2019 07:48:46 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this change that enables issue notifications to be retried in case transient server errors occur, but will not send out duplicate email notifications.
>> 
>> Best regards,
>> Robin
> 
> The pull request has been updated with 1 additional commit.

bots/notify/src/main/java/org/openjdk/skara/bots/notify/PullRequestUpdateConsumer.java line 31:

> 30:     void handleRemovedIssue(PullRequest pr, Issue issue);
> 31:     boolean idempotent();
> 32: }

Suggestion:

    boolean isIdempotent();

-------------

PR: https://git.openjdk.java.net/skara/pull/339


More information about the skara-dev mailing list