[Rev 01] RFR: 214: Improve the message given when a change can be integrated

Erik Helin ehelin at openjdk.java.net
Fri Dec 20 09:07:52 UTC 2019

On Fri, 20 Dec 2019 09:07:51 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> This change adjusts the "this change is now ready to be integrated" message. After the change, it would look something like the below. Comments are welcome!
>> @rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all [project specific requirements](https://github.com/openjdk/skara/blob/master/CONTRIBUTING.md), type `/integrate` in a new comment to proceed. After integration, the commit message will be:
>> No need for locking when using TestHostedRepository
>> Reviewed-by: ehelin
>> - If you would like to add a summary, use the `/summary` command.
>> - To credit additional contributors, use the `/contributor` command.
>> - To add additional solved issues, use the `/solves` command.
>> Since the source branch of this PR was last updated there have been 61 commits pushed to the `master` branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge `master` into your branch first.
>> ➡️ To integrate this PR with the above commit message, type `/integrate` in a new comment.
> The pull request has been updated with 1 additional commit.

Looks good, nice work Robin!


Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/343

More information about the skara-dev mailing list