RFR: 17: Review comments not reflected on mailing lists

Robin Westberg via github.com duke at openjdk.java.net
Mon Jul 1 08:49:22 UTC 2019


On Fri, 28 Jun 2019 13:14:54 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:

> On Fri, 28 Jun 2019 13:11:29 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:
> 
>> Hi all,
>> 
>> Please review the following change that adds support for comments attached to reviews. This is not supported by GitLab CE, but is used by GitHub.
>> 
>> Best regards,
>> Robin
>> 
>> ----------------
>> 
>> Commits:
>>  - 5c9c290c:	Add support for a comment attached to a review
>> 
>> Pull request:
>> http://git.openjdk.java.net/skara/pull/11
>> 
>> Webrev:
>> https://openjdk.github.io/cr/skara/11/webrev.00
>> 
>> Patch:
>> http://git.openjdk.java.net/skara/pull/11.diff
>> 
>> Fetch command:
>> git fetch https://github.com/openjdk/skara.git 5c9c290c:pr/11
> 
> Ehm, small patch :smile: Did you run the integrations tests for GitLab CE and GitHub to test this?

😊 there were actually a few GitLab CE tests failing, fixed now.


More information about the skara-dev mailing list