RFR: Put the credentials lock in the remote repository

Robin Westberg via github.com duke at openjdk.java.net
Mon Jul 1 09:27:24 UTC 2019


On Mon, 1 Jul 2019 09:23:54 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:

> On Mon, 1 Jul 2019 08:54:29 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:
> 
>> Hi all,
>> 
>> Please review the following change that puts the credentials lock (used when running integration tests) in the remote repository instead of a local file, to allow the tests to be launched from multiple hosts.
>> 
>> Best regards,
>> Robin
>> 
>> ----------------
>> 
>> Commits:
>>  - 110e4eeb:	Put the credentials lock in the remote repository so tests can be started from multiple hosts
>> 
>> Pull request:
>> http://git.openjdk.java.net/skara/pull/14
>> 
>> Webrev:
>> https://openjdk.github.io/cr/skara/14/webrev.00
>> 
>> Patch:
>> http://git.openjdk.java.net/skara/pull/14.diff
>> 
>> Fetch command:
>> git fetch https://github.com/openjdk/skara.git 110e4eeb:pr/14
> 
> test/src/main/java/org/openjdk/skara/test/HostCredentials.java line 85:
> 
>> 84:         public String getNamespaceName() {
>> 85:             return config.get("namespace").asString();
>> 86:         }
> 
> Maybe add a comment that `localRepo.push` will throw an `IOException` if the push fails?

Can clarify the existing comment


More information about the skara-dev mailing list