RFR: 25: The GitHub parsePullRequestUrl method is not pattern aware
Erik Duveblad via github.com
duke at openjdk.java.net
Tue Jul 2 07:32:23 UTC 2019
On Tue, 2 Jul 2019 06:17:56 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:
> Hi all,
>
> Please review the following change that uses the replacement pattern for PR links when parsing them as well.
>
> Best regards,
> Robin
>
> ----------------
>
> Commits:
> - aca023b1: Use the replacement pattern for PR links when parsing them as well
>
> Pull request:
> http://git.openjdk.java.net/skara/pull/20
>
> Webrev:
> https://openjdk.github.io/cr/skara/20/webrev.00
>
> Patch:
> http://git.openjdk.java.net/skara/pull/20.diff
>
> Fetch command:
> git fetch https://github.com/openjdk/skara.git aca023b1:pr/20
This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:
Looks good!
More information about the skara-dev
mailing list