RFR: 18: The fetch command in RFR emails does not work

Erik Duveblad via github.com duke at openjdk.java.net
Tue Jul 2 09:14:23 UTC 2019


On Tue, 2 Jul 2019 08:55:58 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:

> Hi all,
> 
> Please review the following change that uses a proper ref in the fetch command sent in RFR emails.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 6854de36:	Make getSourceRef return a reference that can actually be fetched from the repository
> 
> Pull request:
> http://git.openjdk.java.net/skara/pull/23
> 
> Webrev:
> https://openjdk.github.io/cr/skara/23/webrev.00
> 
> Patch:
> http://git.openjdk.java.net/skara/pull/23.diff
> 
> Fetch command:
> git fetch https://github.com/openjdk/skara.git 6854de36:pr/23

This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:

Looks good!

PR: http://git.openjdk.java.net/skara/pull/23


More information about the skara-dev mailing list