RFR: 41: Bot launcher should detect ev. http proxy in environment

[Robin Westberg via github.com]

On Thu, 4 Jul 2019 08:31:00 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:

> Hi all,
> 
> this patch ensures that `BotLauncher.java` correctly sets up corresponding system properties for `http_proxy`, `https_proxy` and `no_proxy`. The patch became a little larger than I intended since I had to break out `HttpProxy` into a new module and package to share it between `cli` and `bots/cli`. I also updated the Gradle `ProxyPlugin` to align with the new `proxy` module (there is unfortunately now way to use `HttpProxy` from the Gradle `ProxyPlugin`).
> 
> ## Testing
> 
> - [x] Executed `sh gradlew test` successfully on Linux
> 
> Thanks,
> Erik
> 
> ----------------
> 
> Commits:
>  - 9584f27f:	41: Bot launcher should detect ev. http proxy in environment
> 
> Pull request:
> http://git.openjdk.java.net/skara/pull/27
> 
> Webrev:
> https://openjdk.github.io/cr/skara/27/webrev.00
> 
> Patch:
> http://git.openjdk.java.net/skara/pull/27.diff
> 
> Fetch command:
> git fetch https://github.com/openjdk/skara.git pull/27/head:pull/27

This PR has been reviewed by Robin Westberg via github.com - changes are approved. Review comment:

Looks good!

PR: http://git.openjdk.java.net/skara/pull/27

proxy/build.gradle line 2:

> 1: /*
> 2:  * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved.
> 3:  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.

```suggestion
 * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
```
:)

PR: http://git.openjdk.java.net/skara/pull/27