From erik.helin at oracle.com Mon Jun 24 13:06:44 2019 From: erik.helin at oracle.com (Erik Helin) Date: Mon, 24 Jun 2019 15:06:44 +0200 Subject: The Skara tooling is now open source Message-ID: Hi all, we are happy to announce that the tooling for project Skara [0] is now open source and available at https://github.com/openjdk/skara. The Skara tooling includes both server-side tools (so called "bots") as well as several command-line tools: - git-jcheck - git-webrev - git-defpath - git-fork - git-pr - git-translate - git-info - git-skara The goal of project Skara is "... to investigate alternative SCM and code review options for the JDK source code ..." [0] and these tools represent the technical part of that work. For more information on how to get started with the tools, the workflows they enable and how we avoid vendor lock-in, please see the OpenJDK wiki page for project Skara [1]. We are more than happy to accept contributions to the Skara tooling, both via patches sent to the Skara mailing list [2] and in the form of pull requests on GitHub [3]. You can find open issues to work on in the Skara JBS project [4]. Please also file issues if you run into any bugs! We would like to thank everyone that has contributed to project Skara: - Joe Darcy - Mark Reinhold - Erik Joelsson - Tim Bell - Tony Squier - Tiep Vo - Stanislav Smirnov - Christian Tornqvist - Dalibor Topic - Jeff Dinkins If you have any questions, feel free to send them to the Skara mailing list [2] or come hang out in the #openjdk IRC channel [5]. Thanks, Erik and Robin [0]: https://openjdk.java.net/projects/skara/ [1]: https://wiki.openjdk.java.net/display/skara [2]: https://mail.openjdk.java.net/mailman/listinfo/skara-dev [3]: https://github.com/openjdk/skara/pulls [4]: https://bugs.openjdk.java.net/projects/SKARA/ [5]: https://openjdk.java.net/irc/ From duke at openjdk.java.net Mon Jun 24 14:35:16 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Mon, 24 Jun 2019 14:35:16 GMT Subject: RFR: 11: git-skara update should only rebuild if updates are found Message-ID: Hi, this small patch ensures that we only rebuild the Skara tooling during `git skara update` if the tool actually pulled down some commits. Thanks, Erik ---------------- Commits: - 1ed20df2: 11: git-skara update should only rebuild if updates are found Pull request: https://github.com/openjdk/skara/pull/1 Webrev: https://openjdk.github.io/cr/skara/1/webrev.00 Patch: https://github.com/openjdk/skara/pull/1.diff Fetch command: git fetch https://github.com/openjdk/skara.git 1ed20df2:pr/1 From duke at openjdk.java.net Mon Jun 24 14:43:15 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Mon, 24 Jun 2019 14:43:15 GMT Subject: RFR: 11: git-skara update should only rebuild if updates are found In-Reply-To: References: Message-ID: This PR has now been reviewed by Robin Westberg via github.com - changes are approved. From duke at openjdk.java.net Tue Jun 25 00:49:17 2019 From: duke at openjdk.java.net (Jeyvison Nascimento via github.com) Date: Tue, 25 Jun 2019 00:49:17 GMT Subject: RFR: SKARA-5 Remove pipeline support from process Message-ID: Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Also, I think something must be changed in ProcessBuilder, am i right? And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) ---------------- Commits: - cf6700bd: SKARA-5 Remove pipeline support from process Pull request: https://github.com/openjdk/skara/pull/2 Webrev: https://openjdk.github.io/cr/skara/2/webrev.00 Patch: https://github.com/openjdk/skara/pull/2.diff Fetch command: git fetch https://github.com/openjdk/skara.git cf6700bd:pr/2 From duke at openjdk.java.net Tue Jun 25 06:14:46 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Tue, 25 Jun 2019 06:14:46 GMT Subject: RFR: 12: Make the notification sender configurable Message-ID: Hi all, Please review the following change that makes the sender of push notification mails configurable, instead of using one of the commits. Best regards, Robin ---------------- Commits: - 8860f6ef: Make sender configurable, add tests Pull request: https://github.com/openjdk/skara/pull/3 Webrev: https://openjdk.github.io/cr/skara/3/webrev.00 Patch: https://github.com/openjdk/skara/pull/3.diff Fetch command: git fetch https://github.com/openjdk/skara.git 8860f6ef:pr/3 From duke at openjdk.java.net Tue Jun 25 08:06:21 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Tue, 25 Jun 2019 08:06:21 GMT Subject: RFR: 12: Make the notification sender configurable In-Reply-To: References: Message-ID: This PR has now been reviewed by Erik Duveblad via github.com - changes are approved. From duke at openjdk.java.net Tue Jun 25 09:18:42 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Tue, 25 Jun 2019 09:18:42 GMT Subject: RFR: 15: Allow a configurable set of labels to block ready for review status Message-ID: <623lF4VuxMjkFNhTwjkRz4EaCcSi_QYF29sEtPxtlZk=.5ba2afab-8d28-4cdc-9ed7-31c2cf08498f@github.com> Hi all, Please review the following change that makes it possible to configure a set of labels that can block the ready for review status. Best regards, Robin ---------------- Commits: - 691b99dc: Allow a configurable set of labels to block ready for review status Pull request: https://github.com/openjdk/skara/pull/4 Webrev: https://openjdk.github.io/cr/skara/4/webrev.00 Patch: https://github.com/openjdk/skara/pull/4.diff Fetch command: git fetch https://github.com/openjdk/skara.git 691b99dc:pr/4 From duke at openjdk.java.net Tue Jun 25 09:45:29 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Tue, 25 Jun 2019 09:45:29 GMT Subject: RFR: 15: Allow a configurable set of labels to block ready for review status In-Reply-To: <623lF4VuxMjkFNhTwjkRz4EaCcSi_QYF29sEtPxtlZk=.5ba2afab-8d28-4cdc-9ed7-31c2cf08498f@github.com> References: <623lF4VuxMjkFNhTwjkRz4EaCcSi_QYF29sEtPxtlZk=.5ba2afab-8d28-4cdc-9ed7-31c2cf08498f@github.com> Message-ID: This PR has now been reviewed by Erik Duveblad via github.com - changes are approved. From duke at openjdk.java.net Tue Jun 25 12:29:36 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Tue, 25 Jun 2019 12:29:36 GMT Subject: RFR: 14: Only use git.openjdk.java.net links in emails Message-ID: Hi all, Please review the following change that makes it possible to configure an alternative base url to use when constructing web links for GitHub, which will allow us to use our host-neutral forwarder. Best regards, Robin ---------------- Commits: - 2f1cf236: Allow configuring an alternate base url to use when constructing GitHub web links Pull request: https://github.com/openjdk/skara/pull/5 Webrev: https://openjdk.github.io/cr/skara/5/webrev.00 Patch: https://github.com/openjdk/skara/pull/5.diff Fetch command: git fetch https://github.com/openjdk/skara.git 2f1cf236:pr/5 From duke at openjdk.java.net Tue Jun 25 12:41:34 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Tue, 25 Jun 2019 12:41:34 GMT Subject: RFR: 14: Only use git.openjdk.java.net links in emails In-Reply-To: References: Message-ID: <0DIEUWIUzaJVXvF4dDoBNTachk5I2i5xfJqwlwj7SFg=.d7b29e38-892c-4beb-97d3-67fdbd4357d5@github.com> This PR has now been reviewed by Erik Duveblad via github.com - changes are approved. From duke at openjdk.java.net Tue Jun 25 12:43:32 2019 From: duke at openjdk.java.net (duke) Date: Tue, 25 Jun 2019 12:43:32 GMT Subject: git: openjdk/skara: 14: Only use git.openjdk.java.net links in emails Message-ID: <1fef437f-7d3f-466a-9ee1-7207b3e3f85d@openjdk.java.net> Changeset: 72627b9d Author: Robin Westberg Date: 2019-06-25 12:42:38 +0000 URL: https://github.com/openjdk/skara/commit/72627b9d 14: Only use git.openjdk.java.net links in emails Reviewed-by: ehelin ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java ! host/src/main/java/org/openjdk/skara/host/HostFactory.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubHost.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubRepository.java ! test/src/main/java/org/openjdk/skara/test/HostCredentials.java From duke at openjdk.java.net Tue Jun 25 14:19:36 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Tue, 25 Jun 2019 14:19:36 GMT Subject: RFR: 16: Allow regular expression replacement for web urls Message-ID: Hi all, Please review the following change that allows configuration of a regular expression replacement for GitHub web urls. Best regards, Robin ---------------- Commits: - 3b704a95: Allow regular expression pattern replacement for web urls Pull request: https://github.com/openjdk/skara/pull/6 Webrev: https://openjdk.github.io/cr/skara/6/webrev.00 Patch: https://github.com/openjdk/skara/pull/6.diff Fetch command: git fetch https://github.com/openjdk/skara.git 3b704a95:pr/6 From duke at openjdk.java.net Tue Jun 25 15:57:34 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Tue, 25 Jun 2019 15:57:34 GMT Subject: RFR: 16: Allow regular expression replacement for web urls In-Reply-To: References: Message-ID: This PR has now been reviewed by Erik Duveblad via github.com - changes are approved. From duke at openjdk.java.net Wed Jun 26 05:39:33 2019 From: duke at openjdk.java.net (duke) Date: Wed, 26 Jun 2019 05:39:33 GMT Subject: git: openjdk/skara: 16: Allow regular expression replacement for web urls Message-ID: <32724a69-da79-4bf6-a2ce-e9a075d7017a@openjdk.java.net> Changeset: a185823d Author: Robin Westberg Date: 2019-06-26 05:38:39 +0000 URL: https://github.com/openjdk/skara/commit/a185823d 16: Allow regular expression replacement for web urls Reviewed-by: ehelin ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java ! host/build.gradle ! host/src/main/java/org/openjdk/skara/host/HostFactory.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubHost.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubRepository.java + host/src/test/java/org/openjdk/skara/host/github/GitHubHostTests.java ! test/src/main/java/org/openjdk/skara/test/HostCredentials.java From duke at openjdk.java.net Wed Jun 26 06:17:37 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Wed, 26 Jun 2019 06:17:37 GMT Subject: RFR: SKARA-5 Remove pipeline support from process In-Reply-To: References: Message-ID: <6JhNpscqhImJd4yBjTKfy_dJ2azFOgb-mK5etboeduQ=.a79877c8-e3a6-47e2-b4d9-e307ef1df052@github.com> On Tue, 25 Jun 2019 00:49:17 GMT, Jeyvison Nascimento via github.com wrote: > Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Also, I think something must be changed in ProcessBuilder, am i right? And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) > > ---------------- > > Commits: > - cf6700bd: SKARA-5 Remove pipeline support from process > > Pull request: > https://github.com/openjdk/skara/pull/2 > > Webrev: > https://openjdk.github.io/cr/skara/2/webrev.00 > > Patch: > https://github.com/openjdk/skara/pull/2.diff > > Fetch command: > git fetch https://github.com/openjdk/skara.git cf6700bd:pr/2 > Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Hi! Thanks for the PR! Yes, this is indeed what we meant. (There's actually even a bit more complexity that can be removed, I'll add a more detailed review). > Also, I think something must be changed in ProcessBuilder, am i right? Do you mean java.lang.ProcessBuilder? That should not need any changes, perhaps I'm misunderstanding the question.. > And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) All tests pass when I run them in your branch, what kind of problem did you see? From duke at openjdk.java.net Wed Jun 26 06:28:39 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Wed, 26 Jun 2019 06:28:39 GMT Subject: RFR: SKARA-5 Remove pipeline support from process In-Reply-To: References: Message-ID: On Tue, 25 Jun 2019 00:49:17 GMT, Jeyvison Nascimento via github.com wrote: > Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Also, I think something must be changed in ProcessBuilder, am i right? And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) > > ---------------- > > Commits: > - cf6700bd: SKARA-5 Remove pipeline support from process > > Pull request: > https://github.com/openjdk/skara/pull/2 > > Webrev: > https://openjdk.github.io/cr/skara/2/webrev.00 > > Patch: > https://github.com/openjdk/skara/pull/2.diff > > Fetch command: > git fetch https://github.com/openjdk/skara.git cf6700bd:pr/2 process/src/main/java/org/openjdk/skara/process/Execution.java line 65: > 64: this.exception = exception; > 65: } > 66: And without pipes, processBuilders don't even need to be a list. process/src/main/java/org/openjdk/skara/process/Execution.java line 59: > 58: > 59: CheckedResult(String command, List stdout, List stderr, int status, Throwable exception) { > 60: this.status = status; The getLastProcessBuilder method could be removed as there is never more than one now. From duke at openjdk.java.net Wed Jun 26 06:28:41 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Wed, 26 Jun 2019 06:28:41 GMT Subject: RFR: SKARA-5 Remove pipeline support from process In-Reply-To: References: Message-ID: This PR has now been reviewed by Robin Westberg via github.com - comment added. From duke at openjdk.java.net Wed Jun 26 10:48:42 2019 From: duke at openjdk.java.net (Jeyvison Nascimento via github.com) Date: Wed, 26 Jun 2019 10:48:42 GMT Subject: RFR: SKARA-5 Remove pipeline support from process In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - f1fb0ada: SKARA-5 Remove pipeline support from process Pull request: http://git.openjdk.java.net/skara/pull/2 Webrevs: - full: https://openjdk.github.io/cr/skara/2/webrev.01 - inc: https://openjdk.github.io/cr/skara/2/webrev.00-01 Updated full patch: http://git.openjdk.java.net/skara/pull/2.diff Fetch command: git fetch https://github.com/openjdk/skara.git f1fb0ada:pr/2 From duke at openjdk.java.net Wed Jun 26 10:51:39 2019 From: duke at openjdk.java.net (Jeyvison Nascimento via github.com) Date: Wed, 26 Jun 2019 10:51:39 GMT Subject: RFR: SKARA-5 Remove pipeline support from process In-Reply-To: <6JhNpscqhImJd4yBjTKfy_dJ2azFOgb-mK5etboeduQ=.a79877c8-e3a6-47e2-b4d9-e307ef1df052@github.com> References: <6JhNpscqhImJd4yBjTKfy_dJ2azFOgb-mK5etboeduQ=.a79877c8-e3a6-47e2-b4d9-e307ef1df052@github.com> Message-ID: On Wed, 26 Jun 2019 06:17:37 GMT, Robin Westberg via github.com wrote: > On Tue, 25 Jun 2019 00:49:17 GMT, Jeyvison Nascimento via github.com wrote: > >> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Also, I think something must be changed in ProcessBuilder, am i right? And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) >> >> ---------------- >> >> Commits: >> - cf6700bd: SKARA-5 Remove pipeline support from process >> >> Pull request: >> https://github.com/openjdk/skara/pull/2 >> >> Webrev: >> https://openjdk.github.io/cr/skara/2/webrev.00 >> >> Patch: >> https://github.com/openjdk/skara/pull/2.diff >> >> Fetch command: >> git fetch https://github.com/openjdk/skara.git cf6700bd:pr/2 > >> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. > > Hi! Thanks for the PR! Yes, this is indeed what we meant. (There's actually even a bit more complexity that can be removed, I'll add a more detailed review). > >> Also, I think something must be changed in ProcessBuilder, am i right? > > Do you mean java.lang.ProcessBuilder? That should not need any changes, perhaps I'm misunderstanding the question.. > >> And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) > > All tests pass when I run them in your branch, what kind of problem did you see? @rwestberg Done :) Hope it's better now. From duke at openjdk.java.net Wed Jun 26 12:10:49 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Wed, 26 Jun 2019 12:10:49 GMT Subject: RFR: SKARA-5 Remove pipeline support from process In-Reply-To: References: Message-ID: This PR has now been reviewed by Erik Duveblad via github.com - comment added. From duke at openjdk.java.net Wed Jun 26 12:10:44 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Wed, 26 Jun 2019 12:10:44 GMT Subject: RFR: SKARA-5 Remove pipeline support from process In-Reply-To: References: Message-ID: On Tue, 25 Jun 2019 00:49:17 GMT, Jeyvison Nascimento via github.com wrote: > Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Also, I think something must be changed in ProcessBuilder, am i right? And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) > > ---------------- > > Commits: > - cf6700bd: SKARA-5 Remove pipeline support from process > > Pull request: > https://github.com/openjdk/skara/pull/2 > > Webrev: > https://openjdk.github.io/cr/skara/2/webrev.00 > > Patch: > https://github.com/openjdk/skara/pull/2.diff > > Fetch command: > git fetch https://github.com/openjdk/skara.git cf6700bd:pr/2 process/src/main/java/org/openjdk/skara/process/Execution.java line 15: > 14: * > 15: * You should have received a copy of the GNU General Public License version > 16: * 2 along with this work; if not, write to the Free Software Foundation, This can also be made into a single `File stderrFile`, we no longer need the a list here (that was only used to support pipelines) process/src/main/java/org/openjdk/skara/process/Execution.java line 103: > 102: > 103: public int status() { > 104: return status; So this would become essentially like the standard output case, `stderrFile = File.createTempFile("stderr", ".txt")` process/src/main/java/org/openjdk/skara/process/Execution.java line 124: > 123: stderrFiles.add(stderrFile); > 124: processBuilder.redirectError(stderrFile); > 125: } else if (outputOption == Process.OutputOption.INHERIT) { We can also remove the field `private List processes` now, that can just be turned into `private java.lang.Process process` (the list was only there to support pipelines). process/src/main/java/org/openjdk/skara/process/Execution.java line 135: > 134: cmd = String.join(" ", processBuilder.command()); > 135: log.fine("Executing '" + cmd + "'"); > 136: Can't you just the field `cmd` here instead that you updated on line 134? From duke at openjdk.java.net Wed Jun 26 14:46:38 2019 From: duke at openjdk.java.net (JornVernee via github.com) Date: Wed, 26 Jun 2019 14:46:38 GMT Subject: RFR: Ignore `path=` lines in git credential fill output. Message-ID: Hi, I'm trying out skara, but when running `git fork https://github.com/openjdk/panama git-panama` I'm getting the following exception: ``` Exception in thread "main" java.io.IOException: 'git credential' returned unexpected line: path= at org.openjdk.skara.cli/org.openjdk.skara.cli.GitCredentials.fill(GitCredentials.java:101) at org.openjdk.skara.cli/org.openjdk.skara.cli.GitFork.main(GitFork.java:130) at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:130) ``` Looks like `path=` is not handled yet? This PR adds some handling that ignores lines starting with `path=` for now, but maybe any unknown line should be ignored instead of throwing an exception, what do you think? ---------------- Commits: - 2149adba: Ignore `path=` lines in git credential fill output. Pull request: http://git.openjdk.java.net/skara/pull/7 Webrev: https://openjdk.github.io/cr/skara/7/webrev.00 Patch: http://git.openjdk.java.net/skara/pull/7.diff Fetch command: git fetch https://github.com/openjdk/skara.git 2149adba:pr/7 From duke at openjdk.java.net Wed Jun 26 14:46:42 2019 From: duke at openjdk.java.net (JornVernee via github.com) Date: Wed, 26 Jun 2019 14:46:42 GMT Subject: RFR: Ignore `path=` lines in git credential fill output. In-Reply-To: References: Message-ID: On Wed, 26 Jun 2019 14:46:38 GMT, JornVernee via github.com wrote: > Hi, > > I'm trying out skara, but when running `git fork https://github.com/openjdk/panama git-panama` I'm getting the following exception: > > ``` > Exception in thread "main" java.io.IOException: 'git credential' returned unexpected line: path= > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitCredentials.fill(GitCredentials.java:101) > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitFork.main(GitFork.java:130) > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:130) > ``` > > Looks like `path=` is not handled yet? > > This PR adds some handling that ignores lines starting with `path=` for now, but maybe any unknown line should be ignored instead of throwing an exception, what do you think? > > ---------------- > > Commits: > - 2149adba: Ignore `path=` lines in git credential fill output. > > Pull request: > http://git.openjdk.java.net/skara/pull/7 > > Webrev: > https://openjdk.github.io/cr/skara/7/webrev.00 > > Patch: > http://git.openjdk.java.net/skara/pull/7.diff > > Fetch command: > git fetch https://github.com/openjdk/skara.git 2149adba:pr/7 Issue created at: https://bugs.openjdk.java.net/browse/SKARA-21 From duke at openjdk.java.net Wed Jun 26 15:06:36 2019 From: duke at openjdk.java.net (JornVernee via github.com) Date: Wed, 26 Jun 2019 15:06:36 GMT Subject: RFR: Ignore `path=` lines in git credential fill output. In-Reply-To: References: Message-ID: On Wed, 26 Jun 2019 14:46:42 GMT, JornVernee via github.com wrote: > On Wed, 26 Jun 2019 14:46:38 GMT, JornVernee via github.com wrote: > >> Hi, >> >> I'm trying out skara, but when running `git fork https://github.com/openjdk/panama git-panama` I'm getting the following exception: >> >> ``` >> Exception in thread "main" java.io.IOException: 'git credential' returned unexpected line: path= >> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitCredentials.fill(GitCredentials.java:101) >> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitFork.main(GitFork.java:130) >> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:130) >> ``` >> >> Looks like `path=` is not handled yet? >> >> This PR adds some handling that ignores lines starting with `path=` for now, but maybe any unknown line should be ignored instead of throwing an exception, what do you think? >> >> ---------------- >> >> Commits: >> - 2149adba: Ignore `path=` lines in git credential fill output. >> >> Pull request: >> http://git.openjdk.java.net/skara/pull/7 >> >> Webrev: >> https://openjdk.github.io/cr/skara/7/webrev.00 >> >> Patch: >> http://git.openjdk.java.net/skara/pull/7.diff >> >> Fetch command: >> git fetch https://github.com/openjdk/skara.git 2149adba:pr/7 > > Issue created at: https://bugs.openjdk.java.net/browse/SKARA-21 webrev is a 404 for me... From duke at openjdk.java.net Wed Jun 26 18:18:36 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Wed, 26 Jun 2019 18:18:36 GMT Subject: RFR: Ignore `path=` lines in git credential fill output. In-Reply-To: References: Message-ID: On Wed, 26 Jun 2019 15:06:36 GMT, JornVernee via github.com wrote: > On Wed, 26 Jun 2019 14:46:42 GMT, JornVernee via github.com wrote: > >> On Wed, 26 Jun 2019 14:46:38 GMT, JornVernee via github.com wrote: >> >>> Hi, >>> >>> I'm trying out skara, but when running `git fork https://github.com/openjdk/panama git-panama` I'm getting the following exception: >>> >>> ``` >>> Exception in thread "main" java.io.IOException: 'git credential' returned unexpected line: path= >>> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitCredentials.fill(GitCredentials.java:101) >>> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitFork.main(GitFork.java:130) >>> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:130) >>> ``` >>> >>> Looks like `path=` is not handled yet? >>> >>> This PR adds some handling that ignores lines starting with `path=` for now, but maybe any unknown line should be ignored instead of throwing an exception, what do you think? >>> >>> ---------------- >>> >>> Commits: >>> - 2149adba: Ignore `path=` lines in git credential fill output. >>> >>> Pull request: >>> http://git.openjdk.java.net/skara/pull/7 >>> >>> Webrev: >>> https://openjdk.github.io/cr/skara/7/webrev.00 >>> >>> Patch: >>> http://git.openjdk.java.net/skara/pull/7.diff >>> >>> Fetch command: >>> git fetch https://github.com/openjdk/skara.git 2149adba:pr/7 >> >> Issue created at: https://bugs.openjdk.java.net/browse/SKARA-21 > > webrev is a 404 for me... Thanks @JornVernee for your contribution! :tada: The patch looks good, have you tried it with a credential with a `path`? I'm thinking that if the user has a `path` set for a credential then we should probably pass that `path` back to `git credential approve` in `GitCredentials::approve`. Won't we otherwise set the credential for the entire host, or am I missing something? Looking at the [man page](https://git-scm.com/docs/git-credential) it seems like we should pass the `path` back to `git credential approve` From duke at openjdk.java.net Wed Jun 26 19:05:36 2019 From: duke at openjdk.java.net (JornVernee via github.com) Date: Wed, 26 Jun 2019 19:05:36 GMT Subject: RFR: Ignore `path=` lines in git credential fill output. In-Reply-To: References: Message-ID: On Wed, 26 Jun 2019 18:18:36 GMT, Erik Duveblad via github.com wrote: > On Wed, 26 Jun 2019 15:06:36 GMT, JornVernee via github.com wrote: > >> On Wed, 26 Jun 2019 14:46:42 GMT, JornVernee via github.com wrote: >> >>> On Wed, 26 Jun 2019 14:46:38 GMT, JornVernee via github.com wrote: >>> >>>> Hi, >>>> >>>> I'm trying out skara, but when running `git fork https://github.com/openjdk/panama git-panama` I'm getting the following exception: >>>> >>>> ``` >>>> Exception in thread "main" java.io.IOException: 'git credential' returned unexpected line: path= >>>> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitCredentials.fill(GitCredentials.java:101) >>>> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitFork.main(GitFork.java:130) >>>> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:130) >>>> ``` >>>> >>>> Looks like `path=` is not handled yet? >>>> >>>> This PR adds some handling that ignores lines starting with `path=` for now, but maybe any unknown line should be ignored instead of throwing an exception, what do you think? >>>> >>>> ---------------- >>>> >>>> Commits: >>>> - 2149adba: Ignore `path=` lines in git credential fill output. >>>> >>>> Pull request: >>>> http://git.openjdk.java.net/skara/pull/7 >>>> >>>> Webrev: >>>> https://openjdk.github.io/cr/skara/7/webrev.00 >>>> >>>> Patch: >>>> http://git.openjdk.java.net/skara/pull/7.diff >>>> >>>> Fetch command: >>>> git fetch https://github.com/openjdk/skara.git 2149adba:pr/7 >>> >>> Issue created at: https://bugs.openjdk.java.net/browse/SKARA-21 >> >> webrev is a 404 for me... > > Thanks @JornVernee for your contribution! :tada: > > The patch looks good, have you tried it with a credential with a `path`? I'm thinking that if the user has a `path` set for a credential then we should probably pass that `path` back to `git credential approve` in `GitCredentials::approve`. Won't we otherwise set the credential for the entire host, or am I missing something? Looking at the [man page](https://git-scm.com/docs/git-credential) it seems like we should pass the `path` back to `git credential approve` Yeah, that's a good point. I hadn't looked into it that much. I figured since there was no handling for `path` it was safe to ignore. I usually use TortoiseGit, and I'm not really familiar with the `credentials` CLI. Trying to run `git credential fill` manually from the command line seems to hang forever, so I'm not sure how best to test it with a credential with a path. From duke at openjdk.java.net Wed Jun 26 19:19:43 2019 From: duke at openjdk.java.net (JornVernee via github.com) Date: Wed, 26 Jun 2019 19:19:43 GMT Subject: RFR: Ignore `path=` lines in git credential fill output. In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 5044d1d6: Pass path to approve and reject instead. Also add a path parameter to GitCredentials::fill Pull request: http://git.openjdk.java.net/skara/pull/7 Webrevs: - full: https://openjdk.github.io/cr/skara/7/webrev.01 - inc: https://openjdk.github.io/cr/skara/7/webrev.00-01 Updated full patch: http://git.openjdk.java.net/skara/pull/7.diff Fetch command: git fetch https://github.com/openjdk/skara.git 5044d1d6:pr/7 From duke at openjdk.java.net Wed Jun 26 20:24:43 2019 From: duke at openjdk.java.net (JornVernee via github.com) Date: Wed, 26 Jun 2019 20:24:43 GMT Subject: RFR: Ignore `path=` lines in git credential fill output. In-Reply-To: References: Message-ID: <7yt-izGRloSGnd6heOtH5l9-j6rExR8xEWl4L4Oz7HU=.d0bc6f06-2ff8-41ee-927f-840eeebf1851@github.com> The pull request has been updated with additional changes. ---------------- Added commits: - 113c93d5: Strip leading slashes returned by uri.getPath() Pull request: http://git.openjdk.java.net/skara/pull/7 Webrevs: - full: https://openjdk.github.io/cr/skara/7/webrev.02 - inc: https://openjdk.github.io/cr/skara/7/webrev.01-02 Updated full patch: http://git.openjdk.java.net/skara/pull/7.diff Fetch command: git fetch https://github.com/openjdk/skara.git 113c93d5:pr/7 From duke at openjdk.java.net Wed Jun 26 20:28:37 2019 From: duke at openjdk.java.net (JornVernee via github.com) Date: Wed, 26 Jun 2019 20:28:37 GMT Subject: RFR: Ignore `path=` lines in git credential fill output. In-Reply-To: References: Message-ID: On Wed, 26 Jun 2019 19:05:36 GMT, JornVernee via github.com wrote: > On Wed, 26 Jun 2019 18:18:36 GMT, Erik Duveblad via github.com wrote: > >> On Wed, 26 Jun 2019 15:06:36 GMT, JornVernee via github.com wrote: >> >>> On Wed, 26 Jun 2019 14:46:42 GMT, JornVernee via github.com wrote: >>> >>>> On Wed, 26 Jun 2019 14:46:38 GMT, JornVernee via github.com wrote: >>>> >>>>> Hi, >>>>> >>>>> I'm trying out skara, but when running `git fork https://github.com/openjdk/panama git-panama` I'm getting the following exception: >>>>> >>>>> ``` >>>>> Exception in thread "main" java.io.IOException: 'git credential' returned unexpected line: path= >>>>> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitCredentials.fill(GitCredentials.java:101) >>>>> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitFork.main(GitFork.java:130) >>>>> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:130) >>>>> ``` >>>>> >>>>> Looks like `path=` is not handled yet? >>>>> >>>>> This PR adds some handling that ignores lines starting with `path=` for now, but maybe any unknown line should be ignored instead of throwing an exception, what do you think? >>>>> >>>>> ---------------- >>>>> >>>>> Commits: >>>>> - 2149adba: Ignore `path=` lines in git credential fill output. >>>>> >>>>> Pull request: >>>>> http://git.openjdk.java.net/skara/pull/7 >>>>> >>>>> Webrev: >>>>> https://openjdk.github.io/cr/skara/7/webrev.00 >>>>> >>>>> Patch: >>>>> http://git.openjdk.java.net/skara/pull/7.diff >>>>> >>>>> Fetch command: >>>>> git fetch https://github.com/openjdk/skara.git 2149adba:pr/7 >>>> >>>> Issue created at: https://bugs.openjdk.java.net/browse/SKARA-21 >>> >>> webrev is a 404 for me... >> >> Thanks @JornVernee for your contribution! :tada: >> >> The patch looks good, have you tried it with a credential with a `path`? I'm thinking that if the user has a `path` set for a credential then we should probably pass that `path` back to `git credential approve` in `GitCredentials::approve`. Won't we otherwise set the credential for the entire host, or am I missing something? Looking at the [man page](https://git-scm.com/docs/git-credential) it seems like we should pass the `path` back to `git credential approve` > > Yeah, that's a good point. I hadn't looked into it that much. I figured since there was no handling for `path` it was safe to ignore. > > I usually use TortoiseGit, and I'm not really familiar with the `credentials` CLI. Trying to run `git credential fill` manually from the command line seems to hang forever, so I'm not sure how best to test it with a credential with a path. Okay, I've tested with a credential with a path as well (had to set `credential.useHttpPath=true` in git config for this), and it seems to be working. I can use `git fork` to clone a repo like that. I also see the credential (including the path) appearing in wincred. From duke at openjdk.java.net Thu Jun 27 00:50:46 2019 From: duke at openjdk.java.net (Jeyvison Nascimento via github.com) Date: Thu, 27 Jun 2019 00:50:46 GMT Subject: RFR: SKARA-5 Remove pipeline support from process In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - d148a859: SKARA-5 Remove pipeline support from process Pull request: http://git.openjdk.java.net/skara/pull/2 Webrevs: - full: https://openjdk.github.io/cr/skara/2/webrev.02 - inc: https://openjdk.github.io/cr/skara/2/webrev.01-02 Updated full patch: http://git.openjdk.java.net/skara/pull/2.diff Fetch command: git fetch https://github.com/openjdk/skara.git d148a859:pr/2 From duke at openjdk.java.net Thu Jun 27 00:52:40 2019 From: duke at openjdk.java.net (Jeyvison Nascimento via github.com) Date: Thu, 27 Jun 2019 00:52:40 GMT Subject: RFR: SKARA-5 Remove pipeline support from process In-Reply-To: References: <6JhNpscqhImJd4yBjTKfy_dJ2azFOgb-mK5etboeduQ=.a79877c8-e3a6-47e2-b4d9-e307ef1df052@github.com> Message-ID: On Wed, 26 Jun 2019 10:51:39 GMT, Jeyvison Nascimento via github.com wrote: > On Wed, 26 Jun 2019 06:17:37 GMT, Robin Westberg via github.com wrote: > >> On Tue, 25 Jun 2019 00:49:17 GMT, Jeyvison Nascimento via github.com wrote: >> >>> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Also, I think something must be changed in ProcessBuilder, am i right? And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) >>> >>> ---------------- >>> >>> Commits: >>> - cf6700bd: SKARA-5 Remove pipeline support from process >>> >>> Pull request: >>> https://github.com/openjdk/skara/pull/2 >>> >>> Webrev: >>> https://openjdk.github.io/cr/skara/2/webrev.00 >>> >>> Patch: >>> https://github.com/openjdk/skara/pull/2.diff >>> >>> Fetch command: >>> git fetch https://github.com/openjdk/skara.git cf6700bd:pr/2 >> >>> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. >> >> Hi! Thanks for the PR! Yes, this is indeed what we meant. (There's actually even a bit more complexity that can be removed, I'll add a more detailed review). >> >>> Also, I think something must be changed in ProcessBuilder, am i right? >> >> Do you mean java.lang.ProcessBuilder? That should not need any changes, perhaps I'm misunderstanding the question.. >> >>> And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) >> >> All tests pass when I run them in your branch, what kind of problem did you see? > > @rwestberg Done :) Hope it's better now. @edvbld Third time is the luck one. Done :) From duke at openjdk.java.net Thu Jun 27 01:13:46 2019 From: duke at openjdk.java.net (Jeyvison Nascimento via github.com) Date: Thu, 27 Jun 2019 01:13:46 GMT Subject: RFR: SKARA-5 Remove pipeline support from process In-Reply-To: References: Message-ID: <9UBigkJDBMEuEFruso4i6uJY0bOvslJe-04V3IS1-XI=.37d690a5-2dcc-4796-95e8-0336f0f263e9@github.com> The pull request has been updated with additional changes. ---------------- Added commits: - d76aaa2f: SKARA-5 Remove pipeline support from process Pull request: http://git.openjdk.java.net/skara/pull/2 Webrevs: - full: https://openjdk.github.io/cr/skara/2/webrev.03 - inc: https://openjdk.github.io/cr/skara/2/webrev.02-03 Updated full patch: http://git.openjdk.java.net/skara/pull/2.diff Fetch command: git fetch https://github.com/openjdk/skara.git d76aaa2f:pr/2 From duke at openjdk.java.net Thu Jun 27 01:34:41 2019 From: duke at openjdk.java.net (Jeyvison Nascimento via github.com) Date: Thu, 27 Jun 2019 01:34:41 GMT Subject: RFR: SKARA-5 Remove pipeline support from process In-Reply-To: References: <6JhNpscqhImJd4yBjTKfy_dJ2azFOgb-mK5etboeduQ=.a79877c8-e3a6-47e2-b4d9-e307ef1df052@github.com> Message-ID: On Thu, 27 Jun 2019 00:52:40 GMT, Jeyvison Nascimento via github.com wrote: > On Wed, 26 Jun 2019 10:51:39 GMT, Jeyvison Nascimento via github.com wrote: > >> On Wed, 26 Jun 2019 06:17:37 GMT, Robin Westberg via github.com wrote: >> >>> On Tue, 25 Jun 2019 00:49:17 GMT, Jeyvison Nascimento via github.com wrote: >>> >>>> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Also, I think something must be changed in ProcessBuilder, am i right? And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) >>>> >>>> ---------------- >>>> >>>> Commits: >>>> - cf6700bd: SKARA-5 Remove pipeline support from process >>>> >>>> Pull request: >>>> https://github.com/openjdk/skara/pull/2 >>>> >>>> Webrev: >>>> https://openjdk.github.io/cr/skara/2/webrev.00 >>>> >>>> Patch: >>>> https://github.com/openjdk/skara/pull/2.diff >>>> >>>> Fetch command: >>>> git fetch https://github.com/openjdk/skara.git cf6700bd:pr/2 >>> >>>> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. >>> >>> Hi! Thanks for the PR! Yes, this is indeed what we meant. (There's actually even a bit more complexity that can be removed, I'll add a more detailed review). >>> >>>> Also, I think something must be changed in ProcessBuilder, am i right? >>> >>> Do you mean java.lang.ProcessBuilder? That should not need any changes, perhaps I'm misunderstanding the question.. >>> >>>> And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) >>> >>> All tests pass when I run them in your branch, what kind of problem did you see? >> >> @rwestberg Done :) Hope it's better now. > > @edvbld Third time is the luck one. Done :) Should https://github.com/openjdk/skara/blob/d76aaa2ff9e8809833137c899ec819977d5903a4/process/src/main/java/org/openjdk/skara/process/Process.java#L40 be just a single command too? From duke at openjdk.java.net Thu Jun 27 05:37:46 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Thu, 27 Jun 2019 05:37:46 GMT Subject: RFR: SKARA-5 Remove pipeline support from process In-Reply-To: References: Message-ID: <5HcXcetAmDxmHn7DbE-uWZB6fKxooyfABphGYK3n5iQ=.6fb0c009-29e9-4549-96bb-c1631cb6a188@github.com> The PR reviewed by Robin Westberg via github.com has now been updated - changes are approved. From duke at openjdk.java.net Thu Jun 27 05:40:43 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Thu, 27 Jun 2019 05:40:43 GMT Subject: RFR: 5: Remove pipeline support from process In-Reply-To: References: <6JhNpscqhImJd4yBjTKfy_dJ2azFOgb-mK5etboeduQ=.a79877c8-e3a6-47e2-b4d9-e307ef1df052@github.com> Message-ID: On Thu, 27 Jun 2019 01:34:41 GMT, Jeyvison Nascimento via github.com wrote: > On Thu, 27 Jun 2019 00:52:40 GMT, Jeyvison Nascimento via github.com wrote: > >> On Wed, 26 Jun 2019 10:51:39 GMT, Jeyvison Nascimento via github.com wrote: >> >>> On Wed, 26 Jun 2019 06:17:37 GMT, Robin Westberg via github.com wrote: >>> >>>> On Tue, 25 Jun 2019 00:49:17 GMT, Jeyvison Nascimento via github.com wrote: >>>> >>>>> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Also, I think something must be changed in ProcessBuilder, am i right? And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) >>>>> >>>>> ---------------- >>>>> >>>>> Commits: >>>>> - cf6700bd: SKARA-5 Remove pipeline support from process >>>>> >>>>> Pull request: >>>>> https://github.com/openjdk/skara/pull/2 >>>>> >>>>> Webrev: >>>>> https://openjdk.github.io/cr/skara/2/webrev.00 >>>>> >>>>> Patch: >>>>> https://github.com/openjdk/skara/pull/2.diff >>>>> >>>>> Fetch command: >>>>> git fetch https://github.com/openjdk/skara.git cf6700bd:pr/2 >>>> >>>>> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. >>>> >>>> Hi! Thanks for the PR! Yes, this is indeed what we meant. (There's actually even a bit more complexity that can be removed, I'll add a more detailed review). >>>> >>>>> Also, I think something must be changed in ProcessBuilder, am i right? >>>> >>>> Do you mean java.lang.ProcessBuilder? That should not need any changes, perhaps I'm misunderstanding the question.. >>>> >>>>> And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) >>>> >>>> All tests pass when I run them in your branch, what kind of problem did you see? >>> >>> @rwestberg Done :) Hope it's better now. >> >> @edvbld Third time is the luck one. Done :) > > Should https://github.com/openjdk/skara/blob/d76aaa2ff9e8809833137c899ec819977d5903a4/process/src/main/java/org/openjdk/skara/process/Process.java#L40 be just a single command too? Btw, I changed the title of the PR to conform to our preferred format (this will be automated in the future). From duke at openjdk.java.net Thu Jun 27 05:46:43 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Thu, 27 Jun 2019 05:46:43 GMT Subject: RFR: 5: Remove pipeline support from process In-Reply-To: References: <6JhNpscqhImJd4yBjTKfy_dJ2azFOgb-mK5etboeduQ=.a79877c8-e3a6-47e2-b4d9-e307ef1df052@github.com> Message-ID: On Thu, 27 Jun 2019 05:40:43 GMT, Robin Westberg via github.com wrote: > On Thu, 27 Jun 2019 01:34:41 GMT, Jeyvison Nascimento via github.com wrote: > >> On Thu, 27 Jun 2019 00:52:40 GMT, Jeyvison Nascimento via github.com wrote: >> >>> On Wed, 26 Jun 2019 10:51:39 GMT, Jeyvison Nascimento via github.com wrote: >>> >>>> On Wed, 26 Jun 2019 06:17:37 GMT, Robin Westberg via github.com wrote: >>>> >>>>> On Tue, 25 Jun 2019 00:49:17 GMT, Jeyvison Nascimento via github.com wrote: >>>>> >>>>>> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Also, I think something must be changed in ProcessBuilder, am i right? And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) >>>>>> >>>>>> ---------------- >>>>>> >>>>>> Commits: >>>>>> - cf6700bd: SKARA-5 Remove pipeline support from process >>>>>> >>>>>> Pull request: >>>>>> https://github.com/openjdk/skara/pull/2 >>>>>> >>>>>> Webrev: >>>>>> https://openjdk.github.io/cr/skara/2/webrev.00 >>>>>> >>>>>> Patch: >>>>>> https://github.com/openjdk/skara/pull/2.diff >>>>>> >>>>>> Fetch command: >>>>>> git fetch https://github.com/openjdk/skara.git cf6700bd:pr/2 >>>>> >>>>>> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. >>>>> >>>>> Hi! Thanks for the PR! Yes, this is indeed what we meant. (There's actually even a bit more complexity that can be removed, I'll add a more detailed review). >>>>> >>>>>> Also, I think something must be changed in ProcessBuilder, am i right? >>>>> >>>>> Do you mean java.lang.ProcessBuilder? That should not need any changes, perhaps I'm misunderstanding the question.. >>>>> >>>>>> And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :) >>>>> >>>>> All tests pass when I run them in your branch, what kind of problem did you see? >>>> >>>> @rwestberg Done :) Hope it's better now. >>> >>> @edvbld Third time is the luck one. Done :) >> >> Should https://github.com/openjdk/skara/blob/d76aaa2ff9e8809833137c899ec819977d5903a4/process/src/main/java/org/openjdk/skara/process/Process.java#L40 be just a single command too? > > Btw, I changed the title of the PR to conform to our preferred format (this will be automated in the future). > Should > > https://github.com/openjdk/skara/blob/d76aaa2ff9e8809833137c899ec819977d5903a4/process/src/main/java/org/openjdk/skara/process/Process.java#L40 > > be just a single command too? And no, that one is fine, commands (executable and its arguments) are passed to ProcessBuilder as a list: https://github.com/openjdk/skara/blob/d76aaa2ff9e8809833137c899ec819977d5903a4/process/src/main/java/org/openjdk/skara/process/Process.java#L87 From duke at openjdk.java.net Thu Jun 27 06:21:39 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Thu, 27 Jun 2019 06:21:39 GMT Subject: RFR: 19: Allow GitHub bots to use a PAT for authentication as well Message-ID: Hi all, Please review the following change that allows configuration of GitHub bots to use either app or pat authentication. Normally app authentication should be used, but for certain cases (like pushing to a repository that should trigger pages rebuilds) app credentials cannot be used. Best regards, Robin ---------------- Commits: - 0d7dfea2: Allow GitHub bots to use a PAT for authentication as well Pull request: http://git.openjdk.java.net/skara/pull/8 Webrev: https://openjdk.github.io/cr/skara/8/webrev.00 Patch: http://git.openjdk.java.net/skara/pull/8.diff Fetch command: git fetch https://github.com/openjdk/skara.git 0d7dfea2:pr/8 From duke at openjdk.java.net Thu Jun 27 07:30:37 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Thu, 27 Jun 2019 07:30:37 GMT Subject: RFR: 19: Allow GitHub bots to use a PAT for authentication as well In-Reply-To: References: Message-ID: This PR has now been reviewed by Erik Duveblad via github.com - changes are approved. From duke at openjdk.java.net Thu Jun 27 07:55:38 2019 From: duke at openjdk.java.net (duke) Date: Thu, 27 Jun 2019 07:55:38 GMT Subject: git: openjdk/skara: 19: Allow GitHub bots to use a PAT for authentication as well Message-ID: <0fe5347c-8174-411e-9029-53f9a7db71d1@openjdk.java.net> Changeset: 561d7152 Author: Robin Westberg Date: 2019-06-27 07:54:39 +0000 URL: http://git.openjdk.java.net/skara/commit/561d7152 19: Allow GitHub bots to use a PAT for authentication as well Reviewed-by: ehelin ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java From duke at openjdk.java.net Thu Jun 27 09:26:47 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Thu, 27 Jun 2019 09:26:47 GMT Subject: RFR: 5: Remove pipeline support from process In-Reply-To: References: Message-ID: The PR reviewed by Erik Duveblad via github.com has now been updated - changes are approved. From duke at openjdk.java.net Thu Jun 27 09:33:24 2019 From: duke at openjdk.java.net (duke) Date: Thu, 27 Jun 2019 09:33:24 GMT Subject: git: openjdk/skara: 5: Remove pipeline support from process Message-ID: <38117a09-c89d-4f10-9285-89f76dc48957@openjdk.java.net> Changeset: c4cc930b Author: Jeyvison Nascimento Date: 2019-06-27 09:32:43 +0000 URL: http://git.openjdk.java.net/skara/commit/c4cc930b 5: Remove pipeline support from process Reviewed-by: rwestberg, ehelin ! process/src/main/java/org/openjdk/skara/process/Execution.java ! process/src/main/java/org/openjdk/skara/process/Process.java ! process/src/test/java/org/openjdk/skara/process/ProcessTests.java From duke at openjdk.java.net Thu Jun 27 12:01:28 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Thu, 27 Jun 2019 12:01:28 GMT Subject: RFR: 24: Allow lazy evaluation of the fullName field in HostUserDetails Message-ID: Hi all, Please review the following change that allows lazy evaluation of the fullName field in HostUserDetails. Most GitHub API calls only return the id and username, so to populate the full name we have to do a separate request. However, the full name is rarely used, so we can save a few API calls by only fetching it when needed. Best regards, Robin ---------------- Commits: - 54d7f40a: Allow lazy evaluation of the fullName field in HostUserDetails Pull request: http://git.openjdk.java.net/skara/pull/9 Webrev: https://openjdk.github.io/cr/skara/9/webrev.00 Patch: http://git.openjdk.java.net/skara/pull/9.diff Fetch command: git fetch https://github.com/openjdk/skara.git 54d7f40a:pr/9 From duke at openjdk.java.net Thu Jun 27 12:42:27 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Thu, 27 Jun 2019 12:42:27 GMT Subject: RFR: 24: Allow lazy evaluation of the fullName field in HostUserDetails In-Reply-To: References: Message-ID: <4Adu2wtHlokTd-9pghsCLoYaNRMWLMUE2OVFRnjGg8A=.71c87222-2996-4ee7-b3f0-faabc12e2eb0@github.com> This PR has now been reviewed by Erik Duveblad via github.com - comment added. From duke at openjdk.java.net Thu Jun 27 12:42:26 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Thu, 27 Jun 2019 12:42:26 GMT Subject: RFR: 24: Allow lazy evaluation of the fullName field in HostUserDetails In-Reply-To: References: Message-ID: On Thu, 27 Jun 2019 12:01:28 GMT, Robin Westberg via github.com wrote: > Hi all, > > Please review the following change that allows lazy evaluation of the fullName field in HostUserDetails. Most GitHub API calls only return the id and username, so to populate the full name we have to do a separate request. However, the full name is rarely used, so we can save a few API calls by only fetching it when needed. > > Best regards, > Robin > > ---------------- > > Commits: > - 54d7f40a: Allow lazy evaluation of the fullName field in HostUserDetails > > Pull request: > http://git.openjdk.java.net/skara/pull/9 > > Webrev: > https://openjdk.github.io/cr/skara/9/webrev.00 > > Patch: > http://git.openjdk.java.net/skara/pull/9.diff > > Fetch command: > git fetch https://github.com/openjdk/skara.git 54d7f40a:pr/9 host/src/main/java/org/openjdk/skara/host/HostUserDetails.java line 52: > 51: return true; > 52: } > 53: if (o == null || getClass() != o.getClass()) { Perhaps check an throw an exception here instead? Assertions are not enabled by default in the launchers. You can use `Optional` to make this short and sweet: ``` var supplier = Optional.ofNullable(nameSupplier).orElseThrow(IllegalStateException::new) name = supplier.get(); return name; ``` From duke at openjdk.java.net Thu Jun 27 12:43:26 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Thu, 27 Jun 2019 12:43:26 GMT Subject: RFR: 24: Allow lazy evaluation of the fullName field in HostUserDetails In-Reply-To: References: Message-ID: On Thu, 27 Jun 2019 12:42:26 GMT, Erik Duveblad via github.com wrote: > On Thu, 27 Jun 2019 12:01:28 GMT, Robin Westberg via github.com wrote: > >> Hi all, >> >> Please review the following change that allows lazy evaluation of the fullName field in HostUserDetails. Most GitHub API calls only return the id and username, so to populate the full name we have to do a separate request. However, the full name is rarely used, so we can save a few API calls by only fetching it when needed. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - 54d7f40a: Allow lazy evaluation of the fullName field in HostUserDetails >> >> Pull request: >> http://git.openjdk.java.net/skara/pull/9 >> >> Webrev: >> https://openjdk.github.io/cr/skara/9/webrev.00 >> >> Patch: >> http://git.openjdk.java.net/skara/pull/9.diff >> >> Fetch command: >> git fetch https://github.com/openjdk/skara.git 54d7f40a:pr/9 > > host/src/main/java/org/openjdk/skara/host/HostUserDetails.java line 52: > >> 51: return true; >> 52: } >> 53: if (o == null || getClass() != o.getClass()) { > > Perhaps check an throw an exception here instead? Assertions are not enabled by default in the launchers. You can use `Optional` to make this short and sweet: > ``` > var supplier = Optional.ofNullable(nameSupplier).orElseThrow(IllegalStateException::new) > name = supplier.get(); > return name; > ``` This can't actually happen (name or namesupplier must be set), it's mostly to make my IDE stop complaining From duke at openjdk.java.net Thu Jun 27 12:43:27 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Thu, 27 Jun 2019 12:43:27 GMT Subject: RFR: 24: Allow lazy evaluation of the fullName field in HostUserDetails In-Reply-To: References: Message-ID: This PR has now been reviewed by Robin Westberg via github.com - comment added. From duke at openjdk.java.net Thu Jun 27 12:59:32 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Thu, 27 Jun 2019 12:59:32 GMT Subject: RFR: 24: Allow lazy evaluation of the fullName field in HostUserDetails In-Reply-To: References: Message-ID: <2JH9sBc4QxukYC-5iD2pxxIckcEn8LMT2nCviepZulk=.e3c7350a-ef33-467c-89cd-5fb88f8c0fc2@github.com> The pull request has been updated with additional changes. ---------------- Added commits: - ae7bf6c6: Remove the assert Pull request: http://git.openjdk.java.net/skara/pull/9 Webrevs: - full: https://openjdk.github.io/cr/skara/9/webrev.01 - inc: https://openjdk.github.io/cr/skara/9/webrev.00-01 Updated full patch: http://git.openjdk.java.net/skara/pull/9.diff Fetch command: git fetch https://github.com/openjdk/skara.git ae7bf6c6:pr/9 From duke at openjdk.java.net Thu Jun 27 13:08:26 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Thu, 27 Jun 2019 13:08:26 GMT Subject: RFR: Ignore `path=` lines in git credential fill output. In-Reply-To: References: Message-ID: This PR has now been reviewed by Erik Duveblad via github.com - changes are approved. From duke at openjdk.java.net Thu Jun 27 13:20:29 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Thu, 27 Jun 2019 13:20:29 GMT Subject: RFR: 24: Allow lazy evaluation of the fullName field in HostUserDetails In-Reply-To: References: Message-ID: <-wvbHOh1jYOeIPkO7xDBZnyT4l_Y2XPxtD-senpIdNw=.529b4f84-728a-42ee-be1e-38cbc5134a20@github.com> On Thu, 27 Jun 2019 12:01:28 GMT, Robin Westberg via github.com wrote: > Hi all, > > Please review the following change that allows lazy evaluation of the fullName field in HostUserDetails. Most GitHub API calls only return the id and username, so to populate the full name we have to do a separate request. However, the full name is rarely used, so we can save a few API calls by only fetching it when needed. > > Best regards, > Robin > > ---------------- > > Commits: > - 54d7f40a: Allow lazy evaluation of the fullName field in HostUserDetails > > Pull request: > http://git.openjdk.java.net/skara/pull/9 > > Webrev: > https://openjdk.github.io/cr/skara/9/webrev.00 > > Patch: > http://git.openjdk.java.net/skara/pull/9.diff > > Fetch command: > git fetch https://github.com/openjdk/skara.git 54d7f40a:pr/9 host/src/main/java/org/openjdk/skara/host/HostUserDetails.java line 26: > 25: import java.util.Objects; > 26: import java.util.function.Supplier; > 27: Nice improvement, but `fullName` can now be as simple as: ```java public String fullName() { if (name == null) { name = nameSupplier.get(); } return name; } ``` From duke at openjdk.java.net Thu Jun 27 13:27:33 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Thu, 27 Jun 2019 13:27:33 GMT Subject: RFR: 24: Allow lazy evaluation of the fullName field in HostUserDetails In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 21018810: Make currentUserDetails fully lazy Pull request: http://git.openjdk.java.net/skara/pull/9 Webrevs: - full: https://openjdk.github.io/cr/skara/9/webrev.02 - inc: https://openjdk.github.io/cr/skara/9/webrev.01-02 Updated full patch: http://git.openjdk.java.net/skara/pull/9.diff Fetch command: git fetch https://github.com/openjdk/skara.git 21018810:pr/9 From duke at openjdk.java.net Thu Jun 27 13:28:30 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Thu, 27 Jun 2019 13:28:30 GMT Subject: RFR: 24: Allow lazy evaluation of the fullName field in HostUserDetails In-Reply-To: <-wvbHOh1jYOeIPkO7xDBZnyT4l_Y2XPxtD-senpIdNw=.529b4f84-728a-42ee-be1e-38cbc5134a20@github.com> References: <-wvbHOh1jYOeIPkO7xDBZnyT4l_Y2XPxtD-senpIdNw=.529b4f84-728a-42ee-be1e-38cbc5134a20@github.com> Message-ID: <9D08O6hu3G24_9RsxPB0X2AuBa6ZAM9TMli1l2HvXIQ=.6e51b489-7852-438c-88e9-087431f48f9c@github.com> On Thu, 27 Jun 2019 13:20:29 GMT, Erik Duveblad via github.com wrote: > On Thu, 27 Jun 2019 12:01:28 GMT, Robin Westberg via github.com wrote: > >> Hi all, >> >> Please review the following change that allows lazy evaluation of the fullName field in HostUserDetails. Most GitHub API calls only return the id and username, so to populate the full name we have to do a separate request. However, the full name is rarely used, so we can save a few API calls by only fetching it when needed. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - 54d7f40a: Allow lazy evaluation of the fullName field in HostUserDetails >> >> Pull request: >> http://git.openjdk.java.net/skara/pull/9 >> >> Webrev: >> https://openjdk.github.io/cr/skara/9/webrev.00 >> >> Patch: >> http://git.openjdk.java.net/skara/pull/9.diff >> >> Fetch command: >> git fetch https://github.com/openjdk/skara.git 54d7f40a:pr/9 > > host/src/main/java/org/openjdk/skara/host/HostUserDetails.java line 26: > >> 25: import java.util.Objects; >> 26: import java.util.function.Supplier; >> 27: > > Nice improvement, but `fullName` can now be as simple as: > ```java > public String fullName() { > if (name == null) { > name = nameSupplier.get(); > } > return name; > } > ``` Sure, can change it From duke at openjdk.java.net Thu Jun 27 13:30:36 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Thu, 27 Jun 2019 13:30:36 GMT Subject: RFR: 24: Allow lazy evaluation of the fullName field in HostUserDetails In-Reply-To: References: Message-ID: The PR reviewed by Erik Duveblad via github.com has now been updated - changes are approved. From duke at openjdk.java.net Thu Jun 27 13:30:30 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Thu, 27 Jun 2019 13:30:30 GMT Subject: RFR: 24: Allow lazy evaluation of the fullName field in HostUserDetails In-Reply-To: References: Message-ID: On Thu, 27 Jun 2019 12:01:28 GMT, Robin Westberg via github.com wrote: > Hi all, > > Please review the following change that allows lazy evaluation of the fullName field in HostUserDetails. Most GitHub API calls only return the id and username, so to populate the full name we have to do a separate request. However, the full name is rarely used, so we can save a few API calls by only fetching it when needed. > > Best regards, > Robin > > ---------------- > > Commits: > - 54d7f40a: Allow lazy evaluation of the fullName field in HostUserDetails > > Pull request: > http://git.openjdk.java.net/skara/pull/9 > > Webrev: > https://openjdk.github.io/cr/skara/9/webrev.00 > > Patch: > http://git.openjdk.java.net/skara/pull/9.diff > > Fetch command: > git fetch https://github.com/openjdk/skara.git 54d7f40a:pr/9 Thanks for reviewing! From duke at openjdk.java.net Thu Jun 27 13:32:24 2019 From: duke at openjdk.java.net (duke) Date: Thu, 27 Jun 2019 13:32:24 GMT Subject: git: openjdk/skara: 24: Allow lazy evaluation of the fullName field in HostUserDetails Message-ID: Changeset: 48427ff3 Author: Robin Westberg Date: 2019-06-27 13:31:34 +0000 URL: http://git.openjdk.java.net/skara/commit/48427ff3 24: Allow lazy evaluation of the fullName field in HostUserDetails Reviewed-by: ehelin ! host/src/main/java/org/openjdk/skara/host/HostUserDetails.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubHost.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubRepository.java From duke at openjdk.java.net Thu Jun 27 13:54:17 2019 From: duke at openjdk.java.net (duke) Date: Thu, 27 Jun 2019 13:54:17 GMT Subject: git: openjdk/skara: Ignore `path=` lines in git credential fill output. Message-ID: <62ddfbdd-91d0-4427-a0a2-60aef847a530@openjdk.java.net> Changeset: 99c82236 Author: Jorn Vernee Date: 2019-06-27 13:53:59 +0000 URL: http://git.openjdk.java.net/skara/commit/99c82236 Ignore `path=` lines in git credential fill output. Reviewed-by: ehelin ! cli/src/main/java/org/openjdk/skara/cli/GitCredentials.java ! cli/src/main/java/org/openjdk/skara/cli/GitFork.java ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java ! cli/src/main/java/org/openjdk/skara/cli/GitToken.java From duke at openjdk.java.net Thu Jun 27 14:21:00 2019 From: duke at openjdk.java.net (JornVernee via github.com) Date: Thu, 27 Jun 2019 14:21:00 GMT Subject: RFR: Check if census endpoint is a URL before trying to parse it as a path. Message-ID: When running `git jcheck --local` I'm getting the following exception: ``` Exception in thread "main" java.nio.file.InvalidPathException: Illegal char <:> at index 5: https://openjdk.java.net/census.xml at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229) at java.base/java.nio.file.Path.of(Path.java:147) at org.openjdk.skara.cli/org.openjdk.skara.cli.GitJCheck.main(GitJCheck.java:159) at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:130) ``` Looking into the source code this seems to be because the fallback endpoint for getting the OpenJDK census is used, a URL, which is not a valid path (at least not on Windows), so the check to see if we're dealing with a path or not fails when parsing the path. This PR switches to a regular expression for checking whether the endpoint is a URL or not (by checking if it starts with `http(s)://`). ---------------- Commits: - dbccc100: Check if census endpoint is a URL before trying to parse it as a path. Pull request: http://git.openjdk.java.net/skara/pull/10 Webrev: https://openjdk.github.io/cr/skara/10/webrev.00 Patch: http://git.openjdk.java.net/skara/pull/10.diff Fetch command: git fetch https://github.com/openjdk/skara.git dbccc100:pr/10 From duke at openjdk.java.net Thu Jun 27 17:08:53 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Thu, 27 Jun 2019 17:08:53 GMT Subject: RFR: Check if census endpoint is a URL before trying to parse it as a path. In-Reply-To: References: Message-ID: <7koFZw6P3zkV6qIwQ5KfIURKsYmC_VZUlgNyJeeNcNA=.2c0757c1-b9e9-4b89-877f-5e83d1dfdc85@github.com> On Thu, 27 Jun 2019 14:21:00 GMT, JornVernee via github.com wrote: > When running `git jcheck --local` I'm getting the following exception: > > ``` > Exception in thread "main" java.nio.file.InvalidPathException: Illegal char <:> at index 5: https://openjdk.java.net/census.xml > at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) > at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) > at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) > at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) > at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229) > at java.base/java.nio.file.Path.of(Path.java:147) > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitJCheck.main(GitJCheck.java:159) > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:130) > ``` > > Looking into the source code this seems to be because the fallback endpoint for getting the OpenJDK census is used, a URL, which is not a valid path (at least not on Windows), so the check to see if we're dealing with a path or not fails when parsing the path. > > This PR switches to a regular expression for checking whether the endpoint is a URL or not (by checking if it starts with `http(s)://`). > > ---------------- > > Commits: > - dbccc100: Check if census endpoint is a URL before trying to parse it as a path. > > Pull request: > http://git.openjdk.java.net/skara/pull/10 > > Webrev: > https://openjdk.github.io/cr/skara/10/webrev.00 > > Patch: > http://git.openjdk.java.net/skara/pull/10.diff > > Fetch command: > git fetch https://github.com/openjdk/skara.git dbccc100:pr/10 cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java line 32: > 31: import org.openjdk.skara.vcs.openjdk.CommitMessageParsers; > 32: > 33: import java.io.IOException; The regex solution works fine, I just tend to stick with `String::startsWith` for simple cases :smiley: What do you think of `return s.startsWith("http://") || s.startsWith("https://");` ? I'm fine with the regex if you prefer that. cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java line 31: > 30: import org.openjdk.skara.vcs.*; > 31: import org.openjdk.skara.vcs.openjdk.CommitMessageParsers; > 32: Nice to add a static method. Very minor nit, I would probably just have went with `String s` here, but I'm fine with `pathOrURL` as well. From duke at openjdk.java.net Thu Jun 27 17:08:54 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Thu, 27 Jun 2019 17:08:54 GMT Subject: RFR: Check if census endpoint is a URL before trying to parse it as a path. In-Reply-To: References: Message-ID: This PR has now been reviewed by Erik Duveblad via github.com - comment added. From duke at openjdk.java.net Thu Jun 27 17:22:53 2019 From: duke at openjdk.java.net (JornVernee via github.com) Date: Thu, 27 Jun 2019 17:22:53 GMT Subject: RFR: Check if census endpoint is a URL before trying to parse it as a path. In-Reply-To: <7koFZw6P3zkV6qIwQ5KfIURKsYmC_VZUlgNyJeeNcNA=.2c0757c1-b9e9-4b89-877f-5e83d1dfdc85@github.com> References: <7koFZw6P3zkV6qIwQ5KfIURKsYmC_VZUlgNyJeeNcNA=.2c0757c1-b9e9-4b89-877f-5e83d1dfdc85@github.com> Message-ID: On Thu, 27 Jun 2019 17:08:53 GMT, Erik Duveblad via github.com wrote: > On Thu, 27 Jun 2019 14:21:00 GMT, JornVernee via github.com wrote: > >> When running `git jcheck --local` I'm getting the following exception: >> >> ``` >> Exception in thread "main" java.nio.file.InvalidPathException: Illegal char <:> at index 5: https://openjdk.java.net/census.xml >> at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) >> at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) >> at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) >> at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) >> at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229) >> at java.base/java.nio.file.Path.of(Path.java:147) >> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitJCheck.main(GitJCheck.java:159) >> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:130) >> ``` >> >> Looking into the source code this seems to be because the fallback endpoint for getting the OpenJDK census is used, a URL, which is not a valid path (at least not on Windows), so the check to see if we're dealing with a path or not fails when parsing the path. >> >> This PR switches to a regular expression for checking whether the endpoint is a URL or not (by checking if it starts with `http(s)://`). >> >> ---------------- >> >> Commits: >> - dbccc100: Check if census endpoint is a URL before trying to parse it as a path. >> >> Pull request: >> http://git.openjdk.java.net/skara/pull/10 >> >> Webrev: >> https://openjdk.github.io/cr/skara/10/webrev.00 >> >> Patch: >> http://git.openjdk.java.net/skara/pull/10.diff >> >> Fetch command: >> git fetch https://github.com/openjdk/skara.git dbccc100:pr/10 > > cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java line 32: > >> 31: import org.openjdk.skara.vcs.openjdk.CommitMessageParsers; >> 32: >> 33: import java.io.IOException; > > The regex solution works fine, I just tend to stick with `String::startsWith` for simple cases :smiley: > What do you think of `return s.startsWith("http://") || s.startsWith("https://");` ? I'm fine with the regex if you prefer that. I was using `s.matches("^http://")` before, but checking on the URI specification https://tools.ietf.org/html/rfc3986#section-3.1 > Although schemes are case-insensitive, the canonical form is lowercase That's why I went with the case insensitive regex. If we don't care about case then it's fine to use `startsWith`, but otherwise we'd need to check every combination of upper and lower case, so in that case the regex seems better. From duke at openjdk.java.net Thu Jun 27 17:22:53 2019 From: duke at openjdk.java.net (JornVernee via github.com) Date: Thu, 27 Jun 2019 17:22:53 GMT Subject: RFR: Check if census endpoint is a URL before trying to parse it as a path. In-Reply-To: References: Message-ID: This PR has now been reviewed by JornVernee via github.com - comment added. From duke at openjdk.java.net Thu Jun 27 17:25:23 2019 From: duke at openjdk.java.net (JornVernee via github.com) Date: Thu, 27 Jun 2019 17:25:23 GMT Subject: RFR: Check if census endpoint is a URL before trying to parse it as a path. In-Reply-To: References: Message-ID: On Thu, 27 Jun 2019 17:08:54 GMT, Erik Duveblad via github.com wrote: > On Thu, 27 Jun 2019 14:21:00 GMT, JornVernee via github.com wrote: > >> When running `git jcheck --local` I'm getting the following exception: >> >> ``` >> Exception in thread "main" java.nio.file.InvalidPathException: Illegal char <:> at index 5: https://openjdk.java.net/census.xml >> at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) >> at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) >> at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) >> at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) >> at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229) >> at java.base/java.nio.file.Path.of(Path.java:147) >> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitJCheck.main(GitJCheck.java:159) >> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:130) >> ``` >> >> Looking into the source code this seems to be because the fallback endpoint for getting the OpenJDK census is used, a URL, which is not a valid path (at least not on Windows), so the check to see if we're dealing with a path or not fails when parsing the path. >> >> This PR switches to a regular expression for checking whether the endpoint is a URL or not (by checking if it starts with `http(s)://`). >> >> ---------------- >> >> Commits: >> - dbccc100: Check if census endpoint is a URL before trying to parse it as a path. >> >> Pull request: >> http://git.openjdk.java.net/skara/pull/10 >> >> Webrev: >> https://openjdk.github.io/cr/skara/10/webrev.00 >> >> Patch: >> http://git.openjdk.java.net/skara/pull/10.diff >> >> Fetch command: >> git fetch https://github.com/openjdk/skara.git dbccc100:pr/10 > > cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java line 31: > >> 30: import org.openjdk.skara.vcs.*; >> 31: import org.openjdk.skara.vcs.openjdk.CommitMessageParsers; >> 32: > > Nice to add a static method. Very minor nit, I would probably just have went with `String s` here, but I'm fine with `pathOrURL` as well. Yeah, `String s` seems fine. I'll change it. From duke at openjdk.java.net Thu Jun 27 17:30:31 2019 From: duke at openjdk.java.net (JornVernee via github.com) Date: Thu, 27 Jun 2019 17:30:31 GMT Subject: RFR: Check if census endpoint is a URL before trying to parse it as a path. In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - b09c2d0e: - Change parameter name of isURL to 's' Pull request: http://git.openjdk.java.net/skara/pull/10 Webrevs: - full: https://openjdk.github.io/cr/skara/10/webrev.01 - inc: https://openjdk.github.io/cr/skara/10/webrev.00-01 Updated full patch: http://git.openjdk.java.net/skara/pull/10.diff Fetch command: git fetch https://github.com/openjdk/skara.git b09c2d0e:pr/10 From erik.helin at oracle.com Fri Jun 28 07:51:06 2019 From: erik.helin at oracle.com (Erik Helin) Date: Fri, 28 Jun 2019 09:51:06 +0200 Subject: CFV: New Skara Committer: Jorn Vernee Message-ID: I hereby nominate Jorn Vernee to Skara Committer. Jorn has contributed two patches to http://git.openjdk.java.net/skara, both fixing issues on Windows. This has been very helpful since no other active committer in Skara is using Windows on a daily basis. Jorn has demonstrated a solid understanding of Java and the Skara CLI code, disciplined testing and a good understanding of OpenJDK processes (he is already a committer in the Panama project). Votes are due by July 12. Only current Skara Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Erik [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From duke at openjdk.java.net Fri Jun 28 07:52:53 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Fri, 28 Jun 2019 07:52:53 GMT Subject: RFR: Check if census endpoint is a URL before trying to parse it as a path. In-Reply-To: <7koFZw6P3zkV6qIwQ5KfIURKsYmC_VZUlgNyJeeNcNA=.2c0757c1-b9e9-4b89-877f-5e83d1dfdc85@github.com> References: <7koFZw6P3zkV6qIwQ5KfIURKsYmC_VZUlgNyJeeNcNA=.2c0757c1-b9e9-4b89-877f-5e83d1dfdc85@github.com> Message-ID: On Thu, 27 Jun 2019 17:08:53 GMT, Erik Duveblad via github.com wrote: > On Thu, 27 Jun 2019 14:21:00 GMT, JornVernee via github.com wrote: > >> When running `git jcheck --local` I'm getting the following exception: >> >> ``` >> Exception in thread "main" java.nio.file.InvalidPathException: Illegal char <:> at index 5: https://openjdk.java.net/census.xml >> at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) >> at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) >> at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) >> at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) >> at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229) >> at java.base/java.nio.file.Path.of(Path.java:147) >> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitJCheck.main(GitJCheck.java:159) >> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:130) >> ``` >> >> Looking into the source code this seems to be because the fallback endpoint for getting the OpenJDK census is used, a URL, which is not a valid path (at least not on Windows), so the check to see if we're dealing with a path or not fails when parsing the path. >> >> This PR switches to a regular expression for checking whether the endpoint is a URL or not (by checking if it starts with `http(s)://`). >> >> ---------------- >> >> Commits: >> - dbccc100: Check if census endpoint is a URL before trying to parse it as a path. >> >> Pull request: >> http://git.openjdk.java.net/skara/pull/10 >> >> Webrev: >> https://openjdk.github.io/cr/skara/10/webrev.00 >> >> Patch: >> http://git.openjdk.java.net/skara/pull/10.diff >> >> Fetch command: >> git fetch https://github.com/openjdk/skara.git dbccc100:pr/10 > > cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java line 32: > >> 31: import org.openjdk.skara.vcs.openjdk.CommitMessageParsers; >> 32: >> 33: import java.io.IOException; > > The regex solution works fine, I just tend to stick with `String::startsWith` for simple cases :smiley: > What do you think of `return s.startsWith("http://") || s.startsWith("https://");` ? I'm fine with the regex if you prefer that. Ah, yes, you are right, better stick with the regex : From duke at openjdk.java.net Fri Jun 28 07:54:23 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Fri, 28 Jun 2019 07:54:23 GMT Subject: RFR: Check if census endpoint is a URL before trying to parse it as a path. In-Reply-To: References: Message-ID: <4XYU4_lMApBXnwPNn_nL48WWsEShhwLH7criCmvnalE=.e7c9ca1b-5964-401d-9fb3-7a8ef1036863@github.com> The PR reviewed by Erik Duveblad via github.com has now been updated - changes are approved. From duke at openjdk.java.net Fri Jun 28 07:54:53 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Fri, 28 Jun 2019 07:54:53 GMT Subject: RFR: Check if census endpoint is a URL before trying to parse it as a path. In-Reply-To: References: Message-ID: On Thu, 27 Jun 2019 14:21:00 GMT, JornVernee via github.com wrote: > When running `git jcheck --local` I'm getting the following exception: > > ``` > Exception in thread "main" java.nio.file.InvalidPathException: Illegal char <:> at index 5: https://openjdk.java.net/census.xml > at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) > at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) > at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) > at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) > at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229) > at java.base/java.nio.file.Path.of(Path.java:147) > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitJCheck.main(GitJCheck.java:159) > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:130) > ``` > > Looking into the source code this seems to be because the fallback endpoint for getting the OpenJDK census is used, a URL, which is not a valid path (at least not on Windows), so the check to see if we're dealing with a path or not fails when parsing the path. > > This PR switches to a regular expression for checking whether the endpoint is a URL or not (by checking if it starts with `http(s)://`). > > ---------------- > > Commits: > - dbccc100: Check if census endpoint is a URL before trying to parse it as a path. > > Pull request: > http://git.openjdk.java.net/skara/pull/10 > > Webrev: > https://openjdk.github.io/cr/skara/10/webrev.00 > > Patch: > http://git.openjdk.java.net/skara/pull/10.diff > > Fetch command: > git fetch https://github.com/openjdk/skara.git dbccc100:pr/10 @JornVernee I just nominated you to become a commiter in Skara, see https://mail.openjdk.java.net/pipermail/skara-dev/2019-June/000109.html for details. From erik.helin at oracle.com Fri Jun 28 07:55:43 2019 From: erik.helin at oracle.com (Erik Helin) Date: Fri, 28 Jun 2019 09:55:43 +0200 Subject: CFV: New Skara Committer: Jorn Vernee In-Reply-To: References: Message-ID: Vote: yes Thanks, Erik On 6/28/19 9:51 AM, Erik Helin wrote: > I hereby nominate Jorn Vernee to Skara Committer. > > Jorn has contributed two patches to http://git.openjdk.java.net/skara, > both fixing issues on Windows. This has been very helpful since no other > active committer in Skara is using Windows on a daily basis. Jorn has > demonstrated a solid understanding of Java and the Skara CLI code, > disciplined testing and a good understanding of OpenJDK processes (he is > already a committer in the Panama project). > > Votes are due by July 12. > > Only current Skara Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Erik > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From robin.westberg at oracle.com Fri Jun 28 09:46:03 2019 From: robin.westberg at oracle.com (Robin Westberg) Date: Fri, 28 Jun 2019 11:46:03 +0200 Subject: CFV: New Skara Committer: Jorn Vernee In-Reply-To: References: Message-ID: <5FAF2C53-8EC4-4782-A3EF-7DC5B82E18DC@oracle.com> Vote: yes Best regards, Robin > On 28 Jun 2019, at 09:51, Erik Helin wrote: > > I hereby nominate Jorn Vernee to Skara Committer. > > Jorn has contributed two patches to http://git.openjdk.java.net/skara, both fixing issues on Windows. This has been very helpful since no other active committer in Skara is using Windows on a daily basis. Jorn has demonstrated a solid understanding of Java and the Skara CLI code, disciplined testing and a good understanding of OpenJDK processes (he is already a committer in the Panama project). > > Votes are due by July 12. > > Only current Skara Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Erik > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From duke at openjdk.java.net Fri Jun 28 10:16:23 2019 From: duke at openjdk.java.net (JornVernee via github.com) Date: Fri, 28 Jun 2019 10:16:23 GMT Subject: RFR: Check if census endpoint is a URL before trying to parse it as a path. In-Reply-To: References: Message-ID: On Fri, 28 Jun 2019 07:54:53 GMT, Erik Duveblad via github.com wrote: > On Thu, 27 Jun 2019 14:21:00 GMT, JornVernee via github.com wrote: > >> When running `git jcheck --local` I'm getting the following exception: >> >> ``` >> Exception in thread "main" java.nio.file.InvalidPathException: Illegal char <:> at index 5: https://openjdk.java.net/census.xml >> at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) >> at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) >> at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) >> at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) >> at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229) >> at java.base/java.nio.file.Path.of(Path.java:147) >> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitJCheck.main(GitJCheck.java:159) >> at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:130) >> ``` >> >> Looking into the source code this seems to be because the fallback endpoint for getting the OpenJDK census is used, a URL, which is not a valid path (at least not on Windows), so the check to see if we're dealing with a path or not fails when parsing the path. >> >> This PR switches to a regular expression for checking whether the endpoint is a URL or not (by checking if it starts with `http(s)://`). >> >> ---------------- >> >> Commits: >> - dbccc100: Check if census endpoint is a URL before trying to parse it as a path. >> >> Pull request: >> http://git.openjdk.java.net/skara/pull/10 >> >> Webrev: >> https://openjdk.github.io/cr/skara/10/webrev.00 >> >> Patch: >> http://git.openjdk.java.net/skara/pull/10.diff >> >> Fetch command: >> git fetch https://github.com/openjdk/skara.git dbccc100:pr/10 > > @JornVernee I just nominated you to become a commiter in Skara, see https://mail.openjdk.java.net/pipermail/skara-dev/2019-June/000109.html for details. @edvbld Thanks for the nomination :) From duke at openjdk.java.net Fri Jun 28 11:35:24 2019 From: duke at openjdk.java.net (duke) Date: Fri, 28 Jun 2019 11:35:24 GMT Subject: git: openjdk/skara: Check if census endpoint is a URL before trying to parse it as a path. Message-ID: <5c6d7482-1a98-4d9f-9cac-df94381c11d1@openjdk.java.net> Changeset: d29c19ed Author: Jorn Vernee Date: 2019-06-28 11:34:54 +0000 URL: http://git.openjdk.java.net/skara/commit/d29c19ed Check if census endpoint is a URL before trying to parse it as a path. Reviewed-by: ehelin ! cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java From duke at openjdk.java.net Fri Jun 28 13:11:29 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Fri, 28 Jun 2019 13:11:29 GMT Subject: RFR: 17: Review comments not reflected on mailing lists Message-ID: Hi all, Please review the following change that adds support for comments attached to reviews. This is not supported by GitLab CE, but is used by GitHub. Best regards, Robin ---------------- Commits: - 5c9c290c: Add support for a comment attached to a review Pull request: http://git.openjdk.java.net/skara/pull/11 Webrev: https://openjdk.github.io/cr/skara/11/webrev.00 Patch: http://git.openjdk.java.net/skara/pull/11.diff Fetch command: git fetch https://github.com/openjdk/skara.git 5c9c290c:pr/11 From duke at openjdk.java.net Fri Jun 28 13:14:54 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Fri, 28 Jun 2019 13:14:54 GMT Subject: RFR: 17: Review comments not reflected on mailing lists In-Reply-To: References: Message-ID: On Fri, 28 Jun 2019 13:11:29 GMT, Robin Westberg via github.com wrote: > Hi all, > > Please review the following change that adds support for comments attached to reviews. This is not supported by GitLab CE, but is used by GitHub. > > Best regards, > Robin > > ---------------- > > Commits: > - 5c9c290c: Add support for a comment attached to a review > > Pull request: > http://git.openjdk.java.net/skara/pull/11 > > Webrev: > https://openjdk.github.io/cr/skara/11/webrev.00 > > Patch: > http://git.openjdk.java.net/skara/pull/11.diff > > Fetch command: > git fetch https://github.com/openjdk/skara.git 5c9c290c:pr/11 Ehm, small patch :smile: Did you run the integrations tests for GitLab CE and GitHub to test this? From duke at openjdk.java.net Fri Jun 28 13:52:58 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Fri, 28 Jun 2019 13:52:58 GMT Subject: RFR: 28: JSON parser does not support empty objects or arrays with whitespace Message-ID: <5mT-WaEzEcN495-ZfySzcQIGF0_Wvk1gPOcdxED6YtM=.38a46bab-485b-4575-8662-33283cf95a88@github.com> Hi all, this patch fixes the small issues that whitespace after `{` and `[` in the JSON parser isn't consumed. I also wrote two small unit tests, `sh gradlew test` now passes. Thanks, Erik ---------------- Commits: - 02e32f0f: 28: JSON parser does not support empty objects or arrays with whitespace Pull request: http://git.openjdk.java.net/skara/pull/12 Webrev: https://openjdk.github.io/cr/skara/12/webrev.00 Patch: http://git.openjdk.java.net/skara/pull/12.diff Fetch command: git fetch https://github.com/openjdk/skara.git 02e32f0f:pr/12 From duke at openjdk.java.net Fri Jun 28 13:53:54 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Fri, 28 Jun 2019 13:53:54 GMT Subject: RFR: 28: JSON parser does not support empty objects or arrays with whitespace In-Reply-To: <5mT-WaEzEcN495-ZfySzcQIGF0_Wvk1gPOcdxED6YtM=.38a46bab-485b-4575-8662-33283cf95a88@github.com> References: <5mT-WaEzEcN495-ZfySzcQIGF0_Wvk1gPOcdxED6YtM=.38a46bab-485b-4575-8662-33283cf95a88@github.com> Message-ID: This PR has now been reviewed by Robin Westberg via github.com - changes are approved. From duke at openjdk.java.net Fri Jun 28 13:55:24 2019 From: duke at openjdk.java.net (duke) Date: Fri, 28 Jun 2019 13:55:24 GMT Subject: git: openjdk/skara: 28: JSON parser does not support empty objects or arrays with whitespace Message-ID: <7828d26d-bf0d-4389-9c65-23161248984f@openjdk.java.net> Changeset: 3bdfd34e Author: Erik Helin Date: 2019-06-28 13:54:54 +0000 URL: http://git.openjdk.java.net/skara/commit/3bdfd34e 28: JSON parser does not support empty objects or arrays with whitespace Reviewed-by: rwestberg ! json/src/main/java/org/openjdk/skara/json/JSONParser.java ! json/src/test/java/org/openjdk/skara/json/JSONParserTests.java From duke at openjdk.java.net Fri Jun 28 14:02:58 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Fri, 28 Jun 2019 14:02:58 GMT Subject: RFR: 29: ModulePlugin removes compiler options Message-ID: Hi all, please review this small patch that ensures that the "module" Gradle plugin does not override the compiler arguments, but instead just add "--module-path". Thanks, Erik ---------------- Commits: - b5158ad1: 29: ModulePlugin removes compiler options Pull request: http://git.openjdk.java.net/skara/pull/13 Webrev: https://openjdk.github.io/cr/skara/13/webrev.00 Patch: http://git.openjdk.java.net/skara/pull/13.diff Fetch command: git fetch https://github.com/openjdk/skara.git b5158ad1:pr/13 From duke at openjdk.java.net Fri Jun 28 14:03:24 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Fri, 28 Jun 2019 14:03:24 GMT Subject: RFR: 29: ModulePlugin removes compiler options In-Reply-To: References: Message-ID: This PR has now been reviewed by Robin Westberg via github.com - changes are approved. From duke at openjdk.java.net Fri Jun 28 14:04:54 2019 From: duke at openjdk.java.net (duke) Date: Fri, 28 Jun 2019 14:04:54 GMT Subject: git: openjdk/skara: 29: ModulePlugin removes compiler options Message-ID: <52f112eb-b4bd-4f5f-903b-842e6f8e1b21@openjdk.java.net> Changeset: 68e0bee6 Author: Erik Helin Date: 2019-06-28 14:04:24 +0000 URL: http://git.openjdk.java.net/skara/commit/68e0bee6 29: ModulePlugin removes compiler options Reviewed-by: rwestberg ! buildSrc/module/src/main/java/org/openjdk/skara/gradle/module/ModulePlugin.java