RFR: SKARA-5 Remove pipeline support from process
Jeyvison Nascimento via github.com
duke at openjdk.java.net
Wed Jun 26 10:51:39 UTC 2019
On Wed, 26 Jun 2019 06:17:37 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:
> On Tue, 25 Jun 2019 00:49:17 GMT, Jeyvison Nascimento via github.com <duke at openjdk.java.net> wrote:
>
>> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Also, I think something must be changed in ProcessBuilder, am i right? And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :)
>>
>> ----------------
>>
>> Commits:
>> - cf6700bd: SKARA-5 Remove pipeline support from process
>>
>> Pull request:
>> https://github.com/openjdk/skara/pull/2
>>
>> Webrev:
>> https://openjdk.github.io/cr/skara/2/webrev.00
>>
>> Patch:
>> https://github.com/openjdk/skara/pull/2.diff
>>
>> Fetch command:
>> git fetch https://github.com/openjdk/skara.git cf6700bd:pr/2
>
>> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know.
>
> Hi! Thanks for the PR! Yes, this is indeed what we meant. (There's actually even a bit more complexity that can be removed, I'll add a more detailed review).
>
>> Also, I think something must be changed in ProcessBuilder, am i right?
>
> Do you mean java.lang.ProcessBuilder? That should not need any changes, perhaps I'm misunderstanding the question..
>
>> And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :)
>
> All tests pass when I run them in your branch, what kind of problem did you see?
@rwestberg Done :) Hope it's better now.
More information about the skara-dev
mailing list