From ngasson at openjdk.org Fri Nov 1 02:15:25 2019 From: ngasson at openjdk.org (Nick Gasson) Date: Fri, 1 Nov 2019 02:15:25 GMT Subject: [Rev 01] RFR: Add support for building on AArch64 In-Reply-To: References: Message-ID: <90dPdpV2mE7K7KRk36gy7eURvhunDfcBDNtaSoYq4zU=.1ad74fa0-b4b3-42b0-9ebf-42dd6e1512d7@github.com> The pull request has been updated with additional changes. ---------------- Added commits: - 0417521a: Correct value of os.arch on Mac Changes: - all: https://git.openjdk.java.net/skara/pull/231/files - new: https://git.openjdk.java.net/skara/pull/231/files/fd6a7291..0417521a Webrevs: - full: https://webrevs.openjdk.java.net/skara/231/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/231/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/231.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/231/head:pull/231 PR: https://git.openjdk.java.net/skara/pull/231 From nick.gasson at arm.com Fri Nov 1 02:48:40 2019 From: nick.gasson at arm.com (Nick Gasson) Date: Fri, 1 Nov 2019 10:48:40 +0800 Subject: RFR: Add support for building on AArch64 In-Reply-To: <46CAF6F9-FE22-43F6-83AB-F63B847BFE1B@oracle.com> References: <3f75d900-58e4-2d6b-24d0-67c5b1ecb0f3@arm.com> <46CAF6F9-FE22-43F6-83AB-F63B847BFE1B@oracle.com> Message-ID: <8008414e-168c-791e-2981-72fe13c8e05a@arm.com> Hi Robin, > >>> Webrev: https://webrevs.openjdk.java.net/skara/231/webrev.00 >> >> This 404s for me - is that a known issue? > > Sometimes it takes a little while to update I think, but usually it is quite fast. Looks like it is working now at least. > Yeah it works for me now, guess I was just impatient :-) Thanks, Nick From rwestberg at openjdk.org Fri Nov 1 07:47:09 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 1 Nov 2019 07:47:09 GMT Subject: RFR: Implement Jira authentication Message-ID: Hi all, Please review this change that implements Jira authentication using vault, as well as the remaining unimplemented methods that required authentication. Best regards, Robin ---------------- Commits: - 3411d75b: Implement Jira authentication using vault and remaining unimplemented methods Changes: https://git.openjdk.java.net/skara/pull/232/files Webrev: https://webrevs.openjdk.java.net/skara/232/webrev.00 Stats: 326 lines in 9 files changed: 299 ins; 3 del; 24 mod Patch: https://git.openjdk.java.net/skara/pull/232.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/232/head:pull/232 PR: https://git.openjdk.java.net/skara/pull/232 From erik.helin at oracle.com Mon Nov 4 13:27:37 2019 From: erik.helin at oracle.com (Erik Helin) Date: Mon, 4 Nov 2019 14:27:37 +0100 Subject: git webrev file list option and how to locate a webrev later on In-Reply-To: References: Message-ID: <53c79337-acc1-290a-4aa8-0416533defc8@oracle.com> On 10/25/19 10:28 PM, Phil Race wrote: > I can't find how to supply a list of files as the arg to git webrev. > Old webrev takes as an arg a file containing the files to consider > > This is a very useful feature? since > 1) I don't always want to include all files that are modified (although > ?probably this isn't so bad since I think it ignores uncommitted files) > 2) I like to control the order of files seen by reviewers to make it > logical > 3) I sometimes need to use the "old-file new-file" > > Is this a planned but as yet unimplemented feature or am I missing > something ? It hasn't been implemented, I wasn't aware of this webrev.ksh feature. I filed: https://bugs.openjdk.java.net/browse/SKARA-146 > And, something I haven't figured out at all, is how I would do even the > supported > options via github .. This will unfortunately not be possible, the webrevs are generated automatically and there is no natural way to support additional webrev options. > Also, the RFR cites the webrev location like this : > > https://webrevs.openjdk.java.net/jfx/24/webrev.00 > > > but it is redirected to > > https://openjdk.github.io/cr/jfx/24/webrev.00/ > > So far as I can see the only identifying piece of information here is the > pull request number. If I want to find the webrev for a particular bug, > how can I easily(!) do it ? We plan on adding links from an issue (bug/enhancement) to a PR, see the following issue for how this will look: https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69 So you will just be able to click the PR link in the issue :) Thanks, Erik > -phil. From ehelin Mon Nov 4 09:11:25 2019 From: ehelin (Erik Helin) Date: Mon, 4 Nov 2019 09:11:25 GMT Subject: [Approved] RFR: Adjust mime encoding In-Reply-To: References: Message-ID: <4f4orMFn9PHXCtytlJk9KlhoePV8ljX9JZnsoho9L3w=.405066af-8dd9-4ae8-83d5-b6bc62a22344@github.com> On Tue, 29 Oct 2019 12:47:57 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that adjusts the MIME encoding to better adhere to RFC1342. > > Best regards, > Robin > > ---------------- > > Commits: > - edea959c: Adjust mime encoding > > Changes: https://git.openjdk.java.net/skara/pull/230/files > Webrev: https://webrevs.openjdk.java.net/skara/230/webrev.00 > Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/230.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/230/head:pull/230 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/230 From ehelin at openjdk.org Mon Nov 4 10:06:03 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 4 Nov 2019 10:06:03 GMT Subject: [Rev 01] RFR: Add support for building on AArch64 In-Reply-To: <90dPdpV2mE7K7KRk36gy7eURvhunDfcBDNtaSoYq4zU=.1ad74fa0-b4b3-42b0-9ebf-42dd6e1512d7@github.com> References: <90dPdpV2mE7K7KRk36gy7eURvhunDfcBDNtaSoYq4zU=.1ad74fa0-b4b3-42b0-9ebf-42dd6e1512d7@github.com> Message-ID: On Fri, 1 Nov 2019 02:15:25 GMT, Nick Gasson wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - 0417521a: Correct value of os.arch on Mac > > Changes: > - all: https://git.openjdk.java.net/skara/pull/231/files > - new: https://git.openjdk.java.net/skara/pull/231/files/fd6a7291..0417521a > > Webrevs: > - full: https://webrevs.openjdk.java.net/skara/231/webrev.01 > - incr: https://webrevs.openjdk.java.net/skara/231/webrev.00-01 > > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/231.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/231/head:pull/231 cli/build.gradle line 103: > 102: sha256 = project.jdkSha256 > 103: } > 104: } This is unfortunately not how the `jdk` property of the `images` target is meant to be used. The JDK fully supports cross-platform linking, something we make use of in Skara. This means if you build the `:cli:images` target on a Linux x64 machine then you will actually get fully working Skara distributions for Windows, macOS *and* Linux (all x64), since we are downloading the JDKs for macOS, Windows and Linux. With this patch we only get Linux x64 distributions. Fortunately the JDK not only supports cross-jlink across operating system, it also supports cross-linking across CPU architectures. So I would prefer to be able to write: linux_x64 { modules = ext.modules launchers = ext.launchers man = 'cli/resources/man' bundles = ['zip', 'tar.gz'] jdk { url = 'https://download.java.net/java/GA/jdk12/GPL/openjdk-12_linux-x64_bin.tar.gz' sha256 = 'b43bc15f4934f6d321170419f2c24451486bc848a2179af5e49d10721438dd56' } } linux_aarch64 { modules = ext.modules launchers = ext.launchers man = 'cli/resources/man' bundles = ['zip', 'tar.gz'] jdk { url = 'https://github.com/AdoptOpenJDK/openjdk12-binaries/releases/download/jdk-12.0.2%2B10/OpenJDK12U-jdk_aarch64_linux_hotspot_12.0.2_10.tar.gz' sha256 = ''855f046afc5a5230ad6da45a5c811194267acd1748f16b648bfe5710703fe8c' } } This way we will always produce Linux AArch64 images on Linux x64 hosts. To get this to work you need to do some minor changes to `ImagesPlugin.java` (and you might have to do some adjustments to `LinkTask.java`). Do you want to take a stab at that? Or do you want me to try and hack something together? gradlew line 105: > 104: ;; > 105: Darwin ) > 106: JDK_URL="${JDK_MACOS_URL}" This part looks good p Hi Nick, first of all, thanks for contributing! We definitely want to support building the Skara tooling on AArch64, but please see my inline comments, it seems that you may have misinterpreted how the `images` target is meant to work. Thanks! Erik ---------------- Disapproved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/231 From erik.helin at oracle.com Mon Nov 4 15:00:17 2019 From: erik.helin at oracle.com (Erik Helin) Date: Mon, 4 Nov 2019 16:00:17 +0100 Subject: Minor issues with STMP server Message-ID: <5ef82949-b9d4-17aa-49c2-9021080e6ecb@oracle.com> Hi all, just wanted to let you know that we currently are experiencing minor issues with our SMTP server, so please disregard any emails sent directly to you that you did not expect. We have almost fixed the issue and will send an update once everything has been resolved. Thanks, Erik From ngasson at openjdk.org Mon Nov 4 13:21:05 2019 From: ngasson at openjdk.org (Nick Gasson) Date: Mon, 4 Nov 2019 13:21:05 GMT Subject: [Rev 01] RFR: Add support for building on AArch64 In-Reply-To: References: <90dPdpV2mE7K7KRk36gy7eURvhunDfcBDNtaSoYq4zU=.1ad74fa0-b4b3-42b0-9ebf-42dd6e1512d7@github.com> Message-ID: On Mon, 4 Nov 2019 10:06:03 GMT, Erik Helin wrote: > On Fri, 1 Nov 2019 02:15:25 GMT, Nick Gasson wrote: > >> The pull request has been updated with additional changes. >> >> ---------------- >> >> Added commits: >> - 0417521a: Correct value of os.arch on Mac >> >> Changes: >> - all: https://git.openjdk.java.net/skara/pull/231/files >> - new: https://git.openjdk.java.net/skara/pull/231/files/fd6a7291..0417521a >> >> Webrevs: >> - full: https://webrevs.openjdk.java.net/skara/231/webrev.01 >> - incr: https://webrevs.openjdk.java.net/skara/231/webrev.00-01 >> >> Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod >> Patch: https://git.openjdk.java.net/skara/pull/231.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/231/head:pull/231 > > cli/build.gradle line 103: > >> 102: sha256 = project.jdkSha256 >> 103: } >> 104: } > > This is unfortunately not how the `jdk` property of the `images` target is meant to be used. > > The JDK fully supports cross-platform linking, something we make use of in Skara. This means if you build the `:cli:images` target on a Linux x64 machine then you will actually get fully working Skara distributions for Windows, macOS *and* Linux (all x64), since we are downloading the JDKs for macOS, Windows and Linux. With this patch we only get Linux x64 distributions. > > Fortunately the JDK not only supports cross-jlink across operating system, it also supports cross-linking across CPU architectures. So I would prefer to be able to write: > > linux_x64 { > modules = ext.modules > launchers = ext.launchers > man = 'cli/resources/man' > bundles = ['zip', 'tar.gz'] > jdk { > url = 'https://download.java.net/java/GA/jdk12/GPL/openjdk-12_linux-x64_bin.tar.gz' > sha256 = 'b43bc15f4934f6d321170419f2c24451486bc848a2179af5e49d10721438dd56' > } > } > > linux_aarch64 { > modules = ext.modules > launchers = ext.launchers > man = 'cli/resources/man' > bundles = ['zip', 'tar.gz'] > jdk { > url = 'https://github.com/AdoptOpenJDK/openjdk12-binaries/releases/download/jdk-12.0.2%2B10/OpenJDK12U-jdk_aarch64_linux_hotspot_12.0.2_10.tar.gz' > sha256 = ''855f046afc5a5230ad6da45a5c811194267acd1748f16b648bfe5710703fe8c' > } > } > > This way we will always produce Linux AArch64 images on Linux x64 hosts. To get this to work you need to do some minor changes to `ImagesPlugin.java` (and you might have to do some adjustments to `LinkTask.java`). Do you want to take a stab at that? Or do you want me to try and hack something together? > > gradlew line 105: > >> 104: ;; >> 105: Darwin ) >> 106: JDK_URL="${JDK_MACOS_URL}" > > This part looks good p > > Hi Nick, > > first of all, thanks for contributing! We definitely want to support building the Skara tooling on AArch64, but please see my inline comments, it seems that you may have misinterpreted how the `images` target is meant to work. > > Thanks! > Erik > > ---------------- > > Disapproved by ehelin (Reviewer). Ah ok, I see that now. I'm happy to have a go at redoing it. PR: https://git.openjdk.java.net/skara/pull/231 From ehelin at openjdk.org Mon Nov 4 10:30:15 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 4 Nov 2019 10:30:15 GMT Subject: [Approved] RFR: Implement Jira authentication In-Reply-To: References: Message-ID: <7LAVg4Sz70XhNyWJ0Ea-G-B9oGgOVgYFnLYP3TM-XnM=.bd6b16b7-a9a2-419b-a1e9-794b215633fb@github.com> On Fri, 1 Nov 2019 07:47:09 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that implements Jira authentication using vault, as well as the remaining unimplemented methods that required authentication. > > Best regards, > Robin > > ---------------- > > Commits: > - 3411d75b: Implement Jira authentication using vault and remaining unimplemented methods > > Changes: https://git.openjdk.java.net/skara/pull/232/files > Webrev: https://webrevs.openjdk.java.net/skara/232/webrev.00 > Stats: 326 lines in 9 files changed: 299 ins; 3 del; 24 mod > Patch: https://git.openjdk.java.net/skara/pull/232.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/232/head:pull/232 Wow, this looks great Robin, nice work! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/232 From robin.westberg at oracle.com Mon Nov 4 15:30:35 2019 From: robin.westberg at oracle.com (Robin Westberg) Date: Mon, 4 Nov 2019 16:30:35 +0100 Subject: Minor issues with STMP server In-Reply-To: <5ef82949-b9d4-17aa-49c2-9021080e6ecb@oracle.com> References: <5ef82949-b9d4-17aa-49c2-9021080e6ecb@oracle.com> Message-ID: <0E291014-CF17-406F-B858-DAA747EBFA91@oracle.com> Hi all, Things should be back to normal and the backlog processed. Best regards, Robin > On 4 Nov 2019, at 16:00, Erik Helin wrote: > > Hi all, > > just wanted to let you know that we currently are experiencing minor issues with our SMTP server, so please disregard any emails sent directly to you that you did not expect. > > We have almost fixed the issue and will send an update once everything has been resolved. > > Thanks, > Erik From rwestberg at openjdk.org Mon Nov 4 15:34:44 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 4 Nov 2019 15:34:44 GMT Subject: [Integrated] RFR: Adjust mime encoding In-Reply-To: References: Message-ID: Changeset: 7984f332 Author: Robin Westberg Date: 2019-11-04 15:34:28 +0000 URL: https://git.openjdk.java.net/skara/commit/7984f332 Adjust mime encoding Reviewed-by: ehelin ! email/src/main/java/org/openjdk/skara/email/MimeText.java ! email/src/test/java/org/openjdk/skara/email/MimeTextTests.java From rwestberg at openjdk.org Tue Nov 5 06:55:44 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 06:55:44 GMT Subject: [Rev 01] RFR: Implement Jira authentication In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 65c80d43: Fix remaining unimplemented method Changes: - all: https://git.openjdk.java.net/skara/pull/232/files - new: https://git.openjdk.java.net/skara/pull/232/files/3411d75b..65c80d43 Webrevs: - full: https://webrevs.openjdk.java.net/skara/232/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/232/webrev.00-01 Stats: 12 lines in 2 files changed: 11 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/232.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/232/head:pull/232 PR: https://git.openjdk.java.net/skara/pull/232 From rwestberg at openjdk.org Tue Nov 5 07:06:08 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 07:06:08 GMT Subject: [Rev 02] RFR: Implement Jira authentication In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - c046c59d: Now with a working test Changes: - all: https://git.openjdk.java.net/skara/pull/232/files - new: https://git.openjdk.java.net/skara/pull/232/files/65c80d43..c046c59d Webrevs: - full: https://webrevs.openjdk.java.net/skara/232/webrev.02 - incr: https://webrevs.openjdk.java.net/skara/232/webrev.01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/232.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/232/head:pull/232 PR: https://git.openjdk.java.net/skara/pull/232 From rwestberg at openjdk.org Tue Nov 5 08:07:38 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 08:07:38 GMT Subject: RFR: 147: Update the "Changes required" message Message-ID: Hi all, Please review this change that updates the message when a reviewer requests changes. Best regards, Robin ---------------- Commits: - f0213c3d: Updated the disapproval message Changes: https://git.openjdk.java.net/skara/pull/233/files Webrev: https://webrevs.openjdk.java.net/skara/233/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-147 Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/233.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/233/head:pull/233 PR: https://git.openjdk.java.net/skara/pull/233 From ehelin at openjdk.org Tue Nov 5 08:53:07 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 5 Nov 2019 08:53:07 GMT Subject: [Approved] RFR: 147: Update the "Changes required" message In-Reply-To: References: Message-ID: <3vywuSunWXRQMyIdyzdD9rMnlgiRVV7Cy2wQESyAddg=.618708dc-832c-4320-aef3-d177dbdcc488@github.com> On Tue, 5 Nov 2019 08:07:38 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that updates the message when a reviewer requests changes. > > Best regards, > Robin > > ---------------- > > Commits: > - f0213c3d: Updated the disapproval message > > Changes: https://git.openjdk.java.net/skara/pull/233/files > Webrev: https://webrevs.openjdk.java.net/skara/233/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-147 > Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod > Patch: https://git.openjdk.java.net/skara/pull/233.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/233/head:pull/233 Looks good, thanks! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/233 From rwestberg at openjdk.org Tue Nov 5 09:21:21 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 09:21:21 GMT Subject: RFR: Support the "neutral" check conclusion Message-ID: <_0o5vv2KPgCDIDYX2NcGmvvHwKlHaXc7OiGJU1PkVHU=.76d94f0c-99de-4da8-995c-2976edd767ee@github.com> Hi all, Please review this minor change that adds support for the "neutral" check conclusion that can be returned by the GitHub check API. Best regards, Robin ---------------- Commits: - fe87b631: Support the "neutral" check conclusion Changes: https://git.openjdk.java.net/skara/pull/234/files Webrev: https://webrevs.openjdk.java.net/skara/234/webrev.00 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/234.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/234/head:pull/234 PR: https://git.openjdk.java.net/skara/pull/234 From ehelin at openjdk.org Tue Nov 5 09:25:55 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 5 Nov 2019 09:25:55 GMT Subject: RFR: Support the "neutral" check conclusion In-Reply-To: <_0o5vv2KPgCDIDYX2NcGmvvHwKlHaXc7OiGJU1PkVHU=.76d94f0c-99de-4da8-995c-2976edd767ee@github.com> References: <_0o5vv2KPgCDIDYX2NcGmvvHwKlHaXc7OiGJU1PkVHU=.76d94f0c-99de-4da8-995c-2976edd767ee@github.com> Message-ID: On Tue, 5 Nov 2019 09:21:21 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that adds support for the "neutral" check conclusion that can be returned by the GitHub check API. > > Best regards, > Robin > > ---------------- > > Commits: > - fe87b631: Support the "neutral" check conclusion > > Changes: https://git.openjdk.java.net/skara/pull/234/files > Webrev: https://webrevs.openjdk.java.net/skara/234/webrev.00 > Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/234.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/234/head:pull/234 forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java line 319: > 318: break; > 319: case "failure": > 320: case "neutral": Suggestion: case "failure": // fallthrough PR: https://git.openjdk.java.net/skara/pull/234 From ehelin at openjdk.org Tue Nov 5 09:25:56 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 5 Nov 2019 09:25:56 GMT Subject: [Approved] RFR: Support the "neutral" check conclusion In-Reply-To: <_0o5vv2KPgCDIDYX2NcGmvvHwKlHaXc7OiGJU1PkVHU=.76d94f0c-99de-4da8-995c-2976edd767ee@github.com> References: <_0o5vv2KPgCDIDYX2NcGmvvHwKlHaXc7OiGJU1PkVHU=.76d94f0c-99de-4da8-995c-2976edd767ee@github.com> Message-ID: On Tue, 5 Nov 2019 09:21:21 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that adds support for the "neutral" check conclusion that can be returned by the GitHub check API. > > Best regards, > Robin > > ---------------- > > Commits: > - fe87b631: Support the "neutral" check conclusion > > Changes: https://git.openjdk.java.net/skara/pull/234/files > Webrev: https://webrevs.openjdk.java.net/skara/234/webrev.00 > Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/234.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/234/head:pull/234 Looks good, how about adding a fallthrough comment? ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/234 From rwestberg at openjdk.org Tue Nov 5 09:28:09 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 09:28:09 GMT Subject: [Rev 01] RFR: Support the "neutral" check conclusion In-Reply-To: <_0o5vv2KPgCDIDYX2NcGmvvHwKlHaXc7OiGJU1PkVHU=.76d94f0c-99de-4da8-995c-2976edd767ee@github.com> References: <_0o5vv2KPgCDIDYX2NcGmvvHwKlHaXc7OiGJU1PkVHU=.76d94f0c-99de-4da8-995c-2976edd767ee@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 93108d3c: Fallthrough comment Changes: - all: https://git.openjdk.java.net/skara/pull/234/files - new: https://git.openjdk.java.net/skara/pull/234/files/fe87b631..93108d3c Webrevs: - full: https://webrevs.openjdk.java.net/skara/234/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/234/webrev.00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/234.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/234/head:pull/234 PR: https://git.openjdk.java.net/skara/pull/234 From rwestberg at openjdk.org Tue Nov 5 09:36:44 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 09:36:44 GMT Subject: [Rev 02] RFR: Support the "neutral" check conclusion In-Reply-To: <_0o5vv2KPgCDIDYX2NcGmvvHwKlHaXc7OiGJU1PkVHU=.76d94f0c-99de-4da8-995c-2976edd767ee@github.com> References: <_0o5vv2KPgCDIDYX2NcGmvvHwKlHaXc7OiGJU1PkVHU=.76d94f0c-99de-4da8-995c-2976edd767ee@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 78caffe1: Support the "neutral" check conclusion Changes: - all: https://git.openjdk.java.net/skara/pull/234/files - new: https://git.openjdk.java.net/skara/pull/234/files/93108d3c..78caffe1 Webrevs: - full: https://webrevs.openjdk.java.net/skara/234/webrev.02 - incr: https://webrevs.openjdk.java.net/skara/234/webrev.01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/234.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/234/head:pull/234 PR: https://git.openjdk.java.net/skara/pull/234 From rwestberg at openjdk.org Tue Nov 5 09:38:23 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 09:38:23 GMT Subject: [Rev 03] RFR: Support the "neutral" check conclusion In-Reply-To: <_0o5vv2KPgCDIDYX2NcGmvvHwKlHaXc7OiGJU1PkVHU=.76d94f0c-99de-4da8-995c-2976edd767ee@github.com> References: <_0o5vv2KPgCDIDYX2NcGmvvHwKlHaXc7OiGJU1PkVHU=.76d94f0c-99de-4da8-995c-2976edd767ee@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - fff38274: Support the "neutral" check conclusion Changes: - all: https://git.openjdk.java.net/skara/pull/234/files - new: https://git.openjdk.java.net/skara/pull/234/files/78caffe1..fff38274 Webrevs: - full: https://webrevs.openjdk.java.net/skara/234/webrev.03 - incr: https://webrevs.openjdk.java.net/skara/234/webrev.02-03 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/234.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/234/head:pull/234 PR: https://git.openjdk.java.net/skara/pull/234 From duke at openjdk.java.net Tue Nov 5 09:38:55 2019 From: duke at openjdk.java.net (duke) Date: Tue, 5 Nov 2019 09:38:55 GMT Subject: git: openjdk/skara: Support the "neutral" check conclusion Message-ID: <58d69ce3-7e13-4b83-a5cb-160eaa8efbb8@openjdk.java.net> Changeset: 17f2684d Author: Robin Westberg Committer: Robin Westberg Date: 2019-11-05 10:37:13 +0000 URL: https://git.openjdk.java.net/skara/commit/17f2684d Support the "neutral" check conclusion Reviewed-by: ehelin ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java From rwestberg at openjdk.org Tue Nov 5 10:20:30 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 10:20:30 GMT Subject: RFR: Discard duplicate checks Message-ID: <0LJ9e5kI2njkJKrs6MzfUyKQh_4sEq8_4OpgS3ZdQZg=.3d1dabbf-31a1-440a-9862-b0c3dbb33737@github.com> Hi all, Please review this minor change that discards multiple GitHub checks with the same name for the same commit. Skara never generates these, but they may appear from external sources. Best regards, Robin ---------------- Commits: - 2108da84: Discard duplicates Changes: https://git.openjdk.java.net/skara/pull/235/files Webrev: https://webrevs.openjdk.java.net/skara/235/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/235.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/235/head:pull/235 PR: https://git.openjdk.java.net/skara/pull/235 From ehelin at openjdk.org Tue Nov 5 10:21:31 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 5 Nov 2019 10:21:31 GMT Subject: [Approved] RFR: Discard duplicate checks In-Reply-To: <0LJ9e5kI2njkJKrs6MzfUyKQh_4sEq8_4OpgS3ZdQZg=.3d1dabbf-31a1-440a-9862-b0c3dbb33737@github.com> References: <0LJ9e5kI2njkJKrs6MzfUyKQh_4sEq8_4OpgS3ZdQZg=.3d1dabbf-31a1-440a-9862-b0c3dbb33737@github.com> Message-ID: <8J0FPA14aSP8TEvOXdAh6eJD9payOmvEIKXsDfYN1No=.3b0f4401-0a8f-4f2d-8c0e-bd904ffe7d2c@github.com> On Tue, 5 Nov 2019 10:20:30 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that discards multiple GitHub checks with the same name for the same commit. Skara never generates these, but they may appear from external sources. > > Best regards, > Robin > > ---------------- > > Commits: > - 2108da84: Discard duplicates > > Changes: https://git.openjdk.java.net/skara/pull/235/files > Webrev: https://webrevs.openjdk.java.net/skara/235/webrev.00 > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/235.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/235/head:pull/235 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/235 From rwestberg at openjdk.org Tue Nov 5 10:25:06 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 10:25:06 GMT Subject: [Rev 01] RFR: Discard duplicate checks In-Reply-To: <0LJ9e5kI2njkJKrs6MzfUyKQh_4sEq8_4OpgS3ZdQZg=.3d1dabbf-31a1-440a-9862-b0c3dbb33737@github.com> References: <0LJ9e5kI2njkJKrs6MzfUyKQh_4sEq8_4OpgS3ZdQZg=.3d1dabbf-31a1-440a-9862-b0c3dbb33737@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - f68d1fb3: Discard duplicate checks Changes: - all: https://git.openjdk.java.net/skara/pull/235/files - new: https://git.openjdk.java.net/skara/pull/235/files/2108da84..f68d1fb3 Webrevs: - full: https://webrevs.openjdk.java.net/skara/235/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/235/webrev.00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/235.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/235/head:pull/235 PR: https://git.openjdk.java.net/skara/pull/235 From duke at openjdk.java.net Tue Nov 5 10:25:16 2019 From: duke at openjdk.java.net (duke) Date: Tue, 5 Nov 2019 10:25:16 GMT Subject: git: openjdk/skara: Discard duplicate checks Message-ID: <4ecc61d5-2b4c-4857-a80b-329a7c3f6552@openjdk.java.net> Changeset: 8c37b496 Author: Robin Westberg Committer: Robin Westberg Date: 2019-11-05 11:24:10 +0000 URL: https://git.openjdk.java.net/skara/commit/8c37b496 Discard duplicate checks Reviewed-by: ehelin ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java From rwestberg at openjdk.org Tue Nov 5 10:37:04 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 10:37:04 GMT Subject: [Integrated] RFR: Implement Jira authentication In-Reply-To: References: Message-ID: <4a4c17d7-f7d8-4ae2-863a-6e795f27427c@openjdk.org> Changeset: 0e3e7114 Author: Robin Westberg Date: 2019-11-05 10:36:46 +0000 URL: https://git.openjdk.java.net/skara/commit/0e3e7114 Implement Jira authentication Reviewed-by: ehelin ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraHost.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssueTrackerFactory.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java + issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraVault.java ! issuetracker/src/test/java/org/openjdk/skara/issuetracker/IssueTrackerTests.java ! test/src/main/java/org/openjdk/skara/test/HostCredentials.java ! test/src/main/java/org/openjdk/skara/test/IssueData.java ! test/src/main/java/org/openjdk/skara/test/TestIssue.java From rwestberg at openjdk.org Tue Nov 5 10:42:15 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 10:42:15 GMT Subject: [Integrated] RFR: 147: Update the "Changes required" message In-Reply-To: References: Message-ID: <2e93a85b-9a3f-47a4-a0f7-2af5d8f7ba2d@openjdk.org> Changeset: 0d73a1f8 Author: Robin Westberg Date: 2019-11-05 10:41:58 +0000 URL: https://git.openjdk.java.net/skara/commit/0d73a1f8 147: Update the "Changes required" message Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From rwestberg at openjdk.org Tue Nov 5 13:11:18 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 13:11:18 GMT Subject: RFR: 149: Improve formatting of bridged emails Message-ID: Hi all, Please review this change that improves the formatting of mailing list messages that are posted to PRs. Best regards, Robin ---------------- Commits: - 6b8ddc84: Improve formatting of bridged mailing list messages Changes: https://git.openjdk.java.net/skara/pull/236/files Webrev: https://webrevs.openjdk.java.net/skara/236/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-149 Stats: 21 lines in 4 files changed: 13 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/skara/pull/236.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/236/head:pull/236 PR: https://git.openjdk.java.net/skara/pull/236 From ehelin at openjdk.org Tue Nov 5 13:15:24 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 5 Nov 2019 13:15:24 GMT Subject: RFR: Add support for offline and local builds Message-ID: Hi all, this patch adds much improved support for both _offline_ and _local_ builds. We are currently downloading both JDK and Gradle distributions for the most common platforms (GNU/Linux x64, macOS x64 and Windows x64), but this scheme does not scale to multiple other operating systems and/or CPU architectures. I have therefore extended the `images` plugin to support a `local` image which uses the JDK that is currently executing Gradle for producing the jlinked image. I also added support for fully offline builds for those want to supply both a JDK and Gradle themselves and ensure that the build does not download anything. Thanks, Erik ## Testing - Tested multiple variants of builds, including local, offline and default builds ---------------- Commits: - 66a6b56b: Added support for offline and local builds Changes: https://git.openjdk.java.net/skara/pull/237/files Webrev: https://webrevs.openjdk.java.net/skara/237/webrev.00 Stats: 300 lines in 10 files changed: 207 ins; 22 del; 71 mod Patch: https://git.openjdk.java.net/skara/pull/237.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 PR: https://git.openjdk.java.net/skara/pull/237 From ehelin at openjdk.org Tue Nov 5 13:17:44 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 5 Nov 2019 13:17:44 GMT Subject: RFR: Add support for building on AArch64 In-Reply-To: References: Message-ID: On Thu, 31 Oct 2019 10:48:09 GMT, Nick Gasson wrote: > I'm working with OpenJDK on Arm machines so I want to be able to run > `git webrev' etc. there. At the moment we can't build the Skara tools on > AArch64 due to an implicit assumption that Linux means X86. I tried to > refactor the build scripts support multiple architectures on Linux. Only > X86 and AArch64 for now but should be trivial to add others. > > Using the AdoptOpenJDK AArch64 binary build as there are no prebuilt > binaries for AArch64 on java.net. > > Currently there are several Gradle sub-projects that use the image > plugin to build Java images, and each specifies the URL and SHA265 of > the binary JDK to use. Changed the top-level Gradle script to parse > deps.env and select the JDK source based on the OS and architecture > system properties. This gets rid of the duplicated URLs but now each > image { .. } block has a redundant section like the following for each > OS: > > jdk { > url = project.jdkUrl > sha256 = project.jdkSha256 > } > > So maybe the plugin should be tweaked to move this up into the image {} > block itself? > > ---------------- > > Commits: > - fd6a7291: Add support for building on AArch64 > > Changes: https://git.openjdk.java.net/skara/pull/231/files > Webrev: https://webrevs.openjdk.java.net/skara/231/webrev.00 > Stats: 85 lines in 5 files changed: 69 ins; 3 del; 13 mod > Patch: https://git.openjdk.java.net/skara/pull/231.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/231/head:pull/231 @nick-arm I thought some more about the build today and ended up implementing something a bit more scalable and future-proof than just adding ARM support on Linux. Please have a look PR #237 and see what you think. If #237 is fine with you, can I go ahead and close this pull request? Thanks, Erik PR: https://git.openjdk.java.net/skara/pull/231 From ehelin at openjdk.org Tue Nov 5 13:19:35 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 5 Nov 2019 13:19:35 GMT Subject: RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: <_js1Gy_aB0XV9Saa1kfbklDD0x2KEp1ahn8go5MlpOM=.b2d56049-0bc7-4235-b16d-c11b55f5b2da@github.com> On Tue, 5 Nov 2019 13:15:24 GMT, Erik Helin wrote: > Hi all, > > this patch adds much improved support for both _offline_ and _local_ builds. We are currently downloading both JDK and Gradle distributions for the most common platforms (GNU/Linux x64, macOS x64 and Windows x64), but this scheme does not scale to multiple other operating systems and/or CPU architectures. I have therefore extended the `images` plugin to support a `local` image which uses the JDK that is currently executing Gradle for producing the jlinked image. > > I also added support for fully offline builds for those want to supply both a JDK and Gradle themselves and ensure that the build does not download anything. > > Thanks, > Erik > > ## Testing > - Tested multiple variants of builds, including local, offline and default builds > > ---------------- > > Commits: > - 66a6b56b: Added support for offline and local builds > > Changes: https://git.openjdk.java.net/skara/pull/237/files > Webrev: https://webrevs.openjdk.java.net/skara/237/webrev.00 > Stats: 300 lines in 10 files changed: 207 ins; 22 del; 71 mod > Patch: https://git.openjdk.java.net/skara/pull/237.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 @nick-arm could you please try this PR out and see if it works for you? PR: https://git.openjdk.java.net/skara/pull/237 From ehelin at openjdk.org Tue Nov 5 13:20:24 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 5 Nov 2019 13:20:24 GMT Subject: RFR: Add support for offline and local builds In-Reply-To: <_js1Gy_aB0XV9Saa1kfbklDD0x2KEp1ahn8go5MlpOM=.b2d56049-0bc7-4235-b16d-c11b55f5b2da@github.com> References: <_js1Gy_aB0XV9Saa1kfbklDD0x2KEp1ahn8go5MlpOM=.b2d56049-0bc7-4235-b16d-c11b55f5b2da@github.com> Message-ID: On Tue, 5 Nov 2019 13:19:35 GMT, Erik Helin wrote: > On Tue, 5 Nov 2019 13:15:24 GMT, Erik Helin wrote: > >> Hi all, >> >> this patch adds much improved support for both _offline_ and _local_ builds. We are currently downloading both JDK and Gradle distributions for the most common platforms (GNU/Linux x64, macOS x64 and Windows x64), but this scheme does not scale to multiple other operating systems and/or CPU architectures. I have therefore extended the `images` plugin to support a `local` image which uses the JDK that is currently executing Gradle for producing the jlinked image. >> >> I also added support for fully offline builds for those want to supply both a JDK and Gradle themselves and ensure that the build does not download anything. >> >> Thanks, >> Erik >> >> ## Testing >> - Tested multiple variants of builds, including local, offline and default builds >> >> ---------------- >> >> Commits: >> - 66a6b56b: Added support for offline and local builds >> >> Changes: https://git.openjdk.java.net/skara/pull/237/files >> Webrev: https://webrevs.openjdk.java.net/skara/237/webrev.00 >> Stats: 300 lines in 10 files changed: 207 ins; 22 del; 71 mod >> Patch: https://git.openjdk.java.net/skara/pull/237.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 > > @nick-arm could you please try this PR out and see if it works for you? @JornVernee could you give this a spin on Windows and see if it works? PR: https://git.openjdk.java.net/skara/pull/237 From rwestberg at openjdk.org Tue Nov 5 13:21:31 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 13:21:31 GMT Subject: [Rev 01] RFR: 149: Improve formatting of bridged emails In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 348c6d3f: Fix tests Changes: - all: https://git.openjdk.java.net/skara/pull/236/files - new: https://git.openjdk.java.net/skara/pull/236/files/6b8ddc84..348c6d3f Webrevs: - full: https://webrevs.openjdk.java.net/skara/236/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/236/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/SKARA-149 Stats: 27 lines in 1 file changed: 18 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/236.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/236/head:pull/236 PR: https://git.openjdk.java.net/skara/pull/236 From rwestberg at openjdk.org Tue Nov 5 13:29:54 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 13:29:54 GMT Subject: RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: On Tue, 5 Nov 2019 13:15:24 GMT, Erik Helin wrote: > Hi all, > > this patch adds much improved support for both _offline_ and _local_ builds. We are currently downloading both JDK and Gradle distributions for the most common platforms (GNU/Linux x64, macOS x64 and Windows x64), but this scheme does not scale to multiple other operating systems and/or CPU architectures. I have therefore extended the `images` plugin to support a `local` image which uses the JDK that is currently executing Gradle for producing the jlinked image. > > I also added support for fully offline builds for those want to supply both a JDK and Gradle themselves and ensure that the build does not download anything. > > Thanks, > Erik > > ## Testing > - Tested multiple variants of builds, including local, offline and default builds > > ---------------- > > Commits: > - 66a6b56b: Added support for offline and local builds > > Changes: https://git.openjdk.java.net/skara/pull/237/files > Webrev: https://webrevs.openjdk.java.net/skara/237/webrev.00 > Stats: 300 lines in 10 files changed: 207 ins; 22 del; 71 mod > Patch: https://git.openjdk.java.net/skara/pull/237.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 README.md line 73: > 72: ### Offline builds > 73: > 74: If you don't want the build to automatically download any depenendcies, then Suggestion: If you don't want the build to automatically download any dependencies, then README.md line 79: > 78: - Gradle 5.6.2 or later > 79: > 80: To create a build then run the command Suggestion: To create a build then run the command: PR: https://git.openjdk.java.net/skara/pull/237 From rwestberg at openjdk.org Tue Nov 5 13:29:55 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 5 Nov 2019 13:29:55 GMT Subject: [Approved] RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: On Tue, 5 Nov 2019 13:15:24 GMT, Erik Helin wrote: > Hi all, > > this patch adds much improved support for both _offline_ and _local_ builds. We are currently downloading both JDK and Gradle distributions for the most common platforms (GNU/Linux x64, macOS x64 and Windows x64), but this scheme does not scale to multiple other operating systems and/or CPU architectures. I have therefore extended the `images` plugin to support a `local` image which uses the JDK that is currently executing Gradle for producing the jlinked image. > > I also added support for fully offline builds for those want to supply both a JDK and Gradle themselves and ensure that the build does not download anything. > > Thanks, > Erik > > ## Testing > - Tested multiple variants of builds, including local, offline and default builds > > ---------------- > > Commits: > - 66a6b56b: Added support for offline and local builds > > Changes: https://git.openjdk.java.net/skara/pull/237/files > Webrev: https://webrevs.openjdk.java.net/skara/237/webrev.00 > Stats: 300 lines in 10 files changed: 207 ins; 22 del; 71 mod > Patch: https://git.openjdk.java.net/skara/pull/237.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 Looks good, I think this approach sounds reasonable. ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/237 From jvernee at openjdk.org Tue Nov 5 15:29:44 2019 From: jvernee at openjdk.org (Jorn Vernee) Date: Tue, 5 Nov 2019 15:29:44 GMT Subject: RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: On Tue, 5 Nov 2019 13:29:54 GMT, Robin Westberg wrote: > On Tue, 5 Nov 2019 13:15:24 GMT, Erik Helin wrote: > >> Hi all, >> >> this patch adds much improved support for both _offline_ and _local_ builds. We are currently downloading both JDK and Gradle distributions for the most common platforms (GNU/Linux x64, macOS x64 and Windows x64), but this scheme does not scale to multiple other operating systems and/or CPU architectures. I have therefore extended the `images` plugin to support a `local` image which uses the JDK that is currently executing Gradle for producing the jlinked image. >> >> I also added support for fully offline builds for those want to supply both a JDK and Gradle themselves and ensure that the build does not download anything. >> >> Thanks, >> Erik >> >> ## Testing >> - Tested multiple variants of builds, including local, offline and default builds >> >> ---------------- >> >> Commits: >> - 66a6b56b: Added support for offline and local builds >> >> Changes: https://git.openjdk.java.net/skara/pull/237/files >> Webrev: https://webrevs.openjdk.java.net/skara/237/webrev.00 >> Stats: 300 lines in 10 files changed: 207 ins; 22 del; 71 mod >> Patch: https://git.openjdk.java.net/skara/pull/237.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 > > README.md line 73: > >> 72: ### Offline builds >> 73: >> 74: If you don't want the build to automatically download any depenendcies, then > > Suggestion: > > If you don't want the build to automatically download any dependencies, then > > README.md line 79: > >> 78: - Gradle 5.6.2 or later >> 79: >> 80: To create a build then run the command > > Suggestion: > > To create a build then run the command: Works for me with gradle 5.6.4 and JDK 12b33 PR: https://git.openjdk.java.net/skara/pull/237 From jvernee at openjdk.org Tue Nov 5 15:34:44 2019 From: jvernee at openjdk.org (Jorn Vernee) Date: Tue, 5 Nov 2019 15:34:44 GMT Subject: RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: <3lhhgN0WwKIvaNB57Vu3_VbRozyUaCz1UVFcbDqxXHI=.ef8e5340-c161-4b39-9e46-1ce7b03dc922@github.com> On Tue, 5 Nov 2019 13:15:24 GMT, Erik Helin wrote: > Hi all, > > this patch adds much improved support for both _offline_ and _local_ builds. We are currently downloading both JDK and Gradle distributions for the most common platforms (GNU/Linux x64, macOS x64 and Windows x64), but this scheme does not scale to multiple other operating systems and/or CPU architectures. I have therefore extended the `images` plugin to support a `local` image which uses the JDK that is currently executing Gradle for producing the jlinked image. > > I also added support for fully offline builds for those want to supply both a JDK and Gradle themselves and ensure that the build does not download anything. > > Thanks, > Erik > > ## Testing > - Tested multiple variants of builds, including local, offline and default builds > > ---------------- > > Commits: > - 66a6b56b: Added support for offline and local builds > > Changes: https://git.openjdk.java.net/skara/pull/237/files > Webrev: https://webrevs.openjdk.java.net/skara/237/webrev.00 > Stats: 300 lines in 10 files changed: 207 ins; 22 del; 71 mod > Patch: https://git.openjdk.java.net/skara/pull/237.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 build.gradle line 125: > 124: def getCPU() { > 125: def cpu = System.getProperty('os.arch').toLowerCase() > 126: if (cpu.startsWith('amd64')) { I think this is x86_64 on Mac for 64 bit platforms PR: https://git.openjdk.java.net/skara/pull/237 From jvernee at openjdk.org Tue Nov 5 15:48:56 2019 From: jvernee at openjdk.org (Jorn Vernee) Date: Tue, 5 Nov 2019 15:48:56 GMT Subject: RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: <8Ab5hpasiCQqscuZ-Ibugwr9c6ihj-95K-rVB1JL3-0=.50896a13-a44f-4e63-b95f-c132b4b5b38d@github.com> On Tue, 5 Nov 2019 13:15:24 GMT, Erik Helin wrote: > Hi all, > > this patch adds much improved support for both _offline_ and _local_ builds. We are currently downloading both JDK and Gradle distributions for the most common platforms (GNU/Linux x64, macOS x64 and Windows x64), but this scheme does not scale to multiple other operating systems and/or CPU architectures. I have therefore extended the `images` plugin to support a `local` image which uses the JDK that is currently executing Gradle for producing the jlinked image. > > I also added support for fully offline builds for those want to supply both a JDK and Gradle themselves and ensure that the build does not download anything. > > Thanks, > Erik > > ## Testing > - Tested multiple variants of builds, including local, offline and default builds > > ---------------- > > Commits: > - 66a6b56b: Added support for offline and local builds > > Changes: https://git.openjdk.java.net/skara/pull/237/files > Webrev: https://webrevs.openjdk.java.net/skara/237/webrev.00 > Stats: 300 lines in 10 files changed: 207 ins; 22 del; 71 mod > Patch: https://git.openjdk.java.net/skara/pull/237.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/ImagesPlugin.java line 56: > 55: var p = System.getProperty("os.arch").toLowerCase(); > 56: if (p.startsWith("amd64")) { > 57: return "x64"; Same here PR: https://git.openjdk.java.net/skara/pull/237 From ehelin at openjdk.org Wed Nov 6 08:09:15 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 6 Nov 2019 08:09:15 GMT Subject: [Rev 01] RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - b70c5274: Add checks for x86_64 and x64 Changes: - all: https://git.openjdk.java.net/skara/pull/237/files - new: https://git.openjdk.java.net/skara/pull/237/files/66a6b56b..b70c5274 Webrevs: - full: https://webrevs.openjdk.java.net/skara/237/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/237/webrev.00-01 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/237.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 PR: https://git.openjdk.java.net/skara/pull/237 From ehelin at openjdk.org Wed Nov 6 08:09:34 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 6 Nov 2019 08:09:34 GMT Subject: RFR: Add support for offline and local builds In-Reply-To: <8Ab5hpasiCQqscuZ-Ibugwr9c6ihj-95K-rVB1JL3-0=.50896a13-a44f-4e63-b95f-c132b4b5b38d@github.com> References: <8Ab5hpasiCQqscuZ-Ibugwr9c6ihj-95K-rVB1JL3-0=.50896a13-a44f-4e63-b95f-c132b4b5b38d@github.com> Message-ID: On Tue, 5 Nov 2019 15:48:56 GMT, Jorn Vernee wrote: > On Tue, 5 Nov 2019 13:15:24 GMT, Erik Helin wrote: > >> Hi all, >> >> this patch adds much improved support for both _offline_ and _local_ builds. We are currently downloading both JDK and Gradle distributions for the most common platforms (GNU/Linux x64, macOS x64 and Windows x64), but this scheme does not scale to multiple other operating systems and/or CPU architectures. I have therefore extended the `images` plugin to support a `local` image which uses the JDK that is currently executing Gradle for producing the jlinked image. >> >> I also added support for fully offline builds for those want to supply both a JDK and Gradle themselves and ensure that the build does not download anything. >> >> Thanks, >> Erik >> >> ## Testing >> - Tested multiple variants of builds, including local, offline and default builds >> >> ---------------- >> >> Commits: >> - 66a6b56b: Added support for offline and local builds >> >> Changes: https://git.openjdk.java.net/skara/pull/237/files >> Webrev: https://webrevs.openjdk.java.net/skara/237/webrev.00 >> Stats: 300 lines in 10 files changed: 207 ins; 22 del; 71 mod >> Patch: https://git.openjdk.java.net/skara/pull/237.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 > > buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/ImagesPlugin.java line 56: > >> 55: var p = System.getProperty("os.arch").toLowerCase(); >> 56: if (p.startsWith("amd64")) { >> 57: return "x64"; > > Same here Thanks, fixed! I also added a check for `"x64"`. PR: https://git.openjdk.java.net/skara/pull/237 From ehelin at openjdk.org Wed Nov 6 08:09:47 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 6 Nov 2019 08:09:47 GMT Subject: RFR: Add support for offline and local builds In-Reply-To: <3lhhgN0WwKIvaNB57Vu3_VbRozyUaCz1UVFcbDqxXHI=.ef8e5340-c161-4b39-9e46-1ce7b03dc922@github.com> References: <3lhhgN0WwKIvaNB57Vu3_VbRozyUaCz1UVFcbDqxXHI=.ef8e5340-c161-4b39-9e46-1ce7b03dc922@github.com> Message-ID: On Tue, 5 Nov 2019 15:34:44 GMT, Jorn Vernee wrote: > On Tue, 5 Nov 2019 13:15:24 GMT, Erik Helin wrote: > >> Hi all, >> >> this patch adds much improved support for both _offline_ and _local_ builds. We are currently downloading both JDK and Gradle distributions for the most common platforms (GNU/Linux x64, macOS x64 and Windows x64), but this scheme does not scale to multiple other operating systems and/or CPU architectures. I have therefore extended the `images` plugin to support a `local` image which uses the JDK that is currently executing Gradle for producing the jlinked image. >> >> I also added support for fully offline builds for those want to supply both a JDK and Gradle themselves and ensure that the build does not download anything. >> >> Thanks, >> Erik >> >> ## Testing >> - Tested multiple variants of builds, including local, offline and default builds >> >> ---------------- >> >> Commits: >> - 66a6b56b: Added support for offline and local builds >> >> Changes: https://git.openjdk.java.net/skara/pull/237/files >> Webrev: https://webrevs.openjdk.java.net/skara/237/webrev.00 >> Stats: 300 lines in 10 files changed: 207 ins; 22 del; 71 mod >> Patch: https://git.openjdk.java.net/skara/pull/237.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 > > build.gradle line 125: > >> 124: def getCPU() { >> 125: def cpu = System.getProperty('os.arch').toLowerCase() >> 126: if (cpu.startsWith('amd64')) { > > I think this is x86_64 on Mac for 64 bit platforms Fixed, also added a check for `"x64"`. PR: https://git.openjdk.java.net/skara/pull/237 From ehelin at openjdk.org Wed Nov 6 08:10:54 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 6 Nov 2019 08:10:54 GMT Subject: [Rev 02] RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - ddccafd5: Fix spelling Changes: - all: https://git.openjdk.java.net/skara/pull/237/files - new: https://git.openjdk.java.net/skara/pull/237/files/b70c5274..ddccafd5 Webrevs: - full: https://webrevs.openjdk.java.net/skara/237/webrev.02 - incr: https://webrevs.openjdk.java.net/skara/237/webrev.01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/237.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 PR: https://git.openjdk.java.net/skara/pull/237 From ehelin at openjdk.org Wed Nov 6 08:11:38 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 6 Nov 2019 08:11:38 GMT Subject: [Rev 03] RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 07073380: Grammar fixes Changes: - all: https://git.openjdk.java.net/skara/pull/237/files - new: https://git.openjdk.java.net/skara/pull/237/files/ddccafd5..07073380 Webrevs: - full: https://webrevs.openjdk.java.net/skara/237/webrev.03 - incr: https://webrevs.openjdk.java.net/skara/237/webrev.02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/237.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 PR: https://git.openjdk.java.net/skara/pull/237 From ehelin at openjdk.org Wed Nov 6 08:19:01 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 6 Nov 2019 08:19:01 GMT Subject: [Rev 04] RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - b68a41a9: Fix Windows x64 JDK hashsum check Changes: - all: https://git.openjdk.java.net/skara/pull/237/files - new: https://git.openjdk.java.net/skara/pull/237/files/07073380..b68a41a9 Webrevs: - full: https://webrevs.openjdk.java.net/skara/237/webrev.04 - incr: https://webrevs.openjdk.java.net/skara/237/webrev.03-04 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/237.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 PR: https://git.openjdk.java.net/skara/pull/237 From rwestberg at openjdk.org Wed Nov 6 10:11:55 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 6 Nov 2019 10:11:55 GMT Subject: [Rev 02] RFR: 149: Improve formatting of bridged emails In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 037c8570: Final round of test fixes Changes: - all: https://git.openjdk.java.net/skara/pull/236/files - new: https://git.openjdk.java.net/skara/pull/236/files/348c6d3f..037c8570 Webrevs: - full: https://webrevs.openjdk.java.net/skara/236/webrev.02 - incr: https://webrevs.openjdk.java.net/skara/236/webrev.01-02 Issue: https://bugs.openjdk.java.net/browse/SKARA-149 Stats: 16 lines in 2 files changed: 1 ins; 0 del; 15 mod Patch: https://git.openjdk.java.net/skara/pull/236.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/236/head:pull/236 PR: https://git.openjdk.java.net/skara/pull/236 From ehelin at openjdk.org Wed Nov 6 11:06:09 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 6 Nov 2019 11:06:09 GMT Subject: RFR: Add "Required" title to jcheck-check only if it fails Message-ID: Hi all, please review this small patch that only sets the title `"Required"` for the jcheck-check if jcheck fails. Thanks, Erik ---------------- Commits: - 41ebd437: Add "Required" title to jcheck-check only if it fails Changes: https://git.openjdk.java.net/skara/pull/238/files Webrev: https://webrevs.openjdk.java.net/skara/238/webrev.00 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/238.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/238/head:pull/238 PR: https://git.openjdk.java.net/skara/pull/238 From rwestberg at openjdk.org Wed Nov 6 11:08:36 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 6 Nov 2019 11:08:36 GMT Subject: [Approved] RFR: Add "Required" title to jcheck-check only if it fails In-Reply-To: References: Message-ID: On Wed, 6 Nov 2019 11:06:09 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that only sets the title `"Required"` for the jcheck-check if jcheck fails. > > Thanks, > Erik > > ---------------- > > Commits: > - 41ebd437: Add "Required" title to jcheck-check only if it fails > > Changes: https://git.openjdk.java.net/skara/pull/238/files > Webrev: https://webrevs.openjdk.java.net/skara/238/webrev.00 > Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/238.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/238/head:pull/238 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/238 From ehelin at openjdk.org Wed Nov 6 11:09:25 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 6 Nov 2019 11:09:25 GMT Subject: [Integrated] RFR: Add "Required" title to jcheck-check only if it fails In-Reply-To: References: Message-ID: Changeset: 43f8ff2b Author: Erik Helin Date: 2019-11-06 11:09:07 +0000 URL: https://git.openjdk.java.net/skara/commit/43f8ff2b Add "Required" title to jcheck-check only if it fails Reviewed-by: rwestberg ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java From ehelin at openjdk.org Wed Nov 6 11:09:38 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 6 Nov 2019 11:09:38 GMT Subject: [Approved] RFR: 149: Improve formatting of bridged emails In-Reply-To: References: Message-ID: On Tue, 5 Nov 2019 13:11:18 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that improves the formatting of mailing list messages that are posted to PRs. > > Best regards, > Robin > > ---------------- > > Commits: > - 6b8ddc84: Improve formatting of bridged mailing list messages > > Changes: https://git.openjdk.java.net/skara/pull/236/files > Webrev: https://webrevs.openjdk.java.net/skara/236/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-149 > Stats: 21 lines in 4 files changed: 13 ins; 0 del; 8 mod > Patch: https://git.openjdk.java.net/skara/pull/236.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/236/head:pull/236 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/236 From rwestberg at openjdk.org Wed Nov 6 11:15:04 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 6 Nov 2019 11:15:04 GMT Subject: [Integrated] RFR: 149: Improve formatting of bridged emails In-Reply-To: References: Message-ID: <1d258612-3e7b-453e-8b7a-7adbdb853279@openjdk.org> Changeset: 12ced194 Author: Robin Westberg Date: 2019-11-06 11:14:47 +0000 URL: https://git.openjdk.java.net/skara/commit/12ced194 149: Improve formatting of bridged emails Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CommentPosterWorkItem.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBotTests.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java ! mailinglist/src/main/java/org/openjdk/skara/mailinglist/Mbox.java ! mailinglist/src/main/java/org/openjdk/skara/mailinglist/mailman/MailmanList.java ! mailinglist/src/test/java/org/openjdk/skara/mailinglist/MailmanTests.java From rwestberg at openjdk.org Wed Nov 6 14:36:02 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 6 Nov 2019 14:36:02 GMT Subject: RFR: 148: Review comment general comment first Message-ID: Hi all, Please review this change that puts general review comments before file specific ones, and improves the threading of Reviewer approvals. Best regards, Robin ---------------- Commits: - 0a679c02: Generic review comment before specific ones, improve reparenting of Reviewer approvals Changes: https://git.openjdk.java.net/skara/pull/239/files Webrev: https://webrevs.openjdk.java.net/skara/239/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-148 Stats: 88 lines in 6 files changed: 74 ins; 2 del; 12 mod Patch: https://git.openjdk.java.net/skara/pull/239.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/239/head:pull/239 PR: https://git.openjdk.java.net/skara/pull/239 From ehelin at openjdk.org Wed Nov 6 14:40:22 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 6 Nov 2019 14:40:22 GMT Subject: [Approved] RFR: 148: Review comment general comment first In-Reply-To: References: Message-ID: On Wed, 6 Nov 2019 14:36:02 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that puts general review comments before file specific ones, and improves the threading of Reviewer approvals. > > Best regards, > Robin > > ---------------- > > Commits: > - 0a679c02: Generic review comment before specific ones, improve reparenting of Reviewer approvals > > Changes: https://git.openjdk.java.net/skara/pull/239/files > Webrev: https://webrevs.openjdk.java.net/skara/239/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-148 > Stats: 88 lines in 6 files changed: 74 ins; 2 del; 12 mod > Patch: https://git.openjdk.java.net/skara/pull/239.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/239/head:pull/239 Looks good, thanks for fixing this! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/239 From rwestberg at openjdk.org Wed Nov 6 16:36:43 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 6 Nov 2019 16:36:43 GMT Subject: [Integrated] RFR: 148: Review comment general comment first In-Reply-To: References: Message-ID: <8bd6a788-cfbe-4ceb-9373-53833237b4a7@openjdk.org> Changeset: f4cc08e2 Author: Robin Westberg Date: 2019-11-06 16:36:26 +0000 URL: https://git.openjdk.java.net/skara/commit/f4cc08e2 148: Review comment general comment first Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! email/src/main/java/org/openjdk/skara/email/Email.java ! email/src/test/java/org/openjdk/skara/email/EmailTests.java From ngasson at openjdk.org Thu Nov 7 06:55:15 2019 From: ngasson at openjdk.org (Nick Gasson) Date: Thu, 7 Nov 2019 06:55:15 GMT Subject: [Rev 04] RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: On Wed, 6 Nov 2019 08:19:01 GMT, Erik Helin wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - b68a41a9: Fix Windows x64 JDK hashsum check > > Changes: > - all: https://git.openjdk.java.net/skara/pull/237/files > - new: https://git.openjdk.java.net/skara/pull/237/files/07073380..b68a41a9 > > Webrevs: > - full: https://webrevs.openjdk.java.net/skara/237/webrev.04 > - incr: https://webrevs.openjdk.java.net/skara/237/webrev.03-04 > > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/237.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 build.gradle line 141: > 140: } > 141: throw new GradleException("Unexpected operating system: " + cpu) > 142: } Should be "Unexpected CPU"? build.gradle line 140: > 139: return 'arm' > 140: } > 141: throw new GradleException("Unexpected operating system: " + cpu) 64-bit and 32-bit Arm have different `os.arch` values. So we need to add: if (cpu.startsWith('aarch64')) { return 'aarch64' } buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/ImagesPlugin.java line 70: > 69: return "arm"; > 70: } > 71: Also need to check for `aarch64` here: if (p.startsWith("aarch64")) { return "aarch64"; } PR: https://git.openjdk.java.net/skara/pull/237 From ehelin at openjdk.org Thu Nov 7 08:59:35 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 7 Nov 2019 08:59:35 GMT Subject: [Rev 05] RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 4d96e1af: Add AArch64 support and fix exception message Changes: - all: https://git.openjdk.java.net/skara/pull/237/files - new: https://git.openjdk.java.net/skara/pull/237/files/b68a41a9..4d96e1af Webrevs: - full: https://webrevs.openjdk.java.net/skara/237/webrev.05 - incr: https://webrevs.openjdk.java.net/skara/237/webrev.04-05 Stats: 7 lines in 2 files changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/237.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 PR: https://git.openjdk.java.net/skara/pull/237 From ehelin at openjdk.org Thu Nov 7 09:08:12 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 7 Nov 2019 09:08:12 GMT Subject: [Rev 04] RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: On Thu, 7 Nov 2019 06:55:15 GMT, Nick Gasson wrote: > On Wed, 6 Nov 2019 08:19:01 GMT, Erik Helin wrote: > >> The pull request has been updated with additional changes. >> >> ---------------- >> >> Added commits: >> - b68a41a9: Fix Windows x64 JDK hashsum check >> >> Changes: >> - all: https://git.openjdk.java.net/skara/pull/237/files >> - new: https://git.openjdk.java.net/skara/pull/237/files/07073380..b68a41a9 >> >> Webrevs: >> - full: https://webrevs.openjdk.java.net/skara/237/webrev.04 >> - incr: https://webrevs.openjdk.java.net/skara/237/webrev.03-04 >> >> Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod >> Patch: https://git.openjdk.java.net/skara/pull/237.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 > > build.gradle line 141: > >> 140: } >> 141: throw new GradleException("Unexpected operating system: " + cpu) >> 142: } > > Should be "Unexpected CPU"? > > build.gradle line 140: > >> 139: return 'arm' >> 140: } >> 141: throw new GradleException("Unexpected operating system: " + cpu) > > 64-bit and 32-bit Arm have different `os.arch` values. So we need to add: > > if (cpu.startsWith('aarch64')) { > return 'aarch64' > } > > buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/ImagesPlugin.java line 70: > >> 69: return "arm"; >> 70: } >> 71: > > Also need to check for `aarch64` here: > > if (p.startsWith("aarch64")) { > return "aarch64"; > } Ah, right, thanks. Fixed! PR: https://git.openjdk.java.net/skara/pull/237 From ehelin at openjdk.org Thu Nov 7 09:08:26 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 7 Nov 2019 09:08:26 GMT Subject: [Rev 04] RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: On Thu, 7 Nov 2019 09:08:12 GMT, Erik Helin wrote: > On Thu, 7 Nov 2019 06:55:15 GMT, Nick Gasson wrote: > >> On Wed, 6 Nov 2019 08:19:01 GMT, Erik Helin wrote: >> >>> The pull request has been updated with additional changes. >>> >>> ---------------- >>> >>> Added commits: >>> - b68a41a9: Fix Windows x64 JDK hashsum check >>> >>> Changes: >>> - all: https://git.openjdk.java.net/skara/pull/237/files >>> - new: https://git.openjdk.java.net/skara/pull/237/files/07073380..b68a41a9 >>> >>> Webrevs: >>> - full: https://webrevs.openjdk.java.net/skara/237/webrev.04 >>> - incr: https://webrevs.openjdk.java.net/skara/237/webrev.03-04 >>> >>> Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod >>> Patch: https://git.openjdk.java.net/skara/pull/237.diff >>> Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 >> >> build.gradle line 141: >> >>> 140: } >>> 141: throw new GradleException("Unexpected operating system: " + cpu) >>> 142: } >> >> Should be "Unexpected CPU"? >> >> build.gradle line 140: >> >>> 139: return 'arm' >>> 140: } >>> 141: throw new GradleException("Unexpected operating system: " + cpu) >> >> 64-bit and 32-bit Arm have different `os.arch` values. So we need to add: >> >> if (cpu.startsWith('aarch64')) { >> return 'aarch64' >> } >> >> buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/ImagesPlugin.java line 70: >> >>> 69: return "arm"; >>> 70: } >>> 71: >> >> Also need to check for `aarch64` here: >> >> if (p.startsWith("aarch64")) { >> return "aarch64"; >> } > > Ah, right, thanks. Fixed! Thanks, fixed this one as well! PR: https://git.openjdk.java.net/skara/pull/237 From rwestberg at openjdk.org Thu Nov 7 09:17:39 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 7 Nov 2019 09:17:39 GMT Subject: RFR: 151: Encode single dot characters in the SMTP client Message-ID: <9dIdgSGIOjGnkEXDkcbzP8PivB6WHBT2sDBEJ7LEtb4=.036f1c20-4e4d-4cf4-8e54-f1ba116d2c94@github.com> Hi all, Please review this change that ensures that lines containing a single dot are properly escaped in the SMTP client. Best regards, Robin ---------------- Commits: - ceccb9ca: Escape lines starting with a dot character in the SMTP client Changes: https://git.openjdk.java.net/skara/pull/240/files Webrev: https://webrevs.openjdk.java.net/skara/240/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-151 Stats: 34 lines in 3 files changed: 21 ins; 9 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/240.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/240/head:pull/240 PR: https://git.openjdk.java.net/skara/pull/240 From ehelin at openjdk.org Thu Nov 7 09:36:32 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 7 Nov 2019 09:36:32 GMT Subject: [Rev 04] RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: On Thu, 7 Nov 2019 06:55:15 GMT, Nick Gasson wrote: > On Wed, 6 Nov 2019 08:19:01 GMT, Erik Helin wrote: > >> The pull request has been updated with additional changes. >> >> ---------------- >> >> Added commits: >> - b68a41a9: Fix Windows x64 JDK hashsum check >> >> Changes: >> - all: https://git.openjdk.java.net/skara/pull/237/files >> - new: https://git.openjdk.java.net/skara/pull/237/files/07073380..b68a41a9 >> >> Webrevs: >> - full: https://webrevs.openjdk.java.net/skara/237/webrev.04 >> - incr: https://webrevs.openjdk.java.net/skara/237/webrev.03-04 >> >> Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod >> Patch: https://git.openjdk.java.net/skara/pull/237.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/237/head:pull/237 > > build.gradle line 141: > >> 140: } >> 141: throw new GradleException("Unexpected operating system: " + cpu) >> 142: } > > Should be "Unexpected CPU"? > > build.gradle line 140: > >> 139: return 'arm' >> 140: } >> 141: throw new GradleException("Unexpected operating system: " + cpu) > > 64-bit and 32-bit Arm have different `os.arch` values. So we need to add: > > if (cpu.startsWith('aarch64')) { > return 'aarch64' > } > > buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/ImagesPlugin.java line 70: > >> 69: return "arm"; >> 70: } >> 71: > > Also need to check for `aarch64` here: > > if (p.startsWith("aarch64")) { > return "aarch64"; > } Yep, fixed, thanks! PR: https://git.openjdk.java.net/skara/pull/237 From ehelin at openjdk.org Thu Nov 7 09:38:15 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 7 Nov 2019 09:38:15 GMT Subject: [Approved] RFR: 151: Encode single dot characters in the SMTP client In-Reply-To: <9dIdgSGIOjGnkEXDkcbzP8PivB6WHBT2sDBEJ7LEtb4=.036f1c20-4e4d-4cf4-8e54-f1ba116d2c94@github.com> References: <9dIdgSGIOjGnkEXDkcbzP8PivB6WHBT2sDBEJ7LEtb4=.036f1c20-4e4d-4cf4-8e54-f1ba116d2c94@github.com> Message-ID: On Thu, 7 Nov 2019 09:17:39 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that lines containing a single dot are properly escaped in the SMTP client. > > Best regards, > Robin > > ---------------- > > Commits: > - ceccb9ca: Escape lines starting with a dot character in the SMTP client > > Changes: https://git.openjdk.java.net/skara/pull/240/files > Webrev: https://webrevs.openjdk.java.net/skara/240/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-151 > Stats: 34 lines in 3 files changed: 21 ins; 9 del; 4 mod > Patch: https://git.openjdk.java.net/skara/pull/240.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/240/head:pull/240 Thanks Robin for fixing this, looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/240 From rwestberg at openjdk.org Thu Nov 7 10:58:14 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 7 Nov 2019 10:58:14 GMT Subject: RFR: Add buildnum extraction support for OpenJFX tags Message-ID: Hi all, Please review this minor change that enables parsing of the tag format used in the OpenJFX project. Best regards, Robin ---------------- Commits: - b7d6dfa0: Add buildnum extraction support for OpenJFX tags Changes: https://git.openjdk.java.net/skara/pull/241/files Webrev: https://webrevs.openjdk.java.net/skara/241/webrev.00 Stats: 29 lines in 2 files changed: 26 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/241.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/241/head:pull/241 PR: https://git.openjdk.java.net/skara/pull/241 From rwestberg at openjdk.org Thu Nov 7 11:00:15 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 7 Nov 2019 11:00:15 GMT Subject: [Integrated] RFR: 151: Encode single dot characters in the SMTP client In-Reply-To: <9dIdgSGIOjGnkEXDkcbzP8PivB6WHBT2sDBEJ7LEtb4=.036f1c20-4e4d-4cf4-8e54-f1ba116d2c94@github.com> References: <9dIdgSGIOjGnkEXDkcbzP8PivB6WHBT2sDBEJ7LEtb4=.036f1c20-4e4d-4cf4-8e54-f1ba116d2c94@github.com> Message-ID: <1cc0adfc-ac0c-46f0-b641-6edf6dad109d@openjdk.org> Changeset: b1e3d870 Author: Robin Westberg Date: 2019-11-07 10:59:57 +0000 URL: https://git.openjdk.java.net/skara/commit/b1e3d870 151: Encode single dot characters in the SMTP client Reviewed-by: ehelin ! email/src/main/java/org/openjdk/skara/email/SMTP.java ! email/src/test/java/org/openjdk/skara/email/SMTPTests.java ! test/src/main/java/org/openjdk/skara/test/SMTPServer.java From kcr at openjdk.org Thu Nov 7 11:12:03 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Thu, 7 Nov 2019 11:12:03 GMT Subject: RFR: Add buildnum extraction support for OpenJFX tags In-Reply-To: References: Message-ID: On Thu, 7 Nov 2019 10:58:14 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that enables parsing of the tag format used in the OpenJFX project. > > Best regards, > Robin > > ---------------- > > Commits: > - b7d6dfa0: Add buildnum extraction support for OpenJFX tags > > Changes: https://git.openjdk.java.net/skara/pull/241/files > Webrev: https://webrevs.openjdk.java.net/skara/241/webrev.00 > Stats: 29 lines in 2 files changed: 26 ins; 1 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/241.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/241/head:pull/241 vcs/src/main/java/org/openjdk/skara/vcs/openjdk/OpenJDKTag.java line 62: > 61: private final static String OpenJDKVersionPattern = "(jdk-([0-9]+(\\.[0-9]){0,3}))(\\+)([0-9]+)"; > 62: private final static String OpenJFXVersionPattern = "((?:jdk-){0,1}([1-9](?:(?:[0-9]*)(\\.(?:0|[1-9][0-9]*)){0,3})))(?:(\\+)([0-9]+)|(-ga))"; > 63: Not related to this change, but the OpenJDKVersionPattern also will need support for `*-ga` tags. vcs/src/main/java/org/openjdk/skara/vcs/openjdk/OpenJDKTag.java line 111: > 110: */ > 111: public int buildNum() { > 112: if (buildNum == null) { Under what conditions will this be null? When using a `*-ga` tag? If so, this seems fine. I presume this will work. I'm curious as to why this is needed, though. As long as a tag passes jcheck, why does the vcs module need to know about valid tag formats that a particular project might choose to use? PR: https://git.openjdk.java.net/skara/pull/241 From rwestberg at openjdk.org Thu Nov 7 11:17:51 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 7 Nov 2019 11:17:51 GMT Subject: RFR: Add buildnum extraction support for OpenJFX tags In-Reply-To: References: Message-ID: On Thu, 7 Nov 2019 11:12:03 GMT, Kevin Rushforth wrote: > On Thu, 7 Nov 2019 10:58:14 GMT, Robin Westberg wrote: > >> Hi all, >> >> Please review this minor change that enables parsing of the tag format used in the OpenJFX project. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - b7d6dfa0: Add buildnum extraction support for OpenJFX tags >> >> Changes: https://git.openjdk.java.net/skara/pull/241/files >> Webrev: https://webrevs.openjdk.java.net/skara/241/webrev.00 >> Stats: 29 lines in 2 files changed: 26 ins; 1 del; 2 mod >> Patch: https://git.openjdk.java.net/skara/pull/241.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/241/head:pull/241 > > vcs/src/main/java/org/openjdk/skara/vcs/openjdk/OpenJDKTag.java line 62: > >> 61: private final static String OpenJDKVersionPattern = "(jdk-([0-9]+(\\.[0-9]){0,3}))(\\+)([0-9]+)"; >> 62: private final static String OpenJFXVersionPattern = "((?:jdk-){0,1}([1-9](?:(?:[0-9]*)(\\.(?:0|[1-9][0-9]*)){0,3})))(?:(\\+)([0-9]+)|(-ga))"; >> 63: > > Not related to this change, but the OpenJDKVersionPattern also will need support for `*-ga` tags. > > vcs/src/main/java/org/openjdk/skara/vcs/openjdk/OpenJDKTag.java line 111: > >> 110: */ >> 111: public int buildNum() { >> 112: if (buildNum == null) { > > Under what conditions will this be null? When using a `*-ga` tag? If so, this seems fine. > > I presume this will work. I'm curious as to why this is needed, though. As long as a tag passes jcheck, why does the vcs module need to know about valid tag formats that a particular project might choose to use? Currently the notifier will ignore all tags that cannot be parsed as an OpenJDKTag (this will be fixed in a separate change). But if the tag can be parsed, the notifier also includes a summary of changes that have been included since the last build. So this change both unblocks tag notifications for JFX as well as this summary. PR: https://git.openjdk.java.net/skara/pull/241 From kcr at openjdk.org Thu Nov 7 11:18:53 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Thu, 7 Nov 2019 11:18:53 GMT Subject: RFR: Add buildnum extraction support for OpenJFX tags In-Reply-To: References: Message-ID: On Thu, 7 Nov 2019 10:58:14 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that enables parsing of the tag format used in the OpenJFX project. > > Best regards, > Robin > > ---------------- > > Commits: > - b7d6dfa0: Add buildnum extraction support for OpenJFX tags > > Changes: https://git.openjdk.java.net/skara/pull/241/files > Webrev: https://webrevs.openjdk.java.net/skara/241/webrev.00 > Stats: 29 lines in 2 files changed: 26 ins; 1 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/241.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/241/head:pull/241 Sounds good. ---------------- Approved by kcr (none). PR: https://git.openjdk.java.net/skara/pull/241 From ehelin at openjdk.org Thu Nov 7 13:05:45 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 7 Nov 2019 13:05:45 GMT Subject: RFR: Add ReadOnlyRepository.annotate(Tag t) method Message-ID: <_YYf-qXLeeWyyYkxQBZSKdGsVqkCIFRYFjDOT3BAASk=.ba3d6fd3-5e15-4e1a-bc1d-ea5d5bc1c283@github.com> Hi all, please review this patch that adds the `ReadOnlyRepository.annotate(Tag t)` method that can be used to get more information for annotated tags (git) or just tags (hg). Thanks, Erik ## Testing - `make test` passes - Added three new unit tests ---------------- Commits: - a8bd1e7c: Add ReadOnlyRepository.annotate(Tag t) method Changes: https://git.openjdk.java.net/skara/pull/242/files Webrev: https://webrevs.openjdk.java.net/skara/242/webrev.00 Stats: 167 lines in 6 files changed: 167 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/242.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/242/head:pull/242 PR: https://git.openjdk.java.net/skara/pull/242 From rwestberg at openjdk.org Thu Nov 7 13:07:41 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 7 Nov 2019 13:07:41 GMT Subject: [Approved] RFR: Add ReadOnlyRepository.annotate(Tag t) method In-Reply-To: <_YYf-qXLeeWyyYkxQBZSKdGsVqkCIFRYFjDOT3BAASk=.ba3d6fd3-5e15-4e1a-bc1d-ea5d5bc1c283@github.com> References: <_YYf-qXLeeWyyYkxQBZSKdGsVqkCIFRYFjDOT3BAASk=.ba3d6fd3-5e15-4e1a-bc1d-ea5d5bc1c283@github.com> Message-ID: On Thu, 7 Nov 2019 13:05:45 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `ReadOnlyRepository.annotate(Tag t)` method that can be used to get more information for annotated tags (git) or just tags (hg). > > Thanks, > Erik > > ## Testing > - `make test` passes > - Added three new unit tests > > ---------------- > > Commits: > - a8bd1e7c: Add ReadOnlyRepository.annotate(Tag t) method > > Changes: https://git.openjdk.java.net/skara/pull/242/files > Webrev: https://webrevs.openjdk.java.net/skara/242/webrev.00 > Stats: 167 lines in 6 files changed: 167 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/242.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/242/head:pull/242 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/242 From ehelin at openjdk.org Thu Nov 7 13:08:20 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 7 Nov 2019 13:08:20 GMT Subject: [Approved] RFR: Add buildnum extraction support for OpenJFX tags In-Reply-To: References: Message-ID: On Thu, 7 Nov 2019 10:58:14 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that enables parsing of the tag format used in the OpenJFX project. > > Best regards, > Robin > > ---------------- > > Commits: > - b7d6dfa0: Add buildnum extraction support for OpenJFX tags > > Changes: https://git.openjdk.java.net/skara/pull/241/files > Webrev: https://webrevs.openjdk.java.net/skara/241/webrev.00 > Stats: 29 lines in 2 files changed: 26 ins; 1 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/241.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/241/head:pull/241 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/241 From ehelin at openjdk.org Thu Nov 7 13:09:01 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 7 Nov 2019 13:09:01 GMT Subject: [Integrated] RFR: Add ReadOnlyRepository.annotate(Tag t) method In-Reply-To: <_YYf-qXLeeWyyYkxQBZSKdGsVqkCIFRYFjDOT3BAASk=.ba3d6fd3-5e15-4e1a-bc1d-ea5d5bc1c283@github.com> References: <_YYf-qXLeeWyyYkxQBZSKdGsVqkCIFRYFjDOT3BAASk=.ba3d6fd3-5e15-4e1a-bc1d-ea5d5bc1c283@github.com> Message-ID: Changeset: e294ce92 Author: Erik Helin Date: 2019-11-07 13:08:46 +0000 URL: https://git.openjdk.java.net/skara/commit/e294ce92 Add ReadOnlyRepository.annotate(Tag t) method Reviewed-by: rwestberg ! jcheck/src/test/java/org/openjdk/skara/jcheck/TestRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/Tag.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java ! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java From rwestberg at openjdk.org Thu Nov 7 14:16:52 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 7 Nov 2019 14:16:52 GMT Subject: RFR: Use tag annotation if present when sending notifications Message-ID: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> Hi all, Please review this change that updates the notifier to include the tag annotation if it is present when creating a new tag notification email. Also ensure that notifications are sent even if a tag does not conform to the OpenJDK tag parser format. Best regards, Robin ---------------- Commits: - 649928d3: Send notifications for non-OpenJDK-compliant tags as well, use tag annotation info if present Changes: https://git.openjdk.java.net/skara/pull/243/files Webrev: https://webrevs.openjdk.java.net/skara/243/webrev.00 Stats: 129 lines in 5 files changed: 78 ins; 9 del; 42 mod Patch: https://git.openjdk.java.net/skara/pull/243.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/243/head:pull/243 PR: https://git.openjdk.java.net/skara/pull/243 From rwestberg at openjdk.org Thu Nov 7 14:28:46 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 7 Nov 2019 14:28:46 GMT Subject: [Rev 01] RFR: Use tag annotation if present when sending notifications In-Reply-To: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> References: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 1edc0fdd: Fix failing test Changes: - all: https://git.openjdk.java.net/skara/pull/243/files - new: https://git.openjdk.java.net/skara/pull/243/files/649928d3..1edc0fdd Webrevs: - full: https://webrevs.openjdk.java.net/skara/243/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/243/webrev.00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/243.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/243/head:pull/243 PR: https://git.openjdk.java.net/skara/pull/243 From ehelin at openjdk.org Fri Nov 8 08:16:14 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 8 Nov 2019 08:16:14 GMT Subject: [Approved] RFR: Use tag annotation if present when sending notifications In-Reply-To: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> References: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> Message-ID: On Thu, 7 Nov 2019 14:28:46 GMT, Robin Westberg wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - 1edc0fdd: Fix failing test > > Changes: > - all: https://git.openjdk.java.net/skara/pull/243/files > - new: https://git.openjdk.java.net/skara/pull/243/files/649928d3..1edc0fdd > > Webrevs: > - full: https://webrevs.openjdk.java.net/skara/243/webrev.01 > - incr: https://webrevs.openjdk.java.net/skara/243/webrev.00-01 > > Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/243.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/243/head:pull/243 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/243 From rwestberg at openjdk.org Fri Nov 8 08:18:15 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 8 Nov 2019 08:18:15 GMT Subject: [Rev 02] RFR: Use tag annotation if present when sending notifications In-Reply-To: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> References: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - fe09eede: Adjust email formatting Changes: - all: https://git.openjdk.java.net/skara/pull/243/files - new: https://git.openjdk.java.net/skara/pull/243/files/1edc0fdd..fe09eede Webrevs: - full: https://webrevs.openjdk.java.net/skara/243/webrev.02 - incr: https://webrevs.openjdk.java.net/skara/243/webrev.01-02 Stats: 109 lines in 4 files changed: 60 ins; 21 del; 28 mod Patch: https://git.openjdk.java.net/skara/pull/243.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/243/head:pull/243 PR: https://git.openjdk.java.net/skara/pull/243 From ehelin at openjdk.org Fri Nov 8 08:22:03 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 8 Nov 2019 08:22:03 GMT Subject: [Approved] RFR: Use tag annotation if present when sending notifications In-Reply-To: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> References: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> Message-ID: On Fri, 8 Nov 2019 08:18:15 GMT, Robin Westberg wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - fe09eede: Adjust email formatting > > Changes: > - all: https://git.openjdk.java.net/skara/pull/243/files > - new: https://git.openjdk.java.net/skara/pull/243/files/1edc0fdd..fe09eede > > Webrevs: > - full: https://webrevs.openjdk.java.net/skara/243/webrev.02 > - incr: https://webrevs.openjdk.java.net/skara/243/webrev.01-02 > > Stats: 109 lines in 4 files changed: 60 ins; 21 del; 28 mod > Patch: https://git.openjdk.java.net/skara/pull/243.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/243/head:pull/243 Still good, just a small suggestion inline based on latest changes ?? bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java line 44: > 43: private final Path storagePath; > 44: private final Pattern branches; > 45: private final StorageBuilder tagStorageBuilder; Please move this below the for loop so it is next to the for loop of `newNonJdkTags` ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/243 From rwestberg at openjdk.org Fri Nov 8 08:24:42 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 8 Nov 2019 08:24:42 GMT Subject: [Rev 03] RFR: Use tag annotation if present when sending notifications In-Reply-To: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> References: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - e02eb57d: Adjust after review Changes: - all: https://git.openjdk.java.net/skara/pull/243/files - new: https://git.openjdk.java.net/skara/pull/243/files/fe09eede..e02eb57d Webrevs: - full: https://webrevs.openjdk.java.net/skara/243/webrev.03 - incr: https://webrevs.openjdk.java.net/skara/243/webrev.02-03 Stats: 8 lines in 1 file changed: 3 ins; 5 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/243.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/243/head:pull/243 PR: https://git.openjdk.java.net/skara/pull/243 From rwestberg at openjdk.org Fri Nov 8 08:24:46 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 8 Nov 2019 08:24:46 GMT Subject: [Approved] RFR: Use tag annotation if present when sending notifications In-Reply-To: References: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> Message-ID: On Fri, 8 Nov 2019 08:22:03 GMT, Erik Helin wrote: > On Fri, 8 Nov 2019 08:18:15 GMT, Robin Westberg wrote: > >> The pull request has been updated with additional changes. >> >> ---------------- >> >> Added commits: >> - fe09eede: Adjust email formatting >> >> Changes: >> - all: https://git.openjdk.java.net/skara/pull/243/files >> - new: https://git.openjdk.java.net/skara/pull/243/files/1edc0fdd..fe09eede >> >> Webrevs: >> - full: https://webrevs.openjdk.java.net/skara/243/webrev.02 >> - incr: https://webrevs.openjdk.java.net/skara/243/webrev.01-02 >> >> Stats: 109 lines in 4 files changed: 60 ins; 21 del; 28 mod >> Patch: https://git.openjdk.java.net/skara/pull/243.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/243/head:pull/243 > > Still good, just a small suggestion inline based on latest changes ?? > > bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java line 44: > >> 43: private final Path storagePath; >> 44: private final Pattern branches; >> 45: private final StorageBuilder tagStorageBuilder; > > Please move this below the for loop so it is next to the for loop of `newNonJdkTags` > > ---------------- > > Approved by ehelin (Reviewer). Sure! PR: https://git.openjdk.java.net/skara/pull/243 From kcr at openjdk.org Fri Nov 8 08:25:51 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Fri, 8 Nov 2019 08:25:51 GMT Subject: RFR: Use tag annotation if present when sending notifications In-Reply-To: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> References: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> Message-ID: <2kngQTHc0Hl90nepbG-NN11MGQScnevg_vkVrr0W1OU=.bee40498-2b78-45b8-b79d-0be00dcb62f8@github.com> On Thu, 7 Nov 2019 14:16:52 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that updates the notifier to include the tag annotation if it is present when creating a new tag notification email. Also ensure that notifications are sent even if a tag does not conform to the OpenJDK tag parser format. > > Best regards, > Robin > > ---------------- > > Commits: > - 649928d3: Send notifications for non-OpenJDK-compliant tags as well, use tag annotation info if present > > Changes: https://git.openjdk.java.net/skara/pull/243/files > Webrev: https://webrevs.openjdk.java.net/skara/243/webrev.00 > Stats: 129 lines in 5 files changed: 78 ins; 9 del; 42 mod > Patch: https://git.openjdk.java.net/skara/pull/243.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/243/head:pull/243 I look forwarded to testing this once you've updated the bot with this change. PR: https://git.openjdk.java.net/skara/pull/243 From rwestberg at openjdk.org Fri Nov 8 08:39:01 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 8 Nov 2019 08:39:01 GMT Subject: [Integrated] RFR: Add buildnum extraction support for OpenJFX tags In-Reply-To: References: Message-ID: <5a62a8a1-afb9-4a5b-a0a4-2434aa256ed1@openjdk.org> Changeset: 069620bc Author: Robin Westberg Date: 2019-11-08 08:38:45 +0000 URL: https://git.openjdk.java.net/skara/commit/069620bc Add buildnum extraction support for OpenJFX tags Reviewed-by: kcr, ehelin ! vcs/src/main/java/org/openjdk/skara/vcs/openjdk/OpenJDKTag.java ! vcs/src/test/java/org/openjdk/skara/vcs/openjdk/OpenJDKTagTests.java From rwestberg at openjdk.org Fri Nov 8 08:40:13 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 8 Nov 2019 08:40:13 GMT Subject: [Integrated] RFR: Use tag annotation if present when sending notifications In-Reply-To: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> References: <8GEZgSCnFr1UWdaVhVFLlkhrnxhM5BnVW0A7N_l0-CM=.bca4205b-9e83-4127-af66-e73c2587095c@github.com> Message-ID: Changeset: 2cb3a2e4 Author: Robin Westberg Date: 2019-11-08 08:39:57 +0000 URL: https://git.openjdk.java.net/skara/commit/2cb3a2e4 Use tag annotation if present when sending notifications Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JsonUpdater.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/UpdateConsumer.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From jvernee at openjdk.org Fri Nov 8 12:09:38 2019 From: jvernee at openjdk.org (Jorn Vernee) Date: Fri, 8 Nov 2019 12:09:38 GMT Subject: RFR: 153: Check if origin remote exists before trying to get the pullPath Message-ID: <-zcPU4rEcoMhS-iVd9VGNCAwv1zx42A0Ki1XwSsSMBI=.2b168b9e-a1f7-41e7-be15-7fbd8f5057ef@github.com> https://bugs.openjdk.java.net/browse/SKARA-153 Trying to create a webrev in a Git repo that does not have a remote named "origin" causes the following exception: Exception in thread "main" java.io.IOException: No pull path found for remote origin at org.openjdk.skara.vcs/org.openjdk.skara.vcs.git.GitRepository.pullPath(GitRepository.java:934) at org.openjdk.skara.cli/org.openjdk.skara.cli.GitWebrev.generate(GitWebrev.java:159) at org.openjdk.skara.args/org.openjdk.skara.args.Command.main(Command.java:54) at org.openjdk.skara.args/org.openjdk.skara.args.MultiCommandParser.lambda$parse$2(MultiCommandParser.java:64) at org.openjdk.skara.cli/org.openjdk.skara.cli.GitWebrev.main(GitWebrev.java:306) at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:127) It seems that the pullPath is only used to generate a title for the webrev. So, it would be good to check whether the remote exists first, to avoid an exception, and rely on the fallback behaviour of using the filename as a title instead. ---------------- Commits: - 45e6d505: Check if origin remote exists before trying to get the pullPath Changes: https://git.openjdk.java.net/skara/pull/244/files Webrev: https://webrevs.openjdk.java.net/skara/244/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-153 Stats: 11 lines in 1 file changed: 2 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/244.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/244/head:pull/244 PR: https://git.openjdk.java.net/skara/pull/244 From ehelin at openjdk.org Mon Nov 11 07:51:31 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 11 Nov 2019 07:51:31 GMT Subject: [Integrated] RFR: Add support for offline and local builds In-Reply-To: References: Message-ID: <2ccd2c20-64ba-4cf5-9027-c3505f03f91a@openjdk.org> Changeset: f3881b62 Author: Erik Helin Date: 2019-11-11 07:51:16 +0000 URL: https://git.openjdk.java.net/skara/commit/f3881b62 Add support for offline and local builds Co-authored-by: Nick Gasson Reviewed-by: rwestberg ! README.md ! bots/cli/build.gradle ! build.gradle ! buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/ImagesPlugin.java ! buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/LaunchersTask.java ! buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/LinkTask.java ! cli/build.gradle ! deps.env ! gradlew ! gradlew.bat From ehelin at openjdk.org Mon Nov 11 07:55:21 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 11 Nov 2019 07:55:21 GMT Subject: [Approved] RFR: 153: Check if origin remote exists before trying to get the pullPath In-Reply-To: <-zcPU4rEcoMhS-iVd9VGNCAwv1zx42A0Ki1XwSsSMBI=.2b168b9e-a1f7-41e7-be15-7fbd8f5057ef@github.com> References: <-zcPU4rEcoMhS-iVd9VGNCAwv1zx42A0Ki1XwSsSMBI=.2b168b9e-a1f7-41e7-be15-7fbd8f5057ef@github.com> Message-ID: On Fri, 8 Nov 2019 12:09:38 GMT, Jorn Vernee wrote: > https://bugs.openjdk.java.net/browse/SKARA-153 > > Trying to create a webrev in a Git repo that does not have a remote named "origin" causes the following exception: > Exception in thread "main" java.io.IOException: No pull path found for remote origin > at org.openjdk.skara.vcs/org.openjdk.skara.vcs.git.GitRepository.pullPath(GitRepository.java:934) > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitWebrev.generate(GitWebrev.java:159) > at org.openjdk.skara.args/org.openjdk.skara.args.Command.main(Command.java:54) > at org.openjdk.skara.args/org.openjdk.skara.args.MultiCommandParser.lambda$parse$2(MultiCommandParser.java:64) > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitWebrev.main(GitWebrev.java:306) > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:127) > > It seems that the pullPath is only used to generate a title for the webrev. So, it would be good to check whether the remote exists first, to avoid an exception, and rely on the fallback behaviour of using the filename as a title instead. > > ---------------- > > Commits: > - 45e6d505: Check if origin remote exists before trying to get the pullPath > > Changes: https://git.openjdk.java.net/skara/pull/244/files > Webrev: https://webrevs.openjdk.java.net/skara/244/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-153 > Stats: 11 lines in 1 file changed: 2 ins; 0 del; 9 mod > Patch: https://git.openjdk.java.net/skara/pull/244.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/244/head:pull/244 Looks good. We should probably rework `ReadOnlyRepository.pullPath` to return `Optional`, but that can be done in a later patch. ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/244 From jvernee at openjdk.org Mon Nov 11 09:23:30 2019 From: jvernee at openjdk.org (Jorn Vernee) Date: Mon, 11 Nov 2019 09:23:30 GMT Subject: [Integrated] RFR: 153: Check if origin remote exists before trying to get the pullPath In-Reply-To: <-zcPU4rEcoMhS-iVd9VGNCAwv1zx42A0Ki1XwSsSMBI=.2b168b9e-a1f7-41e7-be15-7fbd8f5057ef@github.com> References: <-zcPU4rEcoMhS-iVd9VGNCAwv1zx42A0Ki1XwSsSMBI=.2b168b9e-a1f7-41e7-be15-7fbd8f5057ef@github.com> Message-ID: <29dcd6c6-92cb-4d4c-82d3-40c1783cf513@openjdk.org> Changeset: 94ccf841 Author: Jorn Vernee Date: 2019-11-11 09:23:15 +0000 URL: https://git.openjdk.java.net/skara/commit/94ccf841 153: Check if origin remote exists before trying to get the pullPath Reviewed-by: ehelin ! cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java From rwestberg at openjdk.org Mon Nov 11 09:36:06 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 11 Nov 2019 09:36:06 GMT Subject: RFR: Bridgekeeper bot Message-ID: Hi all, Please review this change that implements a "Bridgekeeper" bot. It can be enabled for mirror repositories that do not currently accept pull requests. Best regards, Robin ---------------- Commits: - 869b7a98: Initial implementation Changes: https://git.openjdk.java.net/skara/pull/245/files Webrev: https://webrevs.openjdk.java.net/skara/245/webrev.00 Stats: 338 lines in 6 files changed: 338 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/245.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/245/head:pull/245 PR: https://git.openjdk.java.net/skara/pull/245 From ehelin at openjdk.org Mon Nov 11 10:10:34 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 11 Nov 2019 10:10:34 GMT Subject: RFR: Update to Gradle 6.0 Message-ID: Hi all, please review this patch that updates Gradle to version 6.0. I had to fix two minor deprecation warnings: - `runtime` -> `runtimeOnly` - `version` -> `archiveVersion` Thanks, Erik ## Testing - [x] `sh gradlew test --warning-mode all` - [x] `sh gradlew images --warning-mode all` - Various manual testing of different build targets ---------------- Commits: - 146cd6f6: Update to Gradle 6.0 Changes: https://git.openjdk.java.net/skara/pull/246/files Webrev: https://webrevs.openjdk.java.net/skara/246/webrev.00 Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/246.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/246/head:pull/246 PR: https://git.openjdk.java.net/skara/pull/246 From rwestberg at openjdk.org Mon Nov 11 12:59:23 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 11 Nov 2019 12:59:23 GMT Subject: [Approved] RFR: Update to Gradle 6.0 In-Reply-To: References: Message-ID: On Mon, 11 Nov 2019 10:10:34 GMT, Erik Helin wrote: > Hi all, > > please review this patch that updates Gradle to version 6.0. I had to fix two minor deprecation warnings: > - `runtime` -> `runtimeOnly` > - `version` -> `archiveVersion` > > Thanks, > Erik > > ## Testing > - [x] `sh gradlew test --warning-mode all` > - [x] `sh gradlew images --warning-mode all` > - Various manual testing of different build targets > > ---------------- > > Commits: > - 146cd6f6: Update to Gradle 6.0 > > Changes: https://git.openjdk.java.net/skara/pull/246/files > Webrev: https://webrevs.openjdk.java.net/skara/246/webrev.00 > Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod > Patch: https://git.openjdk.java.net/skara/pull/246.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/246/head:pull/246 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/246 From rwestberg at openjdk.org Mon Nov 11 13:09:44 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 11 Nov 2019 13:09:44 GMT Subject: [Rev 01] RFR: Bridgekeeper bot In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - e1ced0ba: Fix build issue Changes: - all: https://git.openjdk.java.net/skara/pull/245/files - new: https://git.openjdk.java.net/skara/pull/245/files/869b7a98..e1ced0ba Webrevs: - full: https://webrevs.openjdk.java.net/skara/245/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/245/webrev.00-01 Stats: 3 lines in 2 files changed: 2 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/245.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/245/head:pull/245 PR: https://git.openjdk.java.net/skara/pull/245 From ehelin at openjdk.org Mon Nov 11 13:24:00 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 11 Nov 2019 13:24:00 GMT Subject: [Integrated] RFR: Update to Gradle 6.0 In-Reply-To: References: Message-ID: <3d1227fd-0d4d-4b4d-b98e-5c09914bb003@openjdk.org> Changeset: 49bbd418 Author: Erik Helin Date: 2019-11-11 13:23:45 +0000 URL: https://git.openjdk.java.net/skara/commit/49bbd418 Update to Gradle 6.0 Reviewed-by: rwestberg ! buildSrc/build.gradle ! cli/build.gradle ! deps.env From ehelin at openjdk.org Mon Nov 11 14:10:52 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 11 Nov 2019 14:10:52 GMT Subject: [Approved] RFR: Bridgekeeper bot In-Reply-To: References: Message-ID: On Mon, 11 Nov 2019 13:09:44 GMT, Robin Westberg wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - e1ced0ba: Fix build issue > > Changes: > - all: https://git.openjdk.java.net/skara/pull/245/files > - new: https://git.openjdk.java.net/skara/pull/245/files/869b7a98..e1ced0ba > > Webrevs: > - full: https://webrevs.openjdk.java.net/skara/245/webrev.01 > - incr: https://webrevs.openjdk.java.net/skara/245/webrev.00-01 > > Stats: 3 lines in 2 files changed: 2 ins; 1 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/245.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/245/head:pull/245 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/245 From rwestberg at openjdk.org Mon Nov 11 14:19:30 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 11 Nov 2019 14:19:30 GMT Subject: [Integrated] RFR: Bridgekeeper bot In-Reply-To: References: Message-ID: <70a841e6-120d-4279-ac9e-48b44139a6a2@openjdk.org> Changeset: 2a8f113c Author: Robin Westberg Date: 2019-11-11 14:19:15 +0000 URL: https://git.openjdk.java.net/skara/commit/2a8f113c Bridgekeeper bot Reviewed-by: ehelin + bots/bridgekeeper/build.gradle + bots/bridgekeeper/src/main/java/module-info.java + bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/BridgekeeperBot.java + bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/BridgekeeperBotFactory.java + bots/bridgekeeper/src/test/java/org/openjdk/skara/bots/bridgekeeper/BridgekeeperBotTests.java ! settings.gradle From rwestberg at openjdk.org Mon Nov 11 14:24:54 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 11 Nov 2019 14:24:54 GMT Subject: RFR: Add pull request prune functionality Message-ID: Hi all, Please review this change that adds another mode to the bridgekeeper bot that closes PRs after a configurable period of inactivity. Best regards, Robin ---------------- Commits: - 83c41425: Add pull request pruner bot Changes: https://git.openjdk.java.net/skara/pull/247/files Webrev: https://webrevs.openjdk.java.net/skara/247/webrev.00 Stats: 640 lines in 7 files changed: 420 ins; 218 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/247.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/247/head:pull/247 PR: https://git.openjdk.java.net/skara/pull/247 From ehelin at openjdk.org Mon Nov 11 14:24:57 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 11 Nov 2019 14:24:57 GMT Subject: [Approved] RFR: Add pull request prune functionality In-Reply-To: References: Message-ID: On Mon, 11 Nov 2019 14:24:54 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adds another mode to the bridgekeeper bot that closes PRs after a configurable period of inactivity. > > Best regards, > Robin > > ---------------- > > Commits: > - 83c41425: Add pull request pruner bot > > Changes: https://git.openjdk.java.net/skara/pull/247/files > Webrev: https://webrevs.openjdk.java.net/skara/247/webrev.00 > Stats: 640 lines in 7 files changed: 420 ins; 218 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/247.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/247/head:pull/247 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/247 From rwestberg at openjdk.org Mon Nov 11 14:31:24 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 11 Nov 2019 14:31:24 GMT Subject: [Rev 01] RFR: Add pull request prune functionality In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 9983c27b: Improve test robustness Changes: - all: https://git.openjdk.java.net/skara/pull/247/files - new: https://git.openjdk.java.net/skara/pull/247/files/83c41425..9983c27b Webrevs: - full: https://webrevs.openjdk.java.net/skara/247/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/247/webrev.00-01 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/247.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/247/head:pull/247 PR: https://git.openjdk.java.net/skara/pull/247 From kcr at openjdk.org Mon Nov 11 14:43:10 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 11 Nov 2019 14:43:10 GMT Subject: RFR: Add pull request prune functionality In-Reply-To: References: Message-ID: On Mon, 11 Nov 2019 14:24:54 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adds another mode to the bridgekeeper bot that closes PRs after a configurable period of inactivity. > > Best regards, > Robin > > ---------------- > > Commits: > - 83c41425: Add pull request pruner bot > > Changes: https://git.openjdk.java.net/skara/pull/247/files > Webrev: https://webrevs.openjdk.java.net/skara/247/webrev.00 > Stats: 640 lines in 7 files changed: 420 ins; 218 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/247.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/247/head:pull/247 What is the motivation for doing this? I'm not sure that I would find this a useful behavior. PR: https://git.openjdk.java.net/skara/pull/247 From ehelin at openjdk.org Mon Nov 11 15:46:05 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 11 Nov 2019 15:46:05 GMT Subject: RFR: Add tester bot and ci module Message-ID: Hi all, please review this slightly larger patch that adds the `tester` bot and the `ci` module. The `tester` is the bot supporting the `/test` command in a PR, for example writing `/test tier1`. I wanted to name the bot `test` but it was to annoying to get that work with the already present `test` module ?? Thanks, Erik ## Testing - [x] `sh gradlew test` passes on Linux x64 - [x] Added a bunch of new unit tests for the `tester` bot (`ci` module is just an interface) - [x] Manually tested to deploy the bot ---------------- Commits: - 436deb55: Add tester bot and ci module Changes: https://git.openjdk.java.net/skara/pull/248/files Webrev: https://webrevs.openjdk.java.net/skara/248/webrev.00 Stats: 3356 lines in 39 files changed: 3356 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/248.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/248/head:pull/248 PR: https://git.openjdk.java.net/skara/pull/248 From rwestberg at openjdk.org Mon Nov 11 15:54:36 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 11 Nov 2019 15:54:36 GMT Subject: [Rev 02] RFR: Add pull request prune functionality In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - fa681f06: Updated after feedback Changes: - all: https://git.openjdk.java.net/skara/pull/247/files - new: https://git.openjdk.java.net/skara/pull/247/files/9983c27b..fa681f06 Webrevs: - full: https://webrevs.openjdk.java.net/skara/247/webrev.02 - incr: https://webrevs.openjdk.java.net/skara/247/webrev.01-02 Stats: 43 lines in 2 files changed: 35 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/skara/pull/247.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/247/head:pull/247 PR: https://git.openjdk.java.net/skara/pull/247 From rwestberg at openjdk.org Mon Nov 11 15:56:00 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 11 Nov 2019 15:56:00 GMT Subject: RFR: Add pull request prune functionality In-Reply-To: References: Message-ID: On Mon, 11 Nov 2019 14:43:10 GMT, Kevin Rushforth wrote: > On Mon, 11 Nov 2019 14:24:54 GMT, Robin Westberg wrote: > >> Hi all, >> >> Please review this change that adds another mode to the bridgekeeper bot that closes PRs after a configurable period of inactivity. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - 83c41425: Add pull request pruner bot >> >> Changes: https://git.openjdk.java.net/skara/pull/247/files >> Webrev: https://webrevs.openjdk.java.net/skara/247/webrev.00 >> Stats: 640 lines in 7 files changed: 420 ins; 218 del; 2 mod >> Patch: https://git.openjdk.java.net/skara/pull/247.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/247/head:pull/247 > > What is the motivation for doing this? I'm not sure that I would find this a useful behavior. This will allow stale pull requests to eventually be closed, without manual intervention. The duration can be configured per project (or not enabled at all), as different projects may have different needs. PR: https://git.openjdk.java.net/skara/pull/247 From rwestberg at openjdk.org Mon Nov 11 15:56:39 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 11 Nov 2019 15:56:39 GMT Subject: RFR: Add pull request prune functionality In-Reply-To: References: Message-ID: On Mon, 11 Nov 2019 15:56:00 GMT, Robin Westberg wrote: > On Mon, 11 Nov 2019 14:43:10 GMT, Kevin Rushforth wrote: > >> On Mon, 11 Nov 2019 14:24:54 GMT, Robin Westberg wrote: >> >>> Hi all, >>> >>> Please review this change that adds another mode to the bridgekeeper bot that closes PRs after a configurable period of inactivity. >>> >>> Best regards, >>> Robin >>> >>> ---------------- >>> >>> Commits: >>> - 83c41425: Add pull request pruner bot >>> >>> Changes: https://git.openjdk.java.net/skara/pull/247/files >>> Webrev: https://webrevs.openjdk.java.net/skara/247/webrev.00 >>> Stats: 640 lines in 7 files changed: 420 ins; 218 del; 2 mod >>> Patch: https://git.openjdk.java.net/skara/pull/247.diff >>> Fetch: git fetch https://git.openjdk.java.net/skara pull/247/head:pull/247 >> >> What is the motivation for doing this? I'm not sure that I would find this a useful behavior. > > This will allow stale pull requests to eventually be closed, without manual intervention. The duration can be configured per project (or not enabled at all), as different projects may have different needs. After discussing this a bit with Kevin offline, I've updated the logic a bit to send an initial notice before proceeding with the actual close. PR: https://git.openjdk.java.net/skara/pull/247 From rwestberg at openjdk.org Mon Nov 11 15:57:40 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 11 Nov 2019 15:57:40 GMT Subject: RFR: Add pull request prune functionality In-Reply-To: References: Message-ID: On Mon, 11 Nov 2019 15:56:39 GMT, Robin Westberg wrote: > On Mon, 11 Nov 2019 15:56:00 GMT, Robin Westberg wrote: > >> On Mon, 11 Nov 2019 14:43:10 GMT, Kevin Rushforth wrote: >> >>> On Mon, 11 Nov 2019 14:24:54 GMT, Robin Westberg wrote: >>> >>>> Hi all, >>>> >>>> Please review this change that adds another mode to the bridgekeeper bot that closes PRs after a configurable period of inactivity. >>>> >>>> Best regards, >>>> Robin >>>> >>>> ---------------- >>>> >>>> Commits: >>>> - 83c41425: Add pull request pruner bot >>>> >>>> Changes: https://git.openjdk.java.net/skara/pull/247/files >>>> Webrev: https://webrevs.openjdk.java.net/skara/247/webrev.00 >>>> Stats: 640 lines in 7 files changed: 420 ins; 218 del; 2 mod >>>> Patch: https://git.openjdk.java.net/skara/pull/247.diff >>>> Fetch: git fetch https://git.openjdk.java.net/skara pull/247/head:pull/247 >>> >>> What is the motivation for doing this? I'm not sure that I would find this a useful behavior. >> >> This will allow stale pull requests to eventually be closed, without manual intervention. The duration can be configured per project (or not enabled at all), as different projects may have different needs. > > After discussing this a bit with Kevin offline, I've updated the logic a bit to send an initial notice before proceeding with the actual close. @edvbld Please have another look! PR: https://git.openjdk.java.net/skara/pull/247 From rwestberg at openjdk.org Mon Nov 11 16:05:32 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 11 Nov 2019 16:05:32 GMT Subject: [Approved] RFR: Add tester bot and ci module In-Reply-To: References: Message-ID: On Mon, 11 Nov 2019 15:46:05 GMT, Erik Helin wrote: > Hi all, > > please review this slightly larger patch that adds the `tester` bot and the `ci` module. The `tester` is the bot supporting the `/test` command in a PR, for example writing `/test tier1`. I wanted to name the bot `test` but it was to annoying to get that work with the already present `test` module ?? > > Thanks, > Erik > > ## Testing > - [x] `sh gradlew test` passes on Linux x64 > - [x] Added a bunch of new unit tests for the `tester` bot (`ci` module is just an interface) > - [x] Manually tested to deploy the bot > > ---------------- > > Commits: > - 436deb55: Add tester bot and ci module > > Changes: https://git.openjdk.java.net/skara/pull/248/files > Webrev: https://webrevs.openjdk.java.net/skara/248/webrev.00 > Stats: 3356 lines in 39 files changed: 3356 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/248.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/248/head:pull/248 Looks good! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java line 136: > 135: ret.put(entry.name(), ci.get()); > 136: } else { > 137: throw new ConfigurationError("No continuous integration named with url: " + url); Suggestion: throw new ConfigurationError("No continuous integration could be created from url: " + url); ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/248 From ehelin at openjdk.org Mon Nov 11 16:06:48 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 11 Nov 2019 16:06:48 GMT Subject: RFR: Update to JDK 13.0.1 Message-ID: Hi all, please review this small patch that updates to JDK 13.0.1 ?? Thanks, Erik ## Testing - [x] `sh gradlew images` passes - [x] `sh gradlew test` passes on Linux x64 ---------------- Commits: - d6decf00: Update to JDK 13.0.1 Changes: https://git.openjdk.java.net/skara/pull/249/files Webrev: https://webrevs.openjdk.java.net/skara/249/webrev.00 Stats: 14 lines in 3 files changed: 0 ins; 0 del; 14 mod Patch: https://git.openjdk.java.net/skara/pull/249.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/249/head:pull/249 PR: https://git.openjdk.java.net/skara/pull/249 From rwestberg at openjdk.org Mon Nov 11 16:09:22 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 11 Nov 2019 16:09:22 GMT Subject: [Approved] RFR: Update to JDK 13.0.1 In-Reply-To: References: Message-ID: On Mon, 11 Nov 2019 16:06:48 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that updates to JDK 13.0.1 ?? > > Thanks, > Erik > > ## Testing > - [x] `sh gradlew images` passes > - [x] `sh gradlew test` passes on Linux x64 > > ---------------- > > Commits: > - d6decf00: Update to JDK 13.0.1 > > Changes: https://git.openjdk.java.net/skara/pull/249/files > Webrev: https://webrevs.openjdk.java.net/skara/249/webrev.00 > Stats: 14 lines in 3 files changed: 0 ins; 0 del; 14 mod > Patch: https://git.openjdk.java.net/skara/pull/249.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/249/head:pull/249 Good stuff! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/249 From kcr at openjdk.org Mon Nov 11 16:25:52 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 11 Nov 2019 16:25:52 GMT Subject: [Rev 02] RFR: Add pull request prune functionality In-Reply-To: References: Message-ID: On Mon, 11 Nov 2019 15:54:36 GMT, Robin Westberg wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - fa681f06: Updated after feedback > > Changes: > - all: https://git.openjdk.java.net/skara/pull/247/files > - new: https://git.openjdk.java.net/skara/pull/247/files/9983c27b..fa681f06 > > Webrevs: > - full: https://webrevs.openjdk.java.net/skara/247/webrev.02 > - incr: https://webrevs.openjdk.java.net/skara/247/webrev.01-02 > > Stats: 43 lines in 2 files changed: 35 ins; 0 del; 8 mod > Patch: https://git.openjdk.java.net/skara/pull/247.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/247/head:pull/247 Looks good. ---------------- Approved by kcr (none). PR: https://git.openjdk.java.net/skara/pull/247 From ehelin at openjdk.org Tue Nov 12 09:02:12 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 12 Nov 2019 09:02:12 GMT Subject: [Integrated] RFR: Add tester bot and ci module In-Reply-To: References: Message-ID: <48e1fb2a-b308-4b98-9f85-ae236242883f@openjdk.org> Changeset: 980b7a87 Author: Erik Helin Date: 2019-11-12 09:01:57 +0000 URL: https://git.openjdk.java.net/skara/commit/980b7a87 Add tester bot and ci module Reviewed-by: rwestberg ! bot/build.gradle ! bot/src/main/java/module-info.java ! bot/src/main/java/org/openjdk/skara/bot/BotConfiguration.java ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java ! bots/bridgekeeper/build.gradle ! bots/cli/build.gradle ! bots/forward/build.gradle ! bots/hgbridge/build.gradle ! bots/merge/build.gradle ! bots/mirror/build.gradle ! bots/mlbridge/build.gradle ! bots/notify/build.gradle ! bots/pr/build.gradle ! bots/submit/build.gradle + bots/tester/build.gradle + bots/tester/src/main/java/module-info.java + bots/tester/src/main/java/org/openjdk/skara/bots/tester/Stage.java + bots/tester/src/main/java/org/openjdk/skara/bots/tester/State.java + bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestBot.java + bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestBotFactory.java + bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestWorkItem.java + bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryContinuousIntegration.java + bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryHost.java + bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryHostedRepository.java + bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryJob.java + bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java + bots/tester/src/test/java/org/openjdk/skara/bots/tester/StateTests.java + bots/tester/src/test/java/org/openjdk/skara/bots/tester/TestBotTests.java + bots/tester/src/test/java/org/openjdk/skara/bots/tester/TestWorkItemTests.java ! bots/topological/build.gradle + ci/build.gradle + ci/src/main/java/module-info.java + ci/src/main/java/org/openjdk/skara/ci/Build.java + ci/src/main/java/org/openjdk/skara/ci/ContinuousIntegration.java + ci/src/main/java/org/openjdk/skara/ci/ContinuousIntegrationFactory.java + ci/src/main/java/org/openjdk/skara/ci/Job.java + ci/src/main/java/org/openjdk/skara/ci/Test.java ! settings.gradle ! test/build.gradle From ehelin at openjdk.org Tue Nov 12 09:07:22 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 12 Nov 2019 09:07:22 GMT Subject: [Integrated] RFR: Update to JDK 13.0.1 In-Reply-To: References: Message-ID: <37da28ae-d4c5-4d52-8ac2-ac98a40ce47a@openjdk.org> Changeset: 56b9f651 Author: Erik Helin Date: 2019-11-12 09:07:06 +0000 URL: https://git.openjdk.java.net/skara/commit/56b9f651 Update to JDK 13.0.1 Reviewed-by: rwestberg ! bots/cli/build.gradle ! cli/build.gradle ! deps.env From rwestberg at openjdk.org Tue Nov 12 13:18:22 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 12 Nov 2019 13:18:22 GMT Subject: RFR: Add pull request prune functionality In-Reply-To: References: Message-ID: <6tU_pxd-61y977IBwQlZu3tqIbseQ6p4BazyErWYfwE=.651fda06-155b-4507-8d0a-4a5be39a7c9c@github.com> On Mon, 11 Nov 2019 15:57:40 GMT, Robin Westberg wrote: > On Mon, 11 Nov 2019 15:56:39 GMT, Robin Westberg wrote: > >> On Mon, 11 Nov 2019 15:56:00 GMT, Robin Westberg wrote: >> >>> On Mon, 11 Nov 2019 14:43:10 GMT, Kevin Rushforth wrote: >>> >>>> On Mon, 11 Nov 2019 14:24:54 GMT, Robin Westberg wrote: >>>> >>>>> Hi all, >>>>> >>>>> Please review this change that adds another mode to the bridgekeeper bot that closes PRs after a configurable period of inactivity. >>>>> >>>>> Best regards, >>>>> Robin >>>>> >>>>> ---------------- >>>>> >>>>> Commits: >>>>> - 83c41425: Add pull request pruner bot >>>>> >>>>> Changes: https://git.openjdk.java.net/skara/pull/247/files >>>>> Webrev: https://webrevs.openjdk.java.net/skara/247/webrev.00 >>>>> Stats: 640 lines in 7 files changed: 420 ins; 218 del; 2 mod >>>>> Patch: https://git.openjdk.java.net/skara/pull/247.diff >>>>> Fetch: git fetch https://git.openjdk.java.net/skara pull/247/head:pull/247 >>>> >>>> What is the motivation for doing this? I'm not sure that I would find this a useful behavior. >>> >>> This will allow stale pull requests to eventually be closed, without manual intervention. The duration can be configured per project (or not enabled at all), as different projects may have different needs. >> >> After discussing this a bit with Kevin offline, I've updated the logic a bit to send an initial notice before proceeding with the actual close. > > @edvbld Please have another look! @kevinrushforth Thanks for reviewing! PR: https://git.openjdk.java.net/skara/pull/247 From rwestberg at openjdk.org Tue Nov 12 13:18:50 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 12 Nov 2019 13:18:50 GMT Subject: [Integrated] RFR: Add pull request prune functionality In-Reply-To: References: Message-ID: Changeset: e75c0b06 Author: Robin Westberg Date: 2019-11-12 13:18:36 +0000 URL: https://git.openjdk.java.net/skara/commit/e75c0b06 Add pull request prune functionality Reviewed-by: ehelin, kcr - bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/BridgekeeperBot.java ! bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/BridgekeeperBotFactory.java + bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestCloserBot.java + bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestPrunerBot.java - bots/bridgekeeper/src/test/java/org/openjdk/skara/bots/bridgekeeper/BridgekeeperBotTests.java + bots/bridgekeeper/src/test/java/org/openjdk/skara/bots/bridgekeeper/PullRequestCloserBotTests.java + bots/bridgekeeper/src/test/java/org/openjdk/skara/bots/bridgekeeper/PullRequestPrunerBotTests.java From rwestberg at openjdk.org Tue Nov 12 13:26:16 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 12 Nov 2019 13:26:16 GMT Subject: RFR: Update messages when a reviewer isn't a project member Message-ID: Hi all, Please review this small change that updates the role message for reviewers that are either not project members or not OpenJDK authors. Best regards, Robin ---------------- Commits: - 107f2991: Update messages when a reviewer isn't a project member or not an OpenJDK author Changes: https://git.openjdk.java.net/skara/pull/250/files Webrev: https://webrevs.openjdk.java.net/skara/250/webrev.00 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/250.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/250/head:pull/250 PR: https://git.openjdk.java.net/skara/pull/250 From ehelin at openjdk.org Tue Nov 12 13:35:20 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 12 Nov 2019 13:35:20 GMT Subject: [Approved] RFR: Update messages when a reviewer isn't a project member In-Reply-To: References: Message-ID: On Tue, 12 Nov 2019 13:26:16 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that updates the role message for reviewers that are either not project members or not OpenJDK authors. > > Best regards, > Robin > > ---------------- > > Commits: > - 107f2991: Update messages when a reviewer isn't a project member or not an OpenJDK author > > Changes: https://git.openjdk.java.net/skara/pull/250/files > Webrev: https://webrevs.openjdk.java.net/skara/250/webrev.00 > Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/250.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/250/head:pull/250 Looks good, nice touch-up! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/250 From rwestberg at openjdk.org Tue Nov 12 13:51:51 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 12 Nov 2019 13:51:51 GMT Subject: RFR: Add bridgekeeper bot to bot cli image Message-ID: <5JBNwRtOuiRwYeJPSnQlQAm_YGfUDrBCOLvC-8lz0hM=.e1bf2bbe-1045-48f8-ae7b-59a0a849ebf4@github.com> Hi all, Please review this minor change that adds the bridgekeeper to the bot cli image. Best regard, Robin ---------------- Commits: - 0d1acaf7: Add bridgekeeper bot to bot cli image Changes: https://git.openjdk.java.net/skara/pull/251/files Webrev: https://webrevs.openjdk.java.net/skara/251/webrev.00 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/251.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/251/head:pull/251 PR: https://git.openjdk.java.net/skara/pull/251 From ehelin at openjdk.org Tue Nov 12 13:54:24 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 12 Nov 2019 13:54:24 GMT Subject: [Approved] RFR: Add bridgekeeper bot to bot cli image In-Reply-To: <5JBNwRtOuiRwYeJPSnQlQAm_YGfUDrBCOLvC-8lz0hM=.e1bf2bbe-1045-48f8-ae7b-59a0a849ebf4@github.com> References: <5JBNwRtOuiRwYeJPSnQlQAm_YGfUDrBCOLvC-8lz0hM=.e1bf2bbe-1045-48f8-ae7b-59a0a849ebf4@github.com> Message-ID: On Tue, 12 Nov 2019 13:51:51 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that adds the bridgekeeper to the bot cli image. > > Best regard, > Robin > > ---------------- > > Commits: > - 0d1acaf7: Add bridgekeeper bot to bot cli image > > Changes: https://git.openjdk.java.net/skara/pull/251/files > Webrev: https://webrevs.openjdk.java.net/skara/251/webrev.00 > Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/251.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/251/head:pull/251 #classic ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/251 From rwestberg at openjdk.org Tue Nov 12 13:56:04 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 12 Nov 2019 13:56:04 GMT Subject: [Integrated] RFR: Update messages when a reviewer isn't a project member In-Reply-To: References: Message-ID: <024e4d2e-b114-4407-ac93-d570889f1814@openjdk.org> Changeset: 592533cd Author: Robin Westberg Date: 2019-11-12 13:55:47 +0000 URL: https://git.openjdk.java.net/skara/commit/592533cd Update messages when a reviewer isn't a project member Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java From rwestberg at openjdk.org Tue Nov 12 14:02:05 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 12 Nov 2019 14:02:05 GMT Subject: [Integrated] RFR: Add bridgekeeper bot to bot cli image In-Reply-To: <5JBNwRtOuiRwYeJPSnQlQAm_YGfUDrBCOLvC-8lz0hM=.e1bf2bbe-1045-48f8-ae7b-59a0a849ebf4@github.com> References: <5JBNwRtOuiRwYeJPSnQlQAm_YGfUDrBCOLvC-8lz0hM=.e1bf2bbe-1045-48f8-ae7b-59a0a849ebf4@github.com> Message-ID: <2ef42a70-59ba-47a9-b3f5-b2c29ce63ec9@openjdk.org> Changeset: e60df76c Author: Robin Westberg Date: 2019-11-12 14:01:48 +0000 URL: https://git.openjdk.java.net/skara/commit/e60df76c Add bridgekeeper bot to bot cli image Reviewed-by: ehelin ! bots/cli/build.gradle From rwestberg at openjdk.org Tue Nov 12 14:35:26 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 12 Nov 2019 14:35:26 GMT Subject: RFR: Add missing bridgekeeper dependency Message-ID: Hi all, Please review this final change regarding proper bridgekeeper bot dependencies. Best regards, Robin ---------------- Commits: - b199a7ba: Add missing dependency Changes: https://git.openjdk.java.net/skara/pull/252/files Webrev: https://webrevs.openjdk.java.net/skara/252/webrev.00 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/252.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/252/head:pull/252 PR: https://git.openjdk.java.net/skara/pull/252 From ehelin at openjdk.org Tue Nov 12 14:35:41 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 12 Nov 2019 14:35:41 GMT Subject: [Approved] RFR: Add missing bridgekeeper dependency In-Reply-To: References: Message-ID: On Tue, 12 Nov 2019 14:35:26 GMT, Robin Westberg wrote: > Hi all, > > Please review this final change regarding proper bridgekeeper bot dependencies. > > Best regards, > Robin > > ---------------- > > Commits: > - b199a7ba: Add missing dependency > > Changes: https://git.openjdk.java.net/skara/pull/252/files > Webrev: https://webrevs.openjdk.java.net/skara/252/webrev.00 > Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/252.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/252/head:pull/252 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/252 From rwestberg at openjdk.org Tue Nov 12 14:36:29 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 12 Nov 2019 14:36:29 GMT Subject: [Integrated] RFR: Add missing bridgekeeper dependency In-Reply-To: References: Message-ID: <0f523e90-e04e-4f9b-92d2-844737220956@openjdk.org> Changeset: f7e71e62 Author: Robin Westberg Date: 2019-11-12 14:36:15 +0000 URL: https://git.openjdk.java.net/skara/commit/f7e71e62 Add missing bridgekeeper dependency Reviewed-by: ehelin ! bots/cli/build.gradle From joe.darcy at oracle.com Tue Nov 12 17:16:39 2019 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 12 Nov 2019 09:16:39 -0800 Subject: FYI, New candidate JEP: 369: Migrate to GitHub Message-ID: Hello, A new candidate JEP, JEP: 369: "Migrate to GitHub (https://openjdk.java.net/jeps/369), has been published. -Joe From rwestberg at openjdk.org Mon Nov 18 15:21:38 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 18 Nov 2019 15:21:38 GMT Subject: RFR: Improve MimeText conformance Message-ID: Hi all, Please review this change that improves the conformance of the MimeText encoder. Notably, create encode tokens at word boundaries and encode spaces between tokens. Best regards, Robin ---------------- Commits: - b3908d16: Improve MimeText conformance Changes: https://git.openjdk.java.net/skara/pull/255/files Webrev: https://webrevs.openjdk.java.net/skara/255/webrev.00 Stats: 99 lines in 2 files changed: 74 ins; 2 del; 23 mod Patch: https://git.openjdk.java.net/skara/pull/255.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/255/head:pull/255 PR: https://git.openjdk.java.net/skara/pull/255 From ehelin at openjdk.org Mon Nov 18 15:23:06 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 18 Nov 2019 15:23:06 GMT Subject: [Approved] RFR: Improve MimeText conformance In-Reply-To: References: Message-ID: On Mon, 18 Nov 2019 15:21:38 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that improves the conformance of the MimeText encoder. Notably, create encode tokens at word boundaries and encode spaces between tokens. > > Best regards, > Robin > > ---------------- > > Commits: > - b3908d16: Improve MimeText conformance > > Changes: https://git.openjdk.java.net/skara/pull/255/files > Webrev: https://webrevs.openjdk.java.net/skara/255/webrev.00 > Stats: 99 lines in 2 files changed: 74 ins; 2 del; 23 mod > Patch: https://git.openjdk.java.net/skara/pull/255.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/255/head:pull/255 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/255 From rwestberg at openjdk.org Mon Nov 18 15:43:12 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 18 Nov 2019 15:43:12 GMT Subject: RFR: Improve MimeText conformance In-Reply-To: References: Message-ID: On Mon, 18 Nov 2019 15:21:38 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that improves the conformance of the MimeText encoder. Notably, create encode tokens at word boundaries and encode spaces between tokens. > > Best regards, > Robin > > ---------------- > > Commits: > - b3908d16: Improve MimeText conformance > > Changes: https://git.openjdk.java.net/skara/pull/255/files > Webrev: https://webrevs.openjdk.java.net/skara/255/webrev.00 > Stats: 99 lines in 2 files changed: 74 ins; 2 del; 23 mod > Patch: https://git.openjdk.java.net/skara/pull/255.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/255/head:pull/255 Thanks for reviewing! PR: https://git.openjdk.java.net/skara/pull/255 From ehelin at openjdk.org Mon Nov 18 15:48:21 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 18 Nov 2019 15:48:21 GMT Subject: RFR: git-sync --fetch is a no-op Message-ID: Hi all, please review this smallp patch that just removes the `--fetch` option from `git-sync`. The option is not needed since `git-sync` always implicitly does a fetch, so there is no point in providing this flag. Thanks, Erik ---------------- Commits: - cc74e5cd: git-sync --fetch is a no-op Changes: https://git.openjdk.java.net/skara/pull/256/files Webrev: https://webrevs.openjdk.java.net/skara/256/webrev.00 Stats: 15 lines in 1 file changed: 0 ins; 15 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/256.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/256/head:pull/256 PR: https://git.openjdk.java.net/skara/pull/256 From clanger at openjdk.org Mon Nov 18 15:59:08 2019 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 18 Nov 2019 15:59:08 GMT Subject: RFR: Rename encoding/src/main/java/org/openjdk/skara/base85/Base85.java Message-ID: Rename encoding/src/main/java/org/openjdk/skara/base85/Base85.java ---------------- Commits: - 7fcd37ac: Rename encoding/src/main/java/org/openjdk/skara/base85/Base85.java Changes: https://git.openjdk.java.net/skara/pull/257/files Webrev: https://webrevs.openjdk.java.net/skara/257/webrev.00 Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/257.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/257/head:pull/257 PR: https://git.openjdk.java.net/skara/pull/257 From ehelin at openjdk.org Tue Nov 19 09:03:39 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 19 Nov 2019 09:03:39 GMT Subject: [Rev 01] RFR: git-sync --fetch is a no-op In-Reply-To: References: Message-ID: <09DSTn0Lb6xEhiNnNw1yXNxBKo5ejRGAOie3V6ozJcM=.4ee6b41f-59ab-4a7d-b35c-f3e725fb846b@github.com> The pull request has been updated with additional changes. ---------------- Added commits: - db346fcf: Remove spurious curly brace Changes: - all: https://git.openjdk.java.net/skara/pull/256/files - new: https://git.openjdk.java.net/skara/pull/256/files/cc74e5cd..db346fcf Webrevs: - full: https://webrevs.openjdk.java.net/skara/256/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/256/webrev.00-01 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/256.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/256/head:pull/256 PR: https://git.openjdk.java.net/skara/pull/256 From ehelin at openjdk.org Tue Nov 19 09:06:21 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 19 Nov 2019 09:06:21 GMT Subject: [Approved] RFR: Rename encoding/src/main/java/org/openjdk/skara/base85/Base85.java In-Reply-To: References: Message-ID: On Mon, 18 Nov 2019 15:59:08 GMT, Christoph Langer wrote: > Rename encoding/src/main/java/org/openjdk/skara/base85/Base85.java > > ---------------- > > Commits: > - 7fcd37ac: Rename encoding/src/main/java/org/openjdk/skara/base85/Base85.java > > Changes: https://git.openjdk.java.net/skara/pull/257/files > Webrev: https://webrevs.openjdk.java.net/skara/257/webrev.00 > Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/257.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/257/head:pull/257 Thanks for contributing @RealCLanger, the patch looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/257 From ehelin at openjdk.org Tue Nov 19 09:52:54 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 19 Nov 2019 09:52:54 GMT Subject: [Integrated] RFR: Rename encoding/src/main/java/org/openjdk/skara/base85/Base85.java In-Reply-To: References: Message-ID: Changeset: 83f70fda Author: Christoph Langer Committer: Erik Helin Date: 2019-11-19 09:52:34 +0000 URL: https://git.openjdk.java.net/skara/commit/83f70fda Rename encoding/src/main/java/org/openjdk/skara/base85/Base85.java Move Base85.java to the right location (encoding/src/main/java/org/openjdk/skara/encoding) Reviewed-by: ehelin = encoding/src/main/java/org/openjdk/skara/encoding/Base85.java From rwestberg at openjdk.org Tue Nov 19 12:32:34 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 19 Nov 2019 12:32:34 GMT Subject: [Approved] RFR: git-sync --fetch is a no-op In-Reply-To: References: Message-ID: <-f5aN2WXziVBmmfwWRF_KjOWFRqb7Na1S8fg8dX0pQM=.86c219ed-7b15-49e2-bd1d-707f3cd54984@github.com> On Tue, 19 Nov 2019 09:03:39 GMT, Erik Helin wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - db346fcf: Remove spurious curly brace > > Changes: > - all: https://git.openjdk.java.net/skara/pull/256/files > - new: https://git.openjdk.java.net/skara/pull/256/files/cc74e5cd..db346fcf > > Webrevs: > - full: https://webrevs.openjdk.java.net/skara/256/webrev.01 > - incr: https://webrevs.openjdk.java.net/skara/256/webrev.00-01 > > Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/256.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/256/head:pull/256 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/256 From ehelin at openjdk.org Tue Nov 19 14:22:58 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 19 Nov 2019 14:22:58 GMT Subject: RFR: Query GitHub for current user when using PAT Message-ID: Hi all, please review this patch that queries GitHub for the current user when using a PAT as credentials with `GitHubHost.java`. The reason for this is that some credentials manager, in particular Git Credential Manager on Windows, always seems to return "PersonalAccessToken" as the username when calling `git credential fill`. The fix is simple, just query the [/user](https://developer.github.com/v3/users/#get-the-authenticated-user) endoint instead of [/users](https://developer.github.com/v3/users/#get-a-single-user). Thanks, Erik ## Testing - Manual testing with `git pr` and PAT on Linux x64 _with_ a bogus username in credential store. ---------------- Commits: - 6a472c74: Query GitHub for current user when using PAT Changes: https://git.openjdk.java.net/skara/pull/258/files Webrev: https://webrevs.openjdk.java.net/skara/258/webrev.00 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/258.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/258/head:pull/258 PR: https://git.openjdk.java.net/skara/pull/258 From ehelin at openjdk.org Tue Nov 19 14:22:59 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 19 Nov 2019 14:22:59 GMT Subject: RFR: Query GitHub for current user when using PAT In-Reply-To: References: Message-ID: On Tue, 19 Nov 2019 14:22:58 GMT, Erik Helin wrote: > Hi all, > > please review this patch that queries GitHub for the current user when using a PAT as credentials with `GitHubHost.java`. The reason for this is that some credentials manager, in particular Git Credential Manager on Windows, always seems to return "PersonalAccessToken" as the username when calling `git credential fill`. The fix is simple, just query the [/user](https://developer.github.com/v3/users/#get-the-authenticated-user) endoint instead of [/users](https://developer.github.com/v3/users/#get-a-single-user). > > Thanks, > Erik > > ## Testing > - Manual testing with `git pr` and PAT on Linux x64 _with_ a bogus username in credential store. > > ---------------- > > Commits: > - 6a472c74: Query GitHub for current user when using PAT > > Changes: https://git.openjdk.java.net/skara/pull/258/files > Webrev: https://webrevs.openjdk.java.net/skara/258/webrev.00 > Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/258.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/258/head:pull/258 Thanks @RealCLanger for helping out with debugging this! PR: https://git.openjdk.java.net/skara/pull/258 From ehelin at openjdk.org Tue Nov 19 14:23:42 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 19 Nov 2019 14:23:42 GMT Subject: [Integrated] RFR: git-sync --fetch is a no-op In-Reply-To: References: Message-ID: Changeset: 47f068b9 Author: Erik Helin Date: 2019-11-19 14:23:24 +0000 URL: https://git.openjdk.java.net/skara/commit/47f068b9 git-sync --fetch is a no-op Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitSync.java From clanger at openjdk.org Tue Nov 19 14:35:13 2019 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 19 Nov 2019 14:35:13 GMT Subject: RFR: Fix parsing of editor commandline in git-pr. Message-ID: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Fix parsing of editor commandline in git-pr. ---------------- Commits: - 199285fc: Fix parsing of editor commandline in git-pr. Changes: https://git.openjdk.java.net/skara/pull/259/files Webrev: https://webrevs.openjdk.java.net/skara/259/webrev.00 Stats: 10 lines in 2 files changed: 8 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/259.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/259/head:pull/259 PR: https://git.openjdk.java.net/skara/pull/259 From clanger at openjdk.org Tue Nov 19 14:38:24 2019 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 19 Nov 2019 14:38:24 GMT Subject: [Rev 01] RFR: Fix parsing of editor commandline in git-pr. In-Reply-To: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 03935f49: Fix parsing of editor commandline in git-pr. Changes: - all: https://git.openjdk.java.net/skara/pull/259/files - new: https://git.openjdk.java.net/skara/pull/259/files/199285fc..03935f49 Webrevs: - full: https://webrevs.openjdk.java.net/skara/259/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/259/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/259.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/259/head:pull/259 PR: https://git.openjdk.java.net/skara/pull/259 From ehelin at openjdk.org Wed Nov 20 09:10:14 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 20 Nov 2019 09:10:14 GMT Subject: RFR: Fix parsing of editor commandline in git-pr. In-Reply-To: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: On Tue, 19 Nov 2019 14:35:13 GMT, Christoph Langer wrote: > Fix parsing of editor commandline in git-pr. > > ---------------- > > Commits: > - 199285fc: Fix parsing of editor commandline in git-pr. > > Changes: https://git.openjdk.java.net/skara/pull/259/files > Webrev: https://webrevs.openjdk.java.net/skara/259/webrev.00 > Stats: 10 lines in 2 files changed: 8 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/259.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/259/head:pull/259 Hi Christoph, thanks for contributing! Just two small nits before I will continue to review this: 1. Please describe what you changed in this pull request. You did not provide a description in this PR. 2. One usually do not end PR titles with a `.`, so please remove that from the title of the PR. Thanks! Erik PR: https://git.openjdk.java.net/skara/pull/259 From clanger at openjdk.org Wed Nov 20 10:21:22 2019 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 20 Nov 2019 10:21:22 GMT Subject: RFR: Fix parsing of editor commandline in git-pr In-Reply-To: References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: On Wed, 20 Nov 2019 09:10:14 GMT, Erik Helin wrote: > On Tue, 19 Nov 2019 14:35:13 GMT, Christoph Langer wrote: > >> Fix parsing of editor commandline in git-pr. >> >> ---------------- >> >> Commits: >> - 199285fc: Fix parsing of editor commandline in git-pr. >> >> Changes: https://git.openjdk.java.net/skara/pull/259/files >> Webrev: https://webrevs.openjdk.java.net/skara/259/webrev.00 >> Stats: 10 lines in 2 files changed: 8 ins; 0 del; 2 mod >> Patch: https://git.openjdk.java.net/skara/pull/259.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/259/head:pull/259 > > Hi Christoph, > > thanks for contributing! Just two small nits before I will continue to review this: > > 1. Please describe what you changed in this pull request. You did not provide a description in this PR. > 2. One usually do not end PR titles with a `.`, so please remove that from the title of the PR. > > Thanks! > Erik > Hi Christoph, > > thanks for contributing! Just two small nits before I will continue to review this: > > 1. Please describe what you changed in this pull request. You did not provide a description in this PR. > 2. One usually do not end PR titles with a `.`, so please remove that from the title of the PR. > > Thanks! > Erik Hi Erik, thanks for pointing out these points. I think I've addressed them. I created the pull request via the Skara tool call "git pr create". I'm wondering whether there is any documentation about this tool? E.g. is there an option to give a pull request description? Also, how is one supposed to refer to a JBS bug (if I created one). Furthermore, git pr has quite a few suboptions. Is there some documentation on what these all are supposed to do? Thanks Christoph PR: https://git.openjdk.java.net/skara/pull/259 From rwestberg at openjdk.org Wed Nov 20 12:48:04 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 20 Nov 2019 12:48:04 GMT Subject: [Approved] RFR: Query GitHub for current user when using PAT In-Reply-To: References: Message-ID: <2IWdLWGlQHf_mhZXRHl4r1pTyYVFCW2HoDqr15mE5N4=.0038aff2-fe37-42b8-937d-631355be0466@github.com> On Tue, 19 Nov 2019 14:22:58 GMT, Erik Helin wrote: > Hi all, > > please review this patch that queries GitHub for the current user when using a PAT as credentials with `GitHubHost.java`. The reason for this is that some credentials manager, in particular Git Credential Manager on Windows, always seems to return "PersonalAccessToken" as the username when calling `git credential fill`. The fix is simple, just query the [/user](https://developer.github.com/v3/users/#get-the-authenticated-user) endoint instead of [/users](https://developer.github.com/v3/users/#get-a-single-user). > > Thanks, > Erik > > ## Testing > - Manual testing with `git pr` and PAT on Linux x64 _with_ a bogus username in credential store. > > ---------------- > > Commits: > - 6a472c74: Query GitHub for current user when using PAT > > Changes: https://git.openjdk.java.net/skara/pull/258/files > Webrev: https://webrevs.openjdk.java.net/skara/258/webrev.00 > Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/258.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/258/head:pull/258 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/258 From rwestberg at openjdk.org Wed Nov 20 12:53:33 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 20 Nov 2019 12:53:33 GMT Subject: [Integrated] RFR: Improve MimeText conformance In-Reply-To: References: Message-ID: <83227f08-db67-4b6b-aa02-0d07d8caf12d@openjdk.org> Changeset: 483310ea Author: Robin Westberg Date: 2019-11-20 12:53:23 +0000 URL: https://git.openjdk.java.net/skara/commit/483310ea Improve MimeText conformance Reviewed-by: ehelin ! email/src/main/java/org/openjdk/skara/email/MimeText.java ! email/src/test/java/org/openjdk/skara/email/MimeTextTests.java From rwestberg at openjdk.java.net Wed Nov 20 14:12:32 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 20 Nov 2019 14:12:32 GMT Subject: RFR: Fix parsing of editor commandline in git-pr In-Reply-To: References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: On Wed, 20 Nov 2019 10:21:22 GMT, Christoph Langer wrote: > On Wed, 20 Nov 2019 09:10:14 GMT, Erik Helin wrote: > >> On Tue, 19 Nov 2019 14:35:13 GMT, Christoph Langer wrote: >> >>> Fix parsing of editor commandline in git-pr. >>> >>> ---------------- >>> >>> Commits: >>> - 199285fc: Fix parsing of editor commandline in git-pr. >>> >>> Changes: https://git.openjdk.java.net/skara/pull/259/files >>> Webrev: https://webrevs.openjdk.java.net/skara/259/webrev.00 >>> Stats: 10 lines in 2 files changed: 8 ins; 0 del; 2 mod >>> Patch: https://git.openjdk.java.net/skara/pull/259.diff >>> Fetch: git fetch https://git.openjdk.java.net/skara pull/259/head:pull/259 >> >> Hi Christoph, >> >> thanks for contributing! Just two small nits before I will continue to review this: >> >> 1. Please describe what you changed in this pull request. You did not provide a description in this PR. >> 2. One usually do not end PR titles with a `.`, so please remove that from the title of the PR. >> >> Thanks! >> Erik > >> Hi Christoph, >> >> thanks for contributing! Just two small nits before I will continue to review this: >> >> 1. Please describe what you changed in this pull request. You did not provide a description in this PR. >> 2. One usually do not end PR titles with a `.`, so please remove that from the title of the PR. >> >> Thanks! >> Erik > > Hi Erik, > > thanks for pointing out these points. I think I've addressed them. > > I created the pull request via the Skara tool call "git pr create". I'm wondering whether there is any documentation about this tool? > E.g. is there an option to give a pull request description? Also, how is one supposed to refer to a JBS bug (if I created one). > Furthermore, git pr has quite a few suboptions. Is there some documentation on what these all are supposed to do? > > Thanks > Christoph The cli tools have documentation in man format here: https://github.com/openjdk/skara/tree/master/cli/resources/man/man1 - unfortunately, this documentation isn't complete yet.. Erik knows most about these tools, but I think when you are prompted to enter a description, it should be of the format: : title Log description PR: https://git.openjdk.java.net/skara/pull/259 From ehelin at openjdk.java.net Wed Nov 20 14:37:13 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 20 Nov 2019 14:37:13 GMT Subject: [Integrated] RFR: Query GitHub for current user when using PAT In-Reply-To: References: Message-ID: Changeset: 2881d91f Author: Erik Helin Date: 2019-11-20 14:37:02 +0000 URL: https://git.openjdk.java.net/skara/commit/2881d91f Query GitHub for current user when using PAT Reviewed-by: rwestberg ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java From ehelin at openjdk.java.net Wed Nov 20 14:42:12 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 20 Nov 2019 14:42:12 GMT Subject: RFR: Fix parsing of editor commandline in git-pr In-Reply-To: References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: On Wed, 20 Nov 2019 14:12:32 GMT, Robin Westberg wrote: > On Wed, 20 Nov 2019 10:21:22 GMT, Christoph Langer wrote: > >> On Wed, 20 Nov 2019 09:10:14 GMT, Erik Helin wrote: >> >>> On Tue, 19 Nov 2019 14:35:13 GMT, Christoph Langer wrote: >>> >>>> Fix parsing of editor commandline in git-pr. >>>> >>>> ---------------- >>>> >>>> Commits: >>>> - 199285fc: Fix parsing of editor commandline in git-pr. >>>> >>>> Changes: https://git.openjdk.java.net/skara/pull/259/files >>>> Webrev: https://webrevs.openjdk.java.net/skara/259/webrev.00 >>>> Stats: 10 lines in 2 files changed: 8 ins; 0 del; 2 mod >>>> Patch: https://git.openjdk.java.net/skara/pull/259.diff >>>> Fetch: git fetch https://git.openjdk.java.net/skara pull/259/head:pull/259 >>> >>> Hi Christoph, >>> >>> thanks for contributing! Just two small nits before I will continue to review this: >>> >>> 1. Please describe what you changed in this pull request. You did not provide a description in this PR. >>> 2. One usually do not end PR titles with a `.`, so please remove that from the title of the PR. >>> >>> Thanks! >>> Erik >> >>> Hi Christoph, >>> >>> thanks for contributing! Just two small nits before I will continue to review this: >>> >>> 1. Please describe what you changed in this pull request. You did not provide a description in this PR. >>> 2. One usually do not end PR titles with a `.`, so please remove that from the title of the PR. >>> >>> Thanks! >>> Erik >> >> Hi Erik, >> >> thanks for pointing out these points. I think I've addressed them. >> >> I created the pull request via the Skara tool call "git pr create". I'm wondering whether there is any documentation about this tool? >> E.g. is there an option to give a pull request description? Also, how is one supposed to refer to a JBS bug (if I created one). >> Furthermore, git pr has quite a few suboptions. Is there some documentation on what these all are supposed to do? >> >> Thanks >> Christoph > > The cli tools have documentation in man format here: https://github.com/openjdk/skara/tree/master/cli/resources/man/man1 - unfortunately, this documentation isn't complete yet.. > > Erik knows most about these tools, but I think when you are prompted to enter a description, it should be of the format: > > : title > > Log description Christopher, as Robin says, we unfortunately only have a man page at the moment (which won't help you very much since you are on Windows). You can get more abbreviated help information by running `git pr -h`. Robin is also right in how you add a longer multiline description to the pull request. As for the regular expression, could you please add a comments above with a few examples. Also, do you really need the quotation marks around the path to `notepad.exe` for `core.editor`? Won't the following suffice: core.editor = C:\Program Files\Notepad++\notepad++.exe -multiInst -notabbar -nosession -noPlugin Thanks, Erik PR: https://git.openjdk.java.net/skara/pull/259 From ehelin at openjdk.java.net Wed Nov 20 14:58:07 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 20 Nov 2019 14:58:07 GMT Subject: RFR: Add config option for git-sync --pull Message-ID: Hi all, please review this small patch that enables configuring `git sync` to always pull the active branch (via the `sync.pull` configuration). If `sync.pull` is set to `always`, for example via `git config sync.pull always` then `git sync` will always try to pull the active branch after a successful sync. Thanks, Erik ## Testing - [x] Manual testing of `git sync` with and without configuration setting ---------------- Commits: - ae8a592a: Add config option for git-sync --pull Changes: https://git.openjdk.java.net/skara/pull/260/files Webrev: https://webrevs.openjdk.java.net/skara/260/webrev.00 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/260.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/260/head:pull/260 PR: https://git.openjdk.java.net/skara/pull/260 From rwestberg at openjdk.java.net Wed Nov 20 15:16:51 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 20 Nov 2019 15:16:51 GMT Subject: [Approved] RFR: Add config option for git-sync --pull In-Reply-To: References: Message-ID: On Wed, 20 Nov 2019 14:58:07 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that enables configuring `git sync` to always pull the active branch (via the `sync.pull` configuration). If `sync.pull` is set to `always`, for example via `git config sync.pull always` then `git sync` will always try to pull the active branch after a successful sync. > > Thanks, > Erik > > ## Testing > - [x] Manual testing of `git sync` with and without configuration setting > > ---------------- > > Commits: > - ae8a592a: Add config option for git-sync --pull > > Changes: https://git.openjdk.java.net/skara/pull/260/files > Webrev: https://webrevs.openjdk.java.net/skara/260/webrev.00 > Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/260.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/260/head:pull/260 Looks good! There is a test failure on mac, but it seems unrelated, so can perhaps be investigated separately. ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/260 From ehelin at openjdk.java.net Thu Nov 21 08:44:52 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 21 Nov 2019 08:44:52 GMT Subject: RFR: Add config option for git-sync --pull In-Reply-To: References: Message-ID: <2bgum9gkQQLY-35KauLf-vyIIJgS_EhOwRPW_CexsMc=.5c0bc0e1-40a0-467e-9113-da24108eb191@github.com> On Wed, 20 Nov 2019 14:58:07 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that enables configuring `git sync` to always pull the active branch (via the `sync.pull` configuration). If `sync.pull` is set to `always`, for example via `git config sync.pull always` then `git sync` will always try to pull the active branch after a successful sync. > > Thanks, > Erik > > ## Testing > - [x] Manual testing of `git sync` with and without configuration setting > > ---------------- > > Commits: > - ae8a592a: Add config option for git-sync --pull > > Changes: https://git.openjdk.java.net/skara/pull/260/files > Webrev: https://webrevs.openjdk.java.net/skara/260/webrev.00 > Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/260.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/260/head:pull/260 Yeah, the macOS test failure is not because of this change. I agree we can integrate this patch and follow up on test failure later. PR: https://git.openjdk.java.net/skara/pull/260 From ehelin at openjdk.java.net Thu Nov 21 08:45:22 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 21 Nov 2019 08:45:22 GMT Subject: [Integrated] RFR: Add config option for git-sync --pull In-Reply-To: References: Message-ID: <9a5b1e60-f199-4ab7-a1d6-4c36880495d0@openjdk.org> Changeset: 1a8ea845 Author: Erik Helin Date: 2019-11-21 08:45:05 +0000 URL: https://git.openjdk.java.net/skara/commit/1a8ea845 Add config option for git-sync --pull Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitSync.java From rwestberg at openjdk.java.net Thu Nov 21 09:48:05 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 21 Nov 2019 09:48:05 GMT Subject: RFR: Treat Jira 4xx errors different from 5xx Message-ID: Hi all, Please review this small change that considers all 4xx errors returned from Jira as permanent (issue not found) errors, while 5xx errors may go away if the operation is retried. Best regards, Robin ---------------- Commits: - 304cee82: Treat 4xx errors different from 5xx Changes: https://git.openjdk.java.net/skara/pull/261/files Webrev: https://webrevs.openjdk.java.net/skara/261/webrev.00 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/261.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/261/head:pull/261 PR: https://git.openjdk.java.net/skara/pull/261 From ehelin at openjdk.java.net Thu Nov 21 10:19:03 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 21 Nov 2019 10:19:03 GMT Subject: [Approved] RFR: Treat Jira 4xx errors different from 5xx In-Reply-To: References: Message-ID: On Thu, 21 Nov 2019 09:48:05 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that considers all 4xx errors returned from Jira as permanent (issue not found) errors, while 5xx errors may go away if the operation is retried. > > Best regards, > Robin > > ---------------- > > Commits: > - 304cee82: Treat 4xx errors different from 5xx > > Changes: https://git.openjdk.java.net/skara/pull/261/files > Webrev: https://webrevs.openjdk.java.net/skara/261/webrev.00 > Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/261.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/261/head:pull/261 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/261 From ehelin at openjdk.java.net Thu Nov 21 10:48:29 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 21 Nov 2019 10:48:29 GMT Subject: RFR: git-sync should use APIs to find upstream Message-ID: Hi all, this patch changes `git-sync` to to use the `Forge` APIs for finding the upstream repository for a personal fork (in case the `upstream` remote is missing). The big part of this change is making `Forge.repository` return `Optional` instead of `HostedRepository` (because a forge may not have the requested repository). Robin, what do you think about these changes? Thanks, Erik ## Testing - [x] Manual testing of `git sync`, both with and without an `upstream` remote ---------------- Commits: - 20e4e200: git-sync should use APIs to find upstream Changes: https://git.openjdk.java.net/skara/pull/262/files Webrev: https://webrevs.openjdk.java.net/skara/262/webrev.00 Stats: 70 lines in 15 files changed: 44 ins; 0 del; 26 mod Patch: https://git.openjdk.java.net/skara/pull/262.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/262/head:pull/262 PR: https://git.openjdk.java.net/skara/pull/262 From rwestberg at openjdk.java.net Thu Nov 21 11:01:02 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 21 Nov 2019 11:01:02 GMT Subject: [Integrated] RFR: Treat Jira 4xx errors different from 5xx In-Reply-To: References: Message-ID: <41c0a50b-e807-4877-a373-17c992796a36@openjdk.org> Changeset: 6bea8f31 Author: Robin Westberg Date: 2019-11-21 11:00:44 +0000 URL: https://git.openjdk.java.net/skara/commit/6bea8f31 Treat Jira 4xx errors different from 5xx Reviewed-by: ehelin ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java From rwestberg at openjdk.java.net Thu Nov 21 13:47:36 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 21 Nov 2019 13:47:36 GMT Subject: RFR: If there are no changes after squashing, fail jcheck Message-ID: Hi all, Please review this change that ensures that if the contents of a PR are identical to the base after squashing, jcheck will fail (as there's nothing to integrate). Previously, this caused an exception. Best regards, Robin ---------------- Commits: - afb5d7b6: If there are no changes after squashing, fail jcheck Changes: https://git.openjdk.java.net/skara/pull/263/files Webrev: https://webrevs.openjdk.java.net/skara/263/webrev.00 Stats: 71 lines in 5 files changed: 51 ins; 4 del; 16 mod Patch: https://git.openjdk.java.net/skara/pull/263.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/263/head:pull/263 PR: https://git.openjdk.java.net/skara/pull/263 From rwestberg at openjdk.java.net Thu Nov 21 14:00:13 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 21 Nov 2019 14:00:13 GMT Subject: [Approved] RFR: git-sync should use APIs to find upstream In-Reply-To: References: Message-ID: On Thu, 21 Nov 2019 10:48:29 GMT, Erik Helin wrote: > Hi all, > > this patch changes `git-sync` to to use the `Forge` APIs for finding the upstream repository for a personal fork (in case the `upstream` remote is missing). The big part of this change is making `Forge.repository` return `Optional` instead of `HostedRepository` (because a forge may not have the requested repository). Robin, what do you think about these changes? > > Thanks, > Erik > > ## Testing > - [x] Manual testing of `git sync`, both with and without an `upstream` remote > > ---------------- > > Commits: > - 20e4e200: git-sync should use APIs to find upstream > > Changes: https://git.openjdk.java.net/skara/pull/262/files > Webrev: https://webrevs.openjdk.java.net/skara/262/webrev.00 > Stats: 70 lines in 15 files changed: 44 ins; 0 del; 26 mod > Patch: https://git.openjdk.java.net/skara/pull/262.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/262/head:pull/262 Looks good, just have one comment! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 141: > 140: var mergeSourceRepo = pr.repository().forge().repository(sourceRepo.get()).get(); > 141: try { > 142: var sourceHash = prInstance.localRepo().fetch(mergeSourceRepo.url(), sourceBranch.get()); Perhaps this (and the other similar ones) could be replaced with `.orElseThrow()` instead? A few are written like this already. ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/262 From rwestberg at openjdk.java.net Fri Nov 22 11:22:42 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 22 Nov 2019 11:22:42 GMT Subject: RFR: 166: Add `/solves` command Message-ID: <7le6Vsko6jt-Jd2xeHbnJxBs7YGNx9E95zJTfk3Jdr4=.95340f7c-8d0b-4f42-8dca-51765141715d@github.com> Hi all, Please review this change that implements the `/solves` command, which allows a PR to reference more than one issue. Best regards, Robin ---------------- Commits: - aa134ef8: Initial implementation of /solves command Changes: https://git.openjdk.java.net/skara/pull/264/files Webrev: https://webrevs.openjdk.java.net/skara/264/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-166 Stats: 407 lines in 7 files changed: 403 ins; 1 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/264.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/264/head:pull/264 PR: https://git.openjdk.java.net/skara/pull/264 From rwestberg at openjdk.java.net Fri Nov 22 11:24:54 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 22 Nov 2019 11:24:54 GMT Subject: RFR: 166: Add `/solves` command In-Reply-To: <7le6Vsko6jt-Jd2xeHbnJxBs7YGNx9E95zJTfk3Jdr4=.95340f7c-8d0b-4f42-8dca-51765141715d@github.com> References: <7le6Vsko6jt-Jd2xeHbnJxBs7YGNx9E95zJTfk3Jdr4=.95340f7c-8d0b-4f42-8dca-51765141715d@github.com> Message-ID: <84nzplCN-1R0hj-6s3LUiIlQ63v8_LMD7ai9TNETb78=.7f43c568-f6e5-41fa-9549-6a38f320dfdc@github.com> On Fri, 22 Nov 2019 11:22:42 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that implements the `/solves` command, which allows a PR to reference more than one issue. > > Best regards, > Robin > > ---------------- > > Commits: > - aa134ef8: Initial implementation of /solves command > > Changes: https://git.openjdk.java.net/skara/pull/264/files > Webrev: https://webrevs.openjdk.java.net/skara/264/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-166 > Stats: 407 lines in 7 files changed: 403 ins; 1 del; 3 mod > Patch: https://git.openjdk.java.net/skara/pull/264.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/264/head:pull/264 Please note that this implementation does not updated the "Issue" list in the summary. As this is only a cosmetic change and does not affect the actual functionality, it will be done in a separate PR. PR: https://git.openjdk.java.net/skara/pull/264 From ehelin at openjdk.java.net Fri Nov 22 11:39:33 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 22 Nov 2019 11:39:33 GMT Subject: [Approved] RFR: If there are no changes after squashing, fail jcheck In-Reply-To: References: Message-ID: On Thu, 21 Nov 2019 13:47:36 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that if the contents of a PR are identical to the base after squashing, jcheck will fail (as there's nothing to integrate). Previously, this caused an exception. > > Best regards, > Robin > > ---------------- > > Commits: > - afb5d7b6: If there are no changes after squashing, fail jcheck > > Changes: https://git.openjdk.java.net/skara/pull/263/files > Webrev: https://webrevs.openjdk.java.net/skara/263/webrev.00 > Stats: 71 lines in 5 files changed: 51 ins; 4 del; 16 mod > Patch: https://git.openjdk.java.net/skara/pull/263.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/263/head:pull/263 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/263 From ehelin at openjdk.java.net Fri Nov 22 11:42:42 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 22 Nov 2019 11:42:42 GMT Subject: [Approved] RFR: 166: Add `/solves` command In-Reply-To: <7le6Vsko6jt-Jd2xeHbnJxBs7YGNx9E95zJTfk3Jdr4=.95340f7c-8d0b-4f42-8dca-51765141715d@github.com> References: <7le6Vsko6jt-Jd2xeHbnJxBs7YGNx9E95zJTfk3Jdr4=.95340f7c-8d0b-4f42-8dca-51765141715d@github.com> Message-ID: On Fri, 22 Nov 2019 11:22:42 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that implements the `/solves` command, which allows a PR to reference more than one issue. > > Best regards, > Robin > > ---------------- > > Commits: > - aa134ef8: Initial implementation of /solves command > > Changes: https://git.openjdk.java.net/skara/pull/264/files > Webrev: https://webrevs.openjdk.java.net/skara/264/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-166 > Stats: 407 lines in 7 files changed: 403 ins; 1 del; 3 mod > Patch: https://git.openjdk.java.net/skara/pull/264.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/264/head:pull/264 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/264 From ehelin at openjdk.java.net Fri Nov 22 12:13:43 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 22 Nov 2019 12:13:43 GMT Subject: [Approved] RFR: git-sync should use APIs to find upstream In-Reply-To: References: Message-ID: On Thu, 21 Nov 2019 14:00:13 GMT, Robin Westberg wrote: > On Thu, 21 Nov 2019 10:48:29 GMT, Erik Helin wrote: > >> Hi all, >> >> this patch changes `git-sync` to to use the `Forge` APIs for finding the upstream repository for a personal fork (in case the `upstream` remote is missing). The big part of this change is making `Forge.repository` return `Optional` instead of `HostedRepository` (because a forge may not have the requested repository). Robin, what do you think about these changes? >> >> Thanks, >> Erik >> >> ## Testing >> - [x] Manual testing of `git sync`, both with and without an `upstream` remote >> >> ---------------- >> >> Commits: >> - 20e4e200: git-sync should use APIs to find upstream >> >> Changes: https://git.openjdk.java.net/skara/pull/262/files >> Webrev: https://webrevs.openjdk.java.net/skara/262/webrev.00 >> Stats: 70 lines in 15 files changed: 44 ins; 0 del; 26 mod >> Patch: https://git.openjdk.java.net/skara/pull/262.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/262/head:pull/262 > > Looks good, just have one comment! > > bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 141: > >> 140: var mergeSourceRepo = pr.repository().forge().repository(sourceRepo.get()).get(); >> 141: try { >> 142: var sourceHash = prInstance.localRepo().fetch(mergeSourceRepo.url(), sourceBranch.get()); > > Perhaps this (and the other similar ones) could be replaced with `.orElseThrow()` instead? A few are written like this already. > > ---------------- > > Approved by rwestberg (Reviewer). Yeah, I agree. Although the effect of a failed `.get()` will be similar (a `NoSuchElementException` will be thrown), I agree that `.orElseThrow()` expresses the intent more clearly to the reader. PR: https://git.openjdk.java.net/skara/pull/262 From ehelin at openjdk.java.net Fri Nov 22 13:03:08 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 22 Nov 2019 13:03:08 GMT Subject: [Rev 01] RFR: git-sync should use APIs to find upstream In-Reply-To: References: Message-ID: <5fFcKunubBxV7zHNqQMupyIkBYBoAMOnk9lGvVAFnnI=.88300d22-de80-4605-8d8d-a455eb5e96bb@github.com> The pull request has been updated with additional changes. ---------------- Added commits: - a5632222: Use .orElseThrow() instead of .get() Changes: - all: https://git.openjdk.java.net/skara/pull/262/files - new: https://git.openjdk.java.net/skara/pull/262/files/20e4e200..a5632222 Webrevs: - full: https://webrevs.openjdk.java.net/skara/262/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/262/webrev.00-01 Stats: 8 lines in 3 files changed: 2 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/262.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/262/head:pull/262 PR: https://git.openjdk.java.net/skara/pull/262 From ehelin at openjdk.java.net Fri Nov 22 13:14:12 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 22 Nov 2019 13:14:12 GMT Subject: [Integrated] RFR: git-sync should use APIs to find upstream In-Reply-To: References: Message-ID: Changeset: 2f8cfc90 Author: Erik Helin Date: 2019-11-22 13:13:55 +0000 URL: https://git.openjdk.java.net/skara/commit/2f8cfc90 git-sync should use APIs to find upstream Reviewed-by: rwestberg ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryHost.java ! cli/src/main/java/org/openjdk/skara/cli/GitFork.java ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java ! cli/src/main/java/org/openjdk/skara/cli/GitSync.java ! cli/src/main/java/org/openjdk/skara/cli/Remote.java ! forge/src/main/java/org/openjdk/skara/forge/Forge.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabHost.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java ! test/src/main/java/org/openjdk/skara/test/CensusBuilder.java ! test/src/main/java/org/openjdk/skara/test/HostCredentials.java ! test/src/main/java/org/openjdk/skara/test/TestHost.java From rwestberg at openjdk.java.net Fri Nov 22 13:53:03 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 22 Nov 2019 13:53:03 GMT Subject: [Integrated] RFR: 166: Add `/solves` command In-Reply-To: <7le6Vsko6jt-Jd2xeHbnJxBs7YGNx9E95zJTfk3Jdr4=.95340f7c-8d0b-4f42-8dca-51765141715d@github.com> References: <7le6Vsko6jt-Jd2xeHbnJxBs7YGNx9E95zJTfk3Jdr4=.95340f7c-8d0b-4f42-8dca-51765141715d@github.com> Message-ID: <5e9306c6-4cb3-4419-a2df-389aa2fa4e39@openjdk.org> Changeset: a77b854b Author: Robin Westberg Date: 2019-11-22 13:52:53 +0000 URL: https://git.openjdk.java.net/skara/commit/a77b854b 166: Add `/solves` command Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java + bots/pr/src/main/java/org/openjdk/skara/bots/pr/SolvesCommand.java + bots/pr/src/main/java/org/openjdk/skara/bots/pr/SolvesTracker.java + bots/pr/src/test/java/org/openjdk/skara/bots/pr/SolvesTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SummaryTests.java From rwestberg at openjdk.java.net Fri Nov 22 15:32:03 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 22 Nov 2019 15:32:03 GMT Subject: RFR: 166: Update PR status in body with multiple issues if needed Message-ID: Hi all, Please review this change that ensures that the status in the PR body is correctly updated when the `/solves` command is used. Best regards, Robin ---------------- Commits: - d52f724f: Update PR status in body with multiple issues if needed Changes: https://git.openjdk.java.net/skara/pull/265/files Webrev: https://webrevs.openjdk.java.net/skara/265/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-166 Stats: 76 lines in 3 files changed: 57 ins; 1 del; 18 mod Patch: https://git.openjdk.java.net/skara/pull/265.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/265/head:pull/265 PR: https://git.openjdk.java.net/skara/pull/265 From rwestberg at openjdk.java.net Sat Nov 23 10:06:35 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 23 Nov 2019 10:06:35 GMT Subject: RFR: 170: Implement setTitle for GitHub pull requests Message-ID: <0SLUafSbU2_O3_e5MNdIb3TPNHwFbTmQi7_eBE3b2DI=.ce3cfd9d-c6b2-4806-959e-2b9834a88ccd@github.com> Hi all, Please review this small change that implements the setTitle PullRequest API for GitHub. Best regards, Robin ---------------- Commits: - ccde4614: Implement setTitle Changes: https://git.openjdk.java.net/skara/pull/266/files Webrev: https://webrevs.openjdk.java.net/skara/266/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-170 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/266.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/266/head:pull/266 PR: https://git.openjdk.java.net/skara/pull/266 From ehelin at openjdk.java.net Mon Nov 25 06:44:41 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 25 Nov 2019 06:44:41 GMT Subject: [Approved] RFR: 166: Update PR status in body with multiple issues if needed In-Reply-To: References: Message-ID: On Fri, 22 Nov 2019 15:32:03 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that the status in the PR body is correctly updated when the `/solves` command is used. > > Best regards, > Robin > > ---------------- > > Commits: > - d52f724f: Update PR status in body with multiple issues if needed > > Changes: https://git.openjdk.java.net/skara/pull/265/files > Webrev: https://webrevs.openjdk.java.net/skara/265/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-166 > Stats: 76 lines in 3 files changed: 57 ins; 1 del; 18 mod > Patch: https://git.openjdk.java.net/skara/pull/265.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/265/head:pull/265 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/265 From ehelin at openjdk.java.net Mon Nov 25 06:45:12 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 25 Nov 2019 06:45:12 GMT Subject: [Approved] RFR: 170: Implement setTitle for GitHub pull requests In-Reply-To: <0SLUafSbU2_O3_e5MNdIb3TPNHwFbTmQi7_eBE3b2DI=.ce3cfd9d-c6b2-4806-959e-2b9834a88ccd@github.com> References: <0SLUafSbU2_O3_e5MNdIb3TPNHwFbTmQi7_eBE3b2DI=.ce3cfd9d-c6b2-4806-959e-2b9834a88ccd@github.com> Message-ID: On Sat, 23 Nov 2019 10:06:35 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that implements the setTitle PullRequest API for GitHub. > > Best regards, > Robin > > ---------------- > > Commits: > - ccde4614: Implement setTitle > > Changes: https://git.openjdk.java.net/skara/pull/266/files > Webrev: https://webrevs.openjdk.java.net/skara/266/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-170 > Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/266.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/266/head:pull/266 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/266 From rwestberg at openjdk.java.net Mon Nov 25 07:01:11 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 25 Nov 2019 07:01:11 GMT Subject: [Integrated] RFR: 166: Update PR status in body with multiple issues if needed In-Reply-To: References: Message-ID: Changeset: 943987fb Author: Robin Westberg Date: 2019-11-25 07:00:52 +0000 URL: https://git.openjdk.java.net/skara/commit/943987fb 166: Update PR status in body with multiple issues if needed Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SolvesTests.java From rwestberg at openjdk.java.net Mon Nov 25 07:01:43 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 25 Nov 2019 07:01:43 GMT Subject: [Integrated] RFR: 170: Implement setTitle for GitHub pull requests In-Reply-To: <0SLUafSbU2_O3_e5MNdIb3TPNHwFbTmQi7_eBE3b2DI=.ce3cfd9d-c6b2-4806-959e-2b9834a88ccd@github.com> References: <0SLUafSbU2_O3_e5MNdIb3TPNHwFbTmQi7_eBE3b2DI=.ce3cfd9d-c6b2-4806-959e-2b9834a88ccd@github.com> Message-ID: Changeset: bdaf9130 Author: Robin Westberg Date: 2019-11-25 07:01:29 +0000 URL: https://git.openjdk.java.net/skara/commit/bdaf9130 170: Implement setTitle for GitHub pull requests Reviewed-by: ehelin ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java From rwestberg at openjdk.java.net Mon Nov 25 08:46:35 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 25 Nov 2019 08:46:35 GMT Subject: RFR: Implement setTitle for GitLab merge requests Message-ID: Hi all, Please review this minor change that implements the setTitle function for GitLab merge requests. Best regards, Robin ---------------- Commits: - dd35f073: Implement setTitle for GitLab merge requests Changes: https://git.openjdk.java.net/skara/pull/268/files Webrev: https://webrevs.openjdk.java.net/skara/268/webrev.00 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/268.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/268/head:pull/268 PR: https://git.openjdk.java.net/skara/pull/268 From rwestberg at openjdk.java.net Mon Nov 25 09:06:33 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 25 Nov 2019 09:06:33 GMT Subject: RFR: Ensure Python 3 compatibility for the hg extension Message-ID: Hi all, Please review this change that makes Skara's internally used Mercurial extension work with Python 3, while also retaining Python 2 compatibility. The Mercurial distribution on MacOS (through homebrew) recently switched to using Python 3, so this change will make the CI for Mac pass again. Best regards, Robin ---------------- Commits: - 27aef11c: Refactor usages of .encode - 85287fe7: Restore python2 compatibility - dd54ede1: More adjustments - f90befc2: Mercurial wants byte strings when using 3 Changes: https://git.openjdk.java.net/skara/pull/267/files Webrev: https://webrevs.openjdk.java.net/skara/267/webrev.00 Stats: 57 lines in 1 file changed: 7 ins; 3 del; 47 mod Patch: https://git.openjdk.java.net/skara/pull/267.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/267/head:pull/267 PR: https://git.openjdk.java.net/skara/pull/267 From rwestberg at openjdk.java.net Mon Nov 25 09:50:02 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 25 Nov 2019 09:50:02 GMT Subject: [Rev 01] RFR: 169: If there are no changes after squashing, jcheck should fail In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - a89389cc: Find a new way to trigger a jcheck exception Changes: - all: https://git.openjdk.java.net/skara/pull/263/files - new: https://git.openjdk.java.net/skara/pull/263/files/afb5d7b6..a89389cc Webrevs: - full: https://webrevs.openjdk.java.net/skara/263/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/263/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/SKARA-169 Stats: 14 lines in 1 file changed: 8 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/263.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/263/head:pull/263 PR: https://git.openjdk.java.net/skara/pull/263 From rwestberg at openjdk.java.net Mon Nov 25 09:56:25 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 25 Nov 2019 09:56:25 GMT Subject: [Integrated] RFR: If there are no changes after squashing, fail jcheck In-Reply-To: References: Message-ID: Changeset: 6ef64684 Author: Robin Westberg Date: 2019-11-25 09:56:06 +0000 URL: https://git.openjdk.java.net/skara/commit/6ef64684 169: If there are no changes after squashing, jcheck should fail Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java From ehelin at openjdk.java.net Mon Nov 25 11:05:27 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 25 Nov 2019 11:05:27 GMT Subject: [Approved] RFR: Implement setTitle for GitLab merge requests In-Reply-To: References: Message-ID: On Mon, 25 Nov 2019 08:46:35 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that implements the setTitle function for GitLab merge requests. > > Best regards, > Robin > > ---------------- > > Commits: > - dd35f073: Implement setTitle for GitLab merge requests > > Changes: https://git.openjdk.java.net/skara/pull/268/files > Webrev: https://webrevs.openjdk.java.net/skara/268/webrev.00 > Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/268.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/268/head:pull/268 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/268 From ehelin at openjdk.java.net Mon Nov 25 11:09:15 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 25 Nov 2019 11:09:15 GMT Subject: RFR: Ensure Python 3 compatibility for the hg extension In-Reply-To: References: Message-ID: On Mon, 25 Nov 2019 09:06:33 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that makes Skara's internally used Mercurial extension work with Python 3, while also retaining Python 2 compatibility. The Mercurial distribution on MacOS (through homebrew) recently switched to using Python 3, so this change will make the CI for Mac pass again. > > Best regards, > Robin > > ---------------- > > Commits: > - 27aef11c: Refactor usages of .encode > - 85287fe7: Restore python2 compatibility > - dd54ede1: More adjustments > - f90befc2: Mercurial wants byte strings when using 3 > > Changes: https://git.openjdk.java.net/skara/pull/267/files > Webrev: https://webrevs.openjdk.java.net/skara/267/webrev.00 > Stats: 57 lines in 1 file changed: 7 ins; 3 del; 47 mod > Patch: https://git.openjdk.java.net/skara/pull/267.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/267/head:pull/267 Robin what kind of testing have you done on this change? Could you please try to do a fresh conversion of one the smaller repositories, like jtreg, to ensure that we haven't broken anything? The unit tests exercise the Mercurial extension quite a bit, but I really want to ensure we don't mess anything up with regards to the hg -> git conversion. PR: https://git.openjdk.java.net/skara/pull/267 From ehelin at openjdk.java.net Mon Nov 25 11:09:55 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 25 Nov 2019 11:09:55 GMT Subject: RFR: Fix parsing of editor commandline in git-pr In-Reply-To: References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: On Wed, 20 Nov 2019 14:42:12 GMT, Erik Helin wrote: > On Wed, 20 Nov 2019 14:12:32 GMT, Robin Westberg wrote: > >> On Wed, 20 Nov 2019 10:21:22 GMT, Christoph Langer wrote: >> >>> On Wed, 20 Nov 2019 09:10:14 GMT, Erik Helin wrote: >>> >>>> On Tue, 19 Nov 2019 14:35:13 GMT, Christoph Langer wrote: >>>> >>>>> Fix parsing of editor commandline in git-pr. >>>>> >>>>> ---------------- >>>>> >>>>> Commits: >>>>> - 199285fc: Fix parsing of editor commandline in git-pr. >>>>> >>>>> Changes: https://git.openjdk.java.net/skara/pull/259/files >>>>> Webrev: https://webrevs.openjdk.java.net/skara/259/webrev.00 >>>>> Stats: 10 lines in 2 files changed: 8 ins; 0 del; 2 mod >>>>> Patch: https://git.openjdk.java.net/skara/pull/259.diff >>>>> Fetch: git fetch https://git.openjdk.java.net/skara pull/259/head:pull/259 >>>> >>>> Hi Christoph, >>>> >>>> thanks for contributing! Just two small nits before I will continue to review this: >>>> >>>> 1. Please describe what you changed in this pull request. You did not provide a description in this PR. >>>> 2. One usually do not end PR titles with a `.`, so please remove that from the title of the PR. >>>> >>>> Thanks! >>>> Erik >>> >>>> Hi Christoph, >>>> >>>> thanks for contributing! Just two small nits before I will continue to review this: >>>> >>>> 1. Please describe what you changed in this pull request. You did not provide a description in this PR. >>>> 2. One usually do not end PR titles with a `.`, so please remove that from the title of the PR. >>>> >>>> Thanks! >>>> Erik >>> >>> Hi Erik, >>> >>> thanks for pointing out these points. I think I've addressed them. >>> >>> I created the pull request via the Skara tool call "git pr create". I'm wondering whether there is any documentation about this tool? >>> E.g. is there an option to give a pull request description? Also, how is one supposed to refer to a JBS bug (if I created one). >>> Furthermore, git pr has quite a few suboptions. Is there some documentation on what these all are supposed to do? >>> >>> Thanks >>> Christoph >> >> The cli tools have documentation in man format here: https://github.com/openjdk/skara/tree/master/cli/resources/man/man1 - unfortunately, this documentation isn't complete yet.. >> >> Erik knows most about these tools, but I think when you are prompted to enter a description, it should be of the format: >> >> : title >> >> Log description > > Christopher, as Robin says, we unfortunately only have a man page at the moment (which won't help you very much since you are on Windows). You can get more abbreviated help information by running `git pr -h`. Robin is also right in how you add a longer multiline description to the pull request. > > As for the regular expression, could you please add a comments above with a few examples. Also, do you really need the quotation marks around the path to `notepad.exe` for `core.editor`? Won't the following suffice: > > core.editor = C:\Program Files\Notepad++\notepad++.exe -multiInst -notabbar -nosession -noPlugin > > Thanks, > Erik @RealCLanger did you see mine and Robin's comments? PR: https://git.openjdk.java.net/skara/pull/259 From rwestberg at openjdk.java.net Mon Nov 25 13:10:55 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 25 Nov 2019 13:10:55 GMT Subject: [Integrated] RFR: Implement setTitle for GitLab merge requests In-Reply-To: References: Message-ID: Changeset: 07421268 Author: Robin Westberg Date: 2019-11-25 13:10:38 +0000 URL: https://git.openjdk.java.net/skara/commit/07421268 Implement setTitle for GitLab merge requests Reviewed-by: ehelin ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java From rwestberg at openjdk.java.net Mon Nov 25 13:28:47 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 25 Nov 2019 13:28:47 GMT Subject: RFR: Ensure Python 3 compatibility for the hg extension In-Reply-To: References: Message-ID: On Mon, 25 Nov 2019 11:09:15 GMT, Erik Helin wrote: > On Mon, 25 Nov 2019 09:06:33 GMT, Robin Westberg wrote: > >> Hi all, >> >> Please review this change that makes Skara's internally used Mercurial extension work with Python 3, while also retaining Python 2 compatibility. The Mercurial distribution on MacOS (through homebrew) recently switched to using Python 3, so this change will make the CI for Mac pass again. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - 27aef11c: Refactor usages of .encode >> - 85287fe7: Restore python2 compatibility >> - dd54ede1: More adjustments >> - f90befc2: Mercurial wants byte strings when using 3 >> >> Changes: https://git.openjdk.java.net/skara/pull/267/files >> Webrev: https://webrevs.openjdk.java.net/skara/267/webrev.00 >> Stats: 57 lines in 1 file changed: 7 ins; 3 del; 47 mod >> Patch: https://git.openjdk.java.net/skara/pull/267.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/267/head:pull/267 > > Robin what kind of testing have you done on this change? Could you please try to do a fresh conversion of one the smaller repositories, like jtreg, to ensure that we haven't broken anything? The unit tests exercise the Mercurial extension quite a bit, but I really want to ensure we don't mess anything up with regards to the hg -> git conversion. ?? The jtreg repository is actually partially converted in the hgbridge tests, but yes, it makes sense to do something a little more extensive.. I'll kick off a few bigger conversions. PR: https://git.openjdk.java.net/skara/pull/267 From rwestberg at openjdk.java.net Mon Nov 25 16:40:11 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 25 Nov 2019 16:40:11 GMT Subject: RFR: Switch to GitHub's new review comment positioning API Message-ID: Hi all, Please review this change that switches to GitHub's new review comment positioning API. This removes the need for calculating line numbers based on position in the textual diff. Note that support for multi-line comments is not yet done (such comments will be shown as positioned on the last line). We can probably wait a bit with implementing that, as the API is technically still in preview. Best regards, Robin ---------------- Commits: - 1c1ccd13: Switch to GitHub's new review comment positioning API Changes: https://git.openjdk.java.net/skara/pull/269/files Webrev: https://webrevs.openjdk.java.net/skara/269/webrev.00 Stats: 491 lines in 5 files changed: 30 ins; 424 del; 37 mod Patch: https://git.openjdk.java.net/skara/pull/269.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/269/head:pull/269 PR: https://git.openjdk.java.net/skara/pull/269 From rwestberg at openjdk.java.net Tue Nov 26 06:38:06 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 26 Nov 2019 06:38:06 GMT Subject: RFR: Ensure Python 3 compatibility for the hg extension In-Reply-To: References: Message-ID: On Mon, 25 Nov 2019 13:28:47 GMT, Robin Westberg wrote: > On Mon, 25 Nov 2019 11:09:15 GMT, Erik Helin wrote: > >> On Mon, 25 Nov 2019 09:06:33 GMT, Robin Westberg wrote: >> >>> Hi all, >>> >>> Please review this change that makes Skara's internally used Mercurial extension work with Python 3, while also retaining Python 2 compatibility. The Mercurial distribution on MacOS (through homebrew) recently switched to using Python 3, so this change will make the CI for Mac pass again. >>> >>> Best regards, >>> Robin >>> >>> ---------------- >>> >>> Commits: >>> - 27aef11c: Refactor usages of .encode >>> - 85287fe7: Restore python2 compatibility >>> - dd54ede1: More adjustments >>> - f90befc2: Mercurial wants byte strings when using 3 >>> >>> Changes: https://git.openjdk.java.net/skara/pull/267/files >>> Webrev: https://webrevs.openjdk.java.net/skara/267/webrev.00 >>> Stats: 57 lines in 1 file changed: 7 ins; 3 del; 47 mod >>> Patch: https://git.openjdk.java.net/skara/pull/267.diff >>> Fetch: git fetch https://git.openjdk.java.net/skara pull/267/head:pull/267 >> >> Robin what kind of testing have you done on this change? Could you please try to do a fresh conversion of one the smaller repositories, like jtreg, to ensure that we haven't broken anything? The unit tests exercise the Mercurial extension quite a bit, but I really want to ensure we don't mess anything up with regards to the hg -> git conversion. > > ?? The jtreg repository is actually partially converted in the hgbridge tests, but yes, it makes sense to do something a little more extensive.. I'll kick off a few bigger conversions. Converted the jdk and panama repositories, and they ended up with the same commit hashes, so I think it's looking good. This was using using Mercurial with Python 2, but we can probably keep using that for the conversions. PR: https://git.openjdk.java.net/skara/pull/267 From ehelin at openjdk.java.net Tue Nov 26 07:16:25 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 26 Nov 2019 07:16:25 GMT Subject: RFR: Ensure Python 3 compatibility for the hg extension In-Reply-To: References: Message-ID: On Tue, 26 Nov 2019 06:38:06 GMT, Robin Westberg wrote: > On Mon, 25 Nov 2019 13:28:47 GMT, Robin Westberg wrote: > >> On Mon, 25 Nov 2019 11:09:15 GMT, Erik Helin wrote: >> >>> On Mon, 25 Nov 2019 09:06:33 GMT, Robin Westberg wrote: >>> >>>> Hi all, >>>> >>>> Please review this change that makes Skara's internally used Mercurial extension work with Python 3, while also retaining Python 2 compatibility. The Mercurial distribution on MacOS (through homebrew) recently switched to using Python 3, so this change will make the CI for Mac pass again. >>>> >>>> Best regards, >>>> Robin >>>> >>>> ---------------- >>>> >>>> Commits: >>>> - 27aef11c: Refactor usages of .encode >>>> - 85287fe7: Restore python2 compatibility >>>> - dd54ede1: More adjustments >>>> - f90befc2: Mercurial wants byte strings when using 3 >>>> >>>> Changes: https://git.openjdk.java.net/skara/pull/267/files >>>> Webrev: https://webrevs.openjdk.java.net/skara/267/webrev.00 >>>> Stats: 57 lines in 1 file changed: 7 ins; 3 del; 47 mod >>>> Patch: https://git.openjdk.java.net/skara/pull/267.diff >>>> Fetch: git fetch https://git.openjdk.java.net/skara pull/267/head:pull/267 >>> >>> Robin what kind of testing have you done on this change? Could you please try to do a fresh conversion of one the smaller repositories, like jtreg, to ensure that we haven't broken anything? The unit tests exercise the Mercurial extension quite a bit, but I really want to ensure we don't mess anything up with regards to the hg -> git conversion. >> >> ?? The jtreg repository is actually partially converted in the hgbridge tests, but yes, it makes sense to do something a little more extensive.. I'll kick off a few bigger conversions. > > Converted the jdk and panama repositories, and they ended up with the same commit hashes, so I think it's looking good. This was using using Mercurial with Python 2, but we can probably keep using that for the conversions. Ok, great! Yeah, I agree we can keep using Mercurial with Python 2 for the conversion. PR: https://git.openjdk.java.net/skara/pull/267 From ehelin at openjdk.java.net Tue Nov 26 07:16:45 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 26 Nov 2019 07:16:45 GMT Subject: [Approved] RFR: Ensure Python 3 compatibility for the hg extension In-Reply-To: References: Message-ID: On Mon, 25 Nov 2019 09:06:33 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that makes Skara's internally used Mercurial extension work with Python 3, while also retaining Python 2 compatibility. The Mercurial distribution on MacOS (through homebrew) recently switched to using Python 3, so this change will make the CI for Mac pass again. > > Best regards, > Robin > > ---------------- > > Commits: > - 27aef11c: Refactor usages of .encode > - 85287fe7: Restore python2 compatibility > - dd54ede1: More adjustments > - f90befc2: Mercurial wants byte strings when using 3 > > Changes: https://git.openjdk.java.net/skara/pull/267/files > Webrev: https://webrevs.openjdk.java.net/skara/267/webrev.00 > Stats: 57 lines in 1 file changed: 7 ins; 3 del; 47 mod > Patch: https://git.openjdk.java.net/skara/pull/267.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/267/head:pull/267 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/267 From ehelin at openjdk.java.net Tue Nov 26 08:16:47 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 26 Nov 2019 08:16:47 GMT Subject: [Approved] RFR: Switch to GitHub's new review comment positioning API In-Reply-To: References: Message-ID: On Mon, 25 Nov 2019 16:40:11 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that switches to GitHub's new review comment positioning API. This removes the need for calculating line numbers based on position in the textual diff. Note that support for multi-line comments is not yet done (such comments will be shown as positioned on the last line). We can probably wait a bit with implementing that, as the API is technically still in preview. > > Best regards, > Robin > > ---------------- > > Commits: > - 1c1ccd13: Switch to GitHub's new review comment positioning API > > Changes: https://git.openjdk.java.net/skara/pull/269/files > Webrev: https://webrevs.openjdk.java.net/skara/269/webrev.00 > Stats: 491 lines in 5 files changed: 30 ins; 424 del; 37 mod > Patch: https://git.openjdk.java.net/skara/pull/269.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/269/head:pull/269 Looks good, very nice to get rid of the position mapper code! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/269 From rwestberg at openjdk.java.net Tue Nov 26 08:46:06 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 26 Nov 2019 08:46:06 GMT Subject: [Integrated] RFR: Ensure Python 3 compatibility for the hg extension In-Reply-To: References: Message-ID: Changeset: 59405b73 Author: Robin Westberg Date: 2019-11-26 08:45:48 +0000 URL: https://git.openjdk.java.net/skara/commit/59405b73 Ensure Python 3 compatibility for the hg extension Reviewed-by: ehelin ! vcs/src/main/resources/ext.py From rwestberg at openjdk.java.net Tue Nov 26 08:47:08 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 26 Nov 2019 08:47:08 GMT Subject: [Integrated] RFR: Switch to GitHub's new review comment positioning API In-Reply-To: References: Message-ID: <3d59a060-2d1f-4161-97d0-fabfd2e20151@openjdk.org> Changeset: fe273afe Author: Robin Westberg Date: 2019-11-26 08:46:57 +0000 URL: https://git.openjdk.java.net/skara/commit/fe273afe Switch to GitHub's new review comment positioning API Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java - forge/src/main/java/org/openjdk/skara/forge/github/PositionMapper.java - forge/src/test/java/org/openjdk/skara/forge/github/PositionMapperTests.java From ehelin at openjdk.java.net Tue Nov 26 11:03:43 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 26 Nov 2019 11:03:43 GMT Subject: RFR: Add --no-token flag to git-pr Message-ID: Hi all, please review this pull request that adds a `--no-token` flag to `git-pr`. This is useful for those merely wanting to try out the read-only operations of `git-pr` (such as `git pr list` or `git pr show`) or for those that do not want to create a personal access token (PAT). The downside for _not_ using a token for read-only operations is that GitHub quite aggressively rate limits the number of REST API HTTP operations (seems like 60 REST API HTTP operations per minute at the moment). Thanks, Erik ## Testing - Manual testing of various `git-pr` subcommands ---------------- Commits: - ac5efe8e: Add --no-token flag - dab55bda: Support read-only commands in git-pr Changes: https://git.openjdk.java.net/skara/pull/270/files Webrev: https://webrevs.openjdk.java.net/skara/270/webrev.00 Stats: 115 lines in 4 files changed: 43 ins; 41 del; 31 mod Patch: https://git.openjdk.java.net/skara/pull/270.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/270/head:pull/270 PR: https://git.openjdk.java.net/skara/pull/270 From ehelin at openjdk.java.net Tue Nov 26 11:08:05 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 26 Nov 2019 11:08:05 GMT Subject: RFR: Add --no-token flag to git-pr In-Reply-To: References: Message-ID: On Tue, 26 Nov 2019 11:03:43 GMT, Erik Helin wrote: > Hi all, > > please review this pull request that adds a `--no-token` flag to `git-pr`. This is useful for those merely wanting to try out the read-only operations of `git-pr` (such as `git pr list` or `git pr show`) or for those that do not want to create a personal access token (PAT). The downside for _not_ using a token for read-only operations is that GitHub quite aggressively rate limits the number of REST API HTTP operations (seems like 60 REST API HTTP operations per minute at the moment). > > Thanks, > Erik > > ## Testing > - Manual testing of various `git-pr` subcommands > > ---------------- > > Commits: > - ac5efe8e: Add --no-token flag > - dab55bda: Support read-only commands in git-pr > > Changes: https://git.openjdk.java.net/skara/pull/270/files > Webrev: https://webrevs.openjdk.java.net/skara/270/webrev.00 > Stats: 115 lines in 4 files changed: 43 ins; 41 del; 31 mod > Patch: https://git.openjdk.java.net/skara/pull/270.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/270/head:pull/270 Robin please note that this patch also makes some changes to `GitHubHost.java`, `GitHubRepository.java` and how those classes handle the installation token (I also cleaned up an old test that didn't require a token). PR: https://git.openjdk.java.net/skara/pull/270 From rwestberg at openjdk.java.net Tue Nov 26 11:10:33 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 26 Nov 2019 11:10:33 GMT Subject: [Approved] RFR: Add --no-token flag to git-pr In-Reply-To: References: Message-ID: On Tue, 26 Nov 2019 11:03:43 GMT, Erik Helin wrote: > Hi all, > > please review this pull request that adds a `--no-token` flag to `git-pr`. This is useful for those merely wanting to try out the read-only operations of `git-pr` (such as `git pr list` or `git pr show`) or for those that do not want to create a personal access token (PAT). The downside for _not_ using a token for read-only operations is that GitHub quite aggressively rate limits the number of REST API HTTP operations (seems like 60 REST API HTTP operations per minute at the moment). > > Thanks, > Erik > > ## Testing > - Manual testing of various `git-pr` subcommands > > ---------------- > > Commits: > - ac5efe8e: Add --no-token flag > - dab55bda: Support read-only commands in git-pr > > Changes: https://git.openjdk.java.net/skara/pull/270/files > Webrev: https://webrevs.openjdk.java.net/skara/270/webrev.00 > Stats: 115 lines in 4 files changed: 43 ins; 41 del; 31 mod > Patch: https://git.openjdk.java.net/skara/pull/270.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/270/head:pull/270 Looks good! Perhaps a typo, but the anonymous rate limit is actually 60 requests per hour (not minute) so even worse. :) ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/270 From ehelin at openjdk.java.net Tue Nov 26 11:16:11 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 26 Nov 2019 11:16:11 GMT Subject: [Rev 01] RFR: Add --no-token flag to git-pr In-Reply-To: References: Message-ID: The pull request has been updated with a complete new set of changes (possibly due to a rebase). ---------------- Commits: - bb34d4b0: Merge master - ac5efe8e: Add --no-token flag - dab55bda: Support read-only commands in git-pr Changes: https://git.openjdk.java.net/skara/pull/270/files Webrev: https://webrevs.openjdk.java.net/skara/270/webrev.01 Stats: 113 lines in 4 files changed: 42 ins; 41 del; 30 mod Patch: https://git.openjdk.java.net/skara/pull/270.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/270/head:pull/270 PR: https://git.openjdk.java.net/skara/pull/270 From ehelin at openjdk.java.net Tue Nov 26 12:32:44 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 26 Nov 2019 12:32:44 GMT Subject: [Integrated] RFR: Add --no-token flag to git-pr In-Reply-To: References: Message-ID: <3491be80-40c9-4c97-b058-5ee6e5f18341@openjdk.org> Changeset: 5c3f278d Author: Erik Helin Date: 2019-11-26 12:32:27 +0000 URL: https://git.openjdk.java.net/skara/commit/5c3f278d Add --no-token flag to git-pr Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java ! forge/src/test/java/org/openjdk/skara/forge/github/GitHubHostTests.java From rwestberg at openjdk.java.net Tue Nov 26 13:00:47 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 26 Nov 2019 13:00:47 GMT Subject: RFR: Save references to materialized branches locally Message-ID: <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> Hi all, Please review this change that ensure that when bots use `Repository.materialize`, they always save a named reference to what was fetched. This ensures that subsequent fetches will present these existing refs, and avoid re-fetching commits that already exist locally. It also fixes a potential bug where the mlbridge archive reader could have fetched from an incorrect branch. Best regards, Robin ---------------- Commits: - 280c73b8: Use configurable ref for the mlbridge archive - 6b707ae4: Specify a destination ref when using materialize Changes: https://git.openjdk.java.net/skara/pull/271/files Webrev: https://webrevs.openjdk.java.net/skara/271/webrev.00 Stats: 54 lines in 14 files changed: 28 ins; 0 del; 26 mod Patch: https://git.openjdk.java.net/skara/pull/271.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/271/head:pull/271 PR: https://git.openjdk.java.net/skara/pull/271 From rwestberg at openjdk.java.net Tue Nov 26 13:25:25 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 26 Nov 2019 13:25:25 GMT Subject: RFR: Escape potential unintentional markdown formatting when bridging mails Message-ID: Hi all, Please review this change that ensures that text that could be interpreted as markdown formatting is properly escaped when posted as a bridged comment from an email to a PR. Best regards, Robin ---------------- Commits: - 10720647: Escape potential unintentional markdown formatting when posting an email body as a PR comment Changes: https://git.openjdk.java.net/skara/pull/272/files Webrev: https://webrevs.openjdk.java.net/skara/272/webrev.00 Stats: 95 lines in 3 files changed: 94 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/272/head:pull/272 PR: https://git.openjdk.java.net/skara/pull/272 From rwestberg at openjdk.java.net Tue Nov 26 14:06:10 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 26 Nov 2019 14:06:10 GMT Subject: [Rev 01] RFR: Escape potential unintentional markdown formatting when bridging mails In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 0dc06fa6: Fix spelling Changes: - all: https://git.openjdk.java.net/skara/pull/272/files - new: https://git.openjdk.java.net/skara/pull/272/files/10720647..0dc06fa6 Webrevs: - full: https://webrevs.openjdk.java.net/skara/272/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/272/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/272/head:pull/272 PR: https://git.openjdk.java.net/skara/pull/272 From rwestberg at openjdk.java.net Wed Nov 27 09:20:07 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 27 Nov 2019 09:20:07 GMT Subject: RFR: Initial version of issue updater Message-ID: Hi all, Please review this change that adds the first version of an issue updater (similar to what hgupdater currently provides for mercurial repositories). Best regards, Robin ---------------- Commits: - ebed0696: Initial version of issue updater Changes: https://git.openjdk.java.net/skara/pull/273/files Webrev: https://webrevs.openjdk.java.net/skara/273/webrev.00 Stats: 241 lines in 5 files changed: 192 ins; 45 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/273.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/273/head:pull/273 PR: https://git.openjdk.java.net/skara/pull/273 From ehelin at openjdk.java.net Wed Nov 27 09:37:28 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 27 Nov 2019 09:37:28 GMT Subject: RFR: Save references to materialized branches locally In-Reply-To: <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> References: <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> Message-ID: On Tue, 26 Nov 2019 13:00:47 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensure that when bots use `Repository.materialize`, they always save a named reference to what was fetched. This ensures that subsequent fetches will present these existing refs, and avoid re-fetching commits that already exist locally. > > It also fixes a potential bug where the mlbridge archive reader could have fetched from an incorrect branch. > > Best regards, > Robin > > ---------------- > > Commits: > - 280c73b8: Use configurable ref for the mlbridge archive > - 6b707ae4: Specify a destination ref when using materialize > > Changes: https://git.openjdk.java.net/skara/pull/271/files > Webrev: https://webrevs.openjdk.java.net/skara/271/webrev.00 > Stats: 54 lines in 14 files changed: 28 ins; 0 del; 26 mod > Patch: https://git.openjdk.java.net/skara/pull/271.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/271/head:pull/271 bots/hgbridge/src/main/java/org/openjdk/skara/bots/hgbridge/ExporterConfig.java line 172: > 171: var localRepo = Repository.materialize(scratchPath, configurationRepo.url(), > 172: configurationRef + ":hgbridge_config_" + configurationRepo.name()); > 173: Why no `+` here to to imply `--force` to `git fech`? PR: https://git.openjdk.java.net/skara/pull/271 From rwestberg at openjdk.java.net Wed Nov 27 09:41:46 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 27 Nov 2019 09:41:46 GMT Subject: RFR: Save references to materialized branches locally In-Reply-To: References: <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> Message-ID: On Wed, 27 Nov 2019 09:37:28 GMT, Erik Helin wrote: > On Tue, 26 Nov 2019 13:00:47 GMT, Robin Westberg wrote: > >> Hi all, >> >> Please review this change that ensure that when bots use `Repository.materialize`, they always save a named reference to what was fetched. This ensures that subsequent fetches will present these existing refs, and avoid re-fetching commits that already exist locally. >> >> It also fixes a potential bug where the mlbridge archive reader could have fetched from an incorrect branch. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - 280c73b8: Use configurable ref for the mlbridge archive >> - 6b707ae4: Specify a destination ref when using materialize >> >> Changes: https://git.openjdk.java.net/skara/pull/271/files >> Webrev: https://webrevs.openjdk.java.net/skara/271/webrev.00 >> Stats: 54 lines in 14 files changed: 28 ins; 0 del; 26 mod >> Patch: https://git.openjdk.java.net/skara/pull/271.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/271/head:pull/271 > > bots/hgbridge/src/main/java/org/openjdk/skara/bots/hgbridge/ExporterConfig.java line 172: > >> 171: var localRepo = Repository.materialize(scratchPath, configurationRepo.url(), >> 172: configurationRef + ":hgbridge_config_" + configurationRepo.name()); >> 173: > > Why no `+` here to to imply `--force` to `git fech`? No reason, good catch! PR: https://git.openjdk.java.net/skara/pull/271 From ehelin at openjdk.java.net Wed Nov 27 09:43:06 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 27 Nov 2019 09:43:06 GMT Subject: [Approved] RFR: Escape potential unintentional markdown formatting when bridging mails In-Reply-To: References: Message-ID: On Tue, 26 Nov 2019 14:06:10 GMT, Robin Westberg wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - 0dc06fa6: Fix spelling > > Changes: > - all: https://git.openjdk.java.net/skara/pull/272/files > - new: https://git.openjdk.java.net/skara/pull/272/files/10720647..0dc06fa6 > > Webrevs: > - full: https://webrevs.openjdk.java.net/skara/272/webrev.01 > - incr: https://webrevs.openjdk.java.net/skara/272/webrev.00-01 > > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/272.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/272/head:pull/272 Great catch, nice fix! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/272 From rwestberg at openjdk.java.net Wed Nov 27 09:44:51 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 27 Nov 2019 09:44:51 GMT Subject: [Rev 01] RFR: Save references to materialized branches locally In-Reply-To: <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> References: <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - a8f5474a: All materialize-to-local-ref should force update Changes: - all: https://git.openjdk.java.net/skara/pull/271/files - new: https://git.openjdk.java.net/skara/pull/271/files/280c73b8..a8f5474a Webrevs: - full: https://webrevs.openjdk.java.net/skara/271/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/271/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/271.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/271/head:pull/271 PR: https://git.openjdk.java.net/skara/pull/271 From ehelin at openjdk.java.net Wed Nov 27 10:13:57 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 27 Nov 2019 10:13:57 GMT Subject: RFR: Save references to materialized branches locally In-Reply-To: References: <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> Message-ID: On Wed, 27 Nov 2019 09:41:46 GMT, Robin Westberg wrote: > On Wed, 27 Nov 2019 09:37:28 GMT, Erik Helin wrote: > >> On Tue, 26 Nov 2019 13:00:47 GMT, Robin Westberg wrote: >> >>> Hi all, >>> >>> Please review this change that ensure that when bots use `Repository.materialize`, they always save a named reference to what was fetched. This ensures that subsequent fetches will present these existing refs, and avoid re-fetching commits that already exist locally. >>> >>> It also fixes a potential bug where the mlbridge archive reader could have fetched from an incorrect branch. >>> >>> Best regards, >>> Robin >>> >>> ---------------- >>> >>> Commits: >>> - 280c73b8: Use configurable ref for the mlbridge archive >>> - 6b707ae4: Specify a destination ref when using materialize >>> >>> Changes: https://git.openjdk.java.net/skara/pull/271/files >>> Webrev: https://webrevs.openjdk.java.net/skara/271/webrev.00 >>> Stats: 54 lines in 14 files changed: 28 ins; 0 del; 26 mod >>> Patch: https://git.openjdk.java.net/skara/pull/271.diff >>> Fetch: git fetch https://git.openjdk.java.net/skara pull/271/head:pull/271 >> >> bots/hgbridge/src/main/java/org/openjdk/skara/bots/hgbridge/ExporterConfig.java line 172: >> >>> 171: var localRepo = Repository.materialize(scratchPath, configurationRepo.url(), >>> 172: configurationRef + ":hgbridge_config_" + configurationRepo.name()); >>> 173: >> >> Why no `+` here to to imply `--force` to `git fech`? > > No reason, good catch! Should we instead change `Repository.materialize` to always prepend the `+` to the refspec? Or do you think that makes it less clear at the call sites? PR: https://git.openjdk.java.net/skara/pull/271 From rwestberg at openjdk.java.net Wed Nov 27 10:18:37 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 27 Nov 2019 10:18:37 GMT Subject: RFR: Save references to materialized branches locally In-Reply-To: References: <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> Message-ID: On Wed, 27 Nov 2019 10:13:57 GMT, Erik Helin wrote: > On Wed, 27 Nov 2019 09:41:46 GMT, Robin Westberg wrote: > >> On Wed, 27 Nov 2019 09:37:28 GMT, Erik Helin wrote: >> >>> On Tue, 26 Nov 2019 13:00:47 GMT, Robin Westberg wrote: >>> >>>> Hi all, >>>> >>>> Please review this change that ensure that when bots use `Repository.materialize`, they always save a named reference to what was fetched. This ensures that subsequent fetches will present these existing refs, and avoid re-fetching commits that already exist locally. >>>> >>>> It also fixes a potential bug where the mlbridge archive reader could have fetched from an incorrect branch. >>>> >>>> Best regards, >>>> Robin >>>> >>>> ---------------- >>>> >>>> Commits: >>>> - 280c73b8: Use configurable ref for the mlbridge archive >>>> - 6b707ae4: Specify a destination ref when using materialize >>>> >>>> Changes: https://git.openjdk.java.net/skara/pull/271/files >>>> Webrev: https://webrevs.openjdk.java.net/skara/271/webrev.00 >>>> Stats: 54 lines in 14 files changed: 28 ins; 0 del; 26 mod >>>> Patch: https://git.openjdk.java.net/skara/pull/271.diff >>>> Fetch: git fetch https://git.openjdk.java.net/skara pull/271/head:pull/271 >>> >>> bots/hgbridge/src/main/java/org/openjdk/skara/bots/hgbridge/ExporterConfig.java line 172: >>> >>>> 171: var localRepo = Repository.materialize(scratchPath, configurationRepo.url(), >>>> 172: configurationRef + ":hgbridge_config_" + configurationRepo.name()); >>>> 173: >>> >>> Why no `+` here to to imply `--force` to `git fech`? >> >> No reason, good catch! > > Should we instead change `Repository.materialize` to always prepend the `+` to the refspec? Or do you think that makes it less clear at the call sites? Not sure, it's something you only want if you have a target ref, and only if you are using git.. And since materialize is implemented as a default method in Repository, it might be a little odd to have that logic there. Perhaps it could be refactored to not be a default method though. PR: https://git.openjdk.java.net/skara/pull/271 From ehelin at openjdk.java.net Wed Nov 27 10:22:09 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 27 Nov 2019 10:22:09 GMT Subject: [Approved] RFR: Initial version of issue updater In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 09:20:07 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adds the first version of an issue updater (similar to what hgupdater currently provides for mercurial repositories). > > Best regards, > Robin > > ---------------- > > Commits: > - ebed0696: Initial version of issue updater > > Changes: https://git.openjdk.java.net/skara/pull/273/files > Webrev: https://webrevs.openjdk.java.net/skara/273/webrev.00 > Stats: 241 lines in 5 files changed: 192 ins; 45 del; 4 mod > Patch: https://git.openjdk.java.net/skara/pull/273.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/273/head:pull/273 Very nice work Robin! So nice to see all the pieces fit into place ?? I would probably have dropped the `commit` prefix from `CommitFormatters.commitToText` and `CommitFormatters.commitToTextBrief`, so that the methods instead read `CommitFormatters.toText` and `CommitFormatters.toTextBrief`. Since they are `static` it is clear at the call sites that a commit is being formatted. ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/273 From ehelin at openjdk.java.net Wed Nov 27 10:25:47 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 27 Nov 2019 10:25:47 GMT Subject: RFR: Save references to materialized branches locally In-Reply-To: References: <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> Message-ID: On Wed, 27 Nov 2019 10:18:37 GMT, Robin Westberg wrote: > On Wed, 27 Nov 2019 10:13:57 GMT, Erik Helin wrote: > >> On Wed, 27 Nov 2019 09:41:46 GMT, Robin Westberg wrote: >> >>> On Wed, 27 Nov 2019 09:37:28 GMT, Erik Helin wrote: >>> >>>> On Tue, 26 Nov 2019 13:00:47 GMT, Robin Westberg wrote: >>>> >>>>> Hi all, >>>>> >>>>> Please review this change that ensure that when bots use `Repository.materialize`, they always save a named reference to what was fetched. This ensures that subsequent fetches will present these existing refs, and avoid re-fetching commits that already exist locally. >>>>> >>>>> It also fixes a potential bug where the mlbridge archive reader could have fetched from an incorrect branch. >>>>> >>>>> Best regards, >>>>> Robin >>>>> >>>>> ---------------- >>>>> >>>>> Commits: >>>>> - 280c73b8: Use configurable ref for the mlbridge archive >>>>> - 6b707ae4: Specify a destination ref when using materialize >>>>> >>>>> Changes: https://git.openjdk.java.net/skara/pull/271/files >>>>> Webrev: https://webrevs.openjdk.java.net/skara/271/webrev.00 >>>>> Stats: 54 lines in 14 files changed: 28 ins; 0 del; 26 mod >>>>> Patch: https://git.openjdk.java.net/skara/pull/271.diff >>>>> Fetch: git fetch https://git.openjdk.java.net/skara pull/271/head:pull/271 >>>> >>>> bots/hgbridge/src/main/java/org/openjdk/skara/bots/hgbridge/ExporterConfig.java line 172: >>>> >>>>> 171: var localRepo = Repository.materialize(scratchPath, configurationRepo.url(), >>>>> 172: configurationRef + ":hgbridge_config_" + configurationRepo.name()); >>>>> 173: >>>> >>>> Why no `+` here to to imply `--force` to `git fech`? >>> >>> No reason, good catch! >> >> Should we instead change `Repository.materialize` to always prepend the `+` to the refspec? Or do you think that makes it less clear at the call sites? > > Not sure, it's something you only want if you have a target ref, and only if you are using git.. And since materialize is implemented as a default method in Repository, it might be a little odd to have that logic there. Perhaps it could be refactored to not be a default method though. Ah right. No, `Repository.materialize` is `static`, not `default` ?? I think we should leave as it is then. The only other approach I can think if something like `Repository.materalize(Path path, URI remote, String fromRef, String toRef, boolean force, boolean checkout`), but then the parameter list is becoming really long (and `hg` can't handle `fromRef != toRef` anyhow). So I think we just leave it as it is. PR: https://git.openjdk.java.net/skara/pull/271 From ehelin at openjdk.java.net Wed Nov 27 10:26:07 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 27 Nov 2019 10:26:07 GMT Subject: [Approved] RFR: Save references to materialized branches locally In-Reply-To: <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> References: <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> Message-ID: On Wed, 27 Nov 2019 09:44:51 GMT, Robin Westberg wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - a8f5474a: All materialize-to-local-ref should force update > > Changes: > - all: https://git.openjdk.java.net/skara/pull/271/files > - new: https://git.openjdk.java.net/skara/pull/271/files/280c73b8..a8f5474a > > Webrevs: > - full: https://webrevs.openjdk.java.net/skara/271/webrev.01 > - incr: https://webrevs.openjdk.java.net/skara/271/webrev.00-01 > > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/271.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/271/head:pull/271 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/271 From rwestberg at openjdk.java.net Wed Nov 27 12:15:22 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 27 Nov 2019 12:15:22 GMT Subject: [Rev 01] RFR: Initial version of issue updater In-Reply-To: References: Message-ID: <7snMUMUiKwlv1qws-okX0DQjU_2Gpb_j2lLtZuAiWo0=.825bc2c1-ac9f-411f-b95e-2ae5eaf11c23@github.com> The pull request has been updated with additional changes. ---------------- Added commits: - 714ab322: Update after review Changes: - all: https://git.openjdk.java.net/skara/pull/273/files - new: https://git.openjdk.java.net/skara/pull/273/files/ebed0696..714ab322 Webrevs: - full: https://webrevs.openjdk.java.net/skara/273/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/273/webrev.00-01 Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/skara/pull/273.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/273/head:pull/273 PR: https://git.openjdk.java.net/skara/pull/273 From rwestberg at openjdk.java.net Wed Nov 27 12:15:36 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 27 Nov 2019 12:15:36 GMT Subject: RFR: Initial version of issue updater In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 09:20:07 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adds the first version of an issue updater (similar to what hgupdater currently provides for mercurial repositories). > > Best regards, > Robin > > ---------------- > > Commits: > - ebed0696: Initial version of issue updater > > Changes: https://git.openjdk.java.net/skara/pull/273/files > Webrev: https://webrevs.openjdk.java.net/skara/273/webrev.00 > Stats: 241 lines in 5 files changed: 192 ins; 45 del; 4 mod > Patch: https://git.openjdk.java.net/skara/pull/273.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/273/head:pull/273 Sure, can change that! PR: https://git.openjdk.java.net/skara/pull/273 From rwestberg at openjdk.java.net Wed Nov 27 12:15:56 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 27 Nov 2019 12:15:56 GMT Subject: [Integrated] RFR: Initial version of issue updater In-Reply-To: References: Message-ID: <8b8b95ef-fdd2-4657-88d1-a02a88c6cbf4@openjdk.org> Changeset: f3afc994 Author: Robin Westberg Date: 2019-11-27 12:15:39 +0000 URL: https://git.openjdk.java.net/skara/commit/f3afc994 Initial version of issue updater Reviewed-by: ehelin + bots/notify/src/main/java/org/openjdk/skara/bots/notify/CommitFormatters.java + bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From rwestberg at openjdk.java.net Wed Nov 27 12:27:21 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 27 Nov 2019 12:27:21 GMT Subject: RFR: Add support for configuring Jira credentials Message-ID: Hi all, Please review this small change that allows configuring credentials for Jira. Best regards, Robin ---------------- Commits: - 961e7cf0: Add support for configuring Jira credentials Changes: https://git.openjdk.java.net/skara/pull/274/files Webrev: https://webrevs.openjdk.java.net/skara/274/webrev.00 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/274.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/274/head:pull/274 PR: https://git.openjdk.java.net/skara/pull/274 From rwestberg at openjdk.java.net Wed Nov 27 12:31:06 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 27 Nov 2019 12:31:06 GMT Subject: [Integrated] RFR: Escape potential unintentional markdown formatting when bridging mails In-Reply-To: References: Message-ID: <104d08ff-c539-4594-ada6-feb7d9419ed6@openjdk.org> Changeset: 6e2c5bf5 Author: Robin Westberg Date: 2019-11-27 12:30:49 +0000 URL: https://git.openjdk.java.net/skara/commit/6e2c5bf5 Escape potential unintentional markdown formatting when bridging mails Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CommentPosterWorkItem.java + bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/TextToMarkdown.java + bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/TextToMarkdownTests.java From rwestberg at openjdk.java.net Wed Nov 27 12:32:15 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 27 Nov 2019 12:32:15 GMT Subject: [Integrated] RFR: Save references to materialized branches locally In-Reply-To: <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> References: <-2RkRhtghYvjx63IoqZPCSpnfyxSjf9F_4XcFQO6CcE=.a5956672-0b5e-433f-bc58-9d2a59171b65@github.com> Message-ID: Changeset: 1f166345 Author: Robin Westberg Date: 2019-11-27 12:32:00 +0000 URL: https://git.openjdk.java.net/skara/commit/1f166345 Save references to materialized branches locally Reviewed-by: ehelin ! bots/hgbridge/src/main/java/org/openjdk/skara/bots/hgbridge/ExporterConfig.java ! bots/hgbridge/src/main/java/org/openjdk/skara/bots/hgbridge/JBridgeBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CensusInstance.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/PullRequestInstance.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevStorage.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBotTests.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CensusInstance.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java ! bots/submit/src/main/java/org/openjdk/skara/bots/submit/SubmitBotWorkItem.java ! storage/src/main/java/org/openjdk/skara/storage/HostedRepositoryStorage.java From ehelin at openjdk.java.net Wed Nov 27 12:37:29 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 27 Nov 2019 12:37:29 GMT Subject: [Approved] RFR: Add support for configuring Jira credentials In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 12:27:21 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that allows configuring credentials for Jira. > > Best regards, > Robin > > ---------------- > > Commits: > - 961e7cf0: Add support for configuring Jira credentials > > Changes: https://git.openjdk.java.net/skara/pull/274/files > Webrev: https://webrevs.openjdk.java.net/skara/274/webrev.00 > Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/274.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/274/head:pull/274 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/274 From rwestberg at openjdk.java.net Wed Nov 27 12:38:25 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 27 Nov 2019 12:38:25 GMT Subject: [Integrated] RFR: Add support for configuring Jira credentials In-Reply-To: References: Message-ID: <2c7a746d-8ad8-4c16-80a7-d9a099d27051@openjdk.org> Changeset: d6650842 Author: Robin Westberg Date: 2019-11-27 12:38:09 +0000 URL: https://git.openjdk.java.net/skara/commit/d6650842 Add support for configuring Jira credentials Reviewed-by: ehelin ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java From ehelin at openjdk.java.net Wed Nov 27 14:55:42 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 27 Nov 2019 14:55:42 GMT Subject: RFR: 146: git-webrev: Add support for file list argument Message-ID: Hi all, please review this pull request that add support for an input argument to `git-webrev`. The argument is a file that itself contains a list of files to include in the webrev. This input file also specifies the order in which the files should appear in the webrev's index.html file. The main part of the patch is adding support for a list of paths to `ReadOnlyRepository.diff`. One part of the bug that is not addressed yet is the support for specifying `-` as the input file, `git-webrev` should then read the list of file names (separated by `\n`) from stdin. I plan to address this in a follow-up patch since I wanted to keep this patch as small as possible. Thanks, Erik ## Testing - [x] Added a new unit test - [x] Manual testing of `git-webrev` with input file - [x] `make test` passes on Linux x64 ---------------- Commits: - e0c3162f: 146: git-webrev: Add support for file list argument Changes: https://git.openjdk.java.net/skara/pull/275/files Webrev: https://webrevs.openjdk.java.net/skara/275/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-146 Stats: 152 lines in 8 files changed: 146 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/275.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/275/head:pull/275 PR: https://git.openjdk.java.net/skara/pull/275 From rwestberg at openjdk.java.net Thu Nov 28 06:41:33 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 28 Nov 2019 06:41:33 GMT Subject: [Approved] RFR: 146: git-webrev: Add support for file list argument In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 14:55:42 GMT, Erik Helin wrote: > Hi all, > > please review this pull request that add support for an input argument to `git-webrev`. The argument is a file that itself contains a list of files to include in the webrev. This input file also specifies the order in which the files should appear in the webrev's index.html file. > > The main part of the patch is adding support for a list of paths to `ReadOnlyRepository.diff`. > > One part of the bug that is not addressed yet is the support for specifying `-` as the input file, `git-webrev` should then read the list of file names (separated by `\n`) from stdin. I plan to address this in a follow-up patch since I wanted to keep this patch as small as possible. > > Thanks, > Erik > > ## Testing > - [x] Added a new unit test > - [x] Manual testing of `git-webrev` with input file > - [x] `make test` passes on Linux x64 > > ---------------- > > Commits: > - e0c3162f: 146: git-webrev: Add support for file list argument > > Changes: https://git.openjdk.java.net/skara/pull/275/files > Webrev: https://webrevs.openjdk.java.net/skara/275/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-146 > Stats: 152 lines in 8 files changed: 146 ins; 0 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/275.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/275/head:pull/275 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/275 From rwestberg at openjdk.java.net Thu Nov 28 06:45:53 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 28 Nov 2019 06:45:53 GMT Subject: RFR: 146: git-webrev: Add support for file list argument In-Reply-To: References: Message-ID: On Wed, 27 Nov 2019 14:55:42 GMT, Erik Helin wrote: > Hi all, > > please review this pull request that add support for an input argument to `git-webrev`. The argument is a file that itself contains a list of files to include in the webrev. This input file also specifies the order in which the files should appear in the webrev's index.html file. > > The main part of the patch is adding support for a list of paths to `ReadOnlyRepository.diff`. > > One part of the bug that is not addressed yet is the support for specifying `-` as the input file, `git-webrev` should then read the list of file names (separated by `\n`) from stdin. I plan to address this in a follow-up patch since I wanted to keep this patch as small as possible. > > Thanks, > Erik > > ## Testing > - [x] Added a new unit test > - [x] Manual testing of `git-webrev` with input file > - [x] `make test` passes on Linux x64 > > ---------------- > > Commits: > - e0c3162f: 146: git-webrev: Add support for file list argument > > Changes: https://git.openjdk.java.net/skara/pull/275/files > Webrev: https://webrevs.openjdk.java.net/skara/275/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-146 > Stats: 152 lines in 8 files changed: 146 ins; 0 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/275.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/275/head:pull/275 vcs/src/main/resources/ext.py line 173: > 172: if files != '': > 173: wanted = set(files.split(',')) > 174: modified = modified & wanted Suggestion: wanted = set(files.split(b',')) This fails on python3 PR: https://git.openjdk.java.net/skara/pull/275 From ehelin at openjdk.java.net Thu Nov 28 09:40:11 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 28 Nov 2019 09:40:11 GMT Subject: [Rev 01] RFR: 146: git-webrev: Add support for file list argument In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 5521aba0: Use byte strings for data from Mercurial Changes: - all: https://git.openjdk.java.net/skara/pull/275/files - new: https://git.openjdk.java.net/skara/pull/275/files/e0c3162f..5521aba0 Webrevs: - full: https://webrevs.openjdk.java.net/skara/275/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/275/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/SKARA-146 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/275.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/275/head:pull/275 PR: https://git.openjdk.java.net/skara/pull/275 From ehelin at openjdk.java.net Thu Nov 28 10:09:12 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 28 Nov 2019 10:09:12 GMT Subject: [Integrated] RFR: 146: git-webrev: Add support for file list argument In-Reply-To: References: Message-ID: <3ed33686-d852-4c28-b9f5-a936f61767a6@openjdk.org> Changeset: f54b0272 Author: Erik Helin Date: 2019-11-28 10:08:55 +0000 URL: https://git.openjdk.java.net/skara/commit/f54b0272 146: git-webrev: Add support for file list argument Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/TestRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java ! vcs/src/main/resources/ext.py ! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java ! webrev/src/main/java/org/openjdk/skara/webrev/Webrev.java From ehelin at openjdk.java.net Thu Nov 28 10:41:29 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 28 Nov 2019 10:41:29 GMT Subject: RFR: 174: git-webrev should support taking file list via STDIN Message-ID: Hi all, please review this small patch that adds support for `git-webrev` to take the list of files that should be included via STDIN. Thanks, Erik ## Testing - [x] Manual testing of `git-webrev` and passing files to include via STDIN ---------------- Commits: - 218600ee: 174: git-webrev should support taking file list via STDIN Changes: https://git.openjdk.java.net/skara/pull/276/files Webrev: https://webrevs.openjdk.java.net/skara/276/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-174 Stats: 8 lines in 2 files changed: 6 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/276.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/276/head:pull/276 PR: https://git.openjdk.java.net/skara/pull/276 From rwestberg at openjdk.java.net Thu Nov 28 10:41:41 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 28 Nov 2019 10:41:41 GMT Subject: [Approved] RFR: 174: git-webrev should support taking file list via STDIN In-Reply-To: References: Message-ID: On Thu, 28 Nov 2019 10:41:29 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that adds support for `git-webrev` to take the list of files that should be included via STDIN. > > Thanks, > Erik > > ## Testing > - [x] Manual testing of `git-webrev` and passing files to include via STDIN > > ---------------- > > Commits: > - 218600ee: 174: git-webrev should support taking file list via STDIN > > Changes: https://git.openjdk.java.net/skara/pull/276/files > Webrev: https://webrevs.openjdk.java.net/skara/276/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-174 > Stats: 8 lines in 2 files changed: 6 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/276.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/276/head:pull/276 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/276 From ehelin at openjdk.java.net Thu Nov 28 11:16:23 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 28 Nov 2019 11:16:23 GMT Subject: [Integrated] RFR: 174: git-webrev should support taking file list via STDIN In-Reply-To: References: Message-ID: <6aece5b3-1e42-4681-be51-6ab6b138a9c3@openjdk.org> Changeset: 0571c60a Author: Erik Helin Date: 2019-11-28 11:16:04 +0000 URL: https://git.openjdk.java.net/skara/commit/0571c60a 174: git-webrev should support taking file list via STDIN Reviewed-by: rwestberg ! args/src/main/java/org/openjdk/skara/args/ArgumentParser.java ! cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java From ehelin at openjdk.java.net Thu Nov 28 14:02:21 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 28 Nov 2019 14:02:21 GMT Subject: RFR: Use https:// everywhere Message-ID: Hi all, please review this small patch that ensures what we use `https://` links in all our Markdown generated by the bots. Thanks, Erik ## Testing - [x] `make test` on Linux x64 ---------------- Commits: - 108c9e88: Use https:// everywhere Changes: https://git.openjdk.java.net/skara/pull/277/files Webrev: https://webrevs.openjdk.java.net/skara/277/webrev.00 Stats: 6 lines in 4 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/277.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/277/head:pull/277 PR: https://git.openjdk.java.net/skara/pull/277 From rwestberg at openjdk.java.net Thu Nov 28 14:04:31 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 28 Nov 2019 14:04:31 GMT Subject: [Approved] RFR: Use https:// everywhere In-Reply-To: References: Message-ID: On Thu, 28 Nov 2019 14:02:21 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that ensures what we use `https://` links in all our Markdown generated by the bots. > > Thanks, > Erik > > ## Testing > - [x] `make test` on Linux x64 > > ---------------- > > Commits: > - 108c9e88: Use https:// everywhere > > Changes: https://git.openjdk.java.net/skara/pull/277/files > Webrev: https://webrevs.openjdk.java.net/skara/277/webrev.00 > Stats: 6 lines in 4 files changed: 0 ins; 0 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/277.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/277/head:pull/277 Looks good, thanks for fixing! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/277 From ehelin at openjdk.java.net Thu Nov 28 14:45:42 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 28 Nov 2019 14:45:42 GMT Subject: [Integrated] RFR: Use https:// everywhere In-Reply-To: References: Message-ID: <9d847ed5-634b-4332-93e4-a4745b527861@openjdk.org> Changeset: 00579009 Author: Erik Helin Date: 2019-11-28 14:45:25 +0000 URL: https://git.openjdk.java.net/skara/commit/00579009 Use https:// everywhere Reviewed-by: rwestberg ! bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestCloserBot.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/RejectCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java From ehelin at openjdk.java.net Thu Nov 28 15:10:50 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 28 Nov 2019 15:10:50 GMT Subject: RFR: 92: GitRepository::currentBranch fails when on a detached HEAD Message-ID: Hi all, please review this pull request that makes `git webrev` work when the repository is in a "detached HEAD" state (i.e. there is no active branch). The main part of the change is making `ReadOnlyRepository::currentBranch` return `Optional` instead of `Branch`. Thanks, Erik ## Testing - [x] `make test` on Linux x64 - [x] Manually running `git webrev` on a repository with a detached HEAD ---------------- Commits: - 3dc4fea9: 92: GitRepository::currentBranch fails when on a detached HEAD Changes: https://git.openjdk.java.net/skara/pull/278/files Webrev: https://webrevs.openjdk.java.net/skara/278/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-92 Stats: 40 lines in 8 files changed: 16 ins; 2 del; 22 mod Patch: https://git.openjdk.java.net/skara/pull/278.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/278/head:pull/278 PR: https://git.openjdk.java.net/skara/pull/278 From rwestberg at openjdk.java.net Fri Nov 29 09:14:12 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 29 Nov 2019 09:14:12 GMT Subject: [Approved] RFR: 92: GitRepository::currentBranch fails when on a detached HEAD In-Reply-To: References: Message-ID: On Thu, 28 Nov 2019 15:10:50 GMT, Erik Helin wrote: > Hi all, > > please review this pull request that makes `git webrev` work when the repository is in a "detached HEAD" state (i.e. there is no active branch). The main part of the change is making `ReadOnlyRepository::currentBranch` return `Optional` instead of `Branch`. > > Thanks, > Erik > > ## Testing > - [x] `make test` on Linux x64 > - [x] Manually running `git webrev` on a repository with a detached HEAD > > ---------------- > > Commits: > - 3dc4fea9: 92: GitRepository::currentBranch fails when on a detached HEAD > > Changes: https://git.openjdk.java.net/skara/pull/278/files > Webrev: https://webrevs.openjdk.java.net/skara/278/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-92 > Stats: 40 lines in 8 files changed: 16 ins; 2 del; 22 mod > Patch: https://git.openjdk.java.net/skara/pull/278.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/278/head:pull/278 Looks good! Perhaps the error message could be made a bit more helpful, but not sure what it should say. :) cli/src/main/java/org/openjdk/skara/cli/GitPr.java line 523: > 522: var currentBranch = repo.currentBranch().orElseGet(() -> { > 523: System.err.println("error: the repository is in a detached HEAD state"); > 524: System.exit(1); Suggestion: System.err.println("error: the repository is in a detached HEAD state. check out a branch to continue.. or something"); ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/278 From ehelin at openjdk.java.net Fri Nov 29 11:25:43 2019 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 29 Nov 2019 11:25:43 GMT Subject: [Approved] RFR: 92: GitRepository::currentBranch fails when on a detached HEAD In-Reply-To: References: Message-ID: On Fri, 29 Nov 2019 09:14:12 GMT, Robin Westberg wrote: > On Thu, 28 Nov 2019 15:10:50 GMT, Erik Helin wrote: > >> Hi all, >> >> please review this pull request that makes `git webrev` work when the repository is in a "detached HEAD" state (i.e. there is no active branch). The main part of the change is making `ReadOnlyRepository::currentBranch` return `Optional` instead of `Branch`. >> >> Thanks, >> Erik >> >> ## Testing >> - [x] `make test` on Linux x64 >> - [x] Manually running `git webrev` on a repository with a detached HEAD >> >> ---------------- >> >> Commits: >> - 3dc4fea9: 92: GitRepository::currentBranch fails when on a detached HEAD >> >> Changes: https://git.openjdk.java.net/skara/pull/278/files >> Webrev: https://webrevs.openjdk.java.net/skara/278/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/SKARA-92 >> Stats: 40 lines in 8 files changed: 16 ins; 2 del; 22 mod >> Patch: https://git.openjdk.java.net/skara/pull/278.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/278/head:pull/278 > > Looks good! Perhaps the error message could be made a bit more helpful, but not sure what it should say. :) > > cli/src/main/java/org/openjdk/skara/cli/GitPr.java line 523: > >> 522: var currentBranch = repo.currentBranch().orElseGet(() -> { >> 523: System.err.println("error: the repository is in a detached HEAD state"); >> 524: System.exit(1); > > Suggestion: > > System.err.println("error: the repository is in a detached HEAD state. check out a branch to continue.. or something"); > > ---------------- > > Approved by rwestberg (Reviewer). I thought about this as well, but if you see the "detached HEAD" warning when doing e.g. `git checkout HEAD~` there is just no way we are gonna be able to write all that ?? So I figured that the next best thing was to write something concise that is very easy to search for. If the user does not know what "detached HEAD state" means then he/she will immediately search for it and will most likely stumble upon [this explanation](https://www.git-tower.com/learn/git/faq/detached-head-when-checkout-commit) which is the first hit on both DuckDuckGo and Google for me. I think that is the best alternative here, what do you say? PR: https://git.openjdk.java.net/skara/pull/278 From rwestberg at openjdk.java.net Fri Nov 29 11:27:22 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 29 Nov 2019 11:27:22 GMT Subject: RFR: 92: GitRepository::currentBranch fails when on a detached HEAD In-Reply-To: References: Message-ID: On Thu, 28 Nov 2019 15:10:50 GMT, Erik Helin wrote: > Hi all, > > please review this pull request that makes `git webrev` work when the repository is in a "detached HEAD" state (i.e. there is no active branch). The main part of the change is making `ReadOnlyRepository::currentBranch` return `Optional` instead of `Branch`. > > Thanks, > Erik > > ## Testing > - [x] `make test` on Linux x64 > - [x] Manually running `git webrev` on a repository with a detached HEAD > > ---------------- > > Commits: > - 3dc4fea9: 92: GitRepository::currentBranch fails when on a detached HEAD > > Changes: https://git.openjdk.java.net/skara/pull/278/files > Webrev: https://webrevs.openjdk.java.net/skara/278/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-92 > Stats: 40 lines in 8 files changed: 16 ins; 2 del; 22 mod > Patch: https://git.openjdk.java.net/skara/pull/278.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/278/head:pull/278 vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java line 603: > 602: var current = currentBranch().orElseThrow(() -> > 603: new IOException("No current branch to rebase upon") > 604: ); Should this mention the detached head then as well perhaps? PR: https://git.openjdk.java.net/skara/pull/278 From rwestberg at openjdk.java.net Fri Nov 29 11:27:33 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 29 Nov 2019 11:27:33 GMT Subject: [Approved] RFR: 92: GitRepository::currentBranch fails when on a detached HEAD In-Reply-To: References: Message-ID: On Fri, 29 Nov 2019 09:14:12 GMT, Robin Westberg wrote: > On Thu, 28 Nov 2019 15:10:50 GMT, Erik Helin wrote: > >> Hi all, >> >> please review this pull request that makes `git webrev` work when the repository is in a "detached HEAD" state (i.e. there is no active branch). The main part of the change is making `ReadOnlyRepository::currentBranch` return `Optional` instead of `Branch`. >> >> Thanks, >> Erik >> >> ## Testing >> - [x] `make test` on Linux x64 >> - [x] Manually running `git webrev` on a repository with a detached HEAD >> >> ---------------- >> >> Commits: >> - 3dc4fea9: 92: GitRepository::currentBranch fails when on a detached HEAD >> >> Changes: https://git.openjdk.java.net/skara/pull/278/files >> Webrev: https://webrevs.openjdk.java.net/skara/278/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/SKARA-92 >> Stats: 40 lines in 8 files changed: 16 ins; 2 del; 22 mod >> Patch: https://git.openjdk.java.net/skara/pull/278.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/278/head:pull/278 > > Looks good! Perhaps the error message could be made a bit more helpful, but not sure what it should say. :) > > cli/src/main/java/org/openjdk/skara/cli/GitPr.java line 523: > >> 522: var currentBranch = repo.currentBranch().orElseGet(() -> { >> 523: System.err.println("error: the repository is in a detached HEAD state"); >> 524: System.exit(1); > > Suggestion: > > System.err.println("error: the repository is in a detached HEAD state. check out a branch to continue.. or something"); > > ---------------- > > Approved by rwestberg (Reviewer). Sounds good! PR: https://git.openjdk.java.net/skara/pull/278 From rwestberg at openjdk.java.net Fri Nov 29 11:30:04 2019 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 29 Nov 2019 11:30:04 GMT Subject: RFR: 92: GitRepository::currentBranch fails when on a detached HEAD In-Reply-To: References: Message-ID: On Fri, 29 Nov 2019 11:27:22 GMT, Robin Westberg wrote: > On Thu, 28 Nov 2019 15:10:50 GMT, Erik Helin wrote: > >> Hi all, >> >> please review this pull request that makes `git webrev` work when the repository is in a "detached HEAD" state (i.e. there is no active branch). The main part of the change is making `ReadOnlyRepository::currentBranch` return `Optional` instead of `Branch`. >> >> Thanks, >> Erik >> >> ## Testing >> - [x] `make test` on Linux x64 >> - [x] Manually running `git webrev` on a repository with a detached HEAD >> >> ---------------- >> >> Commits: >> - 3dc4fea9: 92: GitRepository::currentBranch fails when on a detached HEAD >> >> Changes: https://git.openjdk.java.net/skara/pull/278/files >> Webrev: https://webrevs.openjdk.java.net/skara/278/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/SKARA-92 >> Stats: 40 lines in 8 files changed: 16 ins; 2 del; 22 mod >> Patch: https://git.openjdk.java.net/skara/pull/278.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/278/head:pull/278 > > vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java line 603: > >> 602: var current = currentBranch().orElseThrow(() -> >> 603: new IOException("No current branch to rebase upon") >> 604: ); > > Should this mention the detached head then as well perhaps? Scratch that, guess this is hg :) PR: https://git.openjdk.java.net/skara/pull/278