RFR: Support the "neutral" check conclusion

Erik Helin ehelin at openjdk.org
Tue Nov 5 09:25:55 UTC 2019


On Tue, 5 Nov 2019 09:21:21 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this minor change that adds support for the "neutral" check conclusion that can be returned by the GitHub check API.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - fe87b631: Support the "neutral" check conclusion
> 
> Changes: https://git.openjdk.java.net/skara/pull/234/files
>  Webrev: https://webrevs.openjdk.java.net/skara/234/webrev.00
>   Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
>   Patch: https://git.openjdk.java.net/skara/pull/234.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/234/head:pull/234

forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java line 319:

> 318:                                         break;
> 319:                                     case "failure":
> 320:                                     case "neutral":

Suggestion:

                                    case "failure":
                                        // fallthrough

PR: https://git.openjdk.java.net/skara/pull/234


More information about the skara-dev mailing list