[Approved] RFR: Add "Required" title to jcheck-check only if it fails

Robin Westberg rwestberg at openjdk.org
Wed Nov 6 11:08:36 UTC 2019


On Wed, 6 Nov 2019 11:06:09 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that only sets the title `"Required"` for the jcheck-check if jcheck fails.
> 
> Thanks,
> Erik
> 
> ----------------
> 
> Commits:
>  - 41ebd437: Add "Required" title to jcheck-check only if it fails
> 
> Changes: https://git.openjdk.java.net/skara/pull/238/files
>  Webrev: https://webrevs.openjdk.java.net/skara/238/webrev.00
>   Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod
>   Patch: https://git.openjdk.java.net/skara/pull/238.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/238/head:pull/238

Looks good!

----------------

Approved by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/238


More information about the skara-dev mailing list