[Approved] RFR: 148: Review comment general comment first

Wed Nov 6 14:40:22 UTC 2019

On Wed, 6 Nov 2019 14:36:02 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that puts general review comments before file specific ones, and improves the threading of Reviewer approvals.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 0a679c02: Generic review comment before specific ones, improve reparenting of Reviewer approvals
> 
> Changes: https://git.openjdk.java.net/skara/pull/239/files
>  Webrev: https://webrevs.openjdk.java.net/skara/239/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/SKARA-148
>   Stats: 88 lines in 6 files changed: 74 ins; 2 del; 12 mod
>   Patch: https://git.openjdk.java.net/skara/pull/239.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/239/head:pull/239

Looks good, thanks for fixing this!

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/239