RFR: Add buildnum extraction support for OpenJFX tags

[Kevin Rushforth]

On Thu, 7 Nov 2019 10:58:14 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this minor change that enables parsing of the tag format used in the OpenJFX project.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - b7d6dfa0: Add buildnum extraction support for OpenJFX tags
> 
> Changes: https://git.openjdk.java.net/skara/pull/241/files
>  Webrev: https://webrevs.openjdk.java.net/skara/241/webrev.00
>   Stats: 29 lines in 2 files changed: 26 ins; 1 del; 2 mod
>   Patch: https://git.openjdk.java.net/skara/pull/241.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/241/head:pull/241

vcs/src/main/java/org/openjdk/skara/vcs/openjdk/OpenJDKTag.java line 62:

> 61:     private final static String OpenJDKVersionPattern = "(jdk-([0-9]+(\\.[0-9]){0,3}))(\\+)([0-9]+)";
> 62:     private final static String OpenJFXVersionPattern = "((?:jdk-){0,1}([1-9](?:(?:[0-9]*)(\\.(?:0|[1-9][0-9]*)){0,3})))(?:(\\+)([0-9]+)|(-ga))";
> 63: 

Not related to this change, but the OpenJDKVersionPattern also will need support for `*-ga` tags.

vcs/src/main/java/org/openjdk/skara/vcs/openjdk/OpenJDKTag.java line 111:

> 110:      */
> 111:     public int buildNum() {
> 112:         if (buildNum == null) {

Under what conditions will this be null? When using a `*-ga` tag? If so, this seems fine.

I presume this will work. I'm curious as to why this is needed, though. As long as a tag passes jcheck, why does the vcs module need to know about valid tag formats that a particular project might choose to use?

PR: https://git.openjdk.java.net/skara/pull/241