[Approved] RFR: Use tag annotation if present when sending notifications

[Erik Helin]

On Fri, 8 Nov 2019 08:18:15 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> The pull request has been updated with additional changes.
> 
> ----------------
> 
> Added commits:
>  - fe09eede: Adjust email formatting
> 
> Changes:
>   - all: https://git.openjdk.java.net/skara/pull/243/files
>   - new: https://git.openjdk.java.net/skara/pull/243/files/1edc0fdd..fe09eede
> 
> Webrevs:
>  - full: https://webrevs.openjdk.java.net/skara/243/webrev.02
>  - incr: https://webrevs.openjdk.java.net/skara/243/webrev.01-02
> 
>   Stats: 109 lines in 4 files changed: 60 ins; 21 del; 28 mod
>   Patch: https://git.openjdk.java.net/skara/pull/243.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/243/head:pull/243

Still good, just a small suggestion inline based on latest changes ��

bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java line 44:

> 43:     private final Path storagePath;
> 44:     private final Pattern branches;
> 45:     private final StorageBuilder<Tag> tagStorageBuilder;

Please move this below the for loop so it is next to the for loop of `newNonJdkTags`

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/243