[Approved] RFR: Add tester bot and ci module

[Robin Westberg]

On Mon, 11 Nov 2019 15:46:05 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this slightly larger patch that adds the `tester` bot and the `ci` module. The `tester` is the bot supporting the `/test` command in a PR, for example writing `/test tier1`. I wanted to name the bot `test` but it was to annoying to get that work with the already present `test` module �� 
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] `sh gradlew test` passes on Linux x64
> - [x] Added a bunch of new unit tests for the `tester` bot (`ci` module is just an interface)
> - [x] Manually tested to deploy the bot
> 
> ----------------
> 
> Commits:
>  - 436deb55: Add tester bot and ci module
> 
> Changes: https://git.openjdk.java.net/skara/pull/248/files
>  Webrev: https://webrevs.openjdk.java.net/skara/248/webrev.00
>   Stats: 3356 lines in 39 files changed: 3356 ins; 0 del; 0 mod
>   Patch: https://git.openjdk.java.net/skara/pull/248.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/248/head:pull/248

Looks good!

bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java line 136:

> 135:                 ret.put(entry.name(), ci.get());
> 136:             } else {
> 137:                 throw new ConfigurationError("No continuous integration named with url: " + url);

Suggestion:

                throw new ConfigurationError("No continuous integration could be created from url: " + url);

----------------

Approved by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/248