RFR: Fix parsing of editor commandline in git-pr

[Erik Helin]

On Wed, 20 Nov 2019 14:12:32 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> On Wed, 20 Nov 2019 10:21:22 GMT, Christoph Langer <clanger at openjdk.org> wrote:
> 
>> On Wed, 20 Nov 2019 09:10:14 GMT, Erik Helin <ehelin at openjdk.org> wrote:
>> 
>>> On Tue, 19 Nov 2019 14:35:13 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>>> 
>>>> Fix parsing of editor commandline in git-pr.
>>>> 
>>>> ----------------
>>>> 
>>>> Commits:
>>>>  - 199285fc: Fix parsing of editor commandline in git-pr.
>>>> 
>>>> Changes: https://git.openjdk.java.net/skara/pull/259/files
>>>>  Webrev: https://webrevs.openjdk.java.net/skara/259/webrev.00
>>>>   Stats: 10 lines in 2 files changed: 8 ins; 0 del; 2 mod
>>>>   Patch: https://git.openjdk.java.net/skara/pull/259.diff
>>>>   Fetch: git fetch https://git.openjdk.java.net/skara pull/259/head:pull/259
>>> 
>>> Hi Christoph,
>>> 
>>> thanks for contributing! Just two small nits before I will continue to review this:
>>> 
>>> 1. Please describe what you changed in this pull request. You did not provide a description in this PR.
>>> 2. One usually do not end PR titles with a `.`, so please remove that from the title of the PR.
>>> 
>>> Thanks!
>>> Erik
>> 
>>> Hi Christoph,
>>> 
>>> thanks for contributing! Just two small nits before I will continue to review this:
>>> 
>>> 1. Please describe what you changed in this pull request. You did not provide a description in this PR.
>>> 2. One usually do not end PR titles with a `.`, so please remove that from the title of the PR.
>>> 
>>> Thanks!
>>> Erik
>> 
>> Hi Erik,
>> 
>> thanks for pointing out these points. I think I've addressed them.
>> 
>> I created the pull request via the Skara tool call "git pr create". I'm wondering whether there is any documentation about this tool?
>> E.g. is there an option to give a pull request description? Also, how is one supposed to refer to a JBS bug (if I created one).
>> Furthermore, git pr has quite a few suboptions. Is there some documentation on what these all are supposed to do?
>> 
>> Thanks
>> Christoph
> 
> The cli tools have documentation in man format here: https://github.com/openjdk/skara/tree/master/cli/resources/man/man1 - unfortunately, this documentation isn't complete yet..
> 
> Erik knows most about these tools, but I think when you are prompted to enter a description, it should be of the format:
> 
> <issue number>: title
> <blank line>
> Log description

Christopher, as Robin says, we unfortunately only have a man page at the moment (which won't help you very much since you are on Windows). You can get more abbreviated help information by running `git pr -h`. Robin is also right in how you add a longer multiline description to the pull request.

As for the regular expression, could you please add a comments above with a few examples. Also, do you really need the quotation marks around the path to `notepad.exe` for `core.editor`? Won't the following suffice:

core.editor = C:\Program Files\Notepad++\notepad++.exe -multiInst -notabbar -nosession -noPlugin

Thanks,
Erik

PR: https://git.openjdk.java.net/skara/pull/259