[Approved] RFR: If there are no changes after squashing, fail jcheck
Erik Helin
ehelin at openjdk.java.net
Fri Nov 22 11:39:33 UTC 2019
On Thu, 21 Nov 2019 13:47:36 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
> Hi all,
>
> Please review this change that ensures that if the contents of a PR are identical to the base after squashing, jcheck will fail (as there's nothing to integrate). Previously, this caused an exception.
>
> Best regards,
> Robin
>
> ----------------
>
> Commits:
> - afb5d7b6: If there are no changes after squashing, fail jcheck
>
> Changes: https://git.openjdk.java.net/skara/pull/263/files
> Webrev: https://webrevs.openjdk.java.net/skara/263/webrev.00
> Stats: 71 lines in 5 files changed: 51 ins; 4 del; 16 mod
> Patch: https://git.openjdk.java.net/skara/pull/263.diff
> Fetch: git fetch https://git.openjdk.java.net/skara pull/263/head:pull/263
Looks good!
----------------
Approved by ehelin (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/263
More information about the skara-dev
mailing list