[Approved] RFR: Ensure Python 3 compatibility for the hg extension

[Erik Helin]

On Mon, 25 Nov 2019 09:06:33 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that makes Skara's internally used Mercurial extension work with Python 3, while also retaining Python 2 compatibility. The Mercurial distribution on MacOS (through homebrew) recently switched to using Python 3, so this change will make the CI for Mac pass again.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 27aef11c: Refactor usages of .encode
>  - 85287fe7: Restore python2 compatibility
>  - dd54ede1: More adjustments
>  - f90befc2: Mercurial wants byte strings when using 3
> 
> Changes: https://git.openjdk.java.net/skara/pull/267/files
>  Webrev: https://webrevs.openjdk.java.net/skara/267/webrev.00
>   Stats: 57 lines in 1 file changed: 7 ins; 3 del; 47 mod
>   Patch: https://git.openjdk.java.net/skara/pull/267.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/267/head:pull/267

Looks good!

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/267