From ehelin at openjdk.org Tue Oct 1 10:12:49 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 1 Oct 2019 10:12:49 GMT Subject: [Approved] RFR: Issue tracker support In-Reply-To: References: Message-ID: On Wed, 25 Sep 2019 13:14:38 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that introduces issue support. An Issue contains a subset of PullRequest functionality, similar to how this is modeled in GitHub and GitLab. It also allows creating support for other issue trackers that do not have repository support, such as Jira. > > Best regards, > Robin > > ---------------- > > Commits: > - 7b0e6107: Implement test version of Issue and IssueProject > - b603a667: GitHub and GitLab does not yet implement Issues > - d1886dcc: Extract IssueProject and Issue from HostedRepository and PullRequest > > Changes: https://git.openjdk.java.net/skara/pull/162/files > Webrev: https://webrevs.openjdk.java.net/skara/162/webrev.00 > Stats: 854 lines in 20 files changed: 608 ins; 240 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/162.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/162/head:pull/162 I know that @rwestberg has a few more commits depending on this one, so lets get the functionality in and then we can extract the interfaces. Approved. ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/162 From duke at openjdk.java.net Tue Oct 1 10:31:43 2019 From: duke at openjdk.java.net (duke) Date: Tue, 1 Oct 2019 10:31:43 GMT Subject: [Integrated] RFR: Issue tracker support In-Reply-To: References: Message-ID: <68cd2832-469d-49d6-827f-f6cc62b7e394@openjdk.java.net> Changeset: 85a94b6b Author: Robin Westberg Date: 2019-10-01 10:31:25 +0000 URL: https://git.openjdk.java.net/skara/commit/85a94b6b Issue tracker support Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java ! host/src/main/java/org/openjdk/skara/host/Host.java ! host/src/main/java/org/openjdk/skara/host/HostedRepository.java + host/src/main/java/org/openjdk/skara/host/Issue.java + host/src/main/java/org/openjdk/skara/host/IssueProject.java ! host/src/main/java/org/openjdk/skara/host/PullRequest.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubHost.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubRepository.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabHost.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabRepository.java ! test/src/main/java/org/openjdk/skara/test/HostCredentials.java + test/src/main/java/org/openjdk/skara/test/IssueData.java + test/src/main/java/org/openjdk/skara/test/PullRequestData.java ! test/src/main/java/org/openjdk/skara/test/TestHost.java ! test/src/main/java/org/openjdk/skara/test/TestHostedRepository.java + test/src/main/java/org/openjdk/skara/test/TestIssue.java + test/src/main/java/org/openjdk/skara/test/TestIssueProject.java ! test/src/main/java/org/openjdk/skara/test/TestPullRequest.java From rwestberg at openjdk.org Tue Oct 1 10:31:19 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 1 Oct 2019 10:31:19 GMT Subject: RFR: Issue tracker support In-Reply-To: <2T39tCb7B8lb0X3_Lqj3nER3v3lwP1fxwJo6MhuwB5Y=.467e64be-bbe1-426e-98ed-3a2bf0e42943@github.com> References: <2T39tCb7B8lb0X3_Lqj3nER3v3lwP1fxwJo6MhuwB5Y=.467e64be-bbe1-426e-98ed-3a2bf0e42943@github.com> Message-ID: On Mon, 30 Sep 2019 14:46:30 GMT, Robin Westberg wrote: > On Mon, 30 Sep 2019 13:40:41 GMT, Erik Helin wrote: > >> On Wed, 25 Sep 2019 13:14:38 GMT, Robin Westberg wrote: >> >>> Hi all, >>> >>> Please review this change that introduces issue support. An Issue contains a subset of PullRequest functionality, similar to how this is modeled in GitHub and GitLab. It also allows creating support for other issue trackers that do not have repository support, such as Jira. >>> >>> Best regards, >>> Robin >>> >>> ---------------- >>> >>> Commits: >>> - 7b0e6107: Implement test version of Issue and IssueProject >>> - b603a667: GitHub and GitLab does not yet implement Issues >>> - d1886dcc: Extract IssueProject and Issue from HostedRepository and PullRequest >>> >>> Changes: https://git.openjdk.java.net/skara/pull/162/files >>> Webrev: https://webrevs.openjdk.java.net/skara/162/webrev.00 >>> Stats: 854 lines in 20 files changed: 608 ins; 240 del; 6 mod >>> Patch: https://git.openjdk.java.net/skara/pull/162.diff >>> Fetch: git fetch https://git.openjdk.java.net/skara pull/162/head:pull/162 >> >> _Very_ nice work Robin to have `PullRequest implements Issue` and `HostedRepository implements IssueTracker`. I see that you basically copied parts of the `PullRequest` and `HostedRepository` interfaces, I would prefer to take this opportunity to update some of the naming conventions for methods (in particular dropping the "get" prefix). I also think that that the `Issue` and `IssueTracker` interfaces should be moved to a separate module: `issuetracker`. Now sure how much of this you want to do in this PR or if you want to integrate this first and the adapt the code? >> >> host/src/main/java/org/openjdk/skara/host/Issue.java line 40: >> >>> 39: */ >>> 40: String getId(); >>> 41: >> >> Please drop the "get" and just use `id` >> >> host/src/main/java/org/openjdk/skara/host/Issue.java line 46: >> >>> 45: */ >>> 46: HostUserDetails getAuthor(); >>> 47: >> >> Again, drop the "get" >> >> host/src/main/java/org/openjdk/skara/host/Issue.java line 52: >> >>> 51: */ >>> 52: String getTitle(); >>> 53: >> >> ...and drop the "get" ?? >> >> host/src/main/java/org/openjdk/skara/host/Issue.java line 64: >> >>> 63: */ >>> 64: String getBody(); >>> 65: >> >> Drop "get" here as well >> >> host/src/main/java/org/openjdk/skara/host/Issue.java line 76: >> >>> 75: */ >>> 76: List getComments(); >>> 77: >> >> and drop "get" here too >> >> host/src/main/java/org/openjdk/skara/host/Issue.java line 95: >> >>> 94: */ >>> 95: ZonedDateTime getCreated(); >>> 96: >> >> I would suggest renaming `getCreated()` to `createdAt()` >> >> host/src/main/java/org/openjdk/skara/host/Issue.java line 101: >> >>> 100: */ >>> 101: ZonedDateTime getUpdated(); >>> 102: >> >> I would suggest renaming `getUpdated` to `updatedAt` >> >> host/src/main/java/org/openjdk/skara/host/Issue.java line 130: >> >>> 129: */ >>> 130: List getLabels(); >>> 131: >> >> Drop the "get" here too >> >> host/src/main/java/org/openjdk/skara/host/Issue.java line 135: >> >>> 134: */ >>> 135: URI getWebUrl(); >>> 136: >> >> Drop "get" here as well >> >> host/src/main/java/org/openjdk/skara/host/Issue.java line 140: >> >>> 139: */ >>> 140: List getAssignees(); >>> 141: >> >> Drop "get" here too >> >> host/src/main/java/org/openjdk/skara/host/Issue.java line 146: >> >>> 145: */ >>> 146: void setAssignees(List assignees); >>> 147: } >> >> Rename this from `setAssignees` to `assignTo`? > > Right, as the PullRequest interface now extends the Issue interface, renaming these methods would touch pretty much every file in the bots directory I guess.. ?? But yes, would be nice to clean up. > > (While I'm at it, I'll have to check if the mailing list archive correctly displays these: ??? and ?) :) Thanks Erik! PR: https://git.openjdk.java.net/skara/pull/162 From rwestberg at openjdk.org Tue Oct 1 10:52:11 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 1 Oct 2019 10:52:11 GMT Subject: RFR: Add issue information to the PR summary Message-ID: Hi all, Please review this change that adds issue information to the PR summary, if it can be parsed from the PR title. It also tries to retrieve the title of the issue from the associated issue tracker. Best regards, Robin ---------------- Commits: - d7dceeed: Add issue information to the PR summary Changes: https://git.openjdk.java.net/skara/pull/171/files Webrev: https://webrevs.openjdk.java.net/skara/171/webrev.00 Stats: 160 lines in 12 files changed: 142 ins; 1 del; 17 mod Patch: https://git.openjdk.java.net/skara/pull/171.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/171/head:pull/171 PR: https://git.openjdk.java.net/skara/pull/171 From ehelin at openjdk.org Tue Oct 1 13:05:32 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 1 Oct 2019 13:05:32 GMT Subject: RFR: Add Makefile wrapper Message-ID: Hi all, this patch adds a Makefile "wrapper" around `gradlew`. This allows the Skara CLI tooling to be installed using the (for Linux/macOS users) familiar commands: $ make $ make install The user can also give a prefix to `make install`, as in `make prefix=/usr install`. The Makefile variables have the same names as for git upstream. One benefit of installing the Skara CLI tooling this way is that the man pages are available via `--help` to various Skara CLI commands. Please note that this is in _no_ way meant to replace the existing Gradle based build system, this is only a thin wrapper for convenience. Thanks, Erik ---------------- Commits: - c34d755a: Add Makefile Changes: https://git.openjdk.java.net/skara/pull/172/files Webrev: https://webrevs.openjdk.java.net/skara/172/webrev.00 Stats: 56 lines in 1 file changed: 56 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/172.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/172/head:pull/172 PR: https://git.openjdk.java.net/skara/pull/172 From ehelin at openjdk.org Tue Oct 1 14:56:45 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 1 Oct 2019 14:56:45 GMT Subject: RFR: Add Host::isMemberOf Message-ID: Hi all, this patch adds a new method `Host::isMemberOf` that can be used to query a host (e.g. GitHub or Gitlab) if a specific user is a member of a particular group. I couldn't come up with a positive test for the method, since it is really hard to rely on a test user being a member of a particular group, but I could at least write a negative test. ## Testing - [x] `sh gradlew test` passes on Linux x86_64 Thanks, Erik ---------------- Commits: - 52633d26: Add Host::isMemberOf Changes: https://git.openjdk.java.net/skara/pull/173/files Webrev: https://webrevs.openjdk.java.net/skara/173/webrev.00 Stats: 70 lines in 5 files changed: 70 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/173.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/173/head:pull/173 PR: https://git.openjdk.java.net/skara/pull/173 From rwestberg at openjdk.org Wed Oct 2 06:06:13 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 2 Oct 2019 06:06:13 GMT Subject: RFR: Add Makefile wrapper In-Reply-To: References: Message-ID: <88illwDNOjZjYrOSqAG2U6JiDvMrIi_cbhev51z0L2U=.c42e18c0-5156-4552-b33d-4f9521597400@github.com> On Tue, 1 Oct 2019 13:05:32 GMT, Erik Helin wrote: > Hi all, > > this patch adds a Makefile "wrapper" around `gradlew`. This allows the Skara CLI tooling to be installed using the (for Linux/macOS users) familiar commands: > > $ make > $ make install > > The user can also give a prefix to `make install`, as in `make prefix=/usr install`. The Makefile variables have the same names as for git upstream. One benefit of installing the Skara CLI tooling this way is that the man pages are available via `--help` to various Skara CLI commands. > > Please note that this is in _no_ way meant to replace the existing Gradle based build system, this is only a thin wrapper for convenience. > > Thanks, > Erik > > ---------------- > > Commits: > - c34d755a: Add Makefile > > Changes: https://git.openjdk.java.net/skara/pull/172/files > Webrev: https://webrevs.openjdk.java.net/skara/172/webrev.00 > Stats: 56 lines in 1 file changed: 56 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/172.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/172/head:pull/172 Makefile line 41: > 40: install: all $(LAUNCHERS) $(MANPAGES) $(sharedir)/skara > 41: > 42: $(mandir)/man1/%: $(BUILD)/bin/man/man1/% Perhaps echo something like "Installed to $(prefix)" here? PR: https://git.openjdk.java.net/skara/pull/172 From rwestberg at openjdk.org Wed Oct 2 06:06:11 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 2 Oct 2019 06:06:11 GMT Subject: [Approved] RFR: Add Makefile wrapper In-Reply-To: References: Message-ID: On Tue, 1 Oct 2019 13:05:32 GMT, Erik Helin wrote: > Hi all, > > this patch adds a Makefile "wrapper" around `gradlew`. This allows the Skara CLI tooling to be installed using the (for Linux/macOS users) familiar commands: > > $ make > $ make install > > The user can also give a prefix to `make install`, as in `make prefix=/usr install`. The Makefile variables have the same names as for git upstream. One benefit of installing the Skara CLI tooling this way is that the man pages are available via `--help` to various Skara CLI commands. > > Please note that this is in _no_ way meant to replace the existing Gradle based build system, this is only a thin wrapper for convenience. > > Thanks, > Erik > > ---------------- > > Commits: > - c34d755a: Add Makefile > > Changes: https://git.openjdk.java.net/skara/pull/172/files > Webrev: https://webrevs.openjdk.java.net/skara/172/webrev.00 > Stats: 56 lines in 1 file changed: 56 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/172.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/172/head:pull/172 Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/172 From ehelin at openjdk.org Wed Oct 2 06:36:39 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 2 Oct 2019 06:36:39 GMT Subject: RFR: Add Makefile wrapper In-Reply-To: <88illwDNOjZjYrOSqAG2U6JiDvMrIi_cbhev51z0L2U=.c42e18c0-5156-4552-b33d-4f9521597400@github.com> References: <88illwDNOjZjYrOSqAG2U6JiDvMrIi_cbhev51z0L2U=.c42e18c0-5156-4552-b33d-4f9521597400@github.com> Message-ID: On Wed, 2 Oct 2019 06:06:13 GMT, Robin Westberg wrote: > On Tue, 1 Oct 2019 13:05:32 GMT, Erik Helin wrote: > >> Hi all, >> >> this patch adds a Makefile "wrapper" around `gradlew`. This allows the Skara CLI tooling to be installed using the (for Linux/macOS users) familiar commands: >> >> $ make >> $ make install >> >> The user can also give a prefix to `make install`, as in `make prefix=/usr install`. The Makefile variables have the same names as for git upstream. One benefit of installing the Skara CLI tooling this way is that the man pages are available via `--help` to various Skara CLI commands. >> >> Please note that this is in _no_ way meant to replace the existing Gradle based build system, this is only a thin wrapper for convenience. >> >> Thanks, >> Erik >> >> ---------------- >> >> Commits: >> - c34d755a: Add Makefile >> >> Changes: https://git.openjdk.java.net/skara/pull/172/files >> Webrev: https://webrevs.openjdk.java.net/skara/172/webrev.00 >> Stats: 56 lines in 1 file changed: 56 ins; 0 del; 0 mod >> Patch: https://git.openjdk.java.net/skara/pull/172.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/172/head:pull/172 > > Makefile line 41: > >> 40: install: all $(LAUNCHERS) $(MANPAGES) $(sharedir)/skara >> 41: >> 42: $(mandir)/man1/%: $(BUILD)/bin/man/man1/% > > Perhaps echo something like "Installed to $(prefix)" here? Good idea, let me fix. Erik Joelsson also suggested offline that I should probably provide an `uninstall` target as well, I will add that too. PR: https://git.openjdk.java.net/skara/pull/172 From rwestberg at openjdk.org Wed Oct 2 06:53:01 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 2 Oct 2019 06:53:01 GMT Subject: RFR: Add Host::isMemberOf In-Reply-To: References: Message-ID: On Tue, 1 Oct 2019 14:56:45 GMT, Erik Helin wrote: > Hi all, > > this patch adds a new method `Host::isMemberOf` that can be used to query a host (e.g. GitHub or Gitlab) if a specific user is a member of a particular group. I couldn't come up with a positive test for the method, since it is really hard to rely on a test user being a member of a particular group, but I could at least write a negative test. > > ## Testing > - [x] `sh gradlew test` passes on Linux x86_64 > > Thanks, > Erik > > ---------------- > > Commits: > - 52633d26: Add Host::isMemberOf > > Changes: https://git.openjdk.java.net/skara/pull/173/files > Webrev: https://webrevs.openjdk.java.net/skara/173/webrev.00 > Stats: 70 lines in 5 files changed: 70 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/173.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/173/head:pull/173 host/src/main/java/org/openjdk/skara/host/Host.java line 34: > 33: boolean supportsReviewBody(); > 34: boolean isMemberOf(long groupId, HostUserDetails user); > 35: You may want to make the groupId parameter a String instead, there are hosts out there that we may want to support that don't use numerical ids. PR: https://git.openjdk.java.net/skara/pull/173 From rwestberg at openjdk.org Wed Oct 2 07:06:10 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 2 Oct 2019 07:06:10 GMT Subject: RFR: Batch add tags in the notifier bot Message-ID: Hi all, Please review this change that allows adding multiple tags in one run when starting to run the notifier for the new repository. Previously, for a repository with many tags, a separate commit would be generated for each. Best regards, Robin ---------------- Commits: - 1b5eae57: And use it in the notifier bot - ac0bef37: Allow updating more than one item at a time for Storage Changes: https://git.openjdk.java.net/skara/pull/174/files Webrev: https://webrevs.openjdk.java.net/skara/174/webrev.00 Stats: 85 lines in 10 files changed: 34 ins; 7 del; 44 mod Patch: https://git.openjdk.java.net/skara/pull/174.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/174/head:pull/174 PR: https://git.openjdk.java.net/skara/pull/174 From ehelin at openjdk.org Wed Oct 2 08:02:41 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 2 Oct 2019 08:02:41 GMT Subject: RFR: Add issue information to the PR summary In-Reply-To: References: Message-ID: <2MfGZAIWL449uCCZk_RogLYlRJZMs5PABgWhjkDbBGw=.373ab1b4-6105-4fa1-9e73-7d4014f3fc3a@github.com> On Tue, 1 Oct 2019 10:52:11 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adds issue information to the PR summary, if it can be parsed from the PR title. It also tries to retrieve the title of the issue from the associated issue tracker. > > Best regards, > Robin > > ---------------- > > Commits: > - d7dceeed: Add issue information to the PR summary > > Changes: https://git.openjdk.java.net/skara/pull/171/files > Webrev: https://webrevs.openjdk.java.net/skara/171/webrev.00 > Stats: 160 lines in 12 files changed: 142 ins; 1 del; 17 mod > Patch: https://git.openjdk.java.net/skara/pull/171.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/171/head:pull/171 bot/src/main/java/org/openjdk/skara/bot/BotConfiguration.java line 49: > 48: */ > 49: IssueProject issueProject(String name); > 50: I just had to test a multi-line comment ?? bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 265: > 264: progressBody.append("--------\n"); > 265: var iss = issueProject.getIssue(issue.get().id()); > 266: if (iss.isPresent()) { Might be easier to use `##` instead of `------`? PR: https://git.openjdk.java.net/skara/pull/171 From ehelin at openjdk.org Wed Oct 2 08:02:39 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 2 Oct 2019 08:02:39 GMT Subject: [Approved] RFR: Add issue information to the PR summary In-Reply-To: References: Message-ID: On Tue, 1 Oct 2019 10:52:11 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adds issue information to the PR summary, if it can be parsed from the PR title. It also tries to retrieve the title of the issue from the associated issue tracker. > > Best regards, > Robin > > ---------------- > > Commits: > - d7dceeed: Add issue information to the PR summary > > Changes: https://git.openjdk.java.net/skara/pull/171/files > Webrev: https://webrevs.openjdk.java.net/skara/171/webrev.00 > Stats: 160 lines in 12 files changed: 142 ins; 1 del; 17 mod > Patch: https://git.openjdk.java.net/skara/pull/171.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/171/head:pull/171 Looks good overall, me and Robin have discussed some of the naming offline and Robin is preparing a PR which will change some/many of the names. ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/171 From ehelin at openjdk.org Wed Oct 2 08:04:20 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 2 Oct 2019 08:04:20 GMT Subject: [Approved] RFR: Batch add tags in the notifier bot In-Reply-To: References: Message-ID: On Wed, 2 Oct 2019 07:06:10 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows adding multiple tags in one run when starting to run the notifier for the new repository. Previously, for a repository with many tags, a separate commit would be generated for each. > > Best regards, > Robin > > ---------------- > > Commits: > - 1b5eae57: And use it in the notifier bot > - ac0bef37: Allow updating more than one item at a time for Storage > > Changes: https://git.openjdk.java.net/skara/pull/174/files > Webrev: https://webrevs.openjdk.java.net/skara/174/webrev.00 > Stats: 85 lines in 10 files changed: 34 ins; 7 del; 44 mod > Patch: https://git.openjdk.java.net/skara/pull/174.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/174/head:pull/174 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/174 From ehelin at openjdk.org Wed Oct 2 08:20:48 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 2 Oct 2019 08:20:48 GMT Subject: RFR: Add CheckBuilder::from Message-ID: Hi all, this small patch adds the method `CheckBuilder::from` that allows a `CheckBuilder` to be initialized to all the values from an existing `Check`, thereby enabling modifying a `Check` (while still preserving the old `Check`). ## Testing - [x] `sh gradlew test` passes - [x] Added one new unit test Thanks, Erik ---------------- Commits: - b97049ef: Add CheckBuilder::from Changes: https://git.openjdk.java.net/skara/pull/175/files Webrev: https://webrevs.openjdk.java.net/skara/175/webrev.00 Stats: 130 lines in 3 files changed: 130 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/175.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/175/head:pull/175 PR: https://git.openjdk.java.net/skara/pull/175 From rwestberg at openjdk.org Wed Oct 2 08:25:39 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 2 Oct 2019 08:25:39 GMT Subject: [Approved] RFR: Add CheckBuilder::from In-Reply-To: References: Message-ID: On Wed, 2 Oct 2019 08:20:48 GMT, Erik Helin wrote: > Hi all, > > this small patch adds the method `CheckBuilder::from` that allows a `CheckBuilder` to be initialized to all the values from an existing `Check`, thereby enabling modifying a `Check` (while still preserving the old `Check`). > > ## Testing > - [x] `sh gradlew test` passes > - [x] Added one new unit test > > Thanks, > Erik > > ---------------- > > Commits: > - b97049ef: Add CheckBuilder::from > > Changes: https://git.openjdk.java.net/skara/pull/175/files > Webrev: https://webrevs.openjdk.java.net/skara/175/webrev.00 > Stats: 130 lines in 3 files changed: 130 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/175.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/175/head:pull/175 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/175 From rwestberg at openjdk.org Wed Oct 2 08:30:45 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 2 Oct 2019 08:30:45 GMT Subject: [Rev 01] RFR: Add issue information to the PR summary In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 037d521c: Update markdown formatting Changes: - all: https://git.openjdk.java.net/skara/pull/171/files - new: https://git.openjdk.java.net/skara/pull/171/files/d7dceeed..037d521c Webrevs: - full: https://webrevs.openjdk.java.net/skara/171/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/171/webrev.00-01 Stats: 6 lines in 1 file changed: 0 ins; 3 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/171.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/171/head:pull/171 PR: https://git.openjdk.java.net/skara/pull/171 From rwestberg at openjdk.org Wed Oct 2 08:31:11 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 2 Oct 2019 08:31:11 GMT Subject: RFR: Add issue information to the PR summary In-Reply-To: <2MfGZAIWL449uCCZk_RogLYlRJZMs5PABgWhjkDbBGw=.373ab1b4-6105-4fa1-9e73-7d4014f3fc3a@github.com> References: <2MfGZAIWL449uCCZk_RogLYlRJZMs5PABgWhjkDbBGw=.373ab1b4-6105-4fa1-9e73-7d4014f3fc3a@github.com> Message-ID: <7cEpABERnqaR_Di9pbQP-upUDeiB75qvJGeTWyTtunA=.2ad20fed-faa9-4d72-85c1-9f4c9fbed95b@github.com> On Wed, 2 Oct 2019 08:02:41 GMT, Erik Helin wrote: > On Tue, 1 Oct 2019 10:52:11 GMT, Robin Westberg wrote: > >> Hi all, >> >> Please review this change that adds issue information to the PR summary, if it can be parsed from the PR title. It also tries to retrieve the title of the issue from the associated issue tracker. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - d7dceeed: Add issue information to the PR summary >> >> Changes: https://git.openjdk.java.net/skara/pull/171/files >> Webrev: https://webrevs.openjdk.java.net/skara/171/webrev.00 >> Stats: 160 lines in 12 files changed: 142 ins; 1 del; 17 mod >> Patch: https://git.openjdk.java.net/skara/pull/171.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/171/head:pull/171 > > bot/src/main/java/org/openjdk/skara/bot/BotConfiguration.java line 49: > >> 48: */ >> 49: IssueProject issueProject(String name); >> 50: > > I just had to test a multi-line comment ?? > > bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 265: > >> 264: progressBody.append("--------\n"); >> 265: var iss = issueProject.getIssue(issue.get().id()); >> 266: if (iss.isPresent()) { > > Might be easier to use `##` instead of `------`? Sure, can change. PR: https://git.openjdk.java.net/skara/pull/171 From duke at openjdk.java.net Wed Oct 2 08:31:42 2019 From: duke at openjdk.java.net (duke) Date: Wed, 2 Oct 2019 08:31:42 GMT Subject: [Integrated] RFR: Add issue information to the PR summary In-Reply-To: References: Message-ID: <117c34f1-8c8d-477e-afb2-5c9a5fab152e@openjdk.java.net> Changeset: 80cc2478 Author: Robin Westberg Date: 2019-10-02 08:31:33 +0000 URL: https://git.openjdk.java.net/skara/commit/80cc2478 Add issue information to the PR summary Reviewed-by: ehelin ! bot/src/main/java/org/openjdk/skara/bot/BotConfiguration.java ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java ! host/src/main/java/org/openjdk/skara/host/IssueProject.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubRepository.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabRepository.java ! test/src/main/java/org/openjdk/skara/test/TestHost.java ! test/src/main/java/org/openjdk/skara/test/TestIssueProject.java From duke at openjdk.java.net Wed Oct 2 08:32:22 2019 From: duke at openjdk.java.net (duke) Date: Wed, 2 Oct 2019 08:32:22 GMT Subject: [Integrated] RFR: Batch add tags in the notifier bot In-Reply-To: References: Message-ID: Changeset: 78dcf940 Author: Robin Westberg Date: 2019-10-02 08:32:13 +0000 URL: https://git.openjdk.java.net/skara/commit/78dcf940 Batch add tags in the notifier bot Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/UpdateHistory.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdateHistoryTests.java ! storage/src/main/java/org/openjdk/skara/storage/FileStorage.java ! storage/src/main/java/org/openjdk/skara/storage/HostedRepositoryStorage.java ! storage/src/main/java/org/openjdk/skara/storage/RepositoryStorage.java ! storage/src/main/java/org/openjdk/skara/storage/Storage.java ! storage/src/main/java/org/openjdk/skara/storage/StorageSerializer.java ! storage/src/test/java/org/openjdk/skara/storage/FileStorageTests.java ! storage/src/test/java/org/openjdk/skara/storage/RepositoryStorageTests.java From duke at openjdk.java.net Wed Oct 2 08:53:42 2019 From: duke at openjdk.java.net (duke) Date: Wed, 2 Oct 2019 08:53:42 GMT Subject: [Integrated] RFR: Add CheckBuilder::from In-Reply-To: References: Message-ID: <429967fb-3f66-4eba-8c86-58cf82ef1366@openjdk.java.net> Changeset: 667f26e6 Author: Erik Helin Date: 2019-10-02 08:53:34 +0000 URL: https://git.openjdk.java.net/skara/commit/667f26e6 Add CheckBuilder::from Reviewed-by: rwestberg ! host/build.gradle ! host/src/main/java/org/openjdk/skara/host/CheckBuilder.java + host/src/test/java/org/openjdk/skara/host/CheckBuilderTests.java From ehelin at openjdk.org Wed Oct 2 08:58:38 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 2 Oct 2019 08:58:38 GMT Subject: RFR: Add Host::isMemberOf In-Reply-To: References: Message-ID: On Wed, 2 Oct 2019 06:53:01 GMT, Robin Westberg wrote: > On Tue, 1 Oct 2019 14:56:45 GMT, Erik Helin wrote: > >> Hi all, >> >> this patch adds a new method `Host::isMemberOf` that can be used to query a host (e.g. GitHub or Gitlab) if a specific user is a member of a particular group. I couldn't come up with a positive test for the method, since it is really hard to rely on a test user being a member of a particular group, but I could at least write a negative test. >> >> ## Testing >> - [x] `sh gradlew test` passes on Linux x86_64 >> >> Thanks, >> Erik >> >> ---------------- >> >> Commits: >> - 52633d26: Add Host::isMemberOf >> >> Changes: https://git.openjdk.java.net/skara/pull/173/files >> Webrev: https://webrevs.openjdk.java.net/skara/173/webrev.00 >> Stats: 70 lines in 5 files changed: 70 ins; 0 del; 0 mod >> Patch: https://git.openjdk.java.net/skara/pull/173.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/173/head:pull/173 > > host/src/main/java/org/openjdk/skara/host/Host.java line 34: > >> 33: boolean supportsReviewBody(); >> 34: boolean isMemberOf(long groupId, HostUserDetails user); >> 35: > > You may want to make the groupId parameter a String instead, there are hosts out there that we may want to support that don't use numerical ids. Thanks, updated! PR: https://git.openjdk.java.net/skara/pull/173 From ehelin at openjdk.org Wed Oct 2 08:58:35 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 2 Oct 2019 08:58:35 GMT Subject: [Rev 01] RFR: Add Host::isMemberOf In-Reply-To: References: Message-ID: <7sPn-Il9S7DoRYlYmguMH-YmD0ly2WDrUoq4SGS-6jE=.f04ec427-5dcd-45bb-96d9-cba810e1f22b@github.com> The pull request has been updated with additional changes. ---------------- Added commits: - 417b671f: Use String instead of long for groupId Changes: - all: https://git.openjdk.java.net/skara/pull/173/files - new: https://git.openjdk.java.net/skara/pull/173/files/52633d26..417b671f Webrevs: - full: https://webrevs.openjdk.java.net/skara/173/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/173/webrev.00-01 Stats: 19 lines in 5 files changed: 12 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/173.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/173/head:pull/173 PR: https://git.openjdk.java.net/skara/pull/173 From rwestberg at openjdk.org Wed Oct 2 09:01:19 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 2 Oct 2019 09:01:19 GMT Subject: [Approved] RFR: Add Host::isMemberOf In-Reply-To: References: Message-ID: On Tue, 1 Oct 2019 14:56:45 GMT, Erik Helin wrote: > Hi all, > > this patch adds a new method `Host::isMemberOf` that can be used to query a host (e.g. GitHub or Gitlab) if a specific user is a member of a particular group. I couldn't come up with a positive test for the method, since it is really hard to rely on a test user being a member of a particular group, but I could at least write a negative test. > > ## Testing > - [x] `sh gradlew test` passes on Linux x86_64 > > Thanks, > Erik > > ---------------- > > Commits: > - 52633d26: Add Host::isMemberOf > > Changes: https://git.openjdk.java.net/skara/pull/173/files > Webrev: https://webrevs.openjdk.java.net/skara/173/webrev.00 > Stats: 70 lines in 5 files changed: 70 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/173.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/173/head:pull/173 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/173 From duke at openjdk.java.net Wed Oct 2 09:10:41 2019 From: duke at openjdk.java.net (duke) Date: Wed, 2 Oct 2019 09:10:41 GMT Subject: [Integrated] RFR: Add Host::isMemberOf In-Reply-To: References: Message-ID: <6bb15bbd-6aa4-4f9b-884c-6682fb1e8c72@openjdk.java.net> Changeset: 048a1c8a Author: Erik Helin Date: 2019-10-02 09:10:33 +0000 URL: https://git.openjdk.java.net/skara/commit/048a1c8a Add Host::isMemberOf Reviewed-by: rwestberg ! host/src/main/java/org/openjdk/skara/host/Host.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubHost.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabHost.java + host/src/test/java/org/openjdk/skara/host/HostTests.java ! test/src/main/java/org/openjdk/skara/test/TestHost.java From rwestberg at openjdk.org Wed Oct 2 09:13:55 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 2 Oct 2019 09:13:55 GMT Subject: RFR: Implement basic support for the Jira issue tracker Message-ID: Hi all, Please review this change that introduces a basic implementation of the Issue* interfaces with support for the Jira tracker. The implementation can currently only perform simple read-only operations, but it is enough to be used for such things as the pull request status bot. Best regards, Robin ---------------- Commits: - c1f4fd24: Implement basic support for the Jira issue tracker Changes: https://git.openjdk.java.net/skara/pull/176/files Webrev: https://webrevs.openjdk.java.net/skara/176/webrev.00 Stats: 335 lines in 6 files changed: 327 ins; 2 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/176.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/176/head:pull/176 PR: https://git.openjdk.java.net/skara/pull/176 From ehelin at openjdk.org Wed Oct 2 09:17:29 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 2 Oct 2019 09:17:29 GMT Subject: [Rev 01] RFR: Add Makefile wrapper In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 2487f811: Add uninstall target - fc56117a: Write friendly message after successful installation Changes: - all: https://git.openjdk.java.net/skara/pull/172/files - new: https://git.openjdk.java.net/skara/pull/172/files/c34d755a..2487f811 Webrevs: - full: https://webrevs.openjdk.java.net/skara/172/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/172/webrev.00-01 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/172.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/172/head:pull/172 PR: https://git.openjdk.java.net/skara/pull/172 From rwestberg at openjdk.org Wed Oct 2 09:21:30 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 2 Oct 2019 09:21:30 GMT Subject: RFR: Add Makefile wrapper In-Reply-To: References: <88illwDNOjZjYrOSqAG2U6JiDvMrIi_cbhev51z0L2U=.c42e18c0-5156-4552-b33d-4f9521597400@github.com> Message-ID: <0_4J0AshVhf_ZltJXTJX4itvXB58xSIT6Gkpx79cobM=.b073c0b5-f72d-4bf5-861f-ee4057a772e1@github.com> On Wed, 2 Oct 2019 06:36:39 GMT, Erik Helin wrote: > On Wed, 2 Oct 2019 06:06:13 GMT, Robin Westberg wrote: > >> On Tue, 1 Oct 2019 13:05:32 GMT, Erik Helin wrote: >> >>> Hi all, >>> >>> this patch adds a Makefile "wrapper" around `gradlew`. This allows the Skara CLI tooling to be installed using the (for Linux/macOS users) familiar commands: >>> >>> $ make >>> $ make install >>> >>> The user can also give a prefix to `make install`, as in `make prefix=/usr install`. The Makefile variables have the same names as for git upstream. One benefit of installing the Skara CLI tooling this way is that the man pages are available via `--help` to various Skara CLI commands. >>> >>> Please note that this is in _no_ way meant to replace the existing Gradle based build system, this is only a thin wrapper for convenience. >>> >>> Thanks, >>> Erik >>> >>> ---------------- >>> >>> Commits: >>> - c34d755a: Add Makefile >>> >>> Changes: https://git.openjdk.java.net/skara/pull/172/files >>> Webrev: https://webrevs.openjdk.java.net/skara/172/webrev.00 >>> Stats: 56 lines in 1 file changed: 56 ins; 0 del; 0 mod >>> Patch: https://git.openjdk.java.net/skara/pull/172.diff >>> Fetch: git fetch https://git.openjdk.java.net/skara pull/172/head:pull/172 >> >> Makefile line 41: >> >>> 40: install: all $(LAUNCHERS) $(MANPAGES) $(sharedir)/skara >>> 41: >>> 42: $(mandir)/man1/%: $(BUILD)/bin/man/man1/% >> >> Perhaps echo something like "Installed to $(prefix)" here? > > Good idea, let me fix. Erik Joelsson also suggested offline that I should probably provide an `uninstall` target as well, I will add that too. Looks good! PR: https://git.openjdk.java.net/skara/pull/172 From duke at openjdk.java.net Wed Oct 2 09:24:31 2019 From: duke at openjdk.java.net (duke) Date: Wed, 2 Oct 2019 09:24:31 GMT Subject: [Integrated] RFR: Add Makefile wrapper In-Reply-To: References: Message-ID: <63a83c82-7a77-48e3-81e1-541ded3a55cc@openjdk.java.net> Changeset: 133e8307 Author: Erik Helin Date: 2019-10-02 09:24:22 +0000 URL: https://git.openjdk.java.net/skara/commit/133e8307 Add Makefile wrapper Reviewed-by: rwestberg + Makefile From rwestberg at openjdk.org Wed Oct 2 09:42:50 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 2 Oct 2019 09:42:50 GMT Subject: RFR: WIP: 108: Command line tools fon't run with Cygwin git In-Reply-To: References: Message-ID: On Mon, 30 Sep 2019 21:28:59 GMT, Kevin Rushforth wrote: > This is a very preliminary "proof of concept" patch that allows `git jcheck` to work with git from Cygwin. It is incomplete, and is missing the necessary checks to allow it to continue working with native Windows git. > > @edvbld @rwestberg - I submitted it this early to get your high-level feedback on whether this support is something that you have already thought about already; if not, I'd like your feedback on the approach. > > The idea would be to check whether we are are using a Cygwin version of git (this should be trivial), and if so, do the conversion between the `Path` strings and the input/output to the `git` command in all of the necessary places in `GitRepository` (that should be the only class that needs to be modified). > > ---------------- > > Commits: > - 11270d33: WIP: 108: Command line tools fon't run with Cygwin git > > Changes: https://git.openjdk.java.net/skara/pull/170/files > Webrev: https://webrevs.openjdk.java.net/skara/170/webrev.00 > Stats: 30 lines in 2 files changed: 23 ins; 0 del; 7 mod > Patch: https://git.openjdk.java.net/skara/pull/170.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/170/head:pull/170 Looks like a reasonable approach to me, perhaps our most prominent Windows user @jornvernee has considered something in this area.. I usually avoid installing cygwin git to avoid issues like this. PR: https://git.openjdk.java.net/skara/pull/170 From rwestberg at openjdk.org Wed Oct 2 10:58:41 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 2 Oct 2019 10:58:41 GMT Subject: RFR: Post specific review comments before generic ones Message-ID: Hi all, Please review this small change that improves the order in which mailing list messages are composed with regards to review comments. Best regards, Robin ---------------- Commits: - ecb12863: Post specific review comments before generic ones Changes: https://git.openjdk.java.net/skara/pull/177/files Webrev: https://webrevs.openjdk.java.net/skara/177/webrev.00 Stats: 65 lines in 2 files changed: 37 ins; 22 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/177.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/177/head:pull/177 PR: https://git.openjdk.java.net/skara/pull/177 From jvernee at openjdk.org Wed Oct 2 12:24:00 2019 From: jvernee at openjdk.org (Jorn Vernee) Date: Wed, 2 Oct 2019 12:24:00 GMT Subject: RFR: WIP: 108: Command line tools fon't run with Cygwin git In-Reply-To: References: Message-ID: On Wed, 2 Oct 2019 09:42:50 GMT, Robin Westberg wrote: > On Mon, 30 Sep 2019 21:28:59 GMT, Kevin Rushforth wrote: > >> This is a very preliminary "proof of concept" patch that allows `git jcheck` to work with git from Cygwin. It is incomplete, and is missing the necessary checks to allow it to continue working with native Windows git. >> >> @edvbld @rwestberg - I submitted it this early to get your high-level feedback on whether this support is something that you have already thought about already; if not, I'd like your feedback on the approach. >> >> The idea would be to check whether we are are using a Cygwin version of git (this should be trivial), and if so, do the conversion between the `Path` strings and the input/output to the `git` command in all of the necessary places in `GitRepository` (that should be the only class that needs to be modified). >> >> ---------------- >> >> Commits: >> - 11270d33: WIP: 108: Command line tools fon't run with Cygwin git >> >> Changes: https://git.openjdk.java.net/skara/pull/170/files >> Webrev: https://webrevs.openjdk.java.net/skara/170/webrev.00 >> Stats: 30 lines in 2 files changed: 23 ins; 0 del; 7 mod >> Patch: https://git.openjdk.java.net/skara/pull/170.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/170/head:pull/170 > > Looks like a reasonable approach to me, perhaps our most prominent Windows user @jornvernee has considered something in this area.. I usually avoid installing cygwin git to avoid issues like this. @rwestberg I'm happily using Windows native git :) PR: https://git.openjdk.java.net/skara/pull/170 From ehelin at openjdk.org Thu Oct 3 08:24:46 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 3 Oct 2019 08:24:46 GMT Subject: [Approved] RFR: Post specific review comments before generic ones In-Reply-To: References: Message-ID: On Wed, 2 Oct 2019 10:58:41 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that improves the order in which mailing list messages are composed with regards to review comments. > > Best regards, > Robin > > ---------------- > > Commits: > - ecb12863: Post specific review comments before generic ones > > Changes: https://git.openjdk.java.net/skara/pull/177/files > Webrev: https://webrevs.openjdk.java.net/skara/177/webrev.00 > Stats: 65 lines in 2 files changed: 37 ins; 22 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/177.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/177/head:pull/177 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/177 From ehelin at openjdk.org Thu Oct 3 10:04:55 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 3 Oct 2019 10:04:55 GMT Subject: [Approved] RFR: Implement basic support for the Jira issue tracker In-Reply-To: References: Message-ID: On Wed, 2 Oct 2019 09:13:55 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that introduces a basic implementation of the Issue* interfaces with support for the Jira tracker. The implementation can currently only perform simple read-only operations, but it is enough to be used for such things as the pull request status bot. > > Best regards, > Robin > > ---------------- > > Commits: > - c1f4fd24: Implement basic support for the Jira issue tracker > > Changes: https://git.openjdk.java.net/skara/pull/176/files > Webrev: https://webrevs.openjdk.java.net/skara/176/webrev.00 > Stats: 335 lines in 6 files changed: 327 ins; 2 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/176.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/176/head:pull/176 Really nice start Robin! You know I want to refactor some stuff, but lets the functionality in there so we can see what it looks like and then we can refactor ?? ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/176 From rwestberg at openjdk.org Thu Oct 3 10:46:49 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 3 Oct 2019 10:46:49 GMT Subject: RFR: Use patterns for branches to notify instead of a list Message-ID: Hi all, Please review this change that lets the notifier use a pattern to determine which branches to monitor, instead of a fixed list. Also fetch everything from the remote in order to perform the pattern matching locally. Best regards, Robin ---------------- Commits: - 7a6183d0: Use patterns for branches to notify instead of a list and just fetch everything from the remote Changes: https://git.openjdk.java.net/skara/pull/178/files Webrev: https://webrevs.openjdk.java.net/skara/178/webrev.00 Stats: 55 lines in 3 files changed: 23 ins; 3 del; 29 mod Patch: https://git.openjdk.java.net/skara/pull/178.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/178/head:pull/178 PR: https://git.openjdk.java.net/skara/pull/178 From duke at openjdk.java.net Thu Oct 3 12:44:48 2019 From: duke at openjdk.java.net (duke) Date: Thu, 3 Oct 2019 12:44:48 GMT Subject: [Integrated] RFR: Implement basic support for the Jira issue tracker In-Reply-To: References: Message-ID: Changeset: 59f04e41 Author: Robin Westberg Date: 2019-10-03 12:44:31 +0000 URL: https://git.openjdk.java.net/skara/commit/59f04e41 Implement basic support for the Jira issue tracker Reviewed-by: ehelin ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java ! host/src/main/java/org/openjdk/skara/host/HostFactory.java ! host/src/main/java/org/openjdk/skara/host/HostUserDetails.java + host/src/main/java/org/openjdk/skara/host/jira/JiraHost.java + host/src/main/java/org/openjdk/skara/host/jira/JiraIssue.java + host/src/main/java/org/openjdk/skara/host/jira/JiraProject.java From duke at openjdk.java.net Thu Oct 3 12:45:28 2019 From: duke at openjdk.java.net (duke) Date: Thu, 3 Oct 2019 12:45:28 GMT Subject: [Integrated] RFR: Post specific review comments before generic ones In-Reply-To: References: Message-ID: <3a251131-cfe1-468b-8744-edcecc744c01@openjdk.java.net> Changeset: 3475db95 Author: Robin Westberg Date: 2019-10-03 12:45:19 +0000 URL: https://git.openjdk.java.net/skara/commit/3475db95 Post specific review comments before generic ones Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From ehelin at openjdk.org Thu Oct 3 12:53:24 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 3 Oct 2019 12:53:24 GMT Subject: [Approved] RFR: Use patterns for branches to notify instead of a list In-Reply-To: References: Message-ID: On Thu, 3 Oct 2019 10:46:49 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that lets the notifier use a pattern to determine which branches to monitor, instead of a fixed list. Also fetch everything from the remote in order to perform the pattern matching locally. > > Best regards, > Robin > > ---------------- > > Commits: > - 7a6183d0: Use patterns for branches to notify instead of a list and just fetch everything from the remote > > Changes: https://git.openjdk.java.net/skara/pull/178/files > Webrev: https://webrevs.openjdk.java.net/skara/178/webrev.00 > Stats: 55 lines in 3 files changed: 23 ins; 3 del; 29 mod > Patch: https://git.openjdk.java.net/skara/pull/178.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/178/head:pull/178 Looks good, just one minor nit! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/178 From ehelin at openjdk.org Thu Oct 3 12:53:25 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 3 Oct 2019 12:53:25 GMT Subject: RFR: Use patterns for branches to notify instead of a list In-Reply-To: References: Message-ID: On Thu, 3 Oct 2019 10:46:49 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that lets the notifier use a pattern to determine which branches to monitor, instead of a fixed list. Also fetch everything from the remote in order to perform the pattern matching locally. > > Best regards, > Robin > > ---------------- > > Commits: > - 7a6183d0: Use patterns for branches to notify instead of a list and just fetch everything from the remote > > Changes: https://git.openjdk.java.net/skara/pull/178/files > Webrev: https://webrevs.openjdk.java.net/skara/178/webrev.00 > Stats: 55 lines in 3 files changed: 23 ins; 3 del; 29 mod > Patch: https://git.openjdk.java.net/skara/pull/178.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/178/head:pull/178 bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java line 182: > 181: } > 182: } > 183: } catch (IOException e) { `if (branches.matcher(ref.name()).matches())` ? PR: https://git.openjdk.java.net/skara/pull/178 From rwestberg at openjdk.org Thu Oct 3 12:58:10 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 3 Oct 2019 12:58:10 GMT Subject: RFR: Use patterns for branches to notify instead of a list In-Reply-To: References: Message-ID: On Thu, 3 Oct 2019 12:53:25 GMT, Erik Helin wrote: > On Thu, 3 Oct 2019 10:46:49 GMT, Robin Westberg wrote: > >> Hi all, >> >> Please review this change that lets the notifier use a pattern to determine which branches to monitor, instead of a fixed list. Also fetch everything from the remote in order to perform the pattern matching locally. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - 7a6183d0: Use patterns for branches to notify instead of a list and just fetch everything from the remote >> >> Changes: https://git.openjdk.java.net/skara/pull/178/files >> Webrev: https://webrevs.openjdk.java.net/skara/178/webrev.00 >> Stats: 55 lines in 3 files changed: 23 ins; 3 del; 29 mod >> Patch: https://git.openjdk.java.net/skara/pull/178.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/178/head:pull/178 > > bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java line 182: > >> 181: } >> 182: } >> 183: } catch (IOException e) { > > `if (branches.matcher(ref.name()).matches())` ? Sure, why not! PR: https://git.openjdk.java.net/skara/pull/178 From rwestberg at openjdk.org Thu Oct 3 12:58:07 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 3 Oct 2019 12:58:07 GMT Subject: [Rev 01] RFR: Use patterns for branches to notify instead of a list In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - aaace9f4: Remove unnecessary local variable Changes: - all: https://git.openjdk.java.net/skara/pull/178/files - new: https://git.openjdk.java.net/skara/pull/178/files/7a6183d0..aaace9f4 Webrevs: - full: https://webrevs.openjdk.java.net/skara/178/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/178/webrev.00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/178.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/178/head:pull/178 PR: https://git.openjdk.java.net/skara/pull/178 From rwestberg at openjdk.org Thu Oct 3 13:18:56 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 3 Oct 2019 13:18:56 GMT Subject: RFR: Fix build failure after rebase Message-ID: Hi all, Please review this minor change that fixes a build problem after the Jira support was integrated. Best regards, Robin ---------------- Commits: - 73b3ea63: Fix build failure after rebase Changes: https://git.openjdk.java.net/skara/pull/179/files Webrev: https://webrevs.openjdk.java.net/skara/179/webrev.00 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/179.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/179/head:pull/179 PR: https://git.openjdk.java.net/skara/pull/179 From ehelin at openjdk.org Thu Oct 3 13:27:15 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 3 Oct 2019 13:27:15 GMT Subject: [Approved] RFR: Fix build failure after rebase In-Reply-To: References: Message-ID: On Thu, 3 Oct 2019 13:18:56 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that fixes a build problem after the Jira support was integrated. > > Best regards, > Robin > > ---------------- > > Commits: > - 73b3ea63: Fix build failure after rebase > > Changes: https://git.openjdk.java.net/skara/pull/179/files > Webrev: https://webrevs.openjdk.java.net/skara/179/webrev.00 > Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/179.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/179/head:pull/179 Looks good ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/179 From duke at openjdk.java.net Thu Oct 3 13:27:57 2019 From: duke at openjdk.java.net (duke) Date: Thu, 3 Oct 2019 13:27:57 GMT Subject: [Integrated] RFR: Fix build failure after rebase In-Reply-To: References: Message-ID: <16dfaa7c-6b1c-4863-ba47-9dade274f60c@openjdk.java.net> Changeset: 0bda3a4f Author: Robin Westberg Date: 2019-10-03 13:27:48 +0000 URL: https://git.openjdk.java.net/skara/commit/0bda3a4f Fix build failure after rebase Reviewed-by: ehelin ! host/src/main/java/org/openjdk/skara/host/jira/JiraHost.java From duke at openjdk.java.net Thu Oct 3 13:43:07 2019 From: duke at openjdk.java.net (duke) Date: Thu, 3 Oct 2019 13:43:07 GMT Subject: git: openjdk/skara: Use patterns for branches to notify instead of a list Message-ID: Changeset: 1bf3e51d Author: Robin Westberg Date: 2019-10-03 13:42:59 +0000 URL: https://git.openjdk.java.net/skara/commit/1bf3e51d Use patterns for branches to notify instead of a list Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From ehelin at openjdk.org Thu Oct 3 14:05:09 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 3 Oct 2019 14:05:09 GMT Subject: RFR: Make it possible to cancel a Check Message-ID: Hi all, this patch became a bit larger than I initially thought. I added a new `CheckState` - `CANCELLED` and a new method to `CheckBuider` - `cancel()`. However to fully support this I needed to quite a bit of refactoring in both `GitHubPullRequest` and `GitLabMergeRequest` so that `createCheck` allows checks with all kinds of states to be created. ## Testing - [x] `sh gradlew test` passes on Linux x86_64 - [x] Added one new unit test - [x] `sh gradlew test` with credentials mostly passes against both GitHub and GitLab (there are a few known failures) Thanks, Erik ---------------- Commits: - ed66f45c: Make it possible cancel a Check Changes: https://git.openjdk.java.net/skara/pull/180/files Webrev: https://webrevs.openjdk.java.net/skara/180/webrev.00 Stats: 245 lines in 5 files changed: 149 ins; 48 del; 48 mod Patch: https://git.openjdk.java.net/skara/pull/180.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/180/head:pull/180 PR: https://git.openjdk.java.net/skara/pull/180 From ehelin at openjdk.org Thu Oct 3 14:15:49 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 3 Oct 2019 14:15:49 GMT Subject: RFR: Fix NPE in GitLabHost::isMemberOf Message-ID: Hi all, this small patch fixes an (embarrasing) NPE in `GitLabHost::isMemberOf`. Calling `.asObject()` will result in `details` being `null` in the `onError` is executed (since `JSON.of()` produces `JSONNull` whose `asObject` returns `null`). The fix is simply to not call `.asObject()`. ## Testing - [x] `sh gradlew test` passes on Linux x86_64 - [x] `HostTests` passes `sh gradlew test` with credentials Thanks, Erik ---------------- Commits: - f5f2bb9f: Fix NPE in GitLabHost::isMemberOf Changes: https://git.openjdk.java.net/skara/pull/181/files Webrev: https://webrevs.openjdk.java.net/skara/181/webrev.00 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/181.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/181/head:pull/181 PR: https://git.openjdk.java.net/skara/pull/181 From philip.race at oracle.com Fri Oct 4 01:44:24 2019 From: philip.race at oracle.com (Philip Race) Date: Thu, 03 Oct 2019 18:44:24 -0700 Subject: user@openjdk.org ? In-Reply-To: <13e65c6b-ba2b-40b6-9b7c-61b613e7ed8e@openjdk.java.net> References: <13e65c6b-ba2b-40b6-9b7c-61b613e7ed8e@openjdk.java.net> Message-ID: <5D96A3F8.9080300@oracle.com> What are these openjdk.org email addresses in the commits ? I sent an email to Kevin's below and got a bounce. So I sent one to my open jdk id prr at openjdk.org and also get a bounce Just to try it, I also sent one to my "github" equivalent user at openjdk.org and again get a bounce. Someone hoping to contact the committer is going to be very confused and stuck. Duke probably won't be able to help them either. Do I have to configure something to make it real ? -phil -------- Original Message -------- Subject: git: jpg-dev/jfx: 8231735: gradle checkrepo is obsolete and doesn't work with git Date: Thu, 3 Oct 2019 16:49:57 GMT From: duke To: Changeset: 3db691dc Author: Kevin Rushforth Date: 2019-10-03 16:49:31 +0000 URL: https://orahub.oraclecorp.com/jpg-dev/jfx/commit/3db691dc 8231735: gradle checkrepo is obsolete and doesn't work with git Reviewed-by: aghaisas ! common-dev-build.sh ! rt-closed/closed-build.gradle From rwestberg at openjdk.org Fri Oct 4 06:08:18 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 4 Oct 2019 06:08:18 GMT Subject: [Approved] RFR: Make it possible to cancel a Check In-Reply-To: References: Message-ID: <6HPjxiQg_nxXUPeIfYBDXolv5eZ4TIb1noTN4wiR9-8=.29eec613-2fe5-423e-98e1-5d1ad06131a6@github.com> On Thu, 3 Oct 2019 14:05:09 GMT, Erik Helin wrote: > Hi all, > > this patch became a bit larger than I initially thought. I added a new `CheckState` - `CANCELLED` and a new method to `CheckBuider` - `cancel()`. However to fully support this I needed to quite a bit of refactoring in both `GitHubPullRequest` and `GitLabMergeRequest` so that `createCheck` allows checks with all kinds of states to be created. > > ## Testing > - [x] `sh gradlew test` passes on Linux x86_64 > - [x] Added one new unit test > - [x] `sh gradlew test` with credentials mostly passes against both GitHub and GitLab (there are a few known failures) > > Thanks, > Erik > > ---------------- > > Commits: > - ed66f45c: Make it possible cancel a Check > > Changes: https://git.openjdk.java.net/skara/pull/180/files > Webrev: https://webrevs.openjdk.java.net/skara/180/webrev.00 > Stats: 245 lines in 5 files changed: 149 ins; 48 del; 48 mod > Patch: https://git.openjdk.java.net/skara/pull/180.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/180/head:pull/180 Looks good, thanks for fixing! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/180 From rwestberg at openjdk.org Fri Oct 4 06:08:17 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 4 Oct 2019 06:08:17 GMT Subject: RFR: Make it possible to cancel a Check In-Reply-To: References: Message-ID: On Thu, 3 Oct 2019 14:05:09 GMT, Erik Helin wrote: > Hi all, > > this patch became a bit larger than I initially thought. I added a new `CheckState` - `CANCELLED` and a new method to `CheckBuider` - `cancel()`. However to fully support this I needed to quite a bit of refactoring in both `GitHubPullRequest` and `GitLabMergeRequest` so that `createCheck` allows checks with all kinds of states to be created. > > ## Testing > - [x] `sh gradlew test` passes on Linux x86_64 > - [x] Added one new unit test > - [x] `sh gradlew test` with credentials mostly passes against both GitHub and GitLab (there are a few known failures) > > Thanks, > Erik > > ---------------- > > Commits: > - ed66f45c: Make it possible cancel a Check > > Changes: https://git.openjdk.java.net/skara/pull/180/files > Webrev: https://webrevs.openjdk.java.net/skara/180/webrev.00 > Stats: 245 lines in 5 files changed: 149 ins; 48 del; 48 mod > Patch: https://git.openjdk.java.net/skara/pull/180.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/180/head:pull/180 host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java line 454: > 453: var annotationString = " - "; > 454: switch (annotation.level()) { > 455: case NOTICE: Suggestion: body = "? The merge request check **" + check.name() + "** has been cancelled."; PR: https://git.openjdk.java.net/skara/pull/180 From rwestberg at openjdk.org Fri Oct 4 06:09:18 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 4 Oct 2019 06:09:18 GMT Subject: [Approved] RFR: Fix NPE in GitLabHost::isMemberOf In-Reply-To: References: Message-ID: On Thu, 3 Oct 2019 14:15:49 GMT, Erik Helin wrote: > Hi all, > > this small patch fixes an (embarrasing) NPE in `GitLabHost::isMemberOf`. Calling `.asObject()` will result in `details` being `null` in the `onError` is executed (since `JSON.of()` produces `JSONNull` whose `asObject` returns `null`). The fix is simply to not call `.asObject()`. > > ## Testing > - [x] `sh gradlew test` passes on Linux x86_64 > - [x] `HostTests` passes `sh gradlew test` with credentials > > Thanks, > Erik > > ---------------- > > Commits: > - f5f2bb9f: Fix NPE in GitLabHost::isMemberOf > > Changes: https://git.openjdk.java.net/skara/pull/181/files > Webrev: https://webrevs.openjdk.java.net/skara/181/webrev.00 > Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/181.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/181/head:pull/181 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/181 From rwestberg at openjdk.org Fri Oct 4 07:20:05 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 4 Oct 2019 07:20:05 GMT Subject: RFR: 118: Use jcheck configuration from PR target branch Message-ID: Hi all, Please review this change that uses the jcheck configuration from the target branch when checking pull requests. See the issue for more details. Best regards, Robin ---------------- Commits: - 3dd7b05e: Read jcheck configuration from the PR target ref Changes: https://git.openjdk.java.net/skara/pull/182/files Webrev: https://webrevs.openjdk.java.net/skara/182/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-118 Stats: 10 lines in 2 files changed: 0 ins; 4 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/182.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/182/head:pull/182 PR: https://git.openjdk.java.net/skara/pull/182 From ehelin at openjdk.org Fri Oct 4 07:25:52 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 4 Oct 2019 07:25:52 GMT Subject: [Rev 01] RFR: Make it possible to cancel a Check In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 01b22f05: Improve grammar Changes: - all: https://git.openjdk.java.net/skara/pull/180/files - new: https://git.openjdk.java.net/skara/pull/180/files/ed66f45c..01b22f05 Webrevs: - full: https://webrevs.openjdk.java.net/skara/180/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/180/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/180.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/180/head:pull/180 PR: https://git.openjdk.java.net/skara/pull/180 From duke at openjdk.java.net Fri Oct 4 07:29:48 2019 From: duke at openjdk.java.net (duke) Date: Fri, 4 Oct 2019 07:29:48 GMT Subject: [Integrated] RFR: Make it possible to cancel a Check In-Reply-To: References: Message-ID: <88e29bdb-f92a-4e78-a72b-55d5d28e13d5@openjdk.java.net> Changeset: fc526853 Author: Erik Helin Date: 2019-10-04 07:29:31 +0000 URL: https://git.openjdk.java.net/skara/commit/fc526853 Make it possible to cancel a Check Co-authored-by: Robin Westberg Reviewed-by: rwestberg ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java ! host/src/main/java/org/openjdk/skara/host/CheckBuilder.java ! host/src/main/java/org/openjdk/skara/host/CheckStatus.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java From duke at openjdk.java.net Fri Oct 4 07:30:47 2019 From: duke at openjdk.java.net (duke) Date: Fri, 4 Oct 2019 07:30:47 GMT Subject: [Integrated] RFR: Fix NPE in GitLabHost::isMemberOf In-Reply-To: References: Message-ID: <3c50f932-aca2-4986-8250-ee5ee50bc80e@openjdk.java.net> Changeset: 70f9f001 Author: Erik Helin Date: 2019-10-04 07:30:30 +0000 URL: https://git.openjdk.java.net/skara/commit/70f9f001 Fix NPE in GitLabHost::isMemberOf Reviewed-by: rwestberg ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabHost.java From ehelin at openjdk.org Fri Oct 4 07:48:33 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 4 Oct 2019 07:48:33 GMT Subject: [Approved] RFR: 118: Use jcheck configuration from PR target branch In-Reply-To: References: Message-ID: On Fri, 4 Oct 2019 07:20:05 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that uses the jcheck configuration from the target branch when checking pull requests. See the issue for more details. > > Best regards, > Robin > > ---------------- > > Commits: > - 3dd7b05e: Read jcheck configuration from the PR target ref > > Changes: https://git.openjdk.java.net/skara/pull/182/files > Webrev: https://webrevs.openjdk.java.net/skara/182/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-118 > Stats: 10 lines in 2 files changed: 0 ins; 4 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/182.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/182/head:pull/182 I agree. The only scenario where this becomes a problem is if a user merges a change to `.jcheck/conf` that is _too_ strict (for example requiring `role=lead` and `minimum=2` for the review check, and impossible criteria to fulfill). In that case the project lead will have to manually push a change directly to the repository, since it won't be possible to integrate a PR since the jcheck check can never be fulfilled. But I still think the advantage this change brings to all other PRs outweigh that disadvantage. Go ahead and integrate this! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/182 From duke at openjdk.java.net Fri Oct 4 07:53:13 2019 From: duke at openjdk.java.net (duke) Date: Fri, 4 Oct 2019 07:53:13 GMT Subject: [Integrated] RFR: 118: Use jcheck configuration from PR target branch In-Reply-To: References: Message-ID: <31e7c5fd-9e17-4ef1-8e7f-332c30076503@openjdk.java.net> Changeset: 58716605 Author: Robin Westberg Date: 2019-10-04 07:52:56 +0000 URL: https://git.openjdk.java.net/skara/commit/58716605 118: Use jcheck configuration from PR target branch Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CensusInstance.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CensusInstance.java From ehelin at openjdk.org Fri Oct 4 07:55:12 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 4 Oct 2019 07:55:12 GMT Subject: RFR: WIP: 108: Command line tools fon't run with Cygwin git In-Reply-To: References: Message-ID: On Wed, 2 Oct 2019 12:24:00 GMT, Jorn Vernee wrote: > On Wed, 2 Oct 2019 09:42:50 GMT, Robin Westberg wrote: > >> On Mon, 30 Sep 2019 21:28:59 GMT, Kevin Rushforth wrote: >> >>> This is a very preliminary "proof of concept" patch that allows `git jcheck` to work with git from Cygwin. It is incomplete, and is missing the necessary checks to allow it to continue working with native Windows git. >>> >>> @edvbld @rwestberg - I submitted it this early to get your high-level feedback on whether this support is something that you have already thought about already; if not, I'd like your feedback on the approach. >>> >>> The idea would be to check whether we are are using a Cygwin version of git (this should be trivial), and if so, do the conversion between the `Path` strings and the input/output to the `git` command in all of the necessary places in `GitRepository` (that should be the only class that needs to be modified). >>> >>> ---------------- >>> >>> Commits: >>> - 11270d33: WIP: 108: Command line tools fon't run with Cygwin git >>> >>> Changes: https://git.openjdk.java.net/skara/pull/170/files >>> Webrev: https://webrevs.openjdk.java.net/skara/170/webrev.00 >>> Stats: 30 lines in 2 files changed: 23 ins; 0 del; 7 mod >>> Patch: https://git.openjdk.java.net/skara/pull/170.diff >>> Fetch: git fetch https://git.openjdk.java.net/skara pull/170/head:pull/170 >> >> Looks like a reasonable approach to me, perhaps our most prominent Windows user @jornvernee has considered something in this area.. I usually avoid installing cygwin git to avoid issues like this. > > @rwestberg I'm happily using Windows native git :) Hi Kevin, thanks for looking into this and sorry for not responding earlier. I would like to understand your use case a bit more - why are you using Cygwin git over [Git for Windows](https://gitforwindows.org/)? I understand that you need to use Cygwin, but why not use the Windows native git binary in Cygwin (instead of Cygwin's version of git)? Looking at your changes I can immediately see that adding support for the Cygwin version of git will have far-reaching consequences for almost all our code, so I would really like to understand the advantages of using Cygwin git before pursuing this further. Thanks, Erik PR: https://git.openjdk.java.net/skara/pull/170 From rwestberg at openjdk.org Fri Oct 4 11:54:40 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 4 Oct 2019 11:54:40 GMT Subject: RFR: 119: Support fetching Jira issues with only a partial id Message-ID: Hi all, Please review the following change that allows specifying Jira issues by number only, without a qualifying project name. Best regards, Robin ---------------- Commits: - fb7a04b0: Support fetching Jira issues with only a partial id Changes: https://git.openjdk.java.net/skara/pull/183/files Webrev: https://webrevs.openjdk.java.net/skara/183/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-119 Stats: 31 lines in 4 files changed: 30 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/183.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/183/head:pull/183 PR: https://git.openjdk.java.net/skara/pull/183 From ehelin at openjdk.org Fri Oct 4 11:55:53 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 4 Oct 2019 11:55:53 GMT Subject: [Approved] RFR: 119: Support fetching Jira issues with only a partial id In-Reply-To: References: Message-ID: On Fri, 4 Oct 2019 11:54:40 GMT, Robin Westberg wrote: > Hi all, > > Please review the following change that allows specifying Jira issues by number only, without a qualifying project name. > > Best regards, > Robin > > ---------------- > > Commits: > - fb7a04b0: Support fetching Jira issues with only a partial id > > Changes: https://git.openjdk.java.net/skara/pull/183/files > Webrev: https://webrevs.openjdk.java.net/skara/183/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-119 > Stats: 31 lines in 4 files changed: 30 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/183.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/183/head:pull/183 Looks good ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/183 From duke at openjdk.java.net Fri Oct 4 11:57:33 2019 From: duke at openjdk.java.net (duke) Date: Fri, 4 Oct 2019 11:57:33 GMT Subject: [Integrated] RFR: 119: Support fetching Jira issues with only a partial id In-Reply-To: References: Message-ID: <4166f9a1-7042-417b-b268-e7843b210b41@openjdk.java.net> Changeset: c8b859f1 Author: Robin Westberg Date: 2019-10-04 11:57:16 +0000 URL: https://git.openjdk.java.net/skara/commit/c8b859f1 119: Support fetching Jira issues with only a partial id Reviewed-by: ehelin ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java ! host/src/main/java/org/openjdk/skara/host/jira/JiraProject.java ! test/src/main/java/org/openjdk/skara/test/TestHost.java ! test/src/main/java/org/openjdk/skara/test/TestIssueProject.java From ehelin at openjdk.org Fri Oct 4 12:24:51 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 4 Oct 2019 12:24:51 GMT Subject: [Approved] RFR: Proper markdown formatting of issue link In-Reply-To: <1OXwz5fvtwFqOx-1cvvuUQOaan3qTttRytXCvFUprlM=.7dc04db3-7c88-471c-85e2-b5809442be86@github.com> References: <1OXwz5fvtwFqOx-1cvvuUQOaan3qTttRytXCvFUprlM=.7dc04db3-7c88-471c-85e2-b5809442be86@github.com> Message-ID: On Fri, 4 Oct 2019 12:24:48 GMT, Robin Westberg wrote: > Hi all, > > Please review this trivial fix that properly formats the issue link in pull request summaries. > > Best regards, > Robin > > ---------------- > > Commits: > - 40deed16: Proper markdown formatting of issue link > > Changes: https://git.openjdk.java.net/skara/pull/184/files > Webrev: https://webrevs.openjdk.java.net/skara/184/webrev.00 > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/184.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/184/head:pull/184 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/184 From rwestberg at openjdk.org Fri Oct 4 12:24:48 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 4 Oct 2019 12:24:48 GMT Subject: RFR: Proper markdown formatting of issue link Message-ID: <1OXwz5fvtwFqOx-1cvvuUQOaan3qTttRytXCvFUprlM=.7dc04db3-7c88-471c-85e2-b5809442be86@github.com> Hi all, Please review this trivial fix that properly formats the issue link in pull request summaries. Best regards, Robin ---------------- Commits: - 40deed16: Proper markdown formatting of issue link Changes: https://git.openjdk.java.net/skara/pull/184/files Webrev: https://webrevs.openjdk.java.net/skara/184/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/184.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/184/head:pull/184 PR: https://git.openjdk.java.net/skara/pull/184 From duke at openjdk.java.net Fri Oct 4 12:26:19 2019 From: duke at openjdk.java.net (duke) Date: Fri, 4 Oct 2019 12:26:19 GMT Subject: git: openjdk/skara: Proper markdown formatting of issue link Message-ID: Changeset: 223b20db Author: Robin Westberg Date: 2019-10-04 12:26:10 +0000 URL: https://git.openjdk.java.net/skara/commit/223b20db Proper markdown formatting of issue link Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java From rwestberg at openjdk.org Mon Oct 7 08:27:00 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 7 Oct 2019 08:27:00 GMT Subject: RFR: 119: Attempt to rebase pull requests before running checks Message-ID: Hi all, Please review this change that provides the final fix for https://bugs.openjdk.java.net/browse/SKARA-119 by performing a rebase before running checks. Best regards, Robin ---------------- Commits: - 07c54ff2: Attempt to rebase pull requests before running checks Changes: https://git.openjdk.java.net/skara/pull/185/files Webrev: https://webrevs.openjdk.java.net/skara/185/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-119 Stats: 100 lines in 4 files changed: 75 ins; 21 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/185.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/185/head:pull/185 PR: https://git.openjdk.java.net/skara/pull/185 From rwestberg at openjdk.org Mon Oct 7 08:50:03 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 7 Oct 2019 08:50:03 GMT Subject: RFR: 117: Add support for custom headers in notifier emails Message-ID: Hi all, Please review this change that adds support for setting custom headers in emails sent by the notifier. Best regards, Robin ---------------- Commits: - f8140181: Add support for custom headers in notifier emails Changes: https://git.openjdk.java.net/skara/pull/186/files Webrev: https://webrevs.openjdk.java.net/skara/186/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-117 Stats: 33 lines in 3 files changed: 25 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/skara/pull/186.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/186/head:pull/186 PR: https://git.openjdk.java.net/skara/pull/186 From ehelin at openjdk.org Mon Oct 7 08:54:17 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 7 Oct 2019 08:54:17 GMT Subject: [Approved] RFR: 119: Attempt to rebase pull requests before running checks In-Reply-To: References: Message-ID: On Mon, 7 Oct 2019 08:27:00 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that provides the final fix for https://bugs.openjdk.java.net/browse/SKARA-119 by performing a rebase before running checks. > > Best regards, > Robin > > ---------------- > > Commits: > - 07c54ff2: Attempt to rebase pull requests before running checks > > Changes: https://git.openjdk.java.net/skara/pull/185/files > Webrev: https://webrevs.openjdk.java.net/skara/185/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-119 > Stats: 100 lines in 4 files changed: 75 ins; 21 del; 4 mod > Patch: https://git.openjdk.java.net/skara/pull/185.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/185/head:pull/185 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/185 From ehelin at openjdk.org Mon Oct 7 08:54:36 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 7 Oct 2019 08:54:36 GMT Subject: [Approved] RFR: 117: Add support for custom headers in notifier emails In-Reply-To: References: Message-ID: <-gVXkcGNdkYQ6aKdTwO-fkm7eBn8zmJ_zdLoe1p9Cyg=.54d83d53-5f61-428d-81df-4ac8a3baef01@github.com> On Mon, 7 Oct 2019 08:50:03 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adds support for setting custom headers in emails sent by the notifier. > > Best regards, > Robin > > ---------------- > > Commits: > - f8140181: Add support for custom headers in notifier emails > > Changes: https://git.openjdk.java.net/skara/pull/186/files > Webrev: https://webrevs.openjdk.java.net/skara/186/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-117 > Stats: 33 lines in 3 files changed: 25 ins; 0 del; 8 mod > Patch: https://git.openjdk.java.net/skara/pull/186.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/186/head:pull/186 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/186 From duke at openjdk.java.net Mon Oct 7 08:58:17 2019 From: duke at openjdk.java.net (duke) Date: Mon, 7 Oct 2019 08:58:17 GMT Subject: [Integrated] RFR: 117: Add support for custom headers in notifier emails In-Reply-To: References: Message-ID: Changeset: efb20a70 Author: Robin Westberg Date: 2019-10-07 08:57:59 +0000 URL: https://git.openjdk.java.net/skara/commit/efb20a70 117: Add support for custom headers in notifier emails Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From duke at openjdk.java.net Mon Oct 7 08:58:56 2019 From: duke at openjdk.java.net (duke) Date: Mon, 7 Oct 2019 08:58:56 GMT Subject: [Integrated] RFR: 119: Attempt to rebase pull requests before running checks In-Reply-To: References: Message-ID: <2137f924-13a6-47cf-959a-6e3ab3b03278@openjdk.java.net> Changeset: dc663d36 Author: Robin Westberg Date: 2019-10-07 08:58:40 +0000 URL: https://git.openjdk.java.net/skara/commit/dc663d36 119: Attempt to rebase pull requests before running checks Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java From rwestberg at openjdk.org Mon Oct 7 11:38:46 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 7 Oct 2019 11:38:46 GMT Subject: RFR: 116: Changes link in email notification is wrong for GitLab Message-ID: Hi all, Please review this change that implements proper changes links in notifications for GitLab. Best regards, Robin ---------------- Commits: - ccfdc1ed: Move getChangeUrl into PullRequest to allow a proper implementation for GitLab Changes: https://git.openjdk.java.net/skara/pull/187/files Webrev: https://webrevs.openjdk.java.net/skara/187/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-116 Stats: 69 lines in 8 files changed: 50 ins; 12 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/187.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/187/head:pull/187 PR: https://git.openjdk.java.net/skara/pull/187 From rwestberg at openjdk.org Mon Oct 7 12:38:14 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 7 Oct 2019 12:38:14 GMT Subject: RFR: 123: Set the commit author as sender of commit notification emails Message-ID: <8Y-4--2pO3gvuE-QB7sEBX04G8IGntTi02y1Zzpy28M=.b48cee18-a941-4925-a7b5-014536765f30@github.com> Hi all, Please review this change that uses the commit author (of the last commit, in case of several) as the email author when sending a commit notification email. This can be overridden on a per-list basis if wanted. Best regards, Robin ---------------- Commits: - ea80d334: Use last committer as the author of a notification, unless overridden on a per-list basis Changes: https://git.openjdk.java.net/skara/pull/188/files Webrev: https://webrevs.openjdk.java.net/skara/188/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-123 Stats: 33 lines in 3 files changed: 11 ins; 7 del; 15 mod Patch: https://git.openjdk.java.net/skara/pull/188.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/188/head:pull/188 PR: https://git.openjdk.java.net/skara/pull/188 From rwestberg at openjdk.org Mon Oct 7 13:17:43 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 7 Oct 2019 13:17:43 GMT Subject: RFR: Rebase before running the final check when integrating Message-ID: <3B-dpdMLfW5R62wcxKy0BF-MsBfxwBknxWnj2N6exiY=.b13b8aac-dfed-4ecc-a42d-5343d40d15f8@github.com> Hi all, Please review this change that performs a rebase before running the final check when integrating, to have the same behavior as the initial checking. Best regards, Robin ---------------- Commits: - 26f28320: Rebase before running the final check when integrating Changes: https://git.openjdk.java.net/skara/pull/189/files Webrev: https://webrevs.openjdk.java.net/skara/189/webrev.00 Stats: 28 lines in 2 files changed: 20 ins; 1 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/189.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/189/head:pull/189 PR: https://git.openjdk.java.net/skara/pull/189 From ehelin at openjdk.org Mon Oct 7 14:05:35 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 7 Oct 2019 14:05:35 GMT Subject: [Approved] RFR: 116: Changes link in email notification is wrong for GitLab In-Reply-To: References: Message-ID: <6OsXkwNAURUzxPs1v_iTT4mQnXTI6KJ3rKamHFpeFAA=.5da5f851-6ea3-4236-acd6-8a1dbcc45475@github.com> On Mon, 7 Oct 2019 11:38:46 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that implements proper changes links in notifications for GitLab. > > Best regards, > Robin > > ---------------- > > Commits: > - ccfdc1ed: Move getChangeUrl into PullRequest to allow a proper implementation for GitLab > > Changes: https://git.openjdk.java.net/skara/pull/187/files > Webrev: https://webrevs.openjdk.java.net/skara/187/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-116 > Stats: 69 lines in 8 files changed: 50 ins; 12 del; 7 mod > Patch: https://git.openjdk.java.net/skara/pull/187.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/187/head:pull/187 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/187 From ehelin at openjdk.org Mon Oct 7 14:06:13 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 7 Oct 2019 14:06:13 GMT Subject: [Approved] RFR: 123: Set the commit author as sender of commit notification emails In-Reply-To: <8Y-4--2pO3gvuE-QB7sEBX04G8IGntTi02y1Zzpy28M=.b48cee18-a941-4925-a7b5-014536765f30@github.com> References: <8Y-4--2pO3gvuE-QB7sEBX04G8IGntTi02y1Zzpy28M=.b48cee18-a941-4925-a7b5-014536765f30@github.com> Message-ID: <5RiToisluSRrdz6t3ojtd6ynJD7io9PecUGizOsUTI8=.afa35168-0763-4899-bfe9-0ecd39163256@github.com> On Mon, 7 Oct 2019 12:38:14 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that uses the commit author (of the last commit, in case of several) as the email author when sending a commit notification email. This can be overridden on a per-list basis if wanted. > > Best regards, > Robin > > ---------------- > > Commits: > - ea80d334: Use last committer as the author of a notification, unless overridden on a per-list basis > > Changes: https://git.openjdk.java.net/skara/pull/188/files > Webrev: https://webrevs.openjdk.java.net/skara/188/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-123 > Stats: 33 lines in 3 files changed: 11 ins; 7 del; 15 mod > Patch: https://git.openjdk.java.net/skara/pull/188.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/188/head:pull/188 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/188 From ehelin at openjdk.org Mon Oct 7 14:07:34 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 7 Oct 2019 14:07:34 GMT Subject: [Approved] RFR: Rebase before running the final check when integrating In-Reply-To: <3B-dpdMLfW5R62wcxKy0BF-MsBfxwBknxWnj2N6exiY=.b13b8aac-dfed-4ecc-a42d-5343d40d15f8@github.com> References: <3B-dpdMLfW5R62wcxKy0BF-MsBfxwBknxWnj2N6exiY=.b13b8aac-dfed-4ecc-a42d-5343d40d15f8@github.com> Message-ID: On Mon, 7 Oct 2019 13:17:43 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that performs a rebase before running the final check when integrating, to have the same behavior as the initial checking. > > Best regards, > Robin > > ---------------- > > Commits: > - 26f28320: Rebase before running the final check when integrating > > Changes: https://git.openjdk.java.net/skara/pull/189/files > Webrev: https://webrevs.openjdk.java.net/skara/189/webrev.00 > Stats: 28 lines in 2 files changed: 20 ins; 1 del; 7 mod > Patch: https://git.openjdk.java.net/skara/pull/189.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/189/head:pull/189 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/189 From duke at openjdk.java.net Mon Oct 7 14:30:22 2019 From: duke at openjdk.java.net (duke) Date: Mon, 7 Oct 2019 14:30:22 GMT Subject: [Integrated] RFR: 123: Set the commit author as sender of commit notification emails In-Reply-To: <8Y-4--2pO3gvuE-QB7sEBX04G8IGntTi02y1Zzpy28M=.b48cee18-a941-4925-a7b5-014536765f30@github.com> References: <8Y-4--2pO3gvuE-QB7sEBX04G8IGntTi02y1Zzpy28M=.b48cee18-a941-4925-a7b5-014536765f30@github.com> Message-ID: Changeset: 5743843e Author: Robin Westberg Date: 2019-10-07 14:30:12 +0000 URL: https://git.openjdk.java.net/skara/commit/5743843e 123: Set the commit author as sender of commit notification emails Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From duke at openjdk.java.net Mon Oct 7 14:29:56 2019 From: duke at openjdk.java.net (duke) Date: Mon, 7 Oct 2019 14:29:56 GMT Subject: [Integrated] RFR: 116: Changes link in email notification is wrong for GitLab In-Reply-To: References: Message-ID: Changeset: 945aefac Author: Robin Westberg Date: 2019-10-07 14:29:46 +0000 URL: https://git.openjdk.java.net/skara/commit/945aefac 116: Changes link in email notification is wrong for GitLab Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/PullRequestInstance.java ! host/src/main/java/org/openjdk/skara/host/PullRequest.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java ! host/src/main/java/org/openjdk/skara/host/network/URIBuilder.java ! host/src/test/java/org/openjdk/skara/host/network/URIBuilderTests.java ! test/src/main/java/org/openjdk/skara/test/TestPullRequest.java From duke at openjdk.java.net Mon Oct 7 14:30:44 2019 From: duke at openjdk.java.net (duke) Date: Mon, 7 Oct 2019 14:30:44 GMT Subject: [Integrated] RFR: Rebase before running the final check when integrating In-Reply-To: <3B-dpdMLfW5R62wcxKy0BF-MsBfxwBknxWnj2N6exiY=.b13b8aac-dfed-4ecc-a42d-5343d40d15f8@github.com> References: <3B-dpdMLfW5R62wcxKy0BF-MsBfxwBknxWnj2N6exiY=.b13b8aac-dfed-4ecc-a42d-5343d40d15f8@github.com> Message-ID: <5d45bec8-6e72-4801-b86e-43b809eaed5f@openjdk.java.net> Changeset: 627dc572 Author: Robin Westberg Date: 2019-10-07 14:30:29 +0000 URL: https://git.openjdk.java.net/skara/commit/627dc572 Rebase before running the final check when integrating Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java From philip.race at oracle.com Mon Oct 7 21:34:11 2019 From: philip.race at oracle.com (Phil Race) Date: Mon, 7 Oct 2019 14:34:11 -0700 Subject: Skara Project Page should redirect folks to the wiki. Message-ID: <95450966-72c1-bb31-248b-69024d35496a@oracle.com> http://openjdk.java.net/projects/skara/ is very bate. Clearly everyone should be looking at https://wiki.openjdk.java.net/display/SKARA So could we please have a prominent link on the project page saying that ? Also that might be a good time to fix the dead link to a purported JDK 12 mirror. -phil. From joe.darcy at oracle.com Tue Oct 8 01:36:39 2019 From: joe.darcy at oracle.com (Joe Darcy) Date: Mon, 7 Oct 2019 18:36:39 -0700 Subject: Skara Project Page should redirect folks to the wiki. In-Reply-To: <95450966-72c1-bb31-248b-69024d35496a@oracle.com> References: <95450966-72c1-bb31-248b-69024d35496a@oracle.com> Message-ID: <32ab1cc3-d18a-e973-c34a-04cf8b285802@oracle.com> Hi Phil, Suggested edits, and a few others, made; thanks, -Joe On 10/7/2019 2:34 PM, Phil Race wrote: > http://openjdk.java.net/projects/skara/ is very bate. > > Clearly everyone should be looking at > https://wiki.openjdk.java.net/display/SKARA > > So could we please have a prominent link on the project page saying > that ? > > Also that might be a good time to fix the dead link to a purported JDK > 12 mirror. > > -phil. From rwestberg at openjdk.org Tue Oct 8 06:38:11 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 8 Oct 2019 06:38:11 GMT Subject: RFR: WIP: 108: Command line tools fon't run with Cygwin git References: Message-ID: On Fri, 4 Oct 2019 07:55:12 GMT, Erik Helin wrote: > On Wed, 2 Oct 2019 12:24:00 GMT, Jorn Vernee wrote: > >> On Wed, 2 Oct 2019 09:42:50 GMT, Robin Westberg wrote: >> >>> On Mon, 30 Sep 2019 21:28:59 GMT, Kevin Rushforth wrote: >>> >>>> This is a very preliminary "proof of concept" patch that allows `git jcheck` to work with git from Cygwin. It is incomplete, and is missing the necessary checks to allow it to continue working with native Windows git. >>>> >>>> @edvbld @rwestberg - I submitted it this early to get your high-level feedback on whether this support is something that you have already thought about already; if not, I'd like your feedback on the approach. >>>> >>>> The idea would be to check whether we are are using a Cygwin version of git (this should be trivial), and if so, do the conversion between the `Path` strings and the input/output to the `git` command in all of the necessary places in `GitRepository` (that should be the only class that needs to be modified). >>>> >>>> ---------------- >>>> >>>> Commits: >>>> - 11270d33: WIP: 108: Command line tools fon't run with Cygwin git >>>> >>>> Changes: https://git.openjdk.java.net/skara/pull/170/files >>>> Webrev: https://webrevs.openjdk.java.net/skara/170/webrev.00 >>>> Stats: 30 lines in 2 files changed: 23 ins; 0 del; 7 mod >>>> Patch: https://git.openjdk.java.net/skara/pull/170.diff >>>> Fetch: git fetch https://git.openjdk.java.net/skara pull/170/head:pull/170 >>> >>> Looks like a reasonable approach to me, perhaps our most prominent Windows user @jornvernee has considered something in this area.. I usually avoid installing cygwin git to avoid issues like this. >> >> @rwestberg I'm happily using Windows native git :) > > Hi Kevin, > > thanks for looking into this and sorry for not responding earlier. I would like to understand your use case a bit more - why are you using Cygwin git over [Git for Windows](https://gitforwindows.org/)? I understand that you need to use Cygwin, but why not use the Windows native git binary in Cygwin (instead of Cygwin's version of git)? > > Looking at your changes I can immediately see that adding support for the Cygwin version of git will have far-reaching consequences for almost all our code, so I would really like to understand the advantages of using Cygwin git before pursuing this further. > > Thanks, > Erik Please disregard this comment, investigating a failed email delivery. PR: https://git.openjdk.java.net/skara/pull/170 From github+1745812 at openjdk.org Tue Oct 8 06:38:11 2019 From: github+1745812 at openjdk.org (Robin Westberg) Date: Tue, 8 Oct 2019 06:38:11 GMT Subject: RFR: WIP: 108: Command line tools fon't run with Cygwin git References: Message-ID: On Fri, 4 Oct 2019 07:55:12 GMT, Erik Helin wrote: > On Wed, 2 Oct 2019 12:24:00 GMT, Jorn Vernee wrote: > >> On Wed, 2 Oct 2019 09:42:50 GMT, Robin Westberg wrote: >> >>> On Mon, 30 Sep 2019 21:28:59 GMT, Kevin Rushforth wrote: >>> >>>> This is a very preliminary "proof of concept" patch that allows `git jcheck` to work with git from Cygwin. It is incomplete, and is missing the necessary checks to allow it to continue working with native Windows git. >>>> >>>> @edvbld @rwestberg - I submitted it this early to get your high-level feedback on whether this support is something that you have already thought about already; if not, I'd like your feedback on the approach. >>>> >>>> The idea would be to check whether we are are using a Cygwin version of git (this should be trivial), and if so, do the conversion between the `Path` strings and the input/output to the `git` command in all of the necessary places in `GitRepository` (that should be the only class that needs to be modified). >>>> >>>> ---------------- >>>> >>>> Commits: >>>> - 11270d33: WIP: 108: Command line tools fon't run with Cygwin git >>>> >>>> Changes: https://git.openjdk.java.net/skara/pull/170/files >>>> Webrev: https://webrevs.openjdk.java.net/skara/170/webrev.00 >>>> Stats: 30 lines in 2 files changed: 23 ins; 0 del; 7 mod >>>> Patch: https://git.openjdk.java.net/skara/pull/170.diff >>>> Fetch: git fetch https://git.openjdk.java.net/skara pull/170/head:pull/170 >>> >>> Looks like a reasonable approach to me, perhaps our most prominent Windows user @jornvernee has considered something in this area.. I usually avoid installing cygwin git to avoid issues like this. >> >> @rwestberg I'm happily using Windows native git :) > > Hi Kevin, > > thanks for looking into this and sorry for not responding earlier. I would like to understand your use case a bit more - why are you using Cygwin git over [Git for Windows](https://gitforwindows.org/)? I understand that you need to use Cygwin, but why not use the Windows native git binary in Cygwin (instead of Cygwin's version of git)? > > Looking at your changes I can immediately see that adding support for the Cygwin version of git will have far-reaching consequences for almost all our code, so I would really like to understand the advantages of using Cygwin git before pursuing this further. > > Thanks, > Erik Please disregard this comment, investigating a failed email delivery. PR: https://git.openjdk.java.net/skara/pull/170 From rwestberg at openjdk.org Tue Oct 8 09:54:05 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 8 Oct 2019 09:54:05 GMT Subject: RFR: Use the domain specified in the census when creating from addresses for non-authors Message-ID: Hi all, Please review this small change that adjusts the from address for emails sent on behalf of non-authors to use the census domain, as it can otherwise be rejected by mail servers. Best regards, Robin ---------------- Commits: - b4b52bef: Use the domain specified in the census when creating from addresses for non-authors Changes: https://git.openjdk.java.net/skara/pull/190/files Webrev: https://webrevs.openjdk.java.net/skara/190/webrev.00 Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/190.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/190/head:pull/190 PR: https://git.openjdk.java.net/skara/pull/190 From rwestberg at openjdk.org Tue Oct 8 12:54:42 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 8 Oct 2019 12:54:42 GMT Subject: RFR: 124: The sponsor label should only be set on PRs that are ready for integration Message-ID: Hi all, Please review this change that ensures that the `sponsor` label is removed from a PR if it transitions away from the `ready` state. Also run a final jcheck before pushing to enforce this. Best regards, Robin ---------------- Commits: - 7c6463df: The sponsor label should only be set on PRs that are ready for integration Changes: https://git.openjdk.java.net/skara/pull/191/files Webrev: https://webrevs.openjdk.java.net/skara/191/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-124 Stats: 110 lines in 3 files changed: 104 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/191.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/191/head:pull/191 PR: https://git.openjdk.java.net/skara/pull/191 From rwestberg at openjdk.org Wed Oct 9 06:44:03 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 9 Oct 2019 06:44:03 GMT Subject: RFR: 123: The notifier should allow the author to be set, not the sender Message-ID: Hi all, Please review this follow-up change that makes the author of notification emails configurable, not the sender. This is consistent with the mailing list bridge. Best regards, Robin ---------------- Commits: - 63593952: The notifier should allow the author to be set, not the sender Changes: https://git.openjdk.java.net/skara/pull/192/files Webrev: https://webrevs.openjdk.java.net/skara/192/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-123 Stats: 40 lines in 3 files changed: 18 ins; 0 del; 22 mod Patch: https://git.openjdk.java.net/skara/pull/192.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/192/head:pull/192 PR: https://git.openjdk.java.net/skara/pull/192 From ehelin at openjdk.org Wed Oct 9 08:51:54 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 9 Oct 2019 08:51:54 GMT Subject: [Approved] RFR: Use the domain specified in the census when creating from addresses for non-authors In-Reply-To: References: Message-ID: <-TXj6k10wBzCKd8LCLhW1jY2ZVh33Sa2x-rto1xxc_o=.3619f5f6-a33a-4cb6-a26a-7647065fc5a5@github.com> On Tue, 8 Oct 2019 09:54:05 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that adjusts the from address for emails sent on behalf of non-authors to use the census domain, as it can otherwise be rejected by mail servers. > > Best regards, > Robin > > ---------------- > > Commits: > - b4b52bef: Use the domain specified in the census when creating from addresses for non-authors > > Changes: https://git.openjdk.java.net/skara/pull/190/files > Webrev: https://webrevs.openjdk.java.net/skara/190/webrev.00 > Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod > Patch: https://git.openjdk.java.net/skara/pull/190.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/190/head:pull/190 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/190 From ehelin at openjdk.org Wed Oct 9 08:52:54 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 9 Oct 2019 08:52:54 GMT Subject: [Approved] RFR: 124: The sponsor label should only be set on PRs that are ready for integration In-Reply-To: References: Message-ID: On Tue, 8 Oct 2019 12:54:42 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that the `sponsor` label is removed from a PR if it transitions away from the `ready` state. Also run a final jcheck before pushing to enforce this. > > Best regards, > Robin > > ---------------- > > Commits: > - 7c6463df: The sponsor label should only be set on PRs that are ready for integration > > Changes: https://git.openjdk.java.net/skara/pull/191/files > Webrev: https://webrevs.openjdk.java.net/skara/191/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-124 > Stats: 110 lines in 3 files changed: 104 ins; 0 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/191.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/191/head:pull/191 Very nice, thanks Robin! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/191 From ehelin at openjdk.org Wed Oct 9 08:59:55 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 9 Oct 2019 08:59:55 GMT Subject: [Approved] RFR: 123: The notifier should allow the author to be set, not the sender In-Reply-To: References: Message-ID: On Wed, 9 Oct 2019 06:44:03 GMT, Robin Westberg wrote: > Hi all, > > Please review this follow-up change that makes the author of notification emails configurable, not the sender. This is consistent with the mailing list bridge. > > Best regards, > Robin > > ---------------- > > Commits: > - 63593952: The notifier should allow the author to be set, not the sender > > Changes: https://git.openjdk.java.net/skara/pull/192/files > Webrev: https://webrevs.openjdk.java.net/skara/192/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-123 > Stats: 40 lines in 3 files changed: 18 ins; 0 del; 22 mod > Patch: https://git.openjdk.java.net/skara/pull/192.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/192/head:pull/192 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/192 From duke at openjdk.java.net Wed Oct 9 09:04:57 2019 From: duke at openjdk.java.net (duke) Date: Wed, 9 Oct 2019 09:04:57 GMT Subject: [Integrated] RFR: Use the domain specified in the census when creating from addresses for non-authors In-Reply-To: References: Message-ID: Changeset: 07bec84b Author: Robin Westberg Date: 2019-10-09 09:04:37 +0000 URL: https://git.openjdk.java.net/skara/commit/07bec84b Use the domain specified in the census when creating from addresses for non-authors Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From duke at openjdk.java.net Wed Oct 9 09:05:45 2019 From: duke at openjdk.java.net (duke) Date: Wed, 9 Oct 2019 09:05:45 GMT Subject: [Integrated] RFR: 123: The notifier should allow the author to be set, not the sender In-Reply-To: References: Message-ID: <91d34114-6d8f-421e-956a-a40f87712c77@openjdk.java.net> Changeset: 8b8af811 Author: Robin Westberg Date: 2019-10-09 09:05:29 +0000 URL: https://git.openjdk.java.net/skara/commit/8b8af811 123: The notifier should allow the author to be set, not the sender Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From duke at openjdk.java.net Wed Oct 9 09:05:16 2019 From: duke at openjdk.java.net (duke) Date: Wed, 9 Oct 2019 09:05:16 GMT Subject: [Integrated] RFR: 124: The sponsor label should only be set on PRs that are ready for integration In-Reply-To: References: Message-ID: <9826b281-5011-49cf-b87c-edede4046817@openjdk.java.net> Changeset: 6f3b2213 Author: Robin Westberg Date: 2019-10-09 09:05:04 +0000 URL: https://git.openjdk.java.net/skara/commit/6f3b2213 124: The sponsor label should only be set on PRs that are ready for integration Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SponsorTests.java From rwestberg at openjdk.org Wed Oct 9 09:59:02 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 9 Oct 2019 09:59:02 GMT Subject: RFR: Use proper markdown formatting in help message Message-ID: Hi all, Please review this trivial fix in the help message given when a pull request does not contain a required reference to an issue. Best regards, Robin ---------------- Commits: - 6b5a06f4: Use proper markdown formatting Changes: https://git.openjdk.java.net/skara/pull/193/files Webrev: https://webrevs.openjdk.java.net/skara/193/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/193.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/193/head:pull/193 PR: https://git.openjdk.java.net/skara/pull/193 From erik.helin at oracle.com Wed Oct 9 09:59:45 2019 From: erik.helin at oracle.com (Erik Helin) Date: Wed, 9 Oct 2019 11:59:45 +0200 Subject: user@openjdk.org ? In-Reply-To: <5D96A3F8.9080300@oracle.com> References: <13e65c6b-ba2b-40b6-9b7c-61b613e7ed8e@openjdk.java.net> <5D96A3F8.9080300@oracle.com> Message-ID: On 10/4/19 3:44 AM, Philip Race wrote: > What are these openjdk.org email addresses in the commits ? As described in JEP 357 [0] we use @openjdk.org as the author/committer email in git commits to signify that the author/committer is an OpenJDK Author [1], Committer [2] or Reviewer [3]. On 10/4/19 3:44 AM, Philip Race wrote: > I sent an email to Kevin's below and got a bounce. > So I sent one to my? open jdk id prr at openjdk.org and also get a bounce > Just to try it, I also sent one to my "github" equivalent > user at openjdk.org and again get a bounce. > Someone hoping to contact the committer is going to be very confused and > stuck. > Duke probably won't be able to help them either. > > Do I have to configure something to make it real ? No, you do not have to configure anything. We are aware of this issue and we are working on it. Unfortunately there are not only technical challenges to solve here, so things are progressing a little bit slower than I hoped for, but we are making progress. Thank you for your patience with this matter, Erik [0]: https://openjdk.java.net/jeps/357 [1]: http://openjdk.java.net/bylaws#author [2]: http://openjdk.java.net/bylaws#committer [3]: http://openjdk.java.net/bylaws#reviewer > -phil > > > > -------- Original Message -------- > Subject:???? git: jpg-dev/jfx: 8231735: gradle checkrepo is obsolete and > doesn't work with git > Date:???? Thu, 3 Oct 2019 16:49:57 GMT > From:???? duke > To:???? > > > > Changeset: 3db691dc > Author:??? Kevin Rushforth > Date:????? 2019-10-03 16:49:31 +0000 > URL:?????? https://orahub.oraclecorp.com/jpg-dev/jfx/commit/3db691dc > > 8231735: gradle checkrepo is obsolete and doesn't work with git > > Reviewed-by: aghaisas > > ! common-dev-build.sh > ! rt-closed/closed-build.gradle > > > From rwestberg at openjdk.org Wed Oct 9 10:24:57 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 9 Oct 2019 10:24:57 GMT Subject: RFR: 125: Add support for timeouts to the SMTP client Message-ID: Hi all, Please review this change that introduces a timeout to the SMTP client code. Best regards, Robin ---------------- Commits: - e6a84303: Add support for timeouts to the SMTP client, default to 30 minutes Changes: https://git.openjdk.java.net/skara/pull/194/files Webrev: https://webrevs.openjdk.java.net/skara/194/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-125 Stats: 31 lines in 4 files changed: 22 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/194.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/194/head:pull/194 PR: https://git.openjdk.java.net/skara/pull/194 From ehelin at openjdk.org Wed Oct 9 10:39:18 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 9 Oct 2019 10:39:18 GMT Subject: [Approved] RFR: Use proper markdown formatting in help message In-Reply-To: References: Message-ID: On Wed, 9 Oct 2019 09:59:02 GMT, Robin Westberg wrote: > Hi all, > > Please review this trivial fix in the help message given when a pull request does not contain a required reference to an issue. > > Best regards, > Robin > > ---------------- > > Commits: > - 6b5a06f4: Use proper markdown formatting > > Changes: https://git.openjdk.java.net/skara/pull/193/files > Webrev: https://webrevs.openjdk.java.net/skara/193/webrev.00 > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/193.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/193/head:pull/193 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/193 From ehelin at openjdk.org Wed Oct 9 10:39:48 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 9 Oct 2019 10:39:48 GMT Subject: [Approved] RFR: 125: Add support for timeouts to the SMTP client In-Reply-To: References: Message-ID: On Wed, 9 Oct 2019 10:24:57 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that introduces a timeout to the SMTP client code. > > Best regards, > Robin > > ---------------- > > Commits: > - e6a84303: Add support for timeouts to the SMTP client, default to 30 minutes > > Changes: https://git.openjdk.java.net/skara/pull/194/files > Webrev: https://webrevs.openjdk.java.net/skara/194/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-125 > Stats: 31 lines in 4 files changed: 22 ins; 0 del; 9 mod > Patch: https://git.openjdk.java.net/skara/pull/194.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/194/head:pull/194 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/194 From rwestberg at openjdk.org Wed Oct 9 10:41:30 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 9 Oct 2019 10:41:30 GMT Subject: [Integrated] RFR: Use proper markdown formatting in help message In-Reply-To: References: Message-ID: <375cfacf-1583-4c89-be64-9023347a8ee5@openjdk.org> Changeset: 9f350037 Author: Robin Westberg Date: 2019-10-09 10:41:11 +0000 URL: https://git.openjdk.java.net/skara/commit/9f350037 Use proper markdown formatting in help message Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java From rwestberg at openjdk.org Wed Oct 9 10:42:09 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 9 Oct 2019 10:42:09 GMT Subject: [Integrated] RFR: 125: Add support for timeouts to the SMTP client In-Reply-To: References: Message-ID: <1dde23ea-965e-4af5-b71e-a47992130e82@openjdk.org> Changeset: 1ce5bd6a Author: Robin Westberg Date: 2019-10-09 10:41:58 +0000 URL: https://git.openjdk.java.net/skara/commit/1ce5bd6a 125: Add support for timeouts to the SMTP client Reviewed-by: ehelin ! email/src/main/java/org/openjdk/skara/email/SMTP.java ! email/src/main/java/org/openjdk/skara/email/SMTPSession.java ! email/src/test/java/org/openjdk/skara/email/SMTPTests.java ! test/src/main/java/org/openjdk/skara/test/SMTPServer.java From rwestberg at openjdk.org Thu Oct 10 09:12:20 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 10 Oct 2019 09:12:20 GMT Subject: RFR: 121: Send notification emails when new tags are created Message-ID: Hi all, Please review this change that implements sending of notification emails when new tags are created. Best regards, Robin ---------------- Commits: - 02eebb1e: Add support for sending email notifications when new tags are created Changes: https://git.openjdk.java.net/skara/pull/195/files Webrev: https://webrevs.openjdk.java.net/skara/195/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-121 Stats: 143 lines in 3 files changed: 134 ins; 7 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/195.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/195/head:pull/195 PR: https://git.openjdk.java.net/skara/pull/195 From ehelin at openjdk.org Thu Oct 10 12:11:48 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 10 Oct 2019 12:11:48 GMT Subject: [Approved] RFR: 121: Send notification emails when new tags are created In-Reply-To: References: Message-ID: On Thu, 10 Oct 2019 09:12:20 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that implements sending of notification emails when new tags are created. > > Best regards, > Robin > > ---------------- > > Commits: > - 02eebb1e: Add support for sending email notifications when new tags are created > > Changes: https://git.openjdk.java.net/skara/pull/195/files > Webrev: https://webrevs.openjdk.java.net/skara/195/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-121 > Stats: 143 lines in 3 files changed: 134 ins; 7 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/195.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/195/head:pull/195 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/195 From ehelin at openjdk.org Thu Oct 10 12:24:51 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 10 Oct 2019 12:24:51 GMT Subject: RFR: Fix gradlew on Cygwin Message-ID: Hi all, this small patch fixes the Skara build on Cygwin _if_ `gradlew` is used instead of `gradlew.bat`. There is no reason for `Unzip.java` in the Cygwin case since the Windows JDK is itself a ZIP archive, so we need a native `unzip` to pack up the Windows JDK. Therefore we might as well use the native `unzip` when unpacking Gradle as well. ## Testing - `sh gradlew` works in Cygwin on Windows Thanks, Erik ---------------- Commits: - 64cf0399: Fix gradlew on Cygwin Changes: https://git.openjdk.java.net/skara/pull/196/files Webrev: https://webrevs.openjdk.java.net/skara/196/webrev.00 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/196.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/196/head:pull/196 PR: https://git.openjdk.java.net/skara/pull/196 From rwestberg at openjdk.org Thu Oct 10 12:36:09 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 10 Oct 2019 12:36:09 GMT Subject: [Approved] RFR: Fix gradlew on Cygwin In-Reply-To: References: Message-ID: On Thu, 10 Oct 2019 12:24:51 GMT, Erik Helin wrote: > Hi all, > > this small patch fixes the Skara build on Cygwin _if_ `gradlew` is used instead of `gradlew.bat`. There is no reason for `Unzip.java` in the Cygwin case since the Windows JDK is itself a ZIP archive, so we need a native `unzip` to pack up the Windows JDK. Therefore we might as well use the native `unzip` when unpacking Gradle as well. > > ## Testing > - `sh gradlew` works in Cygwin on Windows > > Thanks, > Erik > > ---------------- > > Commits: > - 64cf0399: Fix gradlew on Cygwin > > Changes: https://git.openjdk.java.net/skara/pull/196/files > Webrev: https://webrevs.openjdk.java.net/skara/196/webrev.00 > Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/196.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/196/head:pull/196 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/196 From rwestberg at openjdk.org Thu Oct 10 13:07:59 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 10 Oct 2019 13:07:59 GMT Subject: [Integrated] RFR: 121: Send notification emails when new tags are created In-Reply-To: References: Message-ID: <44574897-c6c6-4b9d-b37c-b9e2bbfdbfd9@openjdk.org> Changeset: 07bb71a1 Author: Robin Westberg Date: 2019-10-10 13:07:51 +0000 URL: https://git.openjdk.java.net/skara/commit/07bb71a1 121: Send notification emails when new tags are created Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From ehelin at openjdk.org Thu Oct 10 13:11:09 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 10 Oct 2019 13:11:09 GMT Subject: [Integrated] RFR: Fix gradlew on Cygwin In-Reply-To: References: Message-ID: Changeset: 00791341 Author: Erik Helin Date: 2019-10-10 13:10:57 +0000 URL: https://git.openjdk.java.net/skara/commit/00791341 Fix gradlew on Cygwin Reviewed-by: rwestberg ! gradlew From rwestberg at openjdk.org Thu Oct 10 13:37:34 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 10 Oct 2019 13:37:34 GMT Subject: RFR: Do not send tag-related updates when in PR_ONLY mode Message-ID: Hi all, Please review this minor change that avoids sending tag-related notification emails for notifiers configured to PR_ONLY. Best regards, Robin ---------------- Commits: - d98cd4b9: Do not send tag-related updates when in PR_ONLY mode Changes: https://git.openjdk.java.net/skara/pull/197/files Webrev: https://webrevs.openjdk.java.net/skara/197/webrev.00 Stats: 7 lines in 2 files changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/197.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/197/head:pull/197 PR: https://git.openjdk.java.net/skara/pull/197 From ehelin at openjdk.org Thu Oct 10 15:21:50 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 10 Oct 2019 15:21:50 GMT Subject: [Approved] RFR: Do not send tag-related updates when in PR_ONLY mode In-Reply-To: References: Message-ID: On Thu, 10 Oct 2019 13:37:34 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that avoids sending tag-related notification emails for notifiers configured to PR_ONLY. > > Best regards, > Robin > > ---------------- > > Commits: > - d98cd4b9: Do not send tag-related updates when in PR_ONLY mode > > Changes: https://git.openjdk.java.net/skara/pull/197/files > Webrev: https://webrevs.openjdk.java.net/skara/197/webrev.00 > Stats: 7 lines in 2 files changed: 6 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/197.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/197/head:pull/197 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/197 From ehelin at openjdk.org Thu Oct 10 15:22:33 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 10 Oct 2019 15:22:33 GMT Subject: RFR: Add command git-publish Message-ID: Hi all, this patch adds the command `git-publish` which is handy shortcut for pushing the current branch to the a remote (by default `origin`). I essentially grew tired of typing `git push -u origin ` and don't want to set `git config --global push.default current` since then I don't get an upstream set. ## Testing - Manual testing (pushed the branch for this PR with the tool) Thanks, Erik ---------------- Commits: - 75a56601: Add git-publish to image - 21ae5f31: Add git-publish command Changes: https://git.openjdk.java.net/skara/pull/198/files Webrev: https://webrevs.openjdk.java.net/skara/198/webrev.00 Stats: 85 lines in 2 files changed: 84 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/198.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/198/head:pull/198 PR: https://git.openjdk.java.net/skara/pull/198 From rwestberg at openjdk.org Fri Oct 11 07:12:20 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 11 Oct 2019 07:12:20 GMT Subject: [Approved] RFR: Add command git-publish In-Reply-To: References: Message-ID: On Thu, 10 Oct 2019 15:22:33 GMT, Erik Helin wrote: > Hi all, > > this patch adds the command `git-publish` which is handy shortcut for pushing the current branch to the a remote (by default `origin`). I essentially grew tired of typing `git push -u origin ` and don't want to set `git config --global push.default current` since then I don't get an upstream set. > > ## Testing > - Manual testing (pushed the branch for this PR with the tool) > > Thanks, > Erik > > ---------------- > > Commits: > - 75a56601: Add git-publish to image > - 21ae5f31: Add git-publish command > > Changes: https://git.openjdk.java.net/skara/pull/198/files > Webrev: https://webrevs.openjdk.java.net/skara/198/webrev.00 > Stats: 85 lines in 2 files changed: 84 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/198.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/198/head:pull/198 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/198 From ehelin at openjdk.org Fri Oct 11 07:13:19 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 11 Oct 2019 07:13:19 GMT Subject: [Integrated] RFR: Add command git-publish In-Reply-To: References: Message-ID: Changeset: c1e7a381 Author: Erik Helin Date: 2019-10-11 07:13:03 +0000 URL: https://git.openjdk.java.net/skara/commit/c1e7a381 Add command git-publish Reviewed-by: rwestberg ! cli/build.gradle + cli/src/main/java/org/openjdk/skara/cli/GitPublish.java From ehelin at openjdk.org Fri Oct 11 08:54:45 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 11 Oct 2019 08:54:45 GMT Subject: RFR: Use inheritIO for git command to get output Message-ID: Hi all, this small patch uses a `ProcessBuilder` for `git push --set-upstream` instead of the `Repository.push` function. This is done in order to have to the `git` process inherit the file descriptors from the `java` process, so that the output from `git` will be shown in the terminal. Thanks, Erik ---------------- Commits: - 1d164cfd: Use inheritIO for git command to get output Changes: https://git.openjdk.java.net/skara/pull/199/files Webrev: https://webrevs.openjdk.java.net/skara/199/webrev.00 Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/199.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/199/head:pull/199 PR: https://git.openjdk.java.net/skara/pull/199 From rwestberg at openjdk.org Fri Oct 11 08:55:58 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 11 Oct 2019 08:55:58 GMT Subject: [Approved] RFR: Use inheritIO for git command to get output In-Reply-To: References: Message-ID: <3xa0D6rS920xtVosTkrMI4GtO-ZJdydNzTH-2j-8aXo=.c8bf6116-3f4e-4d1c-999b-0abdc888850b@github.com> On Fri, 11 Oct 2019 08:54:45 GMT, Erik Helin wrote: > Hi all, > > this small patch uses a `ProcessBuilder` for `git push --set-upstream` instead of the `Repository.push` function. This is done in order to have to the `git` process inherit the file descriptors from the `java` process, so that the output from `git` will be shown in the terminal. > > Thanks, > Erik > > ---------------- > > Commits: > - 1d164cfd: Use inheritIO for git command to get output > > Changes: https://git.openjdk.java.net/skara/pull/199/files > Webrev: https://webrevs.openjdk.java.net/skara/199/webrev.00 > Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/199.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/199/head:pull/199 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/199 From ehelin at openjdk.org Fri Oct 11 09:42:11 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 11 Oct 2019 09:42:11 GMT Subject: [Integrated] RFR: Use inheritIO for git command to get output In-Reply-To: References: Message-ID: <4a14e278-3a1f-4471-af4f-b09eb0c2ccd9@openjdk.org> Changeset: 7aa14a54 Author: Erik Helin Date: 2019-10-11 09:42:02 +0000 URL: https://git.openjdk.java.net/skara/commit/7aa14a54 Use inheritIO for git command to get output Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPublish.java From rwestberg at openjdk.org Fri Oct 11 12:09:24 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 11 Oct 2019 12:09:24 GMT Subject: RFR: 122: Send notification emails when new branches are created Message-ID: <_qOc7-XkmGOzhmSbEipbOM1G_LTmsWwmM9nw8DGhx1M=.599661c7-2853-4a9e-8f18-347598c68bce@github.com> Hi all, Please review this change that implements support for sending notification emails when new branches are created. Best regards, Robin ---------------- Commits: - 8a92fd50: Send notification emails when new branches are created Changes: https://git.openjdk.java.net/skara/pull/200/files Webrev: https://webrevs.openjdk.java.net/skara/200/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-122 Stats: 171 lines in 5 files changed: 153 ins; 3 del; 15 mod Patch: https://git.openjdk.java.net/skara/pull/200.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/200/head:pull/200 PR: https://git.openjdk.java.net/skara/pull/200 From rwestberg at openjdk.org Mon Oct 14 06:08:39 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 14 Oct 2019 06:08:39 GMT Subject: [Integrated] RFR: Do not send tag-related updates when in PR_ONLY mode In-Reply-To: References: Message-ID: <4ef22f9f-3438-4eb3-b8a8-3fccc75519f0@openjdk.org> Changeset: 41b7e73b Author: Robin Westberg Date: 2019-10-14 06:08:29 +0000 URL: https://git.openjdk.java.net/skara/commit/41b7e73b Do not send tag-related updates when in PR_ONLY mode Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From rwestberg at openjdk.org Mon Oct 14 07:29:12 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 14 Oct 2019 07:29:12 GMT Subject: RFR: 130: Integrating outdated PRs shows an empty error message Message-ID: Hi all, Please review this change that ensures that an attempt to integrate an outdated PR shows a proper error message instead of just an empty comment. Best regards, Robin ---------------- Commits: - 2f8ae849: Propagate the error message when rebasing fails Changes: https://git.openjdk.java.net/skara/pull/201/files Webrev: https://webrevs.openjdk.java.net/skara/201/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-130 Stats: 116 lines in 5 files changed: 114 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/201.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/201/head:pull/201 PR: https://git.openjdk.java.net/skara/pull/201 From ehelin at openjdk.org Mon Oct 14 09:28:19 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 14 Oct 2019 09:28:19 GMT Subject: [Approved] RFR: 122: Send notification emails when new branches are created In-Reply-To: <_qOc7-XkmGOzhmSbEipbOM1G_LTmsWwmM9nw8DGhx1M=.599661c7-2853-4a9e-8f18-347598c68bce@github.com> References: <_qOc7-XkmGOzhmSbEipbOM1G_LTmsWwmM9nw8DGhx1M=.599661c7-2853-4a9e-8f18-347598c68bce@github.com> Message-ID: On Fri, 11 Oct 2019 12:09:24 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that implements support for sending notification emails when new branches are created. > > Best regards, > Robin > > ---------------- > > Commits: > - 8a92fd50: Send notification emails when new branches are created > > Changes: https://git.openjdk.java.net/skara/pull/200/files > Webrev: https://webrevs.openjdk.java.net/skara/200/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-122 > Stats: 171 lines in 5 files changed: 153 ins; 3 del; 15 mod > Patch: https://git.openjdk.java.net/skara/pull/200.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/200/head:pull/200 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/200 From ehelin at openjdk.org Mon Oct 14 09:28:49 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 14 Oct 2019 09:28:49 GMT Subject: [Approved] RFR: 130: Integrating outdated PRs shows an empty error message In-Reply-To: References: Message-ID: On Mon, 14 Oct 2019 07:29:12 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that an attempt to integrate an outdated PR shows a proper error message instead of just an empty comment. > > Best regards, > Robin > > ---------------- > > Commits: > - 2f8ae849: Propagate the error message when rebasing fails > > Changes: https://git.openjdk.java.net/skara/pull/201/files > Webrev: https://webrevs.openjdk.java.net/skara/201/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-130 > Stats: 116 lines in 5 files changed: 114 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/201.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/201/head:pull/201 Nice fix, looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/201 From jvernee at openjdk.org Mon Oct 14 09:29:49 2019 From: jvernee at openjdk.org (Jorn Vernee) Date: Mon, 14 Oct 2019 09:29:49 GMT Subject: RFR: Correctly compare the os property when generating launch scripts Message-ID: Previous code was comparing `Propterty` to a `String` -> get the `String` from it first ---------------- Commits: - 15cfc426: correctly compare the os property when generating launch scripts Changes: https://git.openjdk.java.net/skara/pull/202/files Webrev: https://webrevs.openjdk.java.net/skara/202/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/202.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/202/head:pull/202 PR: https://git.openjdk.java.net/skara/pull/202 From ehelin at openjdk.org Mon Oct 14 09:35:48 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 14 Oct 2019 09:35:48 GMT Subject: [Approved] RFR: Correctly compare the os property when generating launch scripts In-Reply-To: References: Message-ID: On Mon, 14 Oct 2019 09:29:49 GMT, Jorn Vernee wrote: > Previous code was comparing `Propterty` to a `String` -> get the `String` from it first > > ---------------- > > Commits: > - 15cfc426: correctly compare the os property when generating launch scripts > > Changes: https://git.openjdk.java.net/skara/pull/202/files > Webrev: https://webrevs.openjdk.java.net/skara/202/webrev.00 > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/202.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/202/head:pull/202 Looks good, thanks for fixing! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/202 From jvernee at openjdk.org Mon Oct 14 09:38:05 2019 From: jvernee at openjdk.org (Jorn Vernee) Date: Mon, 14 Oct 2019 09:38:05 GMT Subject: [Integrated] RFR: Correctly compare the os property when generating launch scripts In-Reply-To: References: Message-ID: <31ec8408-59e2-47fb-9f7d-41899a498038@openjdk.org> Changeset: b23d7566 Author: Jorn Vernee Date: 2019-10-14 09:37:41 +0000 URL: https://git.openjdk.java.net/skara/commit/b23d7566 Correctly compare the os property when generating launch scripts Reviewed-by: ehelin ! buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/LaunchersTask.java From rwestberg at openjdk.org Mon Oct 14 11:44:05 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 14 Oct 2019 11:44:05 GMT Subject: RFR: 129: Do not send RFR mails for PRs in Draft stage Message-ID: Hi all, Please review this change that adds support for creating pull requests in draft stage for GitHub and GitLab, as well as querying if this property is set. Finally, this is used to determine if a pull request is ready for review or not. Best regards, Robin ---------------- Commits: - f49ebd73: Add support for draft pull requests on GitHub and GitLab Changes: https://git.openjdk.java.net/skara/pull/203/files Webrev: https://webrevs.openjdk.java.net/skara/203/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-129 Stats: 106 lines in 13 files changed: 89 ins; 3 del; 14 mod Patch: https://git.openjdk.java.net/skara/pull/203.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/203/head:pull/203 PR: https://git.openjdk.java.net/skara/pull/203 From ehelin at openjdk.org Mon Oct 14 13:19:40 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 14 Oct 2019 13:19:40 GMT Subject: [Approved] RFR: 129: Do not send RFR mails for PRs in Draft stage In-Reply-To: References: Message-ID: On Mon, 14 Oct 2019 11:44:05 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adds support for creating pull requests in draft stage for GitHub and GitLab, as well as querying if this property is set. Finally, this is used to determine if a pull request is ready for review or not. > > Best regards, > Robin > > ---------------- > > Commits: > - f49ebd73: Add support for draft pull requests on GitHub and GitLab > > Changes: https://git.openjdk.java.net/skara/pull/203/files > Webrev: https://webrevs.openjdk.java.net/skara/203/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-129 > Stats: 106 lines in 13 files changed: 89 ins; 3 del; 14 mod > Patch: https://git.openjdk.java.net/skara/pull/203.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/203/head:pull/203 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/203 From rwestberg at openjdk.org Mon Oct 14 14:38:02 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 14 Oct 2019 14:38:02 GMT Subject: RFR: 127: Avoid sending consecutive emails too fast Message-ID: Hi all, Please review the following change that makes it possible to configure an interval between emails send to a mailing list. Best regards, Robin ---------------- Commits: - 34e7229f: Add a sendInterval parameter to the mailmanserver Changes: https://git.openjdk.java.net/skara/pull/204/files Webrev: https://webrevs.openjdk.java.net/skara/204/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-127 Stats: 99 lines in 10 files changed: 58 ins; 0 del; 41 mod Patch: https://git.openjdk.java.net/skara/pull/204.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/204/head:pull/204 PR: https://git.openjdk.java.net/skara/pull/204 From rwestberg at openjdk.org Tue Oct 15 06:54:28 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 15 Oct 2019 06:54:28 GMT Subject: RFR: 126: Sanity check tag and commit counts when sending notification emails Message-ID: Hi all, Please review this change that avoids sending excessive amount of notifications in case something unexpected occurs. Best regards, Robin ---------------- Commits: - ed0186f7: Warn instead of sending excessive amounts of notifications Changes: https://git.openjdk.java.net/skara/pull/205/files Webrev: https://webrevs.openjdk.java.net/skara/205/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-126 Stats: 23 lines in 1 file changed: 22 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/205.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/205/head:pull/205 PR: https://git.openjdk.java.net/skara/pull/205 From rwestberg at openjdk.org Tue Oct 15 08:24:01 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 15 Oct 2019 08:24:01 GMT Subject: [Integrated] RFR: 130: Integrating outdated PRs shows an empty error message In-Reply-To: References: Message-ID: <07dfb879-a3dd-4b75-82e3-d6aa7e87f3ce@openjdk.org> Changeset: 751ec38a Author: Robin Westberg Date: 2019-10-15 08:23:49 +0000 URL: https://git.openjdk.java.net/skara/commit/751ec38a 130: Integrating outdated PRs shows an empty error message Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SponsorTests.java From rwestberg at openjdk.org Tue Oct 15 08:24:30 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 15 Oct 2019 08:24:30 GMT Subject: [Integrated] RFR: 129: Do not send RFR mails for PRs in Draft stage In-Reply-To: References: Message-ID: <510a9d1f-ed5a-4ebf-b7e8-7e5ab1a7bf4d@openjdk.org> Changeset: c1ca11a6 Author: Robin Westberg Date: 2019-10-15 08:24:14 +0000 URL: https://git.openjdk.java.net/skara/commit/c1ca11a6 129: Do not send RFR mails for PRs in Draft stage Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java ! host/src/main/java/org/openjdk/skara/host/HostedRepository.java ! host/src/main/java/org/openjdk/skara/host/PullRequest.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubRepository.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabRepository.java ! test/src/main/java/org/openjdk/skara/test/HostCredentials.java ! test/src/main/java/org/openjdk/skara/test/PullRequestData.java ! test/src/main/java/org/openjdk/skara/test/TestHost.java ! test/src/main/java/org/openjdk/skara/test/TestHostedRepository.java ! test/src/main/java/org/openjdk/skara/test/TestPullRequest.java From ehelin at openjdk.org Tue Oct 15 08:24:29 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 15 Oct 2019 08:24:29 GMT Subject: [Approved] RFR: 127: Avoid sending consecutive emails too fast In-Reply-To: References: Message-ID: On Mon, 14 Oct 2019 14:38:02 GMT, Robin Westberg wrote: > Hi all, > > Please review the following change that makes it possible to configure an interval between emails send to a mailing list. > > Best regards, > Robin > > ---------------- > > Commits: > - 34e7229f: Add a sendInterval parameter to the mailmanserver > > Changes: https://git.openjdk.java.net/skara/pull/204/files > Webrev: https://webrevs.openjdk.java.net/skara/204/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-127 > Stats: 99 lines in 10 files changed: 58 ins; 0 del; 41 mod > Patch: https://git.openjdk.java.net/skara/pull/204.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/204/head:pull/204 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/204 From rwestberg at openjdk.org Tue Oct 15 08:25:20 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 15 Oct 2019 08:25:20 GMT Subject: [Integrated] RFR: 127: Avoid sending consecutive emails too fast In-Reply-To: References: Message-ID: <94f5e1c6-3539-4dcd-9fdb-cc81f7355085@openjdk.org> Changeset: f094cb84 Author: Robin Westberg Date: 2019-10-15 08:25:10 +0000 URL: https://git.openjdk.java.net/skara/commit/f094cb84 127: Avoid sending consecutive emails too fast Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBotTests.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java ! mailinglist/src/main/java/org/openjdk/skara/mailinglist/MailingListServerFactory.java ! mailinglist/src/main/java/org/openjdk/skara/mailinglist/mailman/MailmanServer.java ! mailinglist/src/test/java/org/openjdk/skara/mailinglist/MailmanTests.java From ehelin at openjdk.org Tue Oct 15 08:26:00 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 15 Oct 2019 08:26:00 GMT Subject: [Approved] RFR: 126: Sanity check tag and commit counts when sending notification emails In-Reply-To: References: Message-ID: On Tue, 15 Oct 2019 06:54:28 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that avoids sending excessive amount of notifications in case something unexpected occurs. > > Best regards, > Robin > > ---------------- > > Commits: > - ed0186f7: Warn instead of sending excessive amounts of notifications > > Changes: https://git.openjdk.java.net/skara/pull/205/files > Webrev: https://webrevs.openjdk.java.net/skara/205/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-126 > Stats: 23 lines in 1 file changed: 22 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/205.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/205/head:pull/205 Looks ok ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/205 From rwestberg at openjdk.org Tue Oct 15 08:26:59 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 15 Oct 2019 08:26:59 GMT Subject: [Integrated] RFR: 126: Sanity check tag and commit counts when sending notification emails In-Reply-To: References: Message-ID: <2aef70e1-2775-4fce-a6a0-45a64874f684@openjdk.org> Changeset: c4e66bcc Author: Robin Westberg Date: 2019-10-15 08:26:41 +0000 URL: https://git.openjdk.java.net/skara/commit/c4e66bcc 126: Sanity check tag and commit counts when sending notification emails Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java From rwestberg at openjdk.org Tue Oct 15 08:48:03 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 15 Oct 2019 08:48:03 GMT Subject: RFR: Fix compile error and potential log problem Message-ID: Hi all, Please review this minor fix that corrects a compile error and a potential log problem. Best regards, Robin ---------------- Commits: - 3a3fadde: Fix compile error and potential log problem Changes: https://git.openjdk.java.net/skara/pull/206/files Webrev: https://webrevs.openjdk.java.net/skara/206/webrev.00 Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/206.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/206/head:pull/206 PR: https://git.openjdk.java.net/skara/pull/206 From ehelin at openjdk.org Tue Oct 15 08:58:38 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 15 Oct 2019 08:58:38 GMT Subject: [Approved] RFR: Fix compile error and potential log problem In-Reply-To: References: Message-ID: On Tue, 15 Oct 2019 08:48:03 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor fix that corrects a compile error and a potential log problem. > > Best regards, > Robin > > ---------------- > > Commits: > - 3a3fadde: Fix compile error and potential log problem > > Changes: https://git.openjdk.java.net/skara/pull/206/files > Webrev: https://webrevs.openjdk.java.net/skara/206/webrev.00 > Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/206.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/206/head:pull/206 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/206 From rwestberg at openjdk.org Tue Oct 15 09:12:39 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 15 Oct 2019 09:12:39 GMT Subject: [Integrated] RFR: Fix compile error and potential log problem In-Reply-To: References: Message-ID: <6a2864eb-4c11-473e-b2e8-58c9c8ebbe04@openjdk.org> Changeset: 372303df Author: Robin Westberg Date: 2019-10-15 09:12:21 +0000 URL: https://git.openjdk.java.net/skara/commit/372303df Fix compile error and potential log problem Reviewed-by: ehelin ! bots/cli/src/main/java/org/openjdk/skara/bots/cli/BotLauncher.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From rwestberg at openjdk.org Tue Oct 15 13:02:22 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 15 Oct 2019 13:02:22 GMT Subject: RFR: Refactor host interfaces Message-ID: Hi all, Please review this refactoring of the host module interfaces. Best regards, Robin ---------------- Commits: - 24d3ceb7: Split host interface - ef47f7f6: Extract RestRequest and URIBuilder to a network module - 05543918: Rename host interfaces' methods Changes: https://git.openjdk.java.net/skara/pull/207/files Webrev: https://webrevs.openjdk.java.net/skara/207/webrev.00 Stats: 2415 lines in 138 files changed: 529 ins; 361 del; 1525 mod Patch: https://git.openjdk.java.net/skara/pull/207.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/207/head:pull/207 PR: https://git.openjdk.java.net/skara/pull/207 From ehelin at openjdk.org Tue Oct 15 13:05:40 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 15 Oct 2019 13:05:40 GMT Subject: [Approved] RFR: Refactor host interfaces In-Reply-To: References: Message-ID: <0sI9jmg8YpAAr80sL5Rr_-soFUgMVyucZTRHf8Tqbm0=.3f4bd7bc-d374-4b34-ada4-f011835b048f@github.com> On Tue, 15 Oct 2019 13:02:22 GMT, Robin Westberg wrote: > Hi all, > > Please review this refactoring of the host module interfaces. > > Best regards, > Robin > > ---------------- > > Commits: > - 24d3ceb7: Split host interface > - ef47f7f6: Extract RestRequest and URIBuilder to a network module > - 05543918: Rename host interfaces' methods > > Changes: https://git.openjdk.java.net/skara/pull/207/files > Webrev: https://webrevs.openjdk.java.net/skara/207/webrev.00 > Stats: 2415 lines in 138 files changed: 529 ins; 361 del; 1525 mod > Patch: https://git.openjdk.java.net/skara/pull/207.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/207/head:pull/207 Looks good, nice progress towards splitting up the `host` module! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/207 From rwestberg at openjdk.org Tue Oct 15 13:06:50 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 15 Oct 2019 13:06:50 GMT Subject: [Integrated] RFR: Refactor host interfaces In-Reply-To: References: Message-ID: <07098904-32e5-4d4d-a59b-ffdfeb9c5713@openjdk.org> Changeset: 1c7ea97e Author: Robin Westberg Date: 2019-10-15 13:06:31 +0000 URL: https://git.openjdk.java.net/skara/commit/1c7ea97e Refactor host interfaces Reviewed-by: ehelin ! bot/build.gradle ! bot/src/main/java/module-info.java ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java ! bots/cli/build.gradle ! bots/cli/src/main/java/module-info.java ! bots/cli/src/main/java/org/openjdk/skara/bots/cli/BotLauncher.java ! bots/cli/src/main/java/org/openjdk/skara/bots/cli/BotLogstashHandler.java ! bots/cli/src/main/java/org/openjdk/skara/bots/cli/BotSlackHandler.java ! bots/cli/src/test/java/org/openjdk/skara/bots/cli/RestReceiver.java ! bots/forward/src/main/java/org/openjdk/skara/bots/forward/ForwardBot.java ! bots/forward/src/main/java/org/openjdk/skara/bots/forward/ForwardBotFactory.java ! bots/forward/src/test/java/org/openjdk/skara/bots/forward/ForwardBotTests.java ! bots/hgbridge/build.gradle ! bots/hgbridge/src/main/java/module-info.java ! bots/hgbridge/src/main/java/org/openjdk/skara/bots/hgbridge/ExporterConfig.java ! bots/hgbridge/src/main/java/org/openjdk/skara/bots/hgbridge/JBridgeBot.java ! bots/hgbridge/src/main/java/org/openjdk/skara/bots/hgbridge/JBridgeBotFactory.java ! bots/hgbridge/src/test/java/org/openjdk/skara/bots/hgbridge/BridgeBotTests.java ! bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBot.java ! bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBotFactory.java ! bots/merge/src/test/java/org/openjdk/skara/bots/merge/MergeBotTests.java ! bots/mirror/src/main/java/org/openjdk/skara/bots/mirror/MirrorBot.java ! bots/mirror/src/main/java/org/openjdk/skara/bots/mirror/MirrorBotFactory.java ! bots/mirror/src/test/java/org/openjdk/skara/bots/mirror/MirrorBotTests.java ! bots/mlbridge/build.gradle ! bots/mlbridge/src/main/java/module-info.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CensusInstance.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CommentPosterWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/PullRequestInstance.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevStorage.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBotTests.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/WebrevStorageTests.java ! bots/notify/build.gradle ! bots/notify/src/main/java/module-info.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JsonUpdater.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdateHistoryTests.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/AllowCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CensusInstance.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/ContributorCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/Contributors.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelerWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/ProjectPermissions.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReadyForSponsorTracker.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/RejectCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/Summary.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SummaryCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/Veto.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CommandTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/LabelerTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/MergeTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/PullRequestAsserts.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SponsorTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SummaryTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/VetoTests.java ! bots/submit/src/main/java/org/openjdk/skara/bots/submit/SubmitBot.java ! bots/submit/src/main/java/org/openjdk/skara/bots/submit/SubmitBotWorkItem.java ! bots/submit/src/test/java/org/openjdk/skara/bots/submit/CheckUpdaterTests.java ! bots/submit/src/test/java/org/openjdk/skara/bots/submit/SubmitBotTests.java ! bots/topological/src/main/java/module-info.java ! bots/topological/src/main/java/org/openjdk/skara/bots/topological/TopologicalBot.java ! bots/topological/src/test/java/org/openjdk/skara/bots/topological/TopologicalBotTests.java ! cli/src/main/java/org/openjdk/skara/cli/GitFork.java ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java ! host/build.gradle ! host/src/main/java/module-info.java ! host/src/main/java/org/openjdk/skara/host/Comment.java ! host/src/main/java/org/openjdk/skara/host/Host.java ! host/src/main/java/org/openjdk/skara/host/HostFactory.java + host/src/main/java/org/openjdk/skara/host/HostUser.java - host/src/main/java/org/openjdk/skara/host/HostUserDetails.java ! host/src/main/java/org/openjdk/skara/host/HostedRepository.java ! host/src/main/java/org/openjdk/skara/host/Issue.java + host/src/main/java/org/openjdk/skara/host/IssueHost.java ! host/src/main/java/org/openjdk/skara/host/IssueProject.java ! host/src/main/java/org/openjdk/skara/host/PullRequest.java ! host/src/main/java/org/openjdk/skara/host/PullRequestUpdateCache.java + host/src/main/java/org/openjdk/skara/host/RepositoryHost.java ! host/src/main/java/org/openjdk/skara/host/Review.java ! host/src/main/java/org/openjdk/skara/host/ReviewComment.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubApplication.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubHost.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubRepository.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabHost.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabRepository.java ! host/src/main/java/org/openjdk/skara/host/jira/JiraHost.java ! host/src/main/java/org/openjdk/skara/host/jira/JiraIssue.java ! host/src/main/java/org/openjdk/skara/host/jira/JiraProject.java ! host/src/test/java/org/openjdk/skara/host/HostTests.java ! host/src/test/java/org/openjdk/skara/host/github/GitHubHostTests.java - host/src/test/java/org/openjdk/skara/host/network/RestRequestTests.java - host/src/test/java/org/openjdk/skara/host/network/URIBuilderTests.java ! mailinglist/build.gradle ! mailinglist/src/main/java/module-info.java ! mailinglist/src/main/java/org/openjdk/skara/mailinglist/mailman/MailmanServer.java + network/build.gradle + network/src/main/java/module-info.java = network/src/main/java/org/openjdk/skara/network/RestRequest.java = network/src/main/java/org/openjdk/skara/network/URIBuilder.java + network/src/test/java/org/openjdk/skara/network/RestRequestTests.java + network/src/test/java/org/openjdk/skara/network/URIBuilderTests.java ! settings.gradle ! storage/build.gradle ! storage/src/main/java/module-info.java ! storage/src/main/java/org/openjdk/skara/storage/HostedRepositoryStorage.java ! test/build.gradle ! test/src/main/java/module-info.java ! test/src/main/java/org/openjdk/skara/test/CensusBuilder.java ! test/src/main/java/org/openjdk/skara/test/HostCredentials.java ! test/src/main/java/org/openjdk/skara/test/TestHost.java ! test/src/main/java/org/openjdk/skara/test/TestHostedRepository.java ! test/src/main/java/org/openjdk/skara/test/TestIssue.java ! test/src/main/java/org/openjdk/skara/test/TestIssueProject.java ! test/src/main/java/org/openjdk/skara/test/TestMailmanServer.java ! test/src/main/java/org/openjdk/skara/test/TestPullRequest.java From rwestberg at openjdk.org Wed Oct 16 14:33:10 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 16 Oct 2019 14:33:10 GMT Subject: RFR: Split host module Message-ID: Hi all, Please review this refactoring change that splits the host module. Best regards, Robin ---------------- Commits: - 6355570a: Split host module Changes: https://git.openjdk.java.net/skara/pull/208/files Webrev: https://webrevs.openjdk.java.net/skara/208/webrev.00 Stats: 7560 lines in 167 files changed: 3783 ins; 3521 del; 256 mod Patch: https://git.openjdk.java.net/skara/pull/208.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/208/head:pull/208 PR: https://git.openjdk.java.net/skara/pull/208 From ehelin at openjdk.org Wed Oct 16 15:45:20 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 16 Oct 2019 15:45:20 GMT Subject: [Approved] RFR: Split host module In-Reply-To: References: Message-ID: On Wed, 16 Oct 2019 14:33:10 GMT, Robin Westberg wrote: > Hi all, > > Please review this refactoring change that splits the host module. > > Best regards, > Robin > > ---------------- > > Commits: > - 6355570a: Split host module > > Changes: https://git.openjdk.java.net/skara/pull/208/files > Webrev: https://webrevs.openjdk.java.net/skara/208/webrev.00 > Stats: 7560 lines in 167 files changed: 3783 ins; 3521 del; 256 mod > Patch: https://git.openjdk.java.net/skara/pull/208.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/208/head:pull/208 Awesome work, looks great! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/208 From rwestberg at openjdk.org Thu Oct 17 06:52:50 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 17 Oct 2019 06:52:50 GMT Subject: [Integrated] RFR: Split host module In-Reply-To: References: Message-ID: Changeset: 388336b5 Author: Robin Westberg Date: 2019-10-17 06:52:34 +0000 URL: https://git.openjdk.java.net/skara/commit/388336b5 Split host module Reviewed-by: ehelin ! bot/build.gradle ! bot/src/main/java/module-info.java ! bot/src/main/java/org/openjdk/skara/bot/BotConfiguration.java ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java ! bots/cli/build.gradle ! bots/forward/build.gradle ! bots/forward/src/main/java/org/openjdk/skara/bots/forward/ForwardBot.java ! bots/hgbridge/build.gradle ! bots/hgbridge/src/main/java/org/openjdk/skara/bots/hgbridge/ExporterConfig.java ! bots/hgbridge/src/test/java/org/openjdk/skara/bots/hgbridge/BridgeBotTests.java ! bots/merge/build.gradle ! bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBot.java ! bots/mirror/build.gradle ! bots/mirror/src/main/java/org/openjdk/skara/bots/mirror/MirrorBot.java ! bots/mlbridge/build.gradle ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CensusInstance.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CommentPosterWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/PullRequestInstance.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevStorage.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBotTests.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! bots/notify/build.gradle ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JsonUpdater.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/UpdateConsumer.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdateHistoryTests.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java ! bots/pr/build.gradle ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/AllowCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CensusInstance.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandHandler.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/ContributorCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/Contributors.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelerWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReadyForSponsorTracker.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/RejectCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewTracker.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/Summary.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SummaryCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/Veto.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CommandTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/LabelerTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/MergeTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/PullRequestAsserts.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SponsorTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SummaryTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/VetoTests.java ! bots/submit/build.gradle ! bots/submit/src/main/java/org/openjdk/skara/bots/submit/CheckUpdater.java ! bots/submit/src/main/java/org/openjdk/skara/bots/submit/ShellExecutor.java ! bots/submit/src/main/java/org/openjdk/skara/bots/submit/SubmitBot.java ! bots/submit/src/main/java/org/openjdk/skara/bots/submit/SubmitBotWorkItem.java ! bots/submit/src/main/java/org/openjdk/skara/bots/submit/SubmitExecutor.java ! bots/submit/src/test/java/org/openjdk/skara/bots/submit/CheckUpdaterTests.java ! bots/submit/src/test/java/org/openjdk/skara/bots/submit/ShellExecutorTests.java ! bots/submit/src/test/java/org/openjdk/skara/bots/submit/SubmitBotTests.java ! bots/topological/build.gradle ! bots/topological/src/main/java/org/openjdk/skara/bots/topological/TopologicalBot.java ! cli/build.gradle ! cli/src/main/java/module-info.java ! cli/src/main/java/org/openjdk/skara/cli/GitFork.java ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java + forge/build.gradle + forge/src/main/java/module-info.java + forge/src/main/java/org/openjdk/skara/forge/Check.java + forge/src/main/java/org/openjdk/skara/forge/CheckAnnotation.java + forge/src/main/java/org/openjdk/skara/forge/CheckAnnotationBuilder.java + forge/src/main/java/org/openjdk/skara/forge/CheckAnnotationLevel.java = forge/src/main/java/org/openjdk/skara/forge/CheckBuilder.java + forge/src/main/java/org/openjdk/skara/forge/CheckStatus.java + forge/src/main/java/org/openjdk/skara/forge/Forge.java + forge/src/main/java/org/openjdk/skara/forge/ForgeFactory.java = forge/src/main/java/org/openjdk/skara/forge/GitHubApplication.java + forge/src/main/java/org/openjdk/skara/forge/GitHubHost.java + forge/src/main/java/org/openjdk/skara/forge/GitHubPullRequest.java + forge/src/main/java/org/openjdk/skara/forge/GitHubRepository.java + forge/src/main/java/org/openjdk/skara/forge/GitLabHost.java + forge/src/main/java/org/openjdk/skara/forge/GitLabMergeRequest.java + forge/src/main/java/org/openjdk/skara/forge/GitLabRepository.java + forge/src/main/java/org/openjdk/skara/forge/HostedRepository.java = forge/src/main/java/org/openjdk/skara/forge/PositionMapper.java + forge/src/main/java/org/openjdk/skara/forge/PullRequest.java + forge/src/main/java/org/openjdk/skara/forge/PullRequestUpdateCache.java + forge/src/main/java/org/openjdk/skara/forge/Review.java + forge/src/main/java/org/openjdk/skara/forge/ReviewComment.java + forge/src/main/java/org/openjdk/skara/forge/WebHook.java + forge/src/test/java/org/openjdk/skara/forge/CheckBuilderTests.java + forge/src/test/java/org/openjdk/skara/forge/GitHubApplicationTests.java + forge/src/test/java/org/openjdk/skara/forge/GitHubHostTests.java = forge/src/test/java/org/openjdk/skara/forge/PositionMapperTests.java ! host/build.gradle - host/src/main/java/org/openjdk/skara/host/Check.java - host/src/main/java/org/openjdk/skara/host/CheckAnnotation.java - host/src/main/java/org/openjdk/skara/host/CheckAnnotationBuilder.java - host/src/main/java/org/openjdk/skara/host/CheckAnnotationLevel.java - host/src/main/java/org/openjdk/skara/host/CheckStatus.java - host/src/main/java/org/openjdk/skara/host/Comment.java ! host/src/main/java/org/openjdk/skara/host/Host.java - host/src/main/java/org/openjdk/skara/host/HostFactory.java - host/src/main/java/org/openjdk/skara/host/HostedRepository.java - host/src/main/java/org/openjdk/skara/host/Issue.java - host/src/main/java/org/openjdk/skara/host/IssueHost.java - host/src/main/java/org/openjdk/skara/host/IssueProject.java - host/src/main/java/org/openjdk/skara/host/PullRequest.java - host/src/main/java/org/openjdk/skara/host/PullRequestUpdateCache.java - host/src/main/java/org/openjdk/skara/host/RepositoryHost.java - host/src/main/java/org/openjdk/skara/host/Review.java - host/src/main/java/org/openjdk/skara/host/ReviewComment.java - host/src/main/java/org/openjdk/skara/host/WebHook.java - host/src/main/java/org/openjdk/skara/host/github/GitHubHost.java - host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java - host/src/main/java/org/openjdk/skara/host/github/GitHubRepository.java - host/src/main/java/org/openjdk/skara/host/gitlab/GitLabHost.java - host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java - host/src/main/java/org/openjdk/skara/host/gitlab/GitLabRepository.java - host/src/main/java/org/openjdk/skara/host/jira/JiraHost.java - host/src/main/java/org/openjdk/skara/host/jira/JiraProject.java - host/src/test/java/org/openjdk/skara/host/CheckBuilderTests.java - host/src/test/java/org/openjdk/skara/host/HostTests.java - host/src/test/java/org/openjdk/skara/host/github/GitHubApplicationTests.java - host/src/test/java/org/openjdk/skara/host/github/GitHubHostTests.java + issuetracker/build.gradle + issuetracker/src/main/java/module-info.java + issuetracker/src/main/java/org/openjdk/skara/issuetracker/Comment.java + issuetracker/src/main/java/org/openjdk/skara/issuetracker/Issue.java + issuetracker/src/main/java/org/openjdk/skara/issuetracker/IssueProject.java + issuetracker/src/main/java/org/openjdk/skara/issuetracker/IssueTracker.java + issuetracker/src/main/java/org/openjdk/skara/issuetracker/IssueTrackerFactory.java + issuetracker/src/main/java/org/openjdk/skara/issuetracker/JiraHost.java = issuetracker/src/main/java/org/openjdk/skara/issuetracker/JiraIssue.java + issuetracker/src/main/java/org/openjdk/skara/issuetracker/JiraProject.java + issuetracker/src/test/java/org/openjdk/skara/issuetracker/IssueTrackerTests.java ! settings.gradle ! storage/build.gradle ! storage/src/main/java/module-info.java ! storage/src/main/java/org/openjdk/skara/storage/HostedRepositoryStorage.java ! storage/src/main/java/org/openjdk/skara/storage/StorageBuilder.java ! test/build.gradle ! test/src/main/java/module-info.java ! test/src/main/java/org/openjdk/skara/test/CensusBuilder.java ! test/src/main/java/org/openjdk/skara/test/HostCredentials.java ! test/src/main/java/org/openjdk/skara/test/IssueData.java ! test/src/main/java/org/openjdk/skara/test/PullRequestData.java ! test/src/main/java/org/openjdk/skara/test/TestHost.java ! test/src/main/java/org/openjdk/skara/test/TestHostedRepository.java ! test/src/main/java/org/openjdk/skara/test/TestIssue.java ! test/src/main/java/org/openjdk/skara/test/TestIssueProject.java ! test/src/main/java/org/openjdk/skara/test/TestPullRequest.java From ehelin at openjdk.org Fri Oct 18 08:15:39 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 18 Oct 2019 08:15:39 GMT Subject: RFR: 134: BotRunnerConfiguration cannot parse hosts Message-ID: Hi all, this patch fixes a bug that was introduced after the `host` module split. We must separate the different kinds of hosts in the bot configuration file, otherwise the `BotRunnerConfiguration` can't do sanity checking on the configuration. Thanks, Erik ## Testing - [x] `sh gradlew test` passes - [x] `sh gradlew images` passes ---------------- Commits: - 9e30a6b2: 134: BotRunnerConfiguration cannot parse hosts Changes: https://git.openjdk.java.net/skara/pull/209/files Webrev: https://webrevs.openjdk.java.net/skara/209/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-134 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/209.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/209/head:pull/209 PR: https://git.openjdk.java.net/skara/pull/209 From rwestberg at openjdk.org Fri Oct 18 08:21:39 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 18 Oct 2019 08:21:39 GMT Subject: [Approved] RFR: 134: BotRunnerConfiguration cannot parse hosts In-Reply-To: References: Message-ID: On Fri, 18 Oct 2019 08:15:39 GMT, Erik Helin wrote: > Hi all, > > this patch fixes a bug that was introduced after the `host` module split. We must separate the different kinds of hosts in the bot configuration file, otherwise the `BotRunnerConfiguration` can't do sanity checking on the configuration. > > Thanks, > Erik > > ## Testing > - [x] `sh gradlew test` passes > - [x] `sh gradlew images` passes > > ---------------- > > Commits: > - 9e30a6b2: 134: BotRunnerConfiguration cannot parse hosts > > Changes: https://git.openjdk.java.net/skara/pull/209/files > Webrev: https://webrevs.openjdk.java.net/skara/209/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-134 > Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod > Patch: https://git.openjdk.java.net/skara/pull/209.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/209/head:pull/209 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/209 From ehelin at openjdk.org Fri Oct 18 08:30:59 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 18 Oct 2019 08:30:59 GMT Subject: [Integrated] RFR: 134: BotRunnerConfiguration cannot parse hosts In-Reply-To: References: Message-ID: <4c8c5952-154b-4de9-a2e2-4084eca54023@openjdk.org> Changeset: 2913a3d7 Author: Erik Helin Date: 2019-10-18 08:30:43 +0000 URL: https://git.openjdk.java.net/skara/commit/2913a3d7 134: BotRunnerConfiguration cannot parse hosts Reviewed-by: rwestberg ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java From ehelin at openjdk.org Fri Oct 18 08:55:28 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 18 Oct 2019 08:55:28 GMT Subject: RFR: Better formatting of GitLab MR checks Message-ID: <30b4jfb3m98pYYRPXuWkKI9ENNf0Y7wt-UcjfhBqQ-8=.13c7484d-4643-45f9-86a5-1a5ac3f4cec8@github.com> Hi all, please this review this small PR that enhances the formatting of GitLab merge request check runs. Thanks, Erik ## Testing - `sh gradlew test` passes - `sh gradlew images` passes ---------------- Commits: - 6a0cb3d9: Better formatting of GitLab MR checks Changes: https://git.openjdk.java.net/skara/pull/210/files Webrev: https://webrevs.openjdk.java.net/skara/210/webrev.00 Stats: 25 lines in 1 file changed: 4 ins; 0 del; 21 mod Patch: https://git.openjdk.java.net/skara/pull/210.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/210/head:pull/210 PR: https://git.openjdk.java.net/skara/pull/210 From rwestberg at openjdk.org Fri Oct 18 09:01:49 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 18 Oct 2019 09:01:49 GMT Subject: [Approved] RFR: Better formatting of GitLab MR checks In-Reply-To: <30b4jfb3m98pYYRPXuWkKI9ENNf0Y7wt-UcjfhBqQ-8=.13c7484d-4643-45f9-86a5-1a5ac3f4cec8@github.com> References: <30b4jfb3m98pYYRPXuWkKI9ENNf0Y7wt-UcjfhBqQ-8=.13c7484d-4643-45f9-86a5-1a5ac3f4cec8@github.com> Message-ID: On Fri, 18 Oct 2019 08:55:28 GMT, Erik Helin wrote: > Hi all, > > please this review this small PR that enhances the formatting of GitLab merge request check runs. > > Thanks, > Erik > > ## Testing > - `sh gradlew test` passes > - `sh gradlew images` passes > > ---------------- > > Commits: > - 6a0cb3d9: Better formatting of GitLab MR checks > > Changes: https://git.openjdk.java.net/skara/pull/210/files > Webrev: https://webrevs.openjdk.java.net/skara/210/webrev.00 > Stats: 25 lines in 1 file changed: 4 ins; 0 del; 21 mod > Patch: https://git.openjdk.java.net/skara/pull/210.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/210/head:pull/210 Looks fine! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/210 From ehelin at openjdk.org Fri Oct 18 09:02:18 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 18 Oct 2019 09:02:18 GMT Subject: [Integrated] RFR: Better formatting of GitLab MR checks In-Reply-To: <30b4jfb3m98pYYRPXuWkKI9ENNf0Y7wt-UcjfhBqQ-8=.13c7484d-4643-45f9-86a5-1a5ac3f4cec8@github.com> References: <30b4jfb3m98pYYRPXuWkKI9ENNf0Y7wt-UcjfhBqQ-8=.13c7484d-4643-45f9-86a5-1a5ac3f4cec8@github.com> Message-ID: <1918dd63-0d6b-4d2b-9d6e-6bf3deb1e9e4@openjdk.org> Changeset: 37000b57 Author: Erik Helin Date: 2019-10-18 09:02:04 +0000 URL: https://git.openjdk.java.net/skara/commit/37000b57 Better formatting of GitLab MR checks Reviewed-by: rwestberg ! forge/src/main/java/org/openjdk/skara/forge/GitLabMergeRequest.java From ehelin at openjdk.org Fri Oct 18 09:10:18 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 18 Oct 2019 09:10:18 GMT Subject: RFR: Add clean and images targets to Makefile Message-ID: Hi, this patch adds two new "wrapper" targets `images` and `clean` for the Makefile. Thanks, Erik ## Testing - `make images` works - `make clean` works ---------------- Commits: - 9b487b42: Add clean and images targets to Makefile Changes: https://git.openjdk.java.net/skara/pull/211/files Webrev: https://webrevs.openjdk.java.net/skara/211/webrev.00 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/211.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/211/head:pull/211 PR: https://git.openjdk.java.net/skara/pull/211 From rwestberg at openjdk.org Fri Oct 18 09:11:52 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 18 Oct 2019 09:11:52 GMT Subject: [Approved] RFR: Add clean and images targets to Makefile In-Reply-To: References: Message-ID: <_b6UyecarvJJLRdHTv_CjP9NGUDuEZB7Ngzl0syOjY4=.d2fa88ec-f634-4e26-85ec-3c698f6b0ce2@github.com> On Fri, 18 Oct 2019 09:10:18 GMT, Erik Helin wrote: > Hi, > > this patch adds two new "wrapper" targets `images` and `clean` for the Makefile. > > Thanks, > Erik > > ## Testing > - `make images` works > - `make clean` works > > ---------------- > > Commits: > - 9b487b42: Add clean and images targets to Makefile > > Changes: https://git.openjdk.java.net/skara/pull/211/files > Webrev: https://webrevs.openjdk.java.net/skara/211/webrev.00 > Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/211.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/211/head:pull/211 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/211 From ehelin at openjdk.org Fri Oct 18 09:12:28 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 18 Oct 2019 09:12:28 GMT Subject: [Integrated] RFR: Add clean and images targets to Makefile In-Reply-To: References: Message-ID: Changeset: 4cb344cb Author: Erik Helin Date: 2019-10-18 09:12:15 +0000 URL: https://git.openjdk.java.net/skara/commit/4cb344cb Add clean and images targets to Makefile Reviewed-by: rwestberg ! Makefile From rwestberg at openjdk.org Fri Oct 18 11:26:40 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 18 Oct 2019 11:26:40 GMT Subject: RFR: Add experimental GitHub action Message-ID: Hi all, Please review this change that enables a GitHub action for experimental purposes. Best regards, Robin ---------------- Commits: - e31490d7: Add experimental GitHub action Changes: https://git.openjdk.java.net/skara/pull/212/files Webrev: https://webrevs.openjdk.java.net/skara/212/webrev.00 Stats: 20 lines in 1 file changed: 20 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/212.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/212/head:pull/212 PR: https://git.openjdk.java.net/skara/pull/212 From ehelin at openjdk.org Fri Oct 18 11:32:42 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 18 Oct 2019 11:32:42 GMT Subject: [Approved] RFR: Add experimental GitHub action In-Reply-To: References: Message-ID: On Fri, 18 Oct 2019 11:26:40 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that enables a GitHub action for experimental purposes. > > Best regards, > Robin > > ---------------- > > Commits: > - e31490d7: Add experimental GitHub action > > Changes: https://git.openjdk.java.net/skara/pull/212/files > Webrev: https://webrevs.openjdk.java.net/skara/212/webrev.00 > Stats: 20 lines in 1 file changed: 20 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/212.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/212/head:pull/212 Looks good, will be fun to see how it performs! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/212 From ehelin at openjdk.org Fri Oct 18 11:36:18 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 18 Oct 2019 11:36:18 GMT Subject: RFR: Fix number of context lines between coalesced hunks Message-ID: Hi all, this patch fixes a smal issue with the `HunkCoalescer`. If two hunks are more than 2 * number-of-context-lines apart then we correctly calculate that they should be coalesced, but we don't include the correct number of context lines. We only include number-of-context-lines (.e.g. 5), not up to the maximum which is 2 * number-of-context-lines (e.g. 10). This small patch fixes this problem. Thanks to @lkorinth for reporting this bug! Thanks, Erik ---------------- Commits: - a1053732: Fix number of context lines between coalesced hunks Changes: https://git.openjdk.java.net/skara/pull/213/files Webrev: https://webrevs.openjdk.java.net/skara/213/webrev.00 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/213.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/213/head:pull/213 PR: https://git.openjdk.java.net/skara/pull/213 From rwestberg at openjdk.org Fri Oct 18 11:52:19 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 18 Oct 2019 11:52:19 GMT Subject: [Rev 01] RFR: Add experimental GitHub action In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 9e9f2548: Add experimental GitHub action Changes: - all: https://git.openjdk.java.net/skara/pull/212/files - new: https://git.openjdk.java.net/skara/pull/212/files/e31490d7..9e9f2548 Webrevs: - full: https://webrevs.openjdk.java.net/skara/212/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/212/webrev.00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/212.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/212/head:pull/212 PR: https://git.openjdk.java.net/skara/pull/212 From rwestberg at openjdk.org Fri Oct 18 12:02:41 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 18 Oct 2019 12:02:41 GMT Subject: [Approved] RFR: Fix number of context lines between coalesced hunks In-Reply-To: References: Message-ID: On Fri, 18 Oct 2019 11:36:18 GMT, Erik Helin wrote: > Hi all, > > this patch fixes a smal issue with the `HunkCoalescer`. If two hunks are more than 2 * number-of-context-lines apart then we correctly calculate that they should be coalesced, but we don't include the correct number of context lines. We only include number-of-context-lines (.e.g. 5), not up to the maximum which is 2 * number-of-context-lines (e.g. 10). This small patch fixes this problem. > > Thanks to @lkorinth for reporting this bug! > > Thanks, > Erik > > ---------------- > > Commits: > - a1053732: Fix number of context lines between coalesced hunks > > Changes: https://git.openjdk.java.net/skara/pull/213/files > Webrev: https://webrevs.openjdk.java.net/skara/213/webrev.00 > Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/213.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/213/head:pull/213 Looks good, some sort of regression test would perhaps have been nice though.. ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/213 From ehelin at openjdk.org Fri Oct 18 12:14:48 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 18 Oct 2019 12:14:48 GMT Subject: [Integrated] RFR: Fix number of context lines between coalesced hunks In-Reply-To: References: Message-ID: <74bb7f46-f442-49c4-8652-3b894a446095@openjdk.org> Changeset: 32bb9d8b Author: Erik Helin Date: 2019-10-18 12:14:32 +0000 URL: https://git.openjdk.java.net/skara/commit/32bb9d8b Fix number of context lines between coalesced hunks Reviewed-by: rwestberg ! webrev/src/main/java/org/openjdk/skara/webrev/HunkCoalescer.java From ehelin at openjdk.org Fri Oct 18 12:41:38 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 18 Oct 2019 12:41:38 GMT Subject: RFR: Fix the HunkCoalescer again Message-ID: <6-l-STjEG5PHV__ghaL0ip6jZ_jtl6UiB4pVetJeOtY=.b5945d90-0a5a-4a00-889b-18b11b69f5c3@github.com> Hi all, seems like the `HunkCoalescer` wasn't finished with me just yet. I forgot about some end-of-file use cases and also applied my previous fix in the wrong place. This time however it works, many thanks to @JornVernee for testing and reporting the additional bugs. Thanks, Erik ---------------- Commits: - c0c399ca: Fix the HunkCoalescer again Changes: https://git.openjdk.java.net/skara/pull/214/files Webrev: https://webrevs.openjdk.java.net/skara/214/webrev.00 Stats: 12 lines in 1 file changed: 6 ins; 6 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/214.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/214/head:pull/214 PR: https://git.openjdk.java.net/skara/pull/214 From rwestberg at openjdk.org Fri Oct 18 12:52:59 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 18 Oct 2019 12:52:59 GMT Subject: [Approved] RFR: Fix the HunkCoalescer again In-Reply-To: <6-l-STjEG5PHV__ghaL0ip6jZ_jtl6UiB4pVetJeOtY=.b5945d90-0a5a-4a00-889b-18b11b69f5c3@github.com> References: <6-l-STjEG5PHV__ghaL0ip6jZ_jtl6UiB4pVetJeOtY=.b5945d90-0a5a-4a00-889b-18b11b69f5c3@github.com> Message-ID: On Fri, 18 Oct 2019 12:41:38 GMT, Erik Helin wrote: > Hi all, > > seems like the `HunkCoalescer` wasn't finished with me just yet. I forgot about some end-of-file use cases and also applied my previous fix in the wrong place. This time however it works, many thanks to @JornVernee for testing and reporting the additional bugs. > > Thanks, > Erik > > ---------------- > > Commits: > - c0c399ca: Fix the HunkCoalescer again > > Changes: https://git.openjdk.java.net/skara/pull/214/files > Webrev: https://webrevs.openjdk.java.net/skara/214/webrev.00 > Stats: 12 lines in 1 file changed: 6 ins; 6 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/214.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/214/head:pull/214 Very well, but I still think there should be a test or two for this. :) ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/214 From jvernee at openjdk.org Fri Oct 18 16:47:59 2019 From: jvernee at openjdk.org (Jorn Vernee) Date: Fri, 18 Oct 2019 16:47:59 GMT Subject: RFR: Fix the HunkCoalescer again In-Reply-To: <6-l-STjEG5PHV__ghaL0ip6jZ_jtl6UiB4pVetJeOtY=.b5945d90-0a5a-4a00-889b-18b11b69f5c3@github.com> References: <6-l-STjEG5PHV__ghaL0ip6jZ_jtl6UiB4pVetJeOtY=.b5945d90-0a5a-4a00-889b-18b11b69f5c3@github.com> Message-ID: On Fri, 18 Oct 2019 12:41:38 GMT, Erik Helin wrote: > Hi all, > > seems like the `HunkCoalescer` wasn't finished with me just yet. I forgot about some end-of-file use cases and also applied my previous fix in the wrong place. This time however it works, many thanks to @JornVernee for testing and reporting the additional bugs. > > Thanks, > Erik > > ---------------- > > Commits: > - c0c399ca: Fix the HunkCoalescer again > > Changes: https://git.openjdk.java.net/skara/pull/214/files > Webrev: https://webrevs.openjdk.java.net/skara/214/webrev.00 > Stats: 12 lines in 1 file changed: 6 ins; 6 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/214.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/214/head:pull/214 Approved by jvernee (Committer). PR: https://git.openjdk.java.net/skara/pull/214 From ehelin at openjdk.org Mon Oct 21 06:35:09 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 21 Oct 2019 06:35:09 GMT Subject: [Integrated] RFR: Fix the HunkCoalescer again In-Reply-To: <6-l-STjEG5PHV__ghaL0ip6jZ_jtl6UiB4pVetJeOtY=.b5945d90-0a5a-4a00-889b-18b11b69f5c3@github.com> References: <6-l-STjEG5PHV__ghaL0ip6jZ_jtl6UiB4pVetJeOtY=.b5945d90-0a5a-4a00-889b-18b11b69f5c3@github.com> Message-ID: Changeset: f265d888 Author: Erik Helin Date: 2019-10-21 06:34:53 +0000 URL: https://git.openjdk.java.net/skara/commit/f265d888 Fix the HunkCoalescer again Reviewed-by: rwestberg, jvernee ! webrev/src/main/java/org/openjdk/skara/webrev/HunkCoalescer.java From rwestberg at openjdk.org Mon Oct 21 08:53:52 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 21 Oct 2019 08:53:52 GMT Subject: RFR: Enable CI on Windows, fix or disable failing tests Message-ID: Hi all, Please review this change that enables CI for Windows as well, and fixes or disables failing tests. Failing tests: https://bugs.openjdk.java.net/browse/SKARA-136 https://bugs.openjdk.java.net/browse/SKARA-137 Best regards, Robin ---------------- Commits: - 24d62997: Enable CI on Windows, fix or disable failing tests Changes: https://git.openjdk.java.net/skara/pull/215/files Webrev: https://webrevs.openjdk.java.net/skara/215/webrev.00 Stats: 36 lines in 6 files changed: 20 ins; 4 del; 12 mod Patch: https://git.openjdk.java.net/skara/pull/215.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/215/head:pull/215 PR: https://git.openjdk.java.net/skara/pull/215 From ehelin at openjdk.org Mon Oct 21 09:39:59 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 21 Oct 2019 09:39:59 GMT Subject: [Approved] RFR: Enable CI on Windows, fix or disable failing tests In-Reply-To: References: Message-ID: <_HhPTH-9EyCf82Ruqbkud7UNV2VEECoDFx85MsGP7Zs=.82206523-bd56-44c9-a5c4-af8835d36ac6@github.com> On Mon, 21 Oct 2019 08:53:52 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that enables CI for Windows as well, and fixes or disables failing tests. > > Failing tests: > https://bugs.openjdk.java.net/browse/SKARA-136 > https://bugs.openjdk.java.net/browse/SKARA-137 > > Best regards, > Robin > > ---------------- > > Commits: > - 24d62997: Enable CI on Windows, fix or disable failing tests > > Changes: https://git.openjdk.java.net/skara/pull/215/files > Webrev: https://webrevs.openjdk.java.net/skara/215/webrev.00 > Stats: 36 lines in 6 files changed: 20 ins; 4 del; 12 mod > Patch: https://git.openjdk.java.net/skara/pull/215.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/215/head:pull/215 Looks good, great work! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/215 From ehelin at openjdk.org Mon Oct 21 09:47:06 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 21 Oct 2019 09:47:06 GMT Subject: RFR: Minor test cleanup Message-ID: Hi all, please review this small patch that properly cleans up a temporary directory from one test in `RepositoryTests` and also sets the `exceptionFormat` to `"full"` for all `test` targets (so that if a test fails we get full stacktraces). Thanks, Erik ## Testing - `sh gradlew test` passes on Linux x64 ---------------- Commits: - 15085039: Minor test cleanup Changes: https://git.openjdk.java.net/skara/pull/216/files Webrev: https://webrevs.openjdk.java.net/skara/216/webrev.00 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/216.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/216/head:pull/216 PR: https://git.openjdk.java.net/skara/pull/216 From rwestberg at openjdk.org Mon Oct 21 11:52:03 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 21 Oct 2019 11:52:03 GMT Subject: [Approved] RFR: Minor test cleanup In-Reply-To: References: Message-ID: On Mon, 21 Oct 2019 09:47:06 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that properly cleans up a temporary directory from one test in `RepositoryTests` and also sets the `exceptionFormat` to `"full"` for all `test` targets (so that if a test fails we get full stacktraces). > > Thanks, > Erik > > ## Testing > - `sh gradlew test` passes on Linux x64 > > ---------------- > > Commits: > - 15085039: Minor test cleanup > > Changes: https://git.openjdk.java.net/skara/pull/216/files > Webrev: https://webrevs.openjdk.java.net/skara/216/webrev.00 > Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/216.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/216/head:pull/216 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/216 From rwestberg at openjdk.org Mon Oct 21 11:57:07 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 21 Oct 2019 11:57:07 GMT Subject: [Rev 01] RFR: Enable CI on Windows, fix or disable failing tests In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 1064c842: Use for pull requests as well Changes: - all: https://git.openjdk.java.net/skara/pull/215/files - new: https://git.openjdk.java.net/skara/pull/215/files/24d62997..1064c842 Webrevs: - full: https://webrevs.openjdk.java.net/skara/215/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/215/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/215.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/215/head:pull/215 PR: https://git.openjdk.java.net/skara/pull/215 From ehelin at openjdk.org Mon Oct 21 12:18:51 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 21 Oct 2019 12:18:51 GMT Subject: [Integrated] RFR: Minor test cleanup In-Reply-To: References: Message-ID: Changeset: b3241bea Author: Erik Helin Date: 2019-10-21 12:18:32 +0000 URL: https://git.openjdk.java.net/skara/commit/b3241bea Minor test cleanup Reviewed-by: rwestberg ! build.gradle ! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java From ehelin at openjdk.org Mon Oct 21 12:44:42 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 21 Oct 2019 12:44:42 GMT Subject: RFR: Add submodule and subrepo support Message-ID: Hi all, this patch adds initial submodule and subrepo support to `GitRepository` and `HgRepository` and also adds a few unit tests. Thanks, Erik ## Testing - `sh gradlew test` passes on Linux x64 ---------------- Commits: - 3506616c: Add submodule and subrepo support Changes: https://git.openjdk.java.net/skara/pull/217/files Webrev: https://webrevs.openjdk.java.net/skara/217/webrev.00 Stats: 212 lines in 7 files changed: 212 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/217.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/217/head:pull/217 PR: https://git.openjdk.java.net/skara/pull/217 From rwestberg at openjdk.org Mon Oct 21 12:57:49 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 21 Oct 2019 12:57:49 GMT Subject: RFR: Add submodule and subrepo support In-Reply-To: References: Message-ID: On Mon, 21 Oct 2019 12:44:42 GMT, Erik Helin wrote: > Hi all, > > this patch adds initial submodule and subrepo support to `GitRepository` and `HgRepository` and also adds a few unit tests. > > Thanks, > Erik > > ## Testing > - `sh gradlew test` passes on Linux x64 > > ---------------- > > Commits: > - 3506616c: Add submodule and subrepo support > > Changes: https://git.openjdk.java.net/skara/pull/217/files > Webrev: https://webrevs.openjdk.java.net/skara/217/webrev.00 > Stats: 212 lines in 7 files changed: 212 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/217.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/217/head:pull/217 vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java line 1132: > 1131: public void addSubmodule(String pullPath, Path path) throws IOException { > 1132: var uri = Files.exists(Path.of(pullPath)) ? "file://" + pullPath : pullPath; > 1133: HgRepository.clone(URI.create(uri), root().resolve(path).toAbsolutePath(), false); Suggestion: var uri = Files.exists(Path.of(pullPath)) ? Path.of(pullPath).toUri().toString() : pullPath; PR: https://git.openjdk.java.net/skara/pull/217 From rwestberg at openjdk.org Mon Oct 21 12:57:50 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 21 Oct 2019 12:57:50 GMT Subject: [Approved] RFR: Add submodule and subrepo support In-Reply-To: References: Message-ID: On Mon, 21 Oct 2019 12:44:42 GMT, Erik Helin wrote: > Hi all, > > this patch adds initial submodule and subrepo support to `GitRepository` and `HgRepository` and also adds a few unit tests. > > Thanks, > Erik > > ## Testing > - `sh gradlew test` passes on Linux x64 > > ---------------- > > Commits: > - 3506616c: Add submodule and subrepo support > > Changes: https://git.openjdk.java.net/skara/pull/217/files > Webrev: https://webrevs.openjdk.java.net/skara/217/webrev.00 > Stats: 212 lines in 7 files changed: 212 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/217.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/217/head:pull/217 Looks good, just fix the failing test! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/217 From ehelin at openjdk.org Mon Oct 21 13:11:01 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 21 Oct 2019 13:11:01 GMT Subject: [Rev 01] RFR: Add submodule and subrepo support In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 90496423: Fix test on Windows Changes: - all: https://git.openjdk.java.net/skara/pull/217/files - new: https://git.openjdk.java.net/skara/pull/217/files/3506616c..90496423 Webrevs: - full: https://webrevs.openjdk.java.net/skara/217/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/217/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/217.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/217/head:pull/217 PR: https://git.openjdk.java.net/skara/pull/217 From rwestberg at openjdk.org Mon Oct 21 13:27:34 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 21 Oct 2019 13:27:34 GMT Subject: RFR: 135: Cannot report more than 50 check errors on GitHub Message-ID: Hi all, Please review this change that ensures that we don't exceed the maximum number of allowed check annotations on GitHub. Best regards, Robin ---------------- Commits: - 882f72c2: Never report more than 50 errors in a check on GitHub as that is the maximum allowed Changes: https://git.openjdk.java.net/skara/pull/218/files Webrev: https://webrevs.openjdk.java.net/skara/218/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-135 Stats: 36 lines in 2 files changed: 35 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/218.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/218/head:pull/218 PR: https://git.openjdk.java.net/skara/pull/218 From kcr at openjdk.org Mon Oct 21 13:30:00 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 21 Oct 2019 13:30:00 GMT Subject: RFR: 135: Cannot report more than 50 check errors on GitHub In-Reply-To: References: Message-ID: On Mon, 21 Oct 2019 13:27:34 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that we don't exceed the maximum number of allowed check annotations on GitHub. > > Best regards, > Robin > > ---------------- > > Commits: > - 882f72c2: Never report more than 50 errors in a check on GitHub as that is the maximum allowed > > Changes: https://git.openjdk.java.net/skara/pull/218/files > Webrev: https://webrevs.openjdk.java.net/skara/218/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-135 > Stats: 36 lines in 2 files changed: 35 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/218.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/218/head:pull/218 Looks good to me. ---------------- Approved by kcr (none). PR: https://git.openjdk.java.net/skara/pull/218 From rwestberg at openjdk.org Mon Oct 21 14:05:18 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 21 Oct 2019 14:05:18 GMT Subject: RFR: 135: Cannot report more than 50 check errors on GitHub In-Reply-To: References: Message-ID: On Mon, 21 Oct 2019 13:30:00 GMT, Kevin Rushforth wrote: > On Mon, 21 Oct 2019 13:27:34 GMT, Robin Westberg wrote: > >> Hi all, >> >> Please review this change that ensures that we don't exceed the maximum number of allowed check annotations on GitHub. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - 882f72c2: Never report more than 50 errors in a check on GitHub as that is the maximum allowed >> >> Changes: https://git.openjdk.java.net/skara/pull/218/files >> Webrev: https://webrevs.openjdk.java.net/skara/218/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/SKARA-135 >> Stats: 36 lines in 2 files changed: 35 ins; 0 del; 1 mod >> Patch: https://git.openjdk.java.net/skara/pull/218.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/218/head:pull/218 > > Looks good to me. > > ---------------- > > Approved by kcr (none). Thanks for reviewing! PR: https://git.openjdk.java.net/skara/pull/218 From rwestberg at openjdk.org Mon Oct 21 15:23:55 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 21 Oct 2019 15:23:55 GMT Subject: RFR: No need for locking when using TestHostedRepository Message-ID: Hi all, Please review this change that skips creating repository lock files when using the TestHostedRepository, as it uses unique temporary folders anyway. This makes the tests run a little bit faster. Best regards, Robin ---------------- Commits: - 16446a6e: No need for locking when using TestHostedRepository Changes: https://git.openjdk.java.net/skara/pull/219/files Webrev: https://webrevs.openjdk.java.net/skara/219/webrev.00 Stats: 9 lines in 1 file changed: 8 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/219.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/219/head:pull/219 PR: https://git.openjdk.java.net/skara/pull/219 From rwestberg at openjdk.org Tue Oct 22 08:57:45 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 22 Oct 2019 08:57:45 GMT Subject: [Rev 01] RFR: No need for locking when using TestHostedRepository In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - f6c0004c: Recreate if needed - c37fb56e: Improve hosted repo init times Changes: - all: https://git.openjdk.java.net/skara/pull/219/files - new: https://git.openjdk.java.net/skara/pull/219/files/16446a6e..f6c0004c Webrevs: - full: https://webrevs.openjdk.java.net/skara/219/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/219/webrev.00-01 Stats: 52 lines in 2 files changed: 42 ins; 1 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/219.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/219/head:pull/219 PR: https://git.openjdk.java.net/skara/pull/219 From ehelin at openjdk.org Tue Oct 22 09:21:50 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 22 Oct 2019 09:21:50 GMT Subject: [Integrated] RFR: Add submodule and subrepo support In-Reply-To: References: Message-ID: <5608b842-c212-4b43-a8b7-f4846204805e@openjdk.org> Changeset: e23b2482 Author: Erik Helin Date: 2019-10-22 09:21:34 +0000 URL: https://git.openjdk.java.net/skara/commit/e23b2482 Add submodule and subrepo support Reviewed-by: rwestberg ! jcheck/src/test/java/org/openjdk/skara/jcheck/TestRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/Repository.java + vcs/src/main/java/org/openjdk/skara/vcs/Submodule.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java ! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java From ehelin at openjdk.org Tue Oct 22 09:22:30 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 22 Oct 2019 09:22:30 GMT Subject: [Approved] RFR: 135: Cannot report more than 50 check errors on GitHub In-Reply-To: References: Message-ID: On Mon, 21 Oct 2019 13:27:34 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that we don't exceed the maximum number of allowed check annotations on GitHub. > > Best regards, > Robin > > ---------------- > > Commits: > - 882f72c2: Never report more than 50 errors in a check on GitHub as that is the maximum allowed > > Changes: https://git.openjdk.java.net/skara/pull/218/files > Webrev: https://webrevs.openjdk.java.net/skara/218/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-135 > Stats: 36 lines in 2 files changed: 35 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/218.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/218/head:pull/218 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/218 From ehelin at openjdk.org Tue Oct 22 09:23:04 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 22 Oct 2019 09:23:04 GMT Subject: [Approved] RFR: No need for locking when using TestHostedRepository In-Reply-To: References: Message-ID: On Mon, 21 Oct 2019 15:23:55 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that skips creating repository lock files when using the TestHostedRepository, as it uses unique temporary folders anyway. This makes the tests run a little bit faster. > > Best regards, > Robin > > ---------------- > > Commits: > - 16446a6e: No need for locking when using TestHostedRepository > > Changes: https://git.openjdk.java.net/skara/pull/219/files > Webrev: https://webrevs.openjdk.java.net/skara/219/webrev.00 > Stats: 9 lines in 1 file changed: 8 ins; 1 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/219.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/219/head:pull/219 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/219 From rwestberg at openjdk.org Tue Oct 22 09:51:23 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 22 Oct 2019 09:51:23 GMT Subject: [Rev 02] RFR: No need for locking when using TestHostedRepository In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 8ae453d0: Use bare repos instead Changes: - all: https://git.openjdk.java.net/skara/pull/219/files - new: https://git.openjdk.java.net/skara/pull/219/files/f6c0004c..8ae453d0 Webrevs: - full: https://webrevs.openjdk.java.net/skara/219/webrev.02 - incr: https://webrevs.openjdk.java.net/skara/219/webrev.01-02 Stats: 101 lines in 5 files changed: 48 ins; 47 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/219.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/219/head:pull/219 PR: https://git.openjdk.java.net/skara/pull/219 From rwestberg at openjdk.org Tue Oct 22 10:54:29 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 22 Oct 2019 10:54:29 GMT Subject: [Integrated] RFR: 135: Cannot report more than 50 check errors on GitHub In-Reply-To: References: Message-ID: <97963e6c-ebc3-4549-977a-e21c821e114c@openjdk.org> Changeset: cc7fa4f7 Author: Robin Westberg Date: 2019-10-22 10:54:13 +0000 URL: https://git.openjdk.java.net/skara/commit/cc7fa4f7 135: Cannot report more than 50 check errors on GitHub Reviewed-by: kcr, ehelin ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java ! forge/src/main/java/org/openjdk/skara/forge/GitHubPullRequest.java From ehelin at openjdk.org Wed Oct 23 10:40:42 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 23 Oct 2019 10:40:42 GMT Subject: RFR: Add --recurse-submodules to applicable actions in GitRepository Message-ID: Hi all, please review this small patch that adds `--recurse-submodules` to applicable operations in `GitRepository`. Thanks, Erik ## Testing - `make test` on Linux x64 ---------------- Commits: - 6d62da63: Add --recurse-submodules to applicable actions in GitRepository Changes: https://git.openjdk.java.net/skara/pull/220/files Webrev: https://webrevs.openjdk.java.net/skara/220/webrev.00 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/220.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/220/head:pull/220 PR: https://git.openjdk.java.net/skara/pull/220 From rwestberg at openjdk.org Wed Oct 23 10:52:01 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 23 Oct 2019 10:52:01 GMT Subject: RFR: 137: Watchdog test can fail to terminate Message-ID: Hi all, Please review this change that fixes a problem with the BotRunnerTests.watchdogTrigger test. Best regards, Robin ---------------- Commits: - 92fda46a: Re-enable for windows - 3af96ddc: Use the real runner loop for watchdog test Changes: https://git.openjdk.java.net/skara/pull/221/files Webrev: https://webrevs.openjdk.java.net/skara/221/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-137 Stats: 9 lines in 2 files changed: 3 ins; 2 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/221.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/221/head:pull/221 PR: https://git.openjdk.java.net/skara/pull/221 From rwestberg at openjdk.org Wed Oct 23 10:52:21 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 23 Oct 2019 10:52:21 GMT Subject: [Approved] RFR: Add --recurse-submodules to applicable actions in GitRepository In-Reply-To: References: Message-ID: <48xvvynOkaGCgc-QCObOwcsFwhcyQA96bpXaE1vHaks=.52dbb486-25c8-4a80-a771-137d8a39ac30@github.com> On Wed, 23 Oct 2019 10:40:42 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that adds `--recurse-submodules` to applicable operations in `GitRepository`. > > Thanks, > Erik > > ## Testing > - `make test` on Linux x64 > > ---------------- > > Commits: > - 6d62da63: Add --recurse-submodules to applicable actions in GitRepository > > Changes: https://git.openjdk.java.net/skara/pull/220/files > Webrev: https://webrevs.openjdk.java.net/skara/220/webrev.00 > Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod > Patch: https://git.openjdk.java.net/skara/pull/220.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/220/head:pull/220 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/220 From rwestberg at openjdk.org Wed Oct 23 10:57:34 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 23 Oct 2019 10:57:34 GMT Subject: [Rev 01] RFR: 137: Watchdog test can fail to terminate In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 01c88f6c: Relax the assertion a bit Changes: - all: https://git.openjdk.java.net/skara/pull/221/files - new: https://git.openjdk.java.net/skara/pull/221/files/92fda46a..01c88f6c Webrevs: - full: https://webrevs.openjdk.java.net/skara/221/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/221/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/SKARA-137 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/221.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/221/head:pull/221 PR: https://git.openjdk.java.net/skara/pull/221 From ehelin at openjdk.org Wed Oct 23 11:52:19 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 23 Oct 2019 11:52:19 GMT Subject: [Integrated] RFR: Add --recurse-submodules to applicable actions in GitRepository In-Reply-To: References: Message-ID: <0b3f6aab-502d-48bc-bf31-2490a93eaae9@openjdk.org> Changeset: a53a2d39 Author: Erik Helin Date: 2019-10-23 11:52:03 +0000 URL: https://git.openjdk.java.net/skara/commit/a53a2d39 Add --recurse-submodules to applicable actions in GitRepository Reviewed-by: rwestberg ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java From rwestberg at openjdk.org Wed Oct 23 12:44:21 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 23 Oct 2019 12:44:21 GMT Subject: RFR: 138: Check commit notification author email domain Message-ID: Hi all, Please review this change that introduces a configurable whitelist for domains the notifier can send emails on behalf of. Best regards, Robin ---------------- Commits: - 952d9942: Add author domain whitelist pattern Changes: https://git.openjdk.java.net/skara/pull/222/files Webrev: https://webrevs.openjdk.java.net/skara/222/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-138 Stats: 25 lines in 3 files changed: 12 ins; 0 del; 13 mod Patch: https://git.openjdk.java.net/skara/pull/222.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/222/head:pull/222 PR: https://git.openjdk.java.net/skara/pull/222 From ar.arunprasad at gmail.com Wed Oct 23 13:16:51 2019 From: ar.arunprasad at gmail.com (Arunprasad Rajkumar) Date: Wed, 23 Oct 2019 18:46:51 +0530 Subject: Fwd: How to configure my openjdk.org email address? In-Reply-To: References: Message-ID: Hello, I'm an OpenJFX contributor and started using https://github.com/openjdk/jfx recently. I just want to understand that the email id generated as part of git commit(e.g. arajkumar at openjdk,org) is a pseudo account or has a real account associated with it. If it is a real, then how to configure it? Thanks, Arun From ehelin at openjdk.org Wed Oct 23 13:46:02 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 23 Oct 2019 13:46:02 GMT Subject: [Approved] RFR: 137: Watchdog test can fail to terminate In-Reply-To: References: Message-ID: On Wed, 23 Oct 2019 10:52:01 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that fixes a problem with the BotRunnerTests.watchdogTrigger test. > > Best regards, > Robin > > ---------------- > > Commits: > - 92fda46a: Re-enable for windows > - 3af96ddc: Use the real runner loop for watchdog test > > Changes: https://git.openjdk.java.net/skara/pull/221/files > Webrev: https://webrevs.openjdk.java.net/skara/221/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-137 > Stats: 9 lines in 2 files changed: 3 ins; 2 del; 4 mod > Patch: https://git.openjdk.java.net/skara/pull/221.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/221/head:pull/221 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/221 From ehelin at openjdk.org Wed Oct 23 13:46:47 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 23 Oct 2019 13:46:47 GMT Subject: [Approved] RFR: 138: Check commit notification author email domain In-Reply-To: References: Message-ID: On Wed, 23 Oct 2019 12:44:21 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that introduces a configurable whitelist for domains the notifier can send emails on behalf of. > > Best regards, > Robin > > ---------------- > > Commits: > - 952d9942: Add author domain whitelist pattern > > Changes: https://git.openjdk.java.net/skara/pull/222/files > Webrev: https://webrevs.openjdk.java.net/skara/222/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-138 > Stats: 25 lines in 3 files changed: 12 ins; 0 del; 13 mod > Patch: https://git.openjdk.java.net/skara/pull/222.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/222/head:pull/222 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/222 From rwestberg at openjdk.org Thu Oct 24 06:59:09 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 24 Oct 2019 06:59:09 GMT Subject: [Integrated] RFR: 137: Watchdog test can fail to terminate In-Reply-To: References: Message-ID: <6e22c21c-c42a-4e7f-8b92-d0312c068e63@openjdk.org> Changeset: 9cd8fef7 Author: Robin Westberg Date: 2019-10-24 06:58:53 +0000 URL: https://git.openjdk.java.net/skara/commit/9cd8fef7 137: Watchdog test can fail to terminate Reviewed-by: ehelin ! bot/src/main/java/org/openjdk/skara/bot/BotRunner.java ! bot/src/test/java/org/openjdk/skara/bot/BotRunnerTests.java From rwestberg at openjdk.org Thu Oct 24 07:00:10 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 24 Oct 2019 07:00:10 GMT Subject: [Integrated] RFR: 138: Check commit notification author email domain In-Reply-To: References: Message-ID: Changeset: 51eae328 Author: Robin Westberg Date: 2019-10-24 06:59:53 +0000 URL: https://git.openjdk.java.net/skara/commit/51eae328 138: Check commit notification author email domain Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From rwestberg at openjdk.org Thu Oct 24 08:51:32 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 24 Oct 2019 08:51:32 GMT Subject: RFR: Create forges from service providers Message-ID: Hi all, Please review this refactoring that allows forges to be created from service providers. Best regards, Robin ---------------- Commits: - 063bcf6b: Create Forges from service providers Changes: https://git.openjdk.java.net/skara/pull/223/files Webrev: https://webrevs.openjdk.java.net/skara/223/webrev.00 Stats: 2799 lines in 33 files changed: 1446 ins; 1294 del; 59 mod Patch: https://git.openjdk.java.net/skara/pull/223.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/223/head:pull/223 PR: https://git.openjdk.java.net/skara/pull/223 From ehelin at openjdk.org Thu Oct 24 09:08:03 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 24 Oct 2019 09:08:03 GMT Subject: RFR: Create forges from service providers In-Reply-To: References: Message-ID: On Thu, 24 Oct 2019 08:51:32 GMT, Robin Westberg wrote: > Hi all, > > Please review this refactoring that allows forges to be created from service providers. > > Best regards, > Robin > > ---------------- > > Commits: > - 063bcf6b: Create Forges from service providers > > Changes: https://git.openjdk.java.net/skara/pull/223/files > Webrev: https://webrevs.openjdk.java.net/skara/223/webrev.00 > Stats: 2799 lines in 33 files changed: 1446 ins; 1294 del; 59 mod > Patch: https://git.openjdk.java.net/skara/pull/223.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/223/head:pull/223 forge/src/main/java/org/openjdk/skara/forge/Forge.java line 60: > 59: return Optional.empty(); > 60: } > 61: Maybe catch `IllegalArgumentException` instead? A bit more meaning than just `RuntimeException` :) PR: https://git.openjdk.java.net/skara/pull/223 From rwestberg at openjdk.org Thu Oct 24 09:32:50 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 24 Oct 2019 09:32:50 GMT Subject: RFR: Run Windows CI using cmd Message-ID: Hi all, Please review this change that ensures that gradlew.bat is run using cmd when using GitHub actions on Windows. Best regards, Robin ---------------- Commits: - 41cd9d8e: Run Windows CI using cmd Changes: https://git.openjdk.java.net/skara/pull/224/files Webrev: https://webrevs.openjdk.java.net/skara/224/webrev.00 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/224.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/224/head:pull/224 PR: https://git.openjdk.java.net/skara/pull/224 From ehelin at openjdk.org Thu Oct 24 10:10:21 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 24 Oct 2019 10:10:21 GMT Subject: [Approved] RFR: Run Windows CI using cmd In-Reply-To: References: Message-ID: <5UbP992YKLXGkdoCUxEzjDnv689XwJdjUzpMjxiltG4=.68d15c3c-66dc-4b1f-92b0-ea5f840061a7@github.com> On Thu, 24 Oct 2019 09:32:50 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that gradlew.bat is run using cmd when using GitHub actions on Windows. > > Best regards, > Robin > > ---------------- > > Commits: > - 41cd9d8e: Run Windows CI using cmd > > Changes: https://git.openjdk.java.net/skara/pull/224/files > Webrev: https://webrevs.openjdk.java.net/skara/224/webrev.00 > Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/224.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/224/head:pull/224 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/224 From rwestberg at openjdk.org Thu Oct 24 10:37:35 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 24 Oct 2019 10:37:35 GMT Subject: [Rev 01] RFR: Create forges from service providers In-Reply-To: References: Message-ID: The pull request has been updated with a complete new set of changes (possibly due to a rebase). ---------------- Commits: - 7462c78a: Merge remote-tracking branch 'upstream/master' into forge_service - 063bcf6b: Create Forges from service providers Changes: https://git.openjdk.java.net/skara/pull/223/files Webrev: https://webrevs.openjdk.java.net/skara/223/webrev.01 Stats: 2799 lines in 33 files changed: 1446 ins; 1294 del; 59 mod Patch: https://git.openjdk.java.net/skara/pull/223.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/223/head:pull/223 PR: https://git.openjdk.java.net/skara/pull/223 From duke at openjdk.java.net Thu Oct 24 10:49:38 2019 From: duke at openjdk.java.net (duke) Date: Thu, 24 Oct 2019 10:49:38 GMT Subject: git: openjdk/skara: Run Windows CI using cmd Message-ID: Changeset: 6accfe1f Author: Robin Westberg Committer: GitHub Date: 2019-10-24 12:49:27 +0000 URL: https://git.openjdk.java.net/skara/commit/6accfe1f Run Windows CI using cmd ! .github/workflows/ci.yml From rwestberg at openjdk.org Thu Oct 24 10:51:47 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 24 Oct 2019 10:51:47 GMT Subject: [Rev 02] RFR: Create forges from service providers In-Reply-To: References: Message-ID: The pull request has been updated with a complete new set of changes (possibly due to a rebase). ---------------- Commits: - 2e2e1eff: Merge remote-tracking branch 'upstream/master' into forge_service - 7462c78a: Merge remote-tracking branch 'upstream/master' into forge_service - 063bcf6b: Create Forges from service providers Changes: https://git.openjdk.java.net/skara/pull/223/files Webrev: https://webrevs.openjdk.java.net/skara/223/webrev.02 Stats: 2799 lines in 33 files changed: 1446 ins; 1294 del; 59 mod Patch: https://git.openjdk.java.net/skara/pull/223.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/223/head:pull/223 PR: https://git.openjdk.java.net/skara/pull/223 From erik.helin at oracle.com Thu Oct 24 12:57:54 2019 From: erik.helin at oracle.com (Erik Helin) Date: Thu, 24 Oct 2019 14:57:54 +0200 Subject: Fwd: How to configure my openjdk.org email address? In-Reply-To: References: Message-ID: On 10/23/19 3:16 PM, Arunprasad Rajkumar wrote: > Hello, Hi Arun, > I'm an OpenJFX contributor and > started using https://github.com/openjdk/jfx recently. On 10/23/19 3:16 PM, Arunprasad Rajkumar wrote: > I just want to understand that the email id generated as part of git > commit(e.g. arajkumar at openjdk,org) is a pseudo account or has a real > account associated with it. If it is a real, then how to configure it? It is currently a pseudo account. As described in JEP 357 [0] we use @openjdk.org as the author/committer email in git commits to signify that the author/committer is an OpenJDK Author [1], Committer [2] or Reviewer [3]. However, as described in my reply to Phil [4], we are slowly making progress towards making them real accounts. Thanks, Erik [0]: https://openjdk.java.net/jeps/357 [1]: http://openjdk.java.net/bylaws#author [2]: http://openjdk.java.net/bylaws#committer [3]: http://openjdk.java.net/bylaws#reviewer [4]: https://mail.openjdk.java.net/pipermail/skara-dev/2019-October/000871.html > Thanks, > Arun From rwestberg at openjdk.org Thu Oct 24 13:46:41 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 24 Oct 2019 13:46:41 GMT Subject: [Rev 03] RFR: Create forges from service providers In-Reply-To: References: Message-ID: <-8hz9_I9xi1qFHT5xCOEERQE3QIkE_1nFJ2uYZoQu60=.81a0fb0d-d1a0-4f3d-8f5c-54b248578770@github.com> The pull request has been updated with additional changes. ---------------- Added commits: - 84f37fab: Improve error handling Changes: - all: https://git.openjdk.java.net/skara/pull/223/files - new: https://git.openjdk.java.net/skara/pull/223/files/2e2e1eff..84f37fab Webrevs: - full: https://webrevs.openjdk.java.net/skara/223/webrev.03 - incr: https://webrevs.openjdk.java.net/skara/223/webrev.02-03 Stats: 121 lines in 8 files changed: 51 ins; 7 del; 63 mod Patch: https://git.openjdk.java.net/skara/pull/223.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/223/head:pull/223 PR: https://git.openjdk.java.net/skara/pull/223 From rwestberg at openjdk.org Thu Oct 24 13:48:19 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 24 Oct 2019 13:48:19 GMT Subject: RFR: Create forges from service providers In-Reply-To: References: Message-ID: On Thu, 24 Oct 2019 09:08:03 GMT, Erik Helin wrote: > On Thu, 24 Oct 2019 08:51:32 GMT, Robin Westberg wrote: > >> Hi all, >> >> Please review this refactoring that allows forges to be created from service providers. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - 063bcf6b: Create Forges from service providers >> >> Changes: https://git.openjdk.java.net/skara/pull/223/files >> Webrev: https://webrevs.openjdk.java.net/skara/223/webrev.00 >> Stats: 2799 lines in 33 files changed: 1446 ins; 1294 del; 59 mod >> Patch: https://git.openjdk.java.net/skara/pull/223.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/223/head:pull/223 > > forge/src/main/java/org/openjdk/skara/forge/Forge.java line 60: > >> 59: return Optional.empty(); >> 60: } >> 61: > > Maybe catch `IllegalArgumentException` instead? A bit more meaning than just `RuntimeException` :) Good point, I did a bit of cleaning up in the error handling for the isValid call. PR: https://git.openjdk.java.net/skara/pull/223 From ehelin at openjdk.org Fri Oct 25 09:01:02 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 25 Oct 2019 09:01:02 GMT Subject: RFR: Add --recurse-submodules=on-demand to git fetch commands Message-ID: Hi all, please review this small patch that adds `--recurse-submodules=on-demand` to the `git fetch` commands in `GitRepository`. Adding `--recurse-submodules` means blobs for submodules will automatically fetched _if necessary_ (when a submodule has been updated in the parent repo). If no submodules are present then no additional action will be taken. Thanks, Erik ## Testing - `make test` passes on Linux x64 ---------------- Commits: - ac45a86a: Add --recurse-submodules=on-demand to git fetch commands Changes: https://git.openjdk.java.net/skara/pull/225/files Webrev: https://webrevs.openjdk.java.net/skara/225/webrev.00 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/225.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/225/head:pull/225 PR: https://git.openjdk.java.net/skara/pull/225 From rwestberg at openjdk.org Fri Oct 25 09:01:06 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 25 Oct 2019 09:01:06 GMT Subject: [Approved] RFR: Add --recurse-submodules=on-demand to git fetch commands In-Reply-To: References: Message-ID: On Fri, 25 Oct 2019 09:01:02 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that adds `--recurse-submodules=on-demand` to the `git fetch` commands in `GitRepository`. Adding `--recurse-submodules` means blobs for submodules will automatically fetched _if necessary_ (when a submodule has been updated in the parent repo). If no submodules are present then no additional action will be taken. > > Thanks, > Erik > > ## Testing > - `make test` passes on Linux x64 > > ---------------- > > Commits: > - ac45a86a: Add --recurse-submodules=on-demand to git fetch commands > > Changes: https://git.openjdk.java.net/skara/pull/225/files > Webrev: https://webrevs.openjdk.java.net/skara/225/webrev.00 > Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/225.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/225/head:pull/225 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/225 From rwestberg at openjdk.org Fri Oct 25 09:13:48 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 25 Oct 2019 09:13:48 GMT Subject: RFR: 142: The new_line field of a GitLab review comment can be null Message-ID: Hi all, Please review this small change that avoids trying to parse a null value as an integer. Best regards, Robin ---------------- Commits: - 55174654: Use the old_line value if new_line is null Changes: https://git.openjdk.java.net/skara/pull/226/files Webrev: https://webrevs.openjdk.java.net/skara/226/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-142 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/226.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/226/head:pull/226 PR: https://git.openjdk.java.net/skara/pull/226 From rwestberg at openjdk.org Fri Oct 25 09:44:56 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 25 Oct 2019 09:44:56 GMT Subject: [Rev 04] RFR: Create forges from service providers In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - a501ef5e: Restore retry functionality Changes: - all: https://git.openjdk.java.net/skara/pull/223/files - new: https://git.openjdk.java.net/skara/pull/223/files/84f37fab..a501ef5e Webrevs: - full: https://webrevs.openjdk.java.net/skara/223/webrev.04 - incr: https://webrevs.openjdk.java.net/skara/223/webrev.03-04 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/223.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/223/head:pull/223 PR: https://git.openjdk.java.net/skara/pull/223 From ehelin at openjdk.org Fri Oct 25 13:24:28 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 25 Oct 2019 13:24:28 GMT Subject: [Approved] RFR: 142: The new_line field of a GitLab review comment can be null In-Reply-To: References: Message-ID: On Fri, 25 Oct 2019 09:13:48 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that avoids trying to parse a null value as an integer. > > Best regards, > Robin > > ---------------- > > Commits: > - 55174654: Use the old_line value if new_line is null > > Changes: https://git.openjdk.java.net/skara/pull/226/files > Webrev: https://webrevs.openjdk.java.net/skara/226/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-142 > Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/226.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/226/head:pull/226 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/226 From ehelin at openjdk.org Fri Oct 25 13:25:08 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 25 Oct 2019 13:25:08 GMT Subject: [Integrated] RFR: Add --recurse-submodules=on-demand to git fetch commands In-Reply-To: References: Message-ID: <9534214d-05e7-4979-89a6-e60f06438225@openjdk.org> Changeset: c96d768b Author: Erik Helin Date: 2019-10-25 13:24:53 +0000 URL: https://git.openjdk.java.net/skara/commit/c96d768b Add --recurse-submodules=on-demand to git fetch commands Reviewed-by: rwestberg ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java From ehelin at openjdk.org Fri Oct 25 13:26:29 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 25 Oct 2019 13:26:29 GMT Subject: [Approved] RFR: Create forges from service providers In-Reply-To: References: Message-ID: On Thu, 24 Oct 2019 08:51:32 GMT, Robin Westberg wrote: > Hi all, > > Please review this refactoring that allows forges to be created from service providers. > > Best regards, > Robin > > ---------------- > > Commits: > - 063bcf6b: Create Forges from service providers > > Changes: https://git.openjdk.java.net/skara/pull/223/files > Webrev: https://webrevs.openjdk.java.net/skara/223/webrev.00 > Stats: 2799 lines in 33 files changed: 1446 ins; 1294 del; 59 mod > Patch: https://git.openjdk.java.net/skara/pull/223.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/223/head:pull/223 Looks good, nice work! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/223 From rwestberg at openjdk.org Fri Oct 25 13:29:47 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 25 Oct 2019 13:29:47 GMT Subject: [Integrated] RFR: 142: The new_line field of a GitLab review comment can be null In-Reply-To: References: Message-ID: <72c1d49e-b29f-4a2a-92a1-d2e493065447@openjdk.org> Changeset: feb10a0c Author: Robin Westberg Date: 2019-10-25 13:29:31 +0000 URL: https://git.openjdk.java.net/skara/commit/feb10a0c 142: The new_line field of a GitLab review comment can be null Reviewed-by: ehelin ! forge/src/main/java/org/openjdk/skara/forge/GitLabMergeRequest.java From philip.race at oracle.com Fri Oct 25 20:28:18 2019 From: philip.race at oracle.com (Phil Race) Date: Fri, 25 Oct 2019 13:28:18 -0700 Subject: git webrev file list option and how to locate a webrev later on Message-ID: I can't find how to supply a list of files as the arg to git webrev. Old webrev takes as an arg a file containing the files to consider This is a very useful feature? since 1) I don't always want to include all files that are modified (although ?probably this isn't so bad since I think it ignores uncommitted files) 2) I like to control the order of files seen by reviewers to make it logical 3) I sometimes need to use the "old-file new-file" Is this a planned but as yet unimplemented feature or am I missing something ? And, something I haven't figured out at all, is how I would do even the supported options via github .. Also, the RFR cites the webrev location like this : https://webrevs.openjdk.java.net/jfx/24/webrev.00 but it is redirected to https://openjdk.github.io/cr/jfx/24/webrev.00/ So far as I can see the only identifying piece of information here is the pull request number. If I want to find the webrev for a particular bug, how can I easily(!) do it ? -phil. From rwestberg at openjdk.org Mon Oct 28 07:07:48 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 28 Oct 2019 07:07:48 GMT Subject: [Integrated] RFR: Create forges from service providers In-Reply-To: References: Message-ID: <6f9a9bd0-e2e7-4900-905e-4d0ffda00ca5@openjdk.org> Changeset: 68620913 Author: Robin Westberg Date: 2019-10-28 07:07:31 +0000 URL: https://git.openjdk.java.net/skara/commit/68620913 Create forges from service providers Reviewed-by: ehelin ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java ! bots/cli/src/main/java/org/openjdk/skara/bots/cli/BotLogstashHandler.java ! bots/cli/src/main/java/org/openjdk/skara/bots/cli/BotSlackHandler.java ! cli/src/main/java/org/openjdk/skara/cli/GitFork.java ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java ! forge/build.gradle ! forge/src/main/java/module-info.java ! forge/src/main/java/org/openjdk/skara/forge/Forge.java ! forge/src/main/java/org/openjdk/skara/forge/ForgeFactory.java - forge/src/main/java/org/openjdk/skara/forge/GitHubApplication.java - forge/src/main/java/org/openjdk/skara/forge/GitHubHost.java - forge/src/main/java/org/openjdk/skara/forge/GitHubPullRequest.java - forge/src/main/java/org/openjdk/skara/forge/GitHubRepository.java - forge/src/main/java/org/openjdk/skara/forge/GitLabHost.java - forge/src/main/java/org/openjdk/skara/forge/GitLabRepository.java ! forge/src/main/java/org/openjdk/skara/forge/PullRequestUpdateCache.java + forge/src/main/java/org/openjdk/skara/forge/github/GitHubApplication.java + forge/src/main/java/org/openjdk/skara/forge/github/GitHubForgeFactory.java + forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java + forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java + forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java = forge/src/main/java/org/openjdk/skara/forge/github/PositionMapper.java + forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabForgeFactory.java + forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabHost.java = forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java + forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java + forge/src/test/java/org/openjdk/skara/forge/ForgeTests.java - forge/src/test/java/org/openjdk/skara/forge/GitHubApplicationTests.java - forge/src/test/java/org/openjdk/skara/forge/GitHubHostTests.java + forge/src/test/java/org/openjdk/skara/forge/github/GitHubApplicationTests.java + forge/src/test/java/org/openjdk/skara/forge/github/GitHubHostTests.java = forge/src/test/java/org/openjdk/skara/forge/github/PositionMapperTests.java + host/src/main/java/org/openjdk/skara/host/Credential.java - host/src/main/java/org/openjdk/skara/host/PersonalAccessToken.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/IssueTrackerFactory.java ! network/src/main/java/org/openjdk/skara/network/RestRequest.java ! test/src/main/java/org/openjdk/skara/test/HostCredentials.java From rwestberg at openjdk.org Mon Oct 28 10:34:04 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 28 Oct 2019 10:34:04 GMT Subject: RFR: Support review comments on deleted parts of files on GitLab Message-ID: Hi all, Please review this change that properly parses GitLab review comments on deleted parts of a change. Best regards, Robin ---------------- Commits: - 2b9d74c2: Support review comments on deleted parts of files on GitLab Changes: https://git.openjdk.java.net/skara/pull/227/files Webrev: https://webrevs.openjdk.java.net/skara/227/webrev.00 Stats: 16 lines in 1 file changed: 11 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/227.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/227/head:pull/227 PR: https://git.openjdk.java.net/skara/pull/227 From rwestberg at openjdk.org Mon Oct 28 11:30:08 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 28 Oct 2019 11:30:08 GMT Subject: RFR: 72: Retry jcheck if an exception occurs Message-ID: <9w8Zg_iZL7Jqam07BOIRxJ9SWsaMiMHLYm6zvXnPcUg=.9aa8266a-d45f-4e93-aa21-097b2f07eae5@github.com> Hi all, Please review this change that automatically reruns a jcheck that fails due to an exception, as this should only happen on transient errors such as external services being down. Best regards, Robin ---------------- Commits: - cc09ae87: Retry jcheck if an exception occur Changes: https://git.openjdk.java.net/skara/pull/228/files Webrev: https://webrevs.openjdk.java.net/skara/228/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-72 Stats: 64 lines in 2 files changed: 61 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/228.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/228/head:pull/228 PR: https://git.openjdk.java.net/skara/pull/228 From rwestberg at openjdk.org Mon Oct 28 12:00:53 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 28 Oct 2019 12:00:53 GMT Subject: RFR: Use a service provider to create issue trackers Message-ID: Hi all, Please review this refactoring that makes use of a service provider to create issue trackers, similarly to how forges are handled. Best regards, Robin ---------------- Commits: - 1549c96f: Related whitespace cleanups - 20ee09d3: Use a service provider to create issue trackers Changes: https://git.openjdk.java.net/skara/pull/229/files Webrev: https://webrevs.openjdk.java.net/skara/229/webrev.00 Stats: 698 lines in 13 files changed: 382 ins; 307 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/229.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/229/head:pull/229 PR: https://git.openjdk.java.net/skara/pull/229 From ehelin at openjdk.org Mon Oct 28 12:37:59 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 28 Oct 2019 12:37:59 GMT Subject: [Approved] RFR: Support review comments on deleted parts of files on GitLab In-Reply-To: References: Message-ID: On Mon, 28 Oct 2019 10:34:04 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that properly parses GitLab review comments on deleted parts of a change. > > Best regards, > Robin > > ---------------- > > Commits: > - 2b9d74c2: Support review comments on deleted parts of files on GitLab > > Changes: https://git.openjdk.java.net/skara/pull/227/files > Webrev: https://webrevs.openjdk.java.net/skara/227/webrev.00 > Stats: 16 lines in 1 file changed: 11 ins; 0 del; 5 mod > Patch: https://git.openjdk.java.net/skara/pull/227.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/227/head:pull/227 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/227 From ehelin at openjdk.org Mon Oct 28 12:38:28 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 28 Oct 2019 12:38:28 GMT Subject: [Approved] RFR: 72: Retry jcheck if an exception occurs In-Reply-To: <9w8Zg_iZL7Jqam07BOIRxJ9SWsaMiMHLYm6zvXnPcUg=.9aa8266a-d45f-4e93-aa21-097b2f07eae5@github.com> References: <9w8Zg_iZL7Jqam07BOIRxJ9SWsaMiMHLYm6zvXnPcUg=.9aa8266a-d45f-4e93-aa21-097b2f07eae5@github.com> Message-ID: On Mon, 28 Oct 2019 11:30:08 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that automatically reruns a jcheck that fails due to an exception, as this should only happen on transient errors such as external services being down. > > Best regards, > Robin > > ---------------- > > Commits: > - cc09ae87: Retry jcheck if an exception occur > > Changes: https://git.openjdk.java.net/skara/pull/228/files > Webrev: https://webrevs.openjdk.java.net/skara/228/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-72 > Stats: 64 lines in 2 files changed: 61 ins; 1 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/228.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/228/head:pull/228 Looks good, thanks for fixing! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/228 From ehelin at openjdk.org Mon Oct 28 12:39:58 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 28 Oct 2019 12:39:58 GMT Subject: [Approved] RFR: Use a service provider to create issue trackers In-Reply-To: References: Message-ID: On Mon, 28 Oct 2019 12:00:53 GMT, Robin Westberg wrote: > Hi all, > > Please review this refactoring that makes use of a service provider to create issue trackers, similarly to how forges are handled. > > Best regards, > Robin > > ---------------- > > Commits: > - 1549c96f: Related whitespace cleanups > - 20ee09d3: Use a service provider to create issue trackers > > Changes: https://git.openjdk.java.net/skara/pull/229/files > Webrev: https://webrevs.openjdk.java.net/skara/229/webrev.00 > Stats: 698 lines in 13 files changed: 382 ins; 307 del; 9 mod > Patch: https://git.openjdk.java.net/skara/pull/229.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/229/head:pull/229 Looks good. I think this whole refactoring came together very nicely, well done! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/229 From rwestberg at openjdk.org Tue Oct 29 06:59:08 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 29 Oct 2019 06:59:08 GMT Subject: [Integrated] RFR: Support review comments on deleted parts of files on GitLab In-Reply-To: References: Message-ID: <2bb1c498-c5c3-49a3-9ac0-16a37408885b@openjdk.org> Changeset: 06a1bcfe Author: Robin Westberg Date: 2019-10-29 06:58:51 +0000 URL: https://git.openjdk.java.net/skara/commit/06a1bcfe Support review comments on deleted parts of files on GitLab Reviewed-by: ehelin ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java From rwestberg at openjdk.org Tue Oct 29 07:00:09 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 29 Oct 2019 07:00:09 GMT Subject: [Integrated] RFR: 72: Retry jcheck if an exception occurs In-Reply-To: <9w8Zg_iZL7Jqam07BOIRxJ9SWsaMiMHLYm6zvXnPcUg=.9aa8266a-d45f-4e93-aa21-097b2f07eae5@github.com> References: <9w8Zg_iZL7Jqam07BOIRxJ9SWsaMiMHLYm6zvXnPcUg=.9aa8266a-d45f-4e93-aa21-097b2f07eae5@github.com> Message-ID: Changeset: f1f33e28 Author: Robin Westberg Date: 2019-10-29 06:59:52 +0000 URL: https://git.openjdk.java.net/skara/commit/f1f33e28 72: Retry jcheck if an exception occurs Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java From rwestberg at openjdk.org Tue Oct 29 07:00:38 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 29 Oct 2019 07:00:38 GMT Subject: [Integrated] RFR: Use a service provider to create issue trackers In-Reply-To: References: Message-ID: <5e8c71c3-62b3-4096-bf23-f8a52549028f@openjdk.org> Changeset: 4ac34b9a Author: Robin Westberg Date: 2019-10-29 07:00:20 +0000 URL: https://git.openjdk.java.net/skara/commit/4ac34b9a Use a service provider to create issue trackers Reviewed-by: ehelin ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java ! forge/src/main/java/org/openjdk/skara/forge/ForgeFactory.java ! issuetracker/src/main/java/module-info.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/Comment.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/IssueTracker.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/IssueTrackerFactory.java - issuetracker/src/main/java/org/openjdk/skara/issuetracker/JiraHost.java - issuetracker/src/main/java/org/openjdk/skara/issuetracker/JiraIssue.java - issuetracker/src/main/java/org/openjdk/skara/issuetracker/JiraProject.java + issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraHost.java + issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java + issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssueTrackerFactory.java + issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java From rwestberg at openjdk.org Tue Oct 29 12:47:57 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 29 Oct 2019 12:47:57 GMT Subject: RFR: Adjust mime encoding Message-ID: Hi all, Please review this minor change that adjusts the MIME encoding to better adhere to RFC1342. Best regards, Robin ---------------- Commits: - edea959c: Adjust mime encoding Changes: https://git.openjdk.java.net/skara/pull/230/files Webrev: https://webrevs.openjdk.java.net/skara/230/webrev.00 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/230.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/230/head:pull/230 PR: https://git.openjdk.java.net/skara/pull/230 From ngasson at openjdk.org Thu Oct 31 10:48:09 2019 From: ngasson at openjdk.org (Nick Gasson) Date: Thu, 31 Oct 2019 10:48:09 GMT Subject: RFR: Add support for building on AArch64 Message-ID: I'm working with OpenJDK on Arm machines so I want to be able to run `git webrev' etc. there. At the moment we can't build the Skara tools on AArch64 due to an implicit assumption that Linux means X86. I tried to refactor the build scripts support multiple architectures on Linux. Only X86 and AArch64 for now but should be trivial to add others. Using the AdoptOpenJDK AArch64 binary build as there are no prebuilt binaries for AArch64 on java.net. Currently there are several Gradle sub-projects that use the image plugin to build Java images, and each specifies the URL and SHA265 of the binary JDK to use. Changed the top-level Gradle script to parse deps.env and select the JDK source based on the OS and architecture system properties. This gets rid of the duplicated URLs but now each image { .. } block has a redundant section like the following for each OS: jdk { url = project.jdkUrl sha256 = project.jdkSha256 } So maybe the plugin should be tweaked to move this up into the image {} block itself? ---------------- Commits: - fd6a7291: Add support for building on AArch64 Changes: https://git.openjdk.java.net/skara/pull/231/files Webrev: https://webrevs.openjdk.java.net/skara/231/webrev.00 Stats: 85 lines in 5 files changed: 69 ins; 3 del; 13 mod Patch: https://git.openjdk.java.net/skara/pull/231.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/231/head:pull/231 PR: https://git.openjdk.java.net/skara/pull/231 From nick.gasson at arm.com Thu Oct 31 11:01:06 2019 From: nick.gasson at arm.com (Nick Gasson) Date: Thu, 31 Oct 2019 19:01:06 +0800 Subject: RFR: Add support for building on AArch64 In-Reply-To: References: Message-ID: <3f75d900-58e4-2d6b-24d0-67c5b1ecb0f3@arm.com> Hi, What's the workflow for make changes to the PR? (the Mac build broke.) Should I amend the commit and force-push or add another commit to that branch? > Webrev: https://webrevs.openjdk.java.net/skara/231/webrev.00 This 404s for me - is that a known issue? Thanks, Nick From per.liden at oracle.com Thu Oct 31 11:07:47 2019 From: per.liden at oracle.com (Per Liden) Date: Thu, 31 Oct 2019 12:07:47 +0100 Subject: RFR: Add support for building on AArch64 In-Reply-To: <3f75d900-58e4-2d6b-24d0-67c5b1ecb0f3@arm.com> References: <3f75d900-58e4-2d6b-24d0-67c5b1ecb0f3@arm.com> Message-ID: <2fd1ce58-f7e6-f248-2f86-821400efa308@oracle.com> On 10/31/19 12:01 PM, Nick Gasson wrote: > Hi, > > What's the workflow for make changes to the PR? (the Mac build broke.) > Should I amend the commit and force-push or add another commit to that > branch? > >> ? Webrev: https://webrevs.openjdk.java.net/skara/231/webrev.00 > > This 404s for me - is that a known issue? Hmm, works fine for me. cheers, Per From robin.westberg at oracle.com Thu Oct 31 12:24:07 2019 From: robin.westberg at oracle.com (Robin Westberg) Date: Thu, 31 Oct 2019 13:24:07 +0100 Subject: RFR: Add support for building on AArch64 In-Reply-To: <3f75d900-58e4-2d6b-24d0-67c5b1ecb0f3@arm.com> References: <3f75d900-58e4-2d6b-24d0-67c5b1ecb0f3@arm.com> Message-ID: <46CAF6F9-FE22-43F6-83AB-F63B847BFE1B@oracle.com> Hi Nick, > On 31 Oct 2019, at 12:01, Nick Gasson wrote: > > Hi, > > What's the workflow for make changes to the PR? (the Mac build broke.) Should I amend the commit and force-push or add another commit to that branch? Usually adding another commit is the preferred choice, this will enable automatic generation of incremental webrevs. But either works fine, when integrating the branch all commits will be squashed. >> Webrev: https://webrevs.openjdk.java.net/skara/231/webrev.00 > > This 404s for me - is that a known issue? Sometimes it takes a little while to update I think, but usually it is quite fast. Looks like it is working now at least. Best regards, Robin > > Thanks, > Nick