[Approved] RFR: Add issue information to the PR summary

Erik Helin ehelin at openjdk.org
Wed Oct 2 08:02:39 UTC 2019


On Tue, 1 Oct 2019 10:52:11 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that adds issue information to the PR summary, if it can be parsed from the PR title. It also tries to retrieve the title of the issue from the associated issue tracker.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - d7dceeed: Add issue information to the PR summary
> 
> Changes: https://git.openjdk.java.net/skara/pull/171/files
>  Webrev: https://webrevs.openjdk.java.net/skara/171/webrev.00
>   Stats: 160 lines in 12 files changed: 142 ins; 1 del; 17 mod
>   Patch: https://git.openjdk.java.net/skara/pull/171.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/171/head:pull/171

Looks good overall, me and Robin have discussed some of the naming offline and Robin is preparing a PR which will change some/many of the names.

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/171


More information about the skara-dev mailing list