[Approved] RFR: Add CheckBuilder::from

Robin Westberg rwestberg at openjdk.org
Wed Oct 2 08:25:39 UTC 2019


On Wed, 2 Oct 2019 08:20:48 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> this small patch adds the method `CheckBuilder::from` that allows a `CheckBuilder` to be initialized to all the values from an existing `Check`, thereby enabling modifying a `Check` (while still preserving the old `Check`).
> 
> ## Testing
> - [x] `sh gradlew test` passes
> - [x] Added one new unit test
> 
> Thanks,
> Erik
> 
> ----------------
> 
> Commits:
>  - b97049ef: Add CheckBuilder::from
> 
> Changes: https://git.openjdk.java.net/skara/pull/175/files
>  Webrev: https://webrevs.openjdk.java.net/skara/175/webrev.00
>   Stats: 130 lines in 3 files changed: 130 ins; 0 del; 0 mod
>   Patch: https://git.openjdk.java.net/skara/pull/175.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/175/head:pull/175

Looks good!

----------------

Approved by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/175


More information about the skara-dev mailing list