RFR: Add issue information to the PR summary

Robin Westberg rwestberg at openjdk.org
Wed Oct 2 08:31:11 UTC 2019


On Wed, 2 Oct 2019 08:02:41 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> On Tue, 1 Oct 2019 10:52:11 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
> 
>> Hi all,
>> 
>> Please review this change that adds issue information to the PR summary, if it can be parsed from the PR title. It also tries to retrieve the title of the issue from the associated issue tracker.
>> 
>> Best regards,
>> Robin
>> 
>> ----------------
>> 
>> Commits:
>>  - d7dceeed: Add issue information to the PR summary
>> 
>> Changes: https://git.openjdk.java.net/skara/pull/171/files
>>  Webrev: https://webrevs.openjdk.java.net/skara/171/webrev.00
>>   Stats: 160 lines in 12 files changed: 142 ins; 1 del; 17 mod
>>   Patch: https://git.openjdk.java.net/skara/pull/171.diff
>>   Fetch: git fetch https://git.openjdk.java.net/skara pull/171/head:pull/171
> 
> bot/src/main/java/org/openjdk/skara/bot/BotConfiguration.java line 49:
> 
>> 48:      */
>> 49:     IssueProject issueProject(String name);
>> 50: 
> 
> I just had to test a multi-line comment ��
> 
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 265:
> 
>> 264:             progressBody.append("--------\n");
>> 265:             var iss = issueProject.getIssue(issue.get().id());
>> 266:             if (iss.isPresent()) {
> 
> Might be easier to use `##` instead of `------`?

Sure, can change.

PR: https://git.openjdk.java.net/skara/pull/171


More information about the skara-dev mailing list