RFR: Use patterns for branches to notify instead of a list

[Robin Westberg]

On Thu, 3 Oct 2019 12:53:25 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> On Thu, 3 Oct 2019 10:46:49 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
> 
>> Hi all,
>> 
>> Please review this change that lets the notifier use a pattern to determine which branches to monitor, instead of a fixed list. Also fetch everything from the remote in order to perform the pattern matching locally.
>> 
>> Best regards,
>> Robin
>> 
>> ----------------
>> 
>> Commits:
>>  - 7a6183d0: Use patterns for branches to notify instead of a list and just fetch everything from the remote
>> 
>> Changes: https://git.openjdk.java.net/skara/pull/178/files
>>  Webrev: https://webrevs.openjdk.java.net/skara/178/webrev.00
>>   Stats: 55 lines in 3 files changed: 23 ins; 3 del; 29 mod
>>   Patch: https://git.openjdk.java.net/skara/pull/178.diff
>>   Fetch: git fetch https://git.openjdk.java.net/skara pull/178/head:pull/178
> 
> bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java line 182:
> 
>> 181:                 }
>> 182:             }
>> 183:         } catch (IOException e) {
> 
> `if (branches.matcher(ref.name()).matches())` ?

Sure, why not!

PR: https://git.openjdk.java.net/skara/pull/178