[Approved] RFR: 118: Use jcheck configuration from PR target branch

Erik Helin ehelin at openjdk.org
Fri Oct 4 07:48:33 UTC 2019

On Fri, 4 Oct 2019 07:20:05 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> Please review this change that uses the jcheck configuration from the target branch when checking pull requests. See the issue for more details.
> Best regards,
> Robin
> ----------------
> Commits:
>  - 3dd7b05e: Read jcheck configuration from the PR target ref
> Changes: https://git.openjdk.java.net/skara/pull/182/files
>  Webrev: https://webrevs.openjdk.java.net/skara/182/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/SKARA-118
>   Stats: 10 lines in 2 files changed: 0 ins; 4 del; 6 mod
>   Patch: https://git.openjdk.java.net/skara/pull/182.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/182/head:pull/182

I agree.

The only scenario where this becomes a problem is if a user merges a change to `.jcheck/conf` that is _too_ strict (for example requiring `role=lead` and `minimum=2` for the review check, and impossible criteria to fulfill). In that case the project lead will have to manually push a change directly to the repository, since it won't be possible to integrate a PR since the jcheck check can never be fulfilled. But I still think the advantage this change brings to all other PRs outweigh that disadvantage. Go ahead and integrate this!


Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/182

More information about the skara-dev mailing list