[Approved] RFR: 123: Set the commit author as sender of commit notification emails

Erik Helin ehelin at openjdk.org
Mon Oct 7 14:06:13 UTC 2019


On Mon, 7 Oct 2019 12:38:14 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that uses the commit author (of the last commit, in case of several) as the email author when sending a commit notification email. This can be overridden on a per-list basis if wanted.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - ea80d334: Use last committer as the author of a notification, unless overridden on a per-list basis
> 
> Changes: https://git.openjdk.java.net/skara/pull/188/files
>  Webrev: https://webrevs.openjdk.java.net/skara/188/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/SKARA-123
>   Stats: 33 lines in 3 files changed: 11 ins; 7 del; 15 mod
>   Patch: https://git.openjdk.java.net/skara/pull/188.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/188/head:pull/188

Looks good!

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/188


More information about the skara-dev mailing list