[Approved] RFR: 123: The notifier should allow the author to be set, not the sender

Erik Helin ehelin at openjdk.org
Wed Oct 9 08:59:55 UTC 2019


On Wed, 9 Oct 2019 06:44:03 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this follow-up change that makes the author of notification emails configurable, not the sender. This is consistent with the mailing list bridge.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 63593952: The notifier should allow the author to be set, not the sender
> 
> Changes: https://git.openjdk.java.net/skara/pull/192/files
>  Webrev: https://webrevs.openjdk.java.net/skara/192/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/SKARA-123
>   Stats: 40 lines in 3 files changed: 18 ins; 0 del; 22 mod
>   Patch: https://git.openjdk.java.net/skara/pull/192.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/192/head:pull/192

Looks good!

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/192


More information about the skara-dev mailing list