[Approved] RFR: Fix gradlew on Cygwin

Robin Westberg rwestberg at openjdk.org
Thu Oct 10 12:36:09 UTC 2019


On Thu, 10 Oct 2019 12:24:51 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> this small patch fixes the Skara build on Cygwin _if_ `gradlew` is used instead of `gradlew.bat`. There is no reason for `Unzip.java` in the Cygwin case since the Windows JDK is itself a ZIP archive, so we need a native `unzip` to pack up the Windows JDK. Therefore we might as well use the native `unzip` when unpacking Gradle as well.
> 
> ## Testing
> - `sh gradlew` works in Cygwin on Windows
> 
> Thanks,
> Erik
> 
> ----------------
> 
> Commits:
>  - 64cf0399: Fix gradlew on Cygwin
> 
> Changes: https://git.openjdk.java.net/skara/pull/196/files
>  Webrev: https://webrevs.openjdk.java.net/skara/196/webrev.00
>   Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
>   Patch: https://git.openjdk.java.net/skara/pull/196.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/196/head:pull/196

Looks good!

----------------

Approved by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/196


More information about the skara-dev mailing list